Commit Graph

244 Commits

Author SHA1 Message Date
Ian Moody
e179244140 Bug 1541025 - testing/ automated ESLint no-throw-literal fixes. r=jmaher
Result of running:
$ mach eslint -funix testing/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D25758

--HG--
extra : moz-landing-system : lando
2019-04-02 13:44:16 +00:00
Mike Conley
fb0883e923 Bug 1522546 - Properly handle preferred remote types in BrowserTestUtils.waitForNewWindow. r=bobowen
This is to fix some of our tests that use BrowserTestUtils.waitForNewWindow, where
the browser that ends up being passed to it doesn't actually need to flip
remoteness.

For example, in the file:// URI case, we allow the first browse to an HTTP
URI to run within the same process. This means that the preferred remote
type is "file", despite the URI normally mapping to the "web" type of
content process.

Differential Revision: https://phabricator.services.mozilla.com/D18226

--HG--
extra : moz-landing-system : lando
2019-01-31 19:54:33 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner
15b881a65f Bug 1521707 - Move promisePopupEvent to BrowserTestUtils.jsm. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17259

--HG--
extra : moz-landing-system : lando
2019-01-23 14:04:46 +00:00
Mark Banner
d13fd4f699 Bug 1521707 - Move waitForDocLoadAndStopIt to BrowserTestUtils. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17258

--HG--
extra : moz-landing-system : lando
2019-01-23 14:04:30 +00:00
Ehsan Akhgari
4137a92662 Bug 1514340 - Part 2: Break out the content blocking related notifications into nsIWebProgressListener.onContentBlockingEvent(); r=baku,johannh
Differential Revision: https://phabricator.services.mozilla.com/D16052
2019-01-21 09:58:50 -05:00
Mark Banner
8e9e4602f8 Bug 1517456 - Make Task.jsm a test-only module. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D15647

--HG--
rename : toolkit/modules/Task.jsm => toolkit/modules/tests/modules/Task.jsm
extra : moz-landing-system : lando
2019-01-04 08:41:58 +00:00
alwu
3752749336 Bug 1507615 - part2 : add synthesizeTouch() for BrowserTestUtils and test. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D12334

--HG--
extra : moz-landing-system : lando
2018-11-20 01:19:18 +00:00
Andreea Pavel
bbe17004a9 Backed out 2 changesets (bug 1507615) for failing ES lint on a CLOSED TREE
Backed out changeset 8ad653a7a5d6 (bug 1507615)
Backed out changeset a7c904c9581f (bug 1507615)
2018-11-20 02:55:08 +02:00
alwu
789ac1144c Bug 1507615 - part2 : add synthesizeTouch() for BrowserTestUtils and test. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D12334

--HG--
extra : moz-landing-system : lando
2018-11-19 21:28:37 +00:00
Paolo Amadini
f6b106efb2 Bug 1496827 - Remove the "notification" binding. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D11650

--HG--
rename : browser/components/customizableui/content/.eslintrc.js => browser/components/translation/content/.eslintrc.js
rename : browser/components/translation/jar.mn => browser/components/translation/content/jar.mn
rename : browser/components/translation/microsoft-translator-attribution.png => browser/components/translation/content/microsoft-translator-attribution.png
rename : browser/components/customizableui/content/moz.build => browser/components/translation/content/moz.build
rename : browser/components/translation/translation-infobar.xml => browser/components/translation/content/translation-notification.js
extra : rebase_source : 598396d2da96b04782413946976f7bb9fb6be75f
2018-11-13 12:56:42 +00:00
Paolo Amadini
cdb5b4eb19 Bug 1471403 - Part 4 - Convert "notificationbox" to a custom class. r=bgrins
As part of the conversion, support for notificationsHidden and children that are not notifications is also removed.

Differential Revision: https://phabricator.services.mozilla.com/D10894

--HG--
rename : toolkit/content/widgets/notification.xml => toolkit/content/widgets/notificationbox.js
extra : rebase_source : 36a5412e1e9a9dc591fd486d1123c1f763a6f173
2018-11-09 14:58:18 +00:00
Paolo Amadini
ce13039af3 Bug 1471403 - Part 2 - Lazify the creation of "notificationbox" elements. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D10892

--HG--
extra : rebase_source : f66fe90d780c3d446f4a065c0397cbb37f43cb0c
2018-11-09 14:38:49 +00:00
Julian Descottes
260b1e16a3 Bug 1467712 - Fail if SimpleTest ok() is called with more than 2 arguments;r=Standard8
Depends on D10417

Differential Revision: https://phabricator.services.mozilla.com/D10418

--HG--
extra : moz-landing-system : lando
2018-11-01 13:50:27 +00:00
Csoregi Natalia
faba2c8c15 Backed out 4 changesets (bug 1467712) for multiple failures with: Too many arguments passed to ok. CLOSED TREE
Backed out changeset 9ce0ac2b9d71 (bug 1467712)
Backed out changeset 026eb1f6dc6e (bug 1467712)
Backed out changeset 0088a09d869a (bug 1467712)
Backed out changeset 1b19ea76aad6 (bug 1467712)
2018-11-01 15:22:52 +02:00
Julian Descottes
8e101fd73a Bug 1467712 - Fail if SimpleTest ok() is called with more than 2 arguments;r=Standard8
Depends on D10417

Differential Revision: https://phabricator.services.mozilla.com/D10418

--HG--
extra : moz-landing-system : lando
2018-11-01 11:12:37 +00:00
Jay Lim
be822ccbde Bug 1472212 - Rename E10SUtils.canLoadURIInProcess to E10SUtils.canLoadURIInRemoteType and modify it to accept an E10SUtils process type instead of a nsIXULRuntime process type. r=Gijs
See next commit for more info. The idea is to use E10SUtils.canLoadURIInRemoteType to detect
if a URI can load in a given E10SUtils process type. Having it to accept a nsIXULRuntime
process type, which will be mapped back to an E10SUtils process type, is unnecessary.

MozReview-Commit-ID: KeYkuRDyqXO

--HG--
extra : source : a8bba29ad2cb20239b87081f77cdf34249d3337b
extra : intermediate-source : 18f824674b76d87ed8cdaee516ad450c1c9b6496
extra : histedit_source : 3a0a8be23c1a5e749396d7aa8c7decbe152bc1db
2018-07-20 18:02:45 -04:00
Ciure Andrei
60ea98ca60 Backed out 10 changesets (bug 1501044, bug 1472212) for fetch-destination.https.html perma failure CLOSED TREE
Backed out changeset aa35078cabaa (bug 1472212)
Backed out changeset bf02793f802d (bug 1472212)
Backed out changeset 95a7ef6102a6 (bug 1472212)
Backed out changeset 7b7fa6ab2229 (bug 1472212)
Backed out changeset 4fe4ec18f2f3 (bug 1472212)
Backed out changeset 18f824674b76 (bug 1472212)
Backed out changeset 1978a7837502 (bug 1472212)
Backed out changeset 21a6f1a83c73 (bug 1472212)
Backed out changeset 48242d39d532 (bug 1472212)
Backed out changeset 0b5cf2f4305a (bug 1501044)
2018-10-30 23:31:10 +02:00
Jay Lim
a0ee0c93dd Bug 1472212 - Rename E10SUtils.canLoadURIInProcess to E10SUtils.canLoadURIInRemoteType and modify it to accept an E10SUtils process type instead of a nsIXULRuntime process type. r=Gijs
See next commit for more info. The idea is to use E10SUtils.canLoadURIInRemoteType to detect
if a URI can load in a given E10SUtils process type. Having it to accept a nsIXULRuntime
process type, which will be mapped back to an E10SUtils process type, is unnecessary.

MozReview-Commit-ID: KeYkuRDyqXO

--HG--
extra : rebase_source : c4f5d562657bc1ca0a2fe7c277f09add9c976975
extra : intermediate-source : b6996abc7d90edbc99d4ac0c5b9bb4a62c5ae5ae
extra : source : a8bba29ad2cb20239b87081f77cdf34249d3337b
2018-07-20 18:02:45 -04:00
Gurzau Raul
42ed3a7d97 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-30 07:32:36 +02:00
Csoregi Natalia
cc313f779c Backed out 9 changesets (bug 1472212) for browser-chrome tests run issues on Linux x64 asan and failures on browser_ext_windows_create_tabId.js. CLOSED TREE
Backed out changeset 18e46df44cd1 (bug 1472212)
Backed out changeset 2e5de66c1f60 (bug 1472212)
Backed out changeset b94f9883aef0 (bug 1472212)
Backed out changeset ebdca743668c (bug 1472212)
Backed out changeset f8a06d01437e (bug 1472212)
Backed out changeset b6996abc7d90 (bug 1472212)
Backed out changeset 24c257cd18c3 (bug 1472212)
Backed out changeset 176f3ee14e67 (bug 1472212)
Backed out changeset b4baa63e5b1b (bug 1472212)
2018-10-30 01:58:21 +02:00
Gijs Kruitbosch
968a7a4996 Bug 1502982 - use a capturing focus listeners so we catch focus in windows that don't have a URL bar etc., r=bdahl
Differential Revision: https://phabricator.services.mozilla.com/D10103

--HG--
extra : moz-landing-system : lando
2018-10-29 22:16:05 +00:00
Gurzau Raul
8f82fd493f Merge inbound to mozilla-central. a=merge 2018-10-30 00:00:56 +02:00
Brendan Dahl
52f12ef5a5 Bug 1502509 - Handle different event order when waiting for window to open. r=Gijs
In browser.xhtml the focus and activate events can fire before the
DOMContentLoaded event.

Differential Revision: https://phabricator.services.mozilla.com/D9950

--HG--
extra : moz-landing-system : lando
2018-10-28 21:21:42 +00:00
Gijs Kruitbosch
73fbe18957 Bug 1500818 - wait for focus and activate of new windows in BTU.waitForNewWindow, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D9364

--HG--
extra : moz-landing-system : lando
2018-10-22 13:10:35 +00:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Gijs Kruitbosch
5edd5678f6 Bug 1499234 - wait for focus and activate events when opening browser windows on Linux, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D8790

--HG--
extra : moz-landing-system : lando
2018-10-17 09:18:05 +00:00
Jonathan Kingston
2ce3b8373f Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : 3e184da8273decac0f3e7d88be89125a2a027588
extra : intermediate-source : ddea69395fbca528529f4491bc8ea7c701ff45b4
2018-08-29 15:48:52 +01:00
Brindusan Cristian
1db0587c0e Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston
c161024465 Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : 5a82993174e363a1e06cd35fcec98fddd6250d64
2018-08-29 15:48:52 +01:00
arthur.iakab
d2e647e133 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
2018-09-18 20:30:07 +03:00
Jonathan Kingston
23bfc5f0ef Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : edc4d8898d26a199fb230489a644b88c2fd8f739
2018-08-29 15:48:52 +01:00
Tiberius Oros
3235f6720f Backed out 10 changesets (bug 1485305) for failures at browser/content/browser.js on a CLOSED TREE
Backed out changeset 63c50fd60ae4 (bug 1485305)
Backed out changeset bf0f2adb765e (bug 1485305)
Backed out changeset 721871bb64f1 (bug 1485305)
Backed out changeset e9da73786c5f (bug 1485305)
Backed out changeset e02038177b6b (bug 1485305)
Backed out changeset 35bd32f99f60 (bug 1485305)
Backed out changeset f40900bf8621 (bug 1485305)
Backed out changeset 03632075ac2c (bug 1485305)
Backed out changeset 2fee48378f73 (bug 1485305)
Backed out changeset 6263695b3cb8 (bug 1485305)
2018-09-18 14:46:54 +03:00
Jonathan Kingston
f1ecf040f7 Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : 5911bc1f2f1fb6d576fba38af242f9d8cb412b16
2018-08-29 15:48:52 +01:00
Jay Lim
cd2d62fbcb Bug 1472212 - Rename E10SUtils.canLoadURIInProcess to E10SUtils.canLoadURIInRemoteType and modify it to accept an E10SUtils process type instead of a nsIXULRuntime process type. r=Gijs
See next commit for more info. The idea is to use E10SUtils.canLoadURIInRemoteType to detect
if a URI can load in a given E10SUtils process type. Having it to accept a nsIXULRuntime
process type, which will be mapped back to an E10SUtils process type, is unnecessary.

MozReview-Commit-ID: KeYkuRDyqXO

--HG--
extra : rebase_source : a3f94b45b96539a969d83e4c4c10ef6f16950fb3
extra : source : a8bba29ad2cb20239b87081f77cdf34249d3337b
2018-07-20 18:02:45 -04:00
Gijs Kruitbosch
d1b26d3f34 Bug 1486824 - review comment follow-up: change params for openNewBrowserWindow to explicitly check for URL, r=nhnt11 2018-09-03 15:16:55 +01:00
Gijs Kruitbosch
ef7146a4be Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : rebase_source : e51b66bb18d0e600814b48d5cd3ec9d5dea3028a
extra : source : 96b5a88ac0041a1bd382a731749e1fca9aa911ed
2018-09-03 14:43:38 +01:00
Margareta Eliza Balazs
5ddcd7b745 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Gijs Kruitbosch
9d70cb3843 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-30 15:07:36 +00:00
Narcis Beleuzu
a4ec006bb0 Backed out changeset 4e195f7b2d6b (bug 1486824) for clipboard failures on OSX browser_editcontrols_update. a=backout 2018-08-30 15:59:59 +03:00
arthur.iakab
044707fc78 Merge inbound to mozilla-central a=merge 2018-08-30 07:37:00 +03:00
Gijs Kruitbosch
a8e2b8e702 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-29 17:58:25 +00:00
Felipe Gomes
170dde818c Bug 1486568 - forceNewProcess option from BrowserTestUtils should ensure that a cached process is not reused. r=mconley 2018-08-29 16:47:37 -03:00
Johann Hofmann
a0fedd95f1 Bug 1484259 - Add is_hidden and is_visible to ContentTaskUtils.jsm. r=nhnt11
This is just a slightly modified copy of the one in BrowserTestUtils.

Differential Revision: https://phabricator.services.mozilla.com/D3971

--HG--
extra : moz-landing-system : lando
2018-08-22 13:30:04 +00:00
Brian Grinstead
e858b8d083 Bug 1484759 - Update references to browser.xul in tests to use AppConstants.BROWSER_CHROME_URL;r=Gijs
This only includes functions that seem to be using it to reference a window.
There are other instances where it's used as a generic chrome URI, and those
are left unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D3806

--HG--
extra : moz-landing-system : lando
2018-08-21 15:33:26 +00:00
Kris Maglione
0c6cd02ae1 Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r=smaug,mconley
Having to add pagehide/pageshow listeners to the chrome event target is a
serious inconvience for the use cases of this bug. Dispatching to system group
listeners has approximately the same effect as the old code, but is much
easier for window-bound code to handle.

--HG--
extra : rebase_source : d67c14e9ba91772d8a9dd82481120b34bdb551e0
2018-08-15 20:06:49 -07:00
Jonathan Kingston
a91f8e8108 Bug 1466801 - Flipping disallowInheritPrincipal to be allow. r=ckerschb r=gijs
--HG--
rename : browser/base/content/test/general/browser_utilityOverlay.js => browser/base/content/test/contextMenu/browser_utilityOverlay.js
extra : source : 5eab8f37c4bd6048057069cb0ac2ab0b4729d950
2018-07-16 10:17:51 +01:00
Bogdan Tara
89268618f4 Backed out changeset c9b0ce46ad4f (bug 1466801) for pause-remove-from-document-networkState.html failures CLOSED TREE
--HG--
rename : browser/base/content/test/contextMenu/browser_utilityOverlay.js => browser/base/content/test/general/browser_utilityOverlay.js
2018-08-11 03:20:30 +03:00
Jonathan Kingston
c24e0873da Bug 1466801 - Flipping disallowInheritPrincipal to be allow. r=ckerschb r=gijs
--HG--
rename : browser/base/content/test/general/browser_utilityOverlay.js => browser/base/content/test/contextMenu/browser_utilityOverlay.js
extra : source : a7bdcc1e1373724effb0bec2d80eb9c63ae782a1
2018-07-16 10:17:51 +01:00