Commit Graph

834965 Commits

Author SHA1 Message Date
Masayuki Nakano
01d2fe15e1 Bug 1384606 - part 3: Make nsPeekOffsetStruct and its handlers treat bool options with an EnumSet r=emilio
The constructor of `nsPeekOffsetStruct` and `nsIFrame::GetFrameFromDirection`
take too many `bool` arguments.  Therefore, adding new `bool` arguments does
not make sense.  Now, we have a useful `mozilla:EnumSet` class to treat them
with an `enum class`. Therefore, let's change `nsPeekOffsetStruct` with it.

Differential Revision: https://phabricator.services.mozilla.com/D172758
2023-03-18 04:18:53 +00:00
Masayuki Nakano
1ae8b063f9 Bug 1384606 - part 2: Add automated tests for caret browsing around form controls r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D172347
2023-03-18 04:18:53 +00:00
Masayuki Nakano
bf5792cbac Bug 1384606 - part 1: Make nsIFrame::GetFrameFromDirection treat frames in different native anonymous subtree not selectable r=emilio
It's called by `PeekOffsetFor*` and `GetPrevNextBidiLevels`, so it's used for
considering whether to put caret or move a selection range boundary.
Therefore, it should treat nodes which can be managed by `Selection` as
selectable.  In theory, even if a native anonymous subtree does not have
an independent selection, its content nodes should not be the container of
the selection range boundaries of selection outside the subtree since
Selection API shouldn't expose nodes in native anonymous subtrees.  Therefore,
it can simply treat content nodes in different anonymous subtrees are not
selectable.

Note that it's not standardized that how `Selection.modify` works with various
content nodes.
https://w3c.github.io/selection-api/#dom-selection-modify

And also Chrome cannot cross generated content like form controls with this API.
This could cause web-compat issues, but it does not make sense for caret
navigation, and anyway out of scope of this bug.  Therefore, this patch just
adds the crash test.

Differential Revision: https://phabricator.services.mozilla.com/D172204
2023-03-18 04:18:52 +00:00
Cosmin Sabou
5a03595206 Bug 1821918 - Increase the number of chunks for windows debug web-platform tests due to hitting max run time. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D172904
2023-03-18 02:54:49 +00:00
Emanuele Rocca
92da89bf60 Bug 1822827 - Remove explicit NEON flags from skia build r=glandium
While Firefox builds for Android ARMv7 don't support non-NEON
processors, downstreams (including non-Android ones) may still want to
support them.

On the Firefox builds that don't support non-NEON processors, the NEON
flags are actually already passed globally, and they don't need to be
explicitly added. NEON_FLAGS is actually only meant to be used for
sources that specifically need NEON support even when the target doesn't
support it, for, e.g. specialized code behind runtime CPU detection.

So removing NEON_FLAGS is a no-op in practice when NEON processors are
already targeted.

Differential Revision: https://phabricator.services.mozilla.com/D172801
2023-03-17 22:59:50 +00:00
Emilio Cobos Álvarez
a8be8e8d20 Bug 1823020 - Set mUntransformedAnchorRect for rect-anchored popups.
I missed setting mUntransformedAnchorRect in one case, causing Wayland
popups to be wrongly positioned.

Differential Revision: https://phabricator.services.mozilla.com/D172886
2023-03-17 19:26:54 +00:00
Emilio Cobos Álvarez
39aeca9d9c Bug 1449669 - Remove IsNodeOfType. r=longsonr
Depends on D172893

Differential Revision: https://phabricator.services.mozilla.com/D172894
2023-03-17 19:22:14 +00:00
Emilio Cobos Álvarez
6779dc7088 Bug 1449669 - Minor clean ups in nsGenericHTMLElement. r=longsonr
Differential Revision: https://phabricator.services.mozilla.com/D172893
2023-03-17 19:22:13 +00:00
Robert Longson
6fc3d48772 Bug 1781253 - GetBoundingClientRect should return the bounding rect of the text ignoring ink overflow r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D172549
2023-03-17 19:13:45 +00:00
Lee Salzman
94519ca0e5 Bug 1447839 - Avoid creating internal path builder for PathRecording unless necessary. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D172870
2023-03-17 19:04:40 +00:00
Lee Salzman
47c82792d1 Bug 1447839 - Avoid creating internal path for PathRecording unless necessary. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D172869
2023-03-17 19:04:39 +00:00
Mozilla Releng Treescript
e468b1ba27 no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD CLOSED TREE
bg -> 01360f4bce126fd0758abb5759e8d88c809acd25
da -> b4c0357e5185526ae35a036310908bae02e97add
fr -> d95fa0593e2d0f5be54d2e5ab375ba85b39d4ba1
gn -> 6afafc4c9de1141ae87e63fe89e307e877f5b2c9
he -> 103f251af0aaee41278d9cc08085b431328562fa
hu -> d50652202be850d4e8df9d894828132059553835
ia -> ccf08deaa498f3e2491d7755f09651d3dae63bf5
is -> db0d33fcbe9a063a30ac28da1cd77f88a2218ec4
zh-CN -> 9ba36aef7f4fedbacc712c24ad4064b9565b6825
2023-03-17 19:01:27 +00:00
Dale Harvey
a40e109905 Bug 1819867 - Update ubuntu distribution code. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D171448
2023-03-17 17:57:17 +00:00
Zach Hoffman
4b116c8e65 Bug 1808229 - Enable :nth-child(... of <selector>) in all release channels r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D172838
2023-03-17 17:07:12 +00:00
Iain Ireland
58a60ccba9 Bug 1817933: Don't elide shapeguard for debugger targets r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D171520
2023-03-17 16:31:18 +00:00
Robert Longson
209497bfd2 Bug 1822884 - Remove eSHAPE from IsNodeOfType and replace with IsSVGGeometryElement r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D172820
2023-03-17 16:26:34 +00:00
Updatebot
af85a73834 Bug 1822882 - Update irregexp to 49d868fb32eb9982980ed0f6d0925572d425ce94 r=iain
Differential Revision: https://phabricator.services.mozilla.com/D172814
2023-03-17 16:24:29 +00:00
Randell Jesup
708c070510 Bug 1720594: Add an Assertion r=necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D170965
2023-03-17 15:52:55 +00:00
blessingpeters
751e4466a7 Bug 1670436 - Prevent localized strings from being truncated in the crash reporter client r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D172823
2023-03-17 15:52:45 +00:00
Hubert Boma Manilla
bbb52ed0bc Bug 1818806 [devtools] Local overrides feature in the debugger r=ochameau,devtools-backward-compat-reviewers,devtools-reviewers
Highlights for this patch
- Support for the script overrides feature
- Overrides for html files are not supported
- Add styling to indicate overrides
- Add mochitests

Depends on D163600

Differential Revision: https://phabricator.services.mozilla.com/D163610
2023-03-17 14:18:29 +00:00
Jan-Niklas Jaeschke
0ec5448edf Bug 1818686: Reset selection after replacing textarea content when no editor is present. r=masayuki
If the `.textContent` or `.defaultValue` attributes are used to change the content of a textarea,
according to the DOM Spec dictates first all children are removed and then a new child is added.
Removing all child elements must collapse the selection to 0.
However, the spec is not very precise on that matter,
see https://github.com/whatwg/html/issues/9028 .

This was currently not done (the selection was adjusted to the new length instead),
because the `Reset()` call was executed as a script runner,
therefore running (twice) after the new content has already been added.
With this change, the selection is adjusted to the new length explicitly
as soon as `ContentChanged()` is invoked, therefore updating it to 0
when content is removed.

Differential Revision: https://phabricator.services.mozilla.com/D172791
2023-03-17 12:52:46 +00:00
Jonathan Kew
c258387e9f Bug 1822184 - Create an ElementOrArray<T> helper in CanvasRenderingContext2D, and use this to store a single ClipState directly without a separate array allocation. r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D172657
2023-03-17 12:48:11 +00:00
Cristina Horotan
588b393945 Backed out 2 changesets (bug 1815937) for causing wpt failures at blockeduri-inline.html CLOSED TREE
Backed out changeset 668971329051 (bug 1815937)
Backed out changeset a4a3430c9bab (bug 1815937)
2023-03-17 15:52:33 +02:00
Csoregi Natalia
60acb93de2 Backed out changeset f38530a9bedf (bug 1822184) for causing build bustage on CanvasRenderingContext2D.h. CLOSED TREE 2023-03-17 14:11:52 +02:00
Dale Harvey
66849540fe Bug 1822326 - Add ability to configure maximum trending suggestions. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D172766
2023-03-17 11:41:28 +00:00
Jonathan Kew
5f730d4cdb Bug 1822184 - Create an ElementOrArray<T> helper in CanvasRenderingContext2D, and use this to store a single ClipState directly without a separate array allocation. r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D172657
2023-03-17 11:26:18 +00:00
Emilio Cobos Álvarez
8bc6063811 Bug 1822837 - Fix flex-basis of update history list. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D172798
2023-03-17 10:24:10 +00:00
Daisuke Akatsuka
dcd82d22b7 Bug 1822319: Add a test of behavior that user presses enter key to reload current url without selecting r=mak
Differential Revision: https://phabricator.services.mozilla.com/D172845
2023-03-17 08:37:52 +00:00
Iulian Moraru
6f60d5fa4d Backed out 4 changesets (bug 1384606) for causing mochitest browser a11y failures on browser_text_basics.js. CLOSED TREE
Backed out changeset 6f7176c0d6a3 (bug 1384606)
Backed out changeset 19c51e735059 (bug 1384606)
Backed out changeset eb8a5705b2d3 (bug 1384606)
Backed out changeset 39b202962261 (bug 1384606)
2023-03-17 10:40:53 +02:00
Abhishek Tiwari
644c56f50a Bug 1821621 - Convert toolkit/components/kvstore to ES modules r=Standard8,extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D172233
2023-03-17 08:10:33 +00:00
Nicolas Chevobbe
bf793882d2 Bug 1815937 - [devtools] Remove inline script displacement handling in source actor. r=devtools-reviewers,ochameau.
This is all made unnecessary by the previous patch of the stack.

Differential Revision: https://phabricator.services.mozilla.com/D170581
2023-03-17 08:03:08 +00:00
Nicolas Chevobbe
c0be3c7697 Bug 1815937 - Set ScriptLoadContext column number for inline scripts. r=smaug,devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D170580
2023-03-17 08:03:07 +00:00
Ekene Nwobodo
a99307f0ff Bug 1822221 - Convert browser/actors/LinkHandler* JSMs to ESMs. r=kpatenio,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D172542
2023-03-17 07:46:57 +00:00
Cristina Horotan
e7a4fa83cf Bug 1821461 - Disable browser_about_translations.js on linux for frequent failures r=intermittent-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D172685
2023-03-17 07:01:02 +00:00
Mozilla Releng Treescript
596082a5be no bug - Bumping Firefox l10n changesets r=release a=l10n-bump DONTBUILD CLOSED TREE
be -> 981914e311f9bef54f7415ff561b8784714b86bc
he -> 4532acad918fee334291f57934a351c4230ad214
is -> c3429f97ee2c18a089c14f83a0cf00c6d727ef2b
ko -> fc76e3bc54d8e83277c6a37a7b2487c1fbf68862
nl -> 2c0bd865d8750cb81d5ad9c39a5e8c4a7e72399c
nn-NO -> 1b842a5efd9e350a0d7dba8bbcaa8e7833ae335d
pt-BR -> 217e2cf2fddeca56ace0987879561b283675f8a7
sr -> 33da5bd455856295e1c82532280937164fccb575
sv-SE -> 30fcd8ac006aeb8c3c6b5001c4619fa9afea1a2d
zh-TW -> 991f8201bfe26ba76d2016483dc998d603c3f473
2023-03-17 07:00:29 +00:00
Makoto Kato
d0d41ac35f Bug 1822792 - Convert ModuleManager's resouces to ESM. r=geckoview-reviewers,extension-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D172781
2023-03-17 06:34:35 +00:00
Masayuki Nakano
25e942f2a0 Bug 1384606 - part 4: Make nsIFrame::GetFrameFromDirection allow to return content in different native anonymous subtree if the caller wants r=emilio
The a11y module wants to traverse frames in native anonymous subtrees.
Therefore, this patch adds new option for allowing it, makes
`nsIFrame::GetFrameFromDirection` check it before comparing native anonymous
subtree root nodes, and makes `HyperTextAccessible::FindOffset` use the
option.

Differential Revision: https://phabricator.services.mozilla.com/D172759
2023-03-17 06:26:03 +00:00
Masayuki Nakano
9cf5036656 Bug 1384606 - part 3: Make nsPeekOffsetStruct and its handlers treat bool options with an EnumSet r=emilio
The constructor of `nsPeekOffsetStruct` and `nsIFrame::GetFrameFromDirection`
take too many `bool` arguments.  Therefore, adding new `bool` arguments does
not make sense.  Now, we have a useful `mozilla:EnumSet` class to treat them
with an `enum class`. Therefore, let's change `nsPeekOffsetStruct` with it.

Differential Revision: https://phabricator.services.mozilla.com/D172758
2023-03-17 06:26:03 +00:00
Masayuki Nakano
2a1ef347fb Bug 1384606 - part 2: Add automated tests for caret browsing around form controls r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D172347
2023-03-17 06:26:03 +00:00
Masayuki Nakano
458f69ffc8 Bug 1384606 - part 1: Make nsIFrame::GetFrameFromDirection treat frames in different native anonymous subtree not selectable r=emilio
It's called by `PeekOffsetFor*` and `GetPrevNextBidiLevels`, so it's used for
considering whether to put caret or move a selection range boundary.
Therefore, it should treat nodes which can be managed by `Selection` as
selectable.  In theory, even if a native anonymous subtree does not have
an independent selection, its content nodes should not be the container of
the selection range boundaries of selection outside the subtree since
Selection API shouldn't expose nodes in native anonymous subtrees.  Therefore,
it can simply treat content nodes in different anonymous subtrees are not
selectable.

Note that it's not standardized that how `Selection.modify` works with various
content nodes.
https://w3c.github.io/selection-api/#dom-selection-modify

And also Chrome cannot cross generated content like form controls with this API.
This could cause web-compat issues, but it does not make sense for caret
navigation, and anyway out of scope of this bug.  Therefore, this patch just
adds the crash test.

Differential Revision: https://phabricator.services.mozilla.com/D172204
2023-03-17 06:26:02 +00:00
Noemi Erli
585fe519f1 Backed out 4 changesets (bug 1384606) for causing build bustage in nsFrameSelection.h CLOSED TREE
Backed out changeset 917f487fdf0f (bug 1384606)
Backed out changeset 0782f42b2a99 (bug 1384606)
Backed out changeset 22099c5efaf6 (bug 1384606)
Backed out changeset f3a38b1eac88 (bug 1384606)
2023-03-17 06:54:59 +02:00
Cristian Tuns
cf19068dfc Merge mozilla-central to autoland on a CLOSED TREE 2023-03-17 00:49:12 -04:00
Cristian Tuns
81864cc6f7 Merge autoland to mozilla-central. a=merge 2023-03-17 00:42:37 -04:00
Drew Willcoxon
5476f02aa1 Bug 1822918 - Fetch the weather suggestion after wake and coming online. r=daisuke
This listens for some observer service notifications so we can re-fetch the
weather suggestion after wake and coming online, without having to wait for the
timer to fire. Please see the bug for background.

I changed the interval (repeating timer) to a timeout (non-repeating timer)
since the timer needs to be recreated on wake if the wake happens before the
start of the next fetch period.

Differential Revision: https://phabricator.services.mozilla.com/D172844
2023-03-17 04:33:55 +00:00
Masayuki Nakano
c2b9c4058b Bug 1384606 - part 4: Make nsIFrame::GetFrameFromDirection allow to return content in different native anonymous subtree if the caller wants r=emilio
The a11y module wants to traverse frames in native anonymous subtrees.
Therefore, this patch adds new option for allowing it, makes
`nsIFrame::GetFrameFromDirection` check it before comparing native anonymous
subtree root nodes, and makes `HyperTextAccessible::FindOffset` use the
option.

Depends on D172758

Differential Revision: https://phabricator.services.mozilla.com/D172759
2023-03-17 04:22:05 +00:00
Masayuki Nakano
1387f2e7bc Bug 1384606 - part 3: Make nsPeekOffsetStruct and its handlers treat bool options with an EnumSet r=emilio
The constructor of `nsPeekOffsetStruct` and `nsIFrame::GetFrameFromDirection`
take too many `bool` arguments.  Therefore, adding new `bool` arguments does
not make sense.  Now, we have a useful `mozilla:EnumSet` class to treat them
with an `enum class`. Therefore, let's change `nsPeekOffsetStruct` with it.

Differential Revision: https://phabricator.services.mozilla.com/D172758
2023-03-17 04:22:05 +00:00
Masayuki Nakano
3f04e976fa Bug 1384606 - part 2: Add automated tests for caret browsing around form controls r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D172347
2023-03-17 04:22:05 +00:00
Masayuki Nakano
c5e00ff09c Bug 1384606 - part 1: Make nsIFrame::GetFrameFromDirection treat frames in different native anonymous subtree not selectable r=emilio
It's called by `PeekOffsetFor*` and `GetPrevNextBidiLevels`, so it's used for
considering whether to put caret or move a selection range boundary.
Therefore, it should treat nodes which can be managed by `Selection` as
selectable.  In theory, even if a native anonymous subtree does not have
an independent selection, its content nodes should not be the container of
the selection range boundaries of selection outside the subtree since
Selection API shouldn't expose nodes in native anonymous subtrees.  Therefore,
it can simply treat content nodes in different anonymous subtrees are not
selectable.

Note that it's not standardized that how `Selection.modify` works with various
content nodes.
https://w3c.github.io/selection-api/#dom-selection-modify

And also Chrome cannot cross generated content like form controls with this API.
This could cause web-compat issues, but it does not make sense for caret
navigation, and anyway out of scope of this bug.  Therefore, this patch just
adds the crash test.

Differential Revision: https://phabricator.services.mozilla.com/D172204
2023-03-17 04:22:04 +00:00
Makoto Kato
f150350f35 Bug 1819593 - Set media.videocontrols.lock-video-orientation to false as default in GeckoView. r=geckoview-reviewers,owlish
`media.videocontrols.lock-video-orientation` uses deprecated mozLockOrientation
API and this API does nothing.

Fenix/android-component uses MediaSession API and its
`MediaSessionFullscreenFeature` sets screen orientation.

So it means that `media.videocontrols.lock-video-orientation` is unused and
unnecessary now. I would like to set false to avoid conflict of same feature
when toolkit/content/widgets/videocontrols.js implements screen orientation API.

Differential Revision: https://phabricator.services.mozilla.com/D172419
2023-03-17 02:12:41 +00:00
Cristian Tuns
c1b52fd95e Backed out 5 changesets (bug 1811850) for causing linting bustages(bugzilla) CLOSED TREE
Backed out changeset e8fcfc7f8108 (bug 1811850)
Backed out changeset f8950d716c9e (bug 1811850)
Backed out changeset f650123cc188 (bug 1811850)
Backed out changeset d96f90c2c58b (bug 1811850)
Backed out changeset c3b0f9666183 (bug 1811850)
2023-03-16 22:16:30 -04:00