Commit Graph

6 Commits

Author SHA1 Message Date
Ting-Yu Lin
570d1f0e83 Bug 1304441 Part 3 - Insert main summary's frame construction item at front of the list. r=bz
Change the logic that moves the main summary to the front from operating
on generated frames in DetailsFrame::SetInitialChildList() to operating
on frame construction item list in AddFrameConstructionItemsInternal()
so that it will be correct when cooperating with ::first-line.

The root cause of the bug reported is because when specifying
::first-line on details element, the first frame of summary element,
which is generated due to ib-split, will be wrapped in nsFirstLineFrame.
The original code fails to find the summary frame in the wrapper frame
and triggers assertion because of the second ib-split summary frame. To
fix that, we need to descend into the child list of wrapper frames when
checking the main summary.

Add original test case as a crashtest as well as reftests to clearly
reproduce the issue.

Note that in the reftest, the blue color in ::first-line is applied
incorrectly to the second line in the summary due to bug 520605.

MozReview-Commit-ID: Bv4Vcvxp6pY
2016-10-05 14:43:32 +08:00
Ting-Yu Lin
4dc7ab9b9e Bug 1304441 Part 2 - Extract main summary checking code to a function. r=bz
* Change the assertion to non-fatal to make it easier to debug.
* Change the wording per bug 1304441 comment 11.

MozReview-Commit-ID: 1UJXhC4qkrx
2016-10-05 14:43:31 +08:00
Ting-Yu Lin
fd982b69ea Bug 591737 - Provide a default summary element by DetailsFrame. r=bz
If a <details> lacks a direct <summary> child, we need to construct a
default one.

--HG--
extra : commitid : ApnP20Mrr33
extra : rebase_source : 4b059f4e7fa32bac665487aa8a266ba58597b184
2016-01-20 23:20:41 +08:00
Ting-Yu Lin
ea65853708 Bug 591737 - Construct details and summary in nsCSSFrameConstructor. r=bz
--HG--
extra : commitid : 7tnA5fqdD6L
extra : rebase_source : 452368859fb99183605edcf47fd48ff026bf3a50
2016-02-02 17:39:49 +08:00
Ting-Yu Lin
802d6dee0d Bug 591737 - Add SummaryFrame. r=bz
--HG--
extra : commitid : 61ZPHBOWyKH
extra : rebase_source : 860919e85da1fc1593f084dcc1e011e1e6cddba3
2016-02-02 17:39:06 +08:00
Ting-Yu Lin
cff36a1352 Bug 591737 - Add DetailsFrame. r=bz
--HG--
extra : commitid : C6hHNXWpwO8
extra : rebase_source : 47b37776c4f029879bd02c0477e885104b2aaed5
2016-01-20 23:20:41 +08:00