Commit Graph

634030 Commits

Author SHA1 Message Date
Vlad Baicu
e55eb8e3c9 Bug 1516665 - Prevent MediaControlService NPE. r=JanH
Use MediaControlService's context when creating the notification in order to
prevent a NPE.

Differential Revision: https://phabricator.services.mozilla.com/D17391

--HG--
extra : moz-landing-system : lando
2019-02-01 15:07:29 +00:00
Masayuki Nakano
b64bb949e0 Bug 1466208 - part 8: Clean up PresShell::EventHandler::GetFrameForHandlingEventWith() r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D16958

--HG--
extra : moz-landing-system : lando
2019-02-01 02:18:55 +00:00
Mark Banner
38d03bf5ca Bug 1524536 - Port some tests to QuantumBar (Search Engine results, a11y label, autoselect, tab switch reset). r=mak
This starts porting other tests to work with QuantumBar and starts expanding UrlbarTestUtils.jsm with more helper functions.

For the tests, I'm generally using replacing with UrlbarTestUtils except for promiseAutocompleteResultPopup/promiseSearchComplete. These functions feel like they need a more in-depth change (bug 1522902), but probably not until we can remove the old bar.

browser_autocomplete_a11y_label.js and browser_autocomplete_autoselect.js are partially ported, but won't run on QuantumBar yet due to missing functionality.

Depends on D18262

Differential Revision: https://phabricator.services.mozilla.com/D18338

--HG--
rename : browser/components/urlbar/tests/legacy/browser_action_searchengine.js => browser/components/urlbar/tests/browser/browser_action_searchengine.js
rename : browser/components/urlbar/tests/legacy/browser_action_searchengine_alias.js => browser/components/urlbar/tests/browser/browser_action_searchengine_alias.js
rename : browser/components/urlbar/tests/legacy/browser_autocomplete_edit_completed.js => browser/components/urlbar/tests/browser/browser_autocomplete_edit_completed.js
rename : browser/components/urlbar/tests/legacy/browser_new_tab_urlbar_reset.js => browser/components/urlbar/tests/browser/browser_new_tab_urlbar_reset.js
rename : browser/components/urlbar/tests/legacy/browser_urlbar_remove_match.js => browser/components/urlbar/tests/browser/browser_urlbar_remove_match.js
extra : moz-landing-system : lando
2019-02-01 16:33:24 +00:00
Dylan Roeh
c8d8aee4ef Bug 1522153 - Pass an empty list rather than null to onChoicePrompt when no choices are present. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D18261

--HG--
extra : moz-landing-system : lando
2019-01-31 23:48:47 +00:00
Daisuke Akatsuka
e318e6b1c6 Bug 1521440: Add test for reloading about:devtools-toolbox. r=jdescottes
Depends on D17795

Differential Revision: https://phabricator.services.mozilla.com/D17796

--HG--
extra : moz-landing-system : lando
2019-01-31 01:39:39 +00:00
Daisuke Akatsuka
0c01c764aa Bug 1521440: Avoid to move to about:blank after destroying. r=ochameau,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D17795

--HG--
extra : moz-landing-system : lando
2019-01-31 18:08:19 +00:00
Mark Banner
91c1df13da Bug 1524377 - In QuantumBar, don't affect the search url when checking to see if we need to canonize the result. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D18262

--HG--
extra : moz-landing-system : lando
2019-02-01 10:50:05 +00:00
Oriol Brufau
35e59fd61b Bug 1524254 - Rename addTab's title parameter to lazyTabTitle. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D18320

--HG--
extra : moz-landing-system : lando
2019-02-01 10:33:19 +00:00
sotaro
4776754f01 Bug 1524168 - Request AlphaVisual for WebRender r=jrmuizel
When hardware acceleration is enabled, GLContextGLX::FindVisual() is used to choose visual. When widget does not request AlphaVisual, the FindVisual() always choose RGB(24bit) visual. It causes to loose alpha during readback.

Differential Revision: https://phabricator.services.mozilla.com/D18179

--HG--
extra : moz-landing-system : lando
2019-01-31 16:49:08 +00:00
Boris Zbarsky
f195e65a70 Bug 1521907 part 7. Start using CheckedUnwrapStatic/Dynamic in JS debugger. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D17889

--HG--
extra : moz-landing-system : lando
2019-01-30 17:45:22 +00:00
Boris Zbarsky
fe5fc0cc2f Bug 1521907 part 6. Start using CheckedUnwrapStatic/Dynamic in toolkit. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D17886

--HG--
extra : moz-landing-system : lando
2019-02-01 13:22:44 +00:00
Boris Zbarsky
bed98f8c98 Bug 1521907 part 5. Start using CheckedUnwrapStatic/Dynamic in XPConnect. r=peterv
I am not a huge fan of the UnwrapReflectorToISupports setup here.  Maybe we
should introduce two differently-named methods that make it somewhat clear what
the limitations of not taking a JSContext are?  I couldn't think of sane
naming...

Differential Revision: https://phabricator.services.mozilla.com/D17885

--HG--
extra : moz-landing-system : lando
2019-02-01 16:17:44 +00:00
Boris Zbarsky
b014cb9758 Bug 1521907 part 4. Start using CheckedUnwrapStatic/Dynamic in non-binding DOM code. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D17884

--HG--
extra : moz-landing-system : lando
2019-01-31 15:51:52 +00:00
Boris Zbarsky
a3784f4489 Bug 1521907 part 3. Start using CheckedUnwrapStatic/Dynamic in bindings. r=peterv
The basic idea for the changes around UnwrapObjectInternal and its callers
(UnwrapObject, UNWRAP_OBJECT, etc) is to add a parameter to the guts of the
object-unwrapping code in bindings which can be either a JSContext* or nullptr
(statically typed).  Then we test which type it is and do either a
CheckedUnwrapDynamic or CheckedUnwrapStatic.  Since the type is known at
compile time, there is no actual runtime check; the compiler just emits a call
to the right thing directly (verified by examining the assembly output on
Linux).

The rest of the changes are mostly propagating through that template parameter,
adding static asserts to make sure people don't accidentally pass nullptr while
trying to unwrap to a type that might be a WindowProxy or Location, etc.

There are also some changes to places that were calling CheckedUnwrap directly
to use either the static or dynamic version, as needed.

Differential Revision: https://phabricator.services.mozilla.com/D17883

--HG--
extra : moz-landing-system : lando
2019-01-31 15:50:06 +00:00
Boris Zbarsky
9abee38822 Bug 1521907 part 2. Add dynamic CheckedUnwrap support to CrossOriginObjectWrapper. r=peterv
This will allow us to correctly handle CheckedUnwrapDynamic on wrappers around
WindowProxy and Location.

Differential Revision: https://phabricator.services.mozilla.com/D17882

--HG--
extra : moz-landing-system : lando
2019-01-31 11:22:53 +00:00
Boris Zbarsky
9927e55b7e Bug 1521907 part 1. Add a version of CheckedUnwrap that can do a dynamic security check. r=jandem
We're going to need this because we will have multiple Realms in the same
compartment which want different CheckedUnwrap behavior in some cases.  So we
need to be able to check which Realm we're in.

Differential Revision: https://phabricator.services.mozilla.com/D17881

--HG--
extra : moz-landing-system : lando
2019-01-30 17:33:49 +00:00
Mike Conley
c936f4be1a Bug 1518521 - Add a scalar that measures time from process start to first paint of topsites in initial about:home. data-review=chutten, r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D18241

--HG--
extra : moz-landing-system : lando
2019-02-01 13:12:21 +00:00
Dão Gottwald
789e695327 Bug 1524542 - Use the "content" payload when setting the value from an extension result. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D18330

--HG--
extra : moz-landing-system : lando
2019-02-01 14:24:01 +00:00
Michael Ratcliffe
ed1053338d Bug 1522809 - Nodes with name="attributes" break the markup view r=rcaliman
This is another very specific issue.

If you have `<img name="attributes"/>` in the dom then `document.attributes` will return the `<img>` tag.

In the source we bail if `!this.rawNode.attributes` but if we are on the document node this returns the image tag. Because the image tag is not a `NamedNodeMap` trying to iterate over the tag throws the error.

There is a test file [here](https://bugzilla.mozilla.org/attachment.cgi?id=9040577).

Differential Revision: https://phabricator.services.mozilla.com/D18340

--HG--
extra : moz-landing-system : lando
2019-02-01 14:03:44 +00:00
Gabriele Svelto
67c71cede9 Bug 1518947 - Update breakpad to revision 44384d80b32a5bb361c2ec3bee667f7ccee566d7 r=ted
This includes some assorted fixes from upstream plus an adaptation of the
patch in b988fa74ec18de6214b18f723e48331d9a7802ae which includes heap memory
regions in the minidump. Since our support for that is more extensive than
upstream breakpad the resulting change reflects this. Last but not least the
fixes for bug 1489094 and bug 1511140 were split out as patches to be applied
to the unmodified breakpad sources. They will be reintegrated as soon as we
fork breakpad for good.

Differential Revision: https://phabricator.services.mozilla.com/D16326

--HG--
extra : moz-landing-system : lando
2019-01-31 15:50:54 +00:00
Emilio Cobos Álvarez
9af4e0d808 Bug 1523627 - HTMLSourceElement should keep track of its media list even if there's no image next-sibling yet. r=jdm
Differential Revision: https://phabricator.services.mozilla.com/D18334

--HG--
extra : moz-landing-system : lando
2019-02-01 15:20:15 +00:00
Pavel Slepushkin
cd08c8b222 Bug 1471648 - [mozlog] Add support for Python 3; r=raphael
Differential Revision: https://phabricator.services.mozilla.com/D18069

--HG--
extra : moz-landing-system : lando
2019-02-01 13:08:09 +00:00
Nicolas Chevobbe
6654ba7a44 Bug 1494318 - Don't map expression bindings when debugger is not paused; r=bgrins.
Differential Revision: https://phabricator.services.mozilla.com/D18314

--HG--
extra : moz-landing-system : lando
2019-02-01 15:19:47 +00:00
Andrew Halberstadt
4222e67eac Bug 1400426 - [try] Add --exact argument to |mach try fuzzy|, r=jgraham
Passing in --exact reverses the behaviour of the ' operator. For example,
take the query "foo 'bar".

By default: foo is a fuzzy match and bar is an exact match.
With --exact: foo is an exact match and bar is a fuzzy match

Differential Revision: https://phabricator.services.mozilla.com/D16734

--HG--
extra : moz-landing-system : lando
2019-01-30 17:09:34 +00:00
Botond Ballo
9468a30c0e Bug 1521644 - In containerless mode, move handling of pres shell resolution from nsDisplayResolution to nsDisplayAsyncZoom. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D17171

--HG--
extra : moz-landing-system : lando
2019-02-01 18:30:50 +00:00
Botond Ballo
d68203346f Bug 1521644 - Do not place the RCD-RSF scroll clip onto the layers with RCD-RSF scroll metadata in containerless mode. r=mstange
The clip will go onto the async zoom container layer instead.

Differential Revision: https://phabricator.services.mozilla.com/D17169

--HG--
extra : moz-landing-system : lando
2019-02-01 18:30:42 +00:00
Botond Ballo
2206990a93 Bug 1521644 - Trigger a full display list rebuild when transition to or from using an async zoom container. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D17168

--HG--
extra : moz-landing-system : lando
2019-02-01 18:30:28 +00:00
Markus Stange
0a4aa8a57c Bug 1521644 - Wrap the root scroll frame contents into an nsDisplayAsyncZoom when using APZ zooming and containerless scrolling. r=mstange,mattwoodrow
This patch also makes a couple of changes related to clipping:

 - The composition bounds clip is applied to the async zoom container but
   not its contents.

 - The clip applied to the async zoom container is not divided by the
   resolution. This clip is applied after the resolution, so dividing
   by the resolution clips content away when zoomed in.

Differential Revision: https://phabricator.services.mozilla.com/D17176

--HG--
extra : moz-landing-system : lando
2019-02-01 20:31:15 +00:00
Botond Ballo
5a6cf2cbcf Bug 1521644 - Factor out a helper function to serialize a display list collection into a display list. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D17852

--HG--
extra : moz-landing-system : lando
2019-02-01 20:31:10 +00:00
Markus Stange
b97222a5dc Bug 1521644 - Create nsDisplayAsyncZoom which creates a ContainerLayer that is marked as an async zoom container. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D17175

--HG--
extra : moz-landing-system : lando
2019-02-01 20:31:13 +00:00
Markus Stange
5c1e861efd Bug 1521644 - Add a layer property that indicates async zoom container layers. r=mattwoodrow
MozReview-Commit-ID: 6qkFXhRDFs

Differential Revision: https://phabricator.services.mozilla.com/D17174

--HG--
extra : moz-landing-system : lando
2019-02-01 18:29:11 +00:00
Jared Wein
764c20081e Bug 1520966 - Update test_xml_load to use modal state properties and remove now unused checkModalPrompt code. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D18268

--HG--
extra : moz-landing-system : lando
2019-02-01 18:49:58 +00:00
Jared Wein
74a50ba714 Bug 1520966 - Make toolkit/components/passwordmgr/test/text_xhr.html work with e10s. r=MattN
I didn't use the checkPromptModal function because the implementation in chromeScript was getting a null document reference. Since handlePrompt already has access to this information it made sense to extend handlePrompt to cover more cases.

Differential Revision: https://phabricator.services.mozilla.com/D18267

--HG--
rename : toolkit/components/passwordmgr/test/test_xhr.html => toolkit/components/passwordmgr/test/mochitest/test_xhr.html
extra : moz-landing-system : lando
2019-02-01 20:15:02 +00:00
Benjamin Bouvier
5ca6ea03da Bug 1522882: Drive-by comment fixes; r=nbp
Differential Revision: https://phabricator.services.mozilla.com/D18194

--HG--
extra : rebase_source : 1a9f3468a1d8dd3ddd347d10b38f52468c86f364
2019-01-28 16:10:17 +01:00
Raphael Pierzina
7ce54efbf2 Bug 1522045 - Update Telemetry preferences documentation for ping server; r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D17656

--HG--
extra : moz-landing-system : lando
2019-01-28 08:50:04 +00:00
Ciure Andrei
0e8b5d7b70 Backed out changeset 9c17fddb650f (bug 1428713) for mozprocess raptor failure CLOSED TREE 2019-02-01 17:14:52 +02:00
Benjamin Bouvier
eed37cd072 Bug 1522882: Exit early and print help when IONFLAGS isn't correctly set; r=nbp
Differential Revision: https://phabricator.services.mozilla.com/D18193

--HG--
extra : rebase_source : a16fc95b5a27140d3231bf3db70bf7ec33558f9a
extra : amend_source : 2e7c1831bb577fb29826ef161a16642e1a2747a1
2019-01-25 17:47:42 +01:00
Benjamin Bouvier
2e4330200f Bug 1522882: Add wasm function number to Iongraph spew; r=nbp
Differential Revision: https://phabricator.services.mozilla.com/D18192

--HG--
extra : rebase_source : d596d59a40fb660c35df7018bed605a847942ad9
2019-01-25 17:10:28 +01:00
André Bargull
2ee80e7ac9 Bug 1520286 - Part 2: Add VM-call for TypedArray constructor with Array/TypedArray arguments. r=jandem
--HG--
extra : rebase_source : 899acfc898773aec0a1b3b69aeb1aae07958cdc6
2019-02-01 05:14:41 -08:00
André Bargull
24cd46ac83 Bug 1520286 - Part 1: Switch over inlinable natives via JSJitInfo instead of performing pointer comparisons. r=tcampbell
--HG--
extra : rebase_source : 3293dc0ba2cb953b14d1cca56c8abc4985681b9a
2019-02-01 05:14:40 -08:00
Geoff Brown
7c8f4e8f58 Bug 1522689 - Update command line help for several android test commands; r=bc 2019-02-01 07:18:05 -07:00
Oriol Brufau
d2be6ed36e Bug 1488095 - Test that webext tabs.move preserves tab laziness. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D17282

--HG--
extra : moz-landing-system : lando
2019-01-24 15:23:03 +00:00
Tom Tung
4db3b15c8d Bug 1523682 - Extend QM_INITIALIZATION_TIME telemetry probe; r=asuth, data-review=chutten
Differential Revision: https://phabricator.services.mozilla.com/D18051

--HG--
extra : moz-landing-system : lando
2019-02-01 10:16:26 +00:00
Patrick Brosset
a3ccdb3812 Bug 1523909 - Simplifying the scrollable badge to just scroll; r=gl
Differential Revision: https://phabricator.services.mozilla.com/D18093

--HG--
extra : moz-landing-system : lando
2019-02-01 10:10:21 +00:00
Jan de Mooij
0c7e884af5 Bug 1522837 part 8 - Implement JSOP_GETIMPORT in BaselineInterpreterCodeGen. r=tcampbell
Eventually this op could use an IC or some frontend/bytecode refactoring to make
it faster in the interpreter. For now following the C++ interpreter is the
simplest solution though.

Differential Revision: https://phabricator.services.mozilla.com/D17939

--HG--
extra : moz-landing-system : lando
2019-01-31 18:13:25 +00:00
Jan de Mooij
bd4243cae1 Bug 1522837 part 7 - Implement JSOP_NEWARRAY_COPYONWRITE in BaselineInterpreterCodeGen. r=tcampbell
Depends on D17937

Differential Revision: https://phabricator.services.mozilla.com/D17938

--HG--
extra : moz-landing-system : lando
2019-01-29 18:05:13 +00:00
Jan de Mooij
59fb8e7b5d Bug 1522837 part 6 - Implement JSOP_BUILTINPROTO in BaselineInterpreterCodeGen. r=tcampbell
Depends on D17936

Differential Revision: https://phabricator.services.mozilla.com/D17937

--HG--
extra : moz-landing-system : lando
2019-01-29 17:58:04 +00:00
Jan de Mooij
0b373aec27 Bug 1522837 part 5 - Implement JSOP_IMPORTMETA in BaselineInterpreterCodeGen. r=tcampbell
Depends on D17935

Differential Revision: https://phabricator.services.mozilla.com/D17936

--HG--
extra : moz-landing-system : lando
2019-01-29 17:44:30 +00:00
Jan de Mooij
120ec68d75 Bug 1522837 part 4 - Implement JSOP_CALLSITEOBJ in BaselineInterpreterCodeGen. r=tcampbell
This is just a VM call in the interpreter. We could optimize this with an IC or
inline path if it ever becomes a problem.

Depends on D17934

Differential Revision: https://phabricator.services.mozilla.com/D17935

--HG--
extra : moz-landing-system : lando
2019-01-29 17:41:30 +00:00
Jan de Mooij
fabe18cff5 Bug 1522837 part 3 - Refactor JSOP_OBJECT in BaselineCodeGen. r=tcampbell
This adds js::SingletonObjectLiteralOperation and calls it from both the
interpreter and Baseline. The Baseline compiler still has a fast path for the
cloning-not-necessary case.

Depends on D17645

Differential Revision: https://phabricator.services.mozilla.com/D17934

--HG--
extra : moz-landing-system : lando
2019-01-29 16:54:05 +00:00