Bug 1694521 fixes the test_trr_flags test by not using channels and
invalid ports - so the speculative connection difference no longer
applies.
Differential Revision: https://phabricator.services.mozilla.com/D106898
1. Moved some setup stuff to head.js
2. Removed dumps
3. Changed comments to info()s at the beginning of tests
4. Combined some related tests.
5. Added helper to set TRR mode and uri
6. Some de-duplication when needing to do a test for different modes (more to be done)
7. Added some comments where missing, e.g. linking a bug
8. Gave all test functions good names
Differential Revision: https://phabricator.services.mozilla.com/D106215
Bug 1694521 fixes the test_trr_flags test by not using channels and
invalid ports - so the speculative connection difference no longer
applies.
Differential Revision: https://phabricator.services.mozilla.com/D106898
1. Moved some setup stuff to head.js
2. Removed dumps
3. Changed comments to info()s at the beginning of tests
4. Combined some related tests.
5. Added helper to set TRR mode and uri
6. Some de-duplication when needing to do a test for different modes (more to be done)
7. Added some comments where missing, e.g. linking a bug
8. Gave all test functions good names
Differential Revision: https://phabricator.services.mozilla.com/D106215
We now pass a map object instead multiple arguments.
This way if we need to add/remove/change something we don't need to worry
about backwards compatibility and having to change all the callsites as
we do in this patch :)
Differential Revision: https://phabricator.services.mozilla.com/D109000
- Adds CONFIRM_TRYING_FAILED confirmation state. We use this state when we retry confirmation after confirmation fails.
- Rename CONFIRM_TRYING to CONFIRM_TRYING_OK. We use this state when we try confirmation but no confirmation failure has happened.
- Rename CONFIRM_INIT to CONFIRM_OFF. We use this state whenever there is an event that would disable TRR - such as a TRR mode change.
- Add CONFIRM_DISABLED confirmation state. We use this state in mode3 or when confirmationNS=="skip"
- To potentially allow us to have the same behaviour as after Bug 1689113, specifically the we might be able to report TRRService::Enabled = true when retrying and the state is CONFIRM_TRYING_FAILED we added `network.trr.attempt-when-retrying-confirmation`
- After a large number of TRR failures occurs, we immediately trigger another confirmation and go into CONFIRM_TRYING_OK. This allows us to cope with a temporary increase in network latency that is smaller than 6s.
- We no longer trigger confirmation for nsIRequest::TRR_FIRST_MODE when the resolver mode is not TRR_FIRST. This allows us to simplify the code.
- test_trr_proxy.js now calls trr_test_setup() after it sets up the pac script to avoid confirmation causing non-local connections in tests.
- Moves all the confirmation state handing into HandleConfirmationEvent
Differential Revision: https://phabricator.services.mozilla.com/D107666
This test was disabled in Bug 1666072 when we set the allowSTS=false for
captive portal requests to prevent a HSTS upgrade redirect.
Bug 1681683 added a different property (isOCSP) to be able to differentiate
OCSP channels from regular ones, so even if captive portal channels have
allowSTS=false, they still use the same TRR mode as was initially set
on the channel. This means the test will now work in mode3 as well.
Differential Revision: https://phabricator.services.mozilla.com/D106892
This patch wants to solve several quirks around the shutdown terminator.
- Use the same shutdown phase definitions in AppShutdown and nsTerminator. This touches quite a few files.
- Ensure that the terminator phase shift is handled before any shutdown observer notifications are sent and reduce its heartbeat duration.
- Add missing phases to the shutdown telemetry.
Please note that this changes the unit of "tick" to 100ms rather than 1s.
As a side effect, we also remove the obsolete "shutdown-persist" context.
While the existing test coverage continues to prove the most important functions, we acknowledge the wish for better test coverage with [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1693966 | bug 1693966 ]].
Differential Revision: https://phabricator.services.mozilla.com/D103626
This patch wants to solve several quirks around the shutdown terminator.
- Use the same shutdown phase definitions in AppShutdown and nsTerminator. This touches quite a few files.
- Ensure that the terminator phase shift is handled before any shutdown observer notifications are sent and reduce its heartbeat duration.
- Add missing phases to the shutdown telemetry.
Please note that this changes the unit of "tick" to 100ms rather than 1s.
As a side effect, we also remove the obsolete "shutdown-persist" context.
While the existing test coverage continues to prove the most important functions, we acknowledge the wish for better test coverage with [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1693966 | bug 1693966 ]].
Differential Revision: https://phabricator.services.mozilla.com/D103626
1. Moved some setup stuff to head.js
2. Removed dumps
3. Changed comments to info()s at the beginning of tests
4. Combined some related tests.
5. Added helper to set TRR mode and uri
6. Some de-duplication when needing to do a test for different modes (more to be done)
7. Added some comments where missing, e.g. linking a bug
8. Gave all test functions good names
Differential Revision: https://phabricator.services.mozilla.com/D106215
