Commit Graph

758078 Commits

Author SHA1 Message Date
Mike Hommey
2072d3a612 Bug 1711834 - Let the compiler generate the Matrix4x4Typed copy assignment operator. r=mattwoodrow
This avoids GCC complaining about the case where doing `m = m` would
memcpy from an address onto itself.

Differential Revision: https://phabricator.services.mozilla.com/D115460
2021-05-24 20:58:11 +00:00
sotaro
3033ee4b0e Bug 1704000 - Enable reftests on Android emulator for SW-WR r=jmaher,gfx-reviewers,bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D115779
2021-05-24 20:57:26 +00:00
Joel Maher
3ad9f06697 Bug 1710923 - migrate windows 7x32 debug tests to windows 10x32. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D115017
2021-05-24 20:06:43 +00:00
Ed Lee
3c8062040a Bug 1711858 - Avoid "Fire starts here" from getting hidden by noodles r=pdahiya
Remove explicit section-left children widths to allow the parent to flex with a static width section-main for initial screen. Clean up some breakpoint sizing with percent/viewport widths.

Differential Revision: https://phabricator.services.mozilla.com/D115546
2021-05-24 19:01:16 +00:00
Olli Pettay
9138dbca37 Bug 1711564, MediaStreamTrack should pass owner global to the DOMEventTargetHelper, r=jib
Differential Revision: https://phabricator.services.mozilla.com/D115427
2021-05-24 18:27:21 +00:00
Dorel Luca
08f063f4c8 Backed out changeset 2c95330ad7c7 (bug 1711437) for Devtools failures in devtools/client/inspector/markup/test/browser_markup_shadowdom.js. CLOSED TREE 2021-05-24 23:01:46 +03:00
Mike Kaply
e528cec2a2 Bug 1692159 - Disable saved password preference if disabled by policy. r=mixedpuppy,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D115655
2021-05-24 17:30:33 +00:00
Emilio Cobos Álvarez
510cae01ca Bug 1711437 - Don't EnsureUniqueInner from the cssRules getter. r=layout-reviewers,jfkthame
Instead, fix up the various content data structures when the stylesheet
is mutated. This makes reading a stylesheet not disable style sharing.

Differential Revision: https://phabricator.services.mozilla.com/D115203
2021-05-24 17:18:44 +00:00
Morgan Reschenberg
7bc169515a Bug 1710748: Return button menus when form controls are queried from rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D115429
2021-05-24 17:02:46 +00:00
Markus Stange
4cb5ee5a2d Bug 1712358 - Call NotifyWait() when the native event loop goes idle. This fixes unintended BHR hang reports when we are in a nested native event loop, such as when a menu is open. r=florian
The 'BHR-detected hang' markers in these profiles show the difference:
Before: https://share.firefox.dev/34anZE5
After: https://share.firefox.dev/3udb8vq

Differential Revision: https://phabricator.services.mozilla.com/D115764
2021-05-24 17:02:44 +00:00
Morgan Reschenberg
288a4006cf Bug 1710742: Modify VO checkbox search key to work with quick nav r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D115430
2021-05-24 17:02:31 +00:00
Bryce Seager van Dyk
a4dbbb7a9c Bug 1706164 - Make MediaKeys interact with EncryptedMediaChild to check output protection status. r=alwu
This changes the MediaKeys to actually service output protection status queries
by sending those queries to the EncryptedMediaChild actor and handling responses
from the actor. These interactions are done via the observer service.

Differential Revision: https://phabricator.services.mozilla.com/D115418
2021-05-24 16:50:20 +00:00
Bryce Seager van Dyk
d9f34a3187 Bug 1706164 - Use webrtc screen and window sharing data in EncryptedMediaChild to determine if media may be captured. r=alwu
This expands EncryptedMediaChild to be able to query and track the information
now shared by webrtcUI around screen and window sharing. The actor will use this
information to report to observers if capture is possible or not.

For now we use a coarse approach where we only track if the screen or any window
is shared, but in future I plan to have a more granular tracking of windows.

Differential Revision: https://phabricator.services.mozilla.com/D115417
2021-05-24 16:50:19 +00:00
Bryce Seager van Dyk
16f81a9237 Bug 1706164 - Share screen and window sharing status from webrtcUI via sharedData. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D115416
2021-05-24 16:50:19 +00:00
Bryce Seager van Dyk
acbeaeeb24 Bug 1706164 - Plumb QueryOutputProtectionStatus requests from the CDM to MediaKeys. r=alwu
This patch plumbs the QueryOutputProtectionStatus call from the CDM up to the
MediaKeys. This is plumbing is done to get the request to an endpoint of Gecko
C++ code, and future patches will do further plumbing in order to complete the
query.

After the first query is complete, we cache the result in a CDM's
ChromiumCDMParent and update the value only when notified of changes from the
MediaKeys. This has the benefit of that checks after the first don't need to
touch the main thread. This avoids adding more main thread work, and means we
can still complete checks in a timely fashion even if the main thread is running
hot.

We cache in the parent rather than the child so that the parent can make
decisions on how to handle requests even if the CDM machinery is not yet fully
initialized. In future it may make sense to move the caching to the child, but
I'd prefer to do this only after other refactoring of the machinery which I
consider out of scope for this bug.

Future patches will ensure listeners are in place such that the cached data is
updated when updates are received further up the stack.

Differential Revision: https://phabricator.services.mozilla.com/D115415
2021-05-24 16:50:18 +00:00
Gijs Kruitbosch
2d2e51253d Bug 1700976 - do not prompt for externally-opened web- or extension-handled 'external' protocols, r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D115478
2021-05-24 16:02:50 +00:00
Alexandre Poirot
fa827a1cbe Bug 1709792 - [devtools] Support target switching in har automation. r=bomsy
* Stop memoizing web console front
* track navigations via DOCUMENT_EVENT's dom-complete
* await for HarAutomation async initialization from toolbox codebase

These changes help fix browser_harautomation_simple.js.
But this isn't enough as will-navigate can easily be missed.

Differential Revision: https://phabricator.services.mozilla.com/D114464
2021-05-24 15:37:33 +00:00
Alexandre Poirot
3c37b9918b Bug 1709792 - [devtools] Remove har's toolbox overlay. r=bomsy
This introduces uncessary complexity and makes it uterly complex to wait
for HarAutomation's async initialization.
Its init isn't async yet.

Differential Revision: https://phabricator.services.mozilla.com/D114837
2021-05-24 15:37:32 +00:00
Alexandre Poirot
438cc8620d Bug 1709792 - [devtools] Pass around commands in har automation. r=bomsy
Make this codebase fully embrace commands and stop being target/toolbox oriented.

Differential Revision: https://phabricator.services.mozilla.com/D114836
2021-05-24 15:37:32 +00:00
Michael Cooper
17bed3c2b3 Bug 1711218 - Don't undo user pref changes when Normandy experiments end r=Gijs
When a user changes a preference involved in a Normandy experiment, we no
longer immediately end the experiment. This caused a problem because Normandy
didn't check for user changes when resetting prefereces at the end of an
experiment. As a result it would reset all preferences back to their original
values on the specified branch, even if that would mean changing a preference
it knows the user had modified.

This change causes Normandy to never reset the user branch of an experiment
preference that the user has changed. This is true even if the user changes the
preference away from the experimental value and then back to it.

Differential Revision: https://phabricator.services.mozilla.com/D115713
2021-05-24 15:36:16 +00:00
Narcis Beleuzu
b41573863c Bug 1711117 - Disable browser_bookmark_add_tags.js on Linux for frequent failures. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D115759
2021-05-24 15:25:39 +00:00
Alexandre Poirot
a13bc1e7d2 Bug 1712567 - [devtools] Cover console persist feature with cross process navigation. r=nchevobbe
About browser_jsterm_autocomplete_getters_cache, we weren't correctly waiting
for popup to close because of the reload. Instead we probably worked around intermittents
by closing the popup explicitly before the reload.
But that creates other issue, where the reload may close the popup *after* we do Ctrl+Space.
(this patch doesn't trigger any issue with this test, but better fix that)

Differential Revision: https://phabricator.services.mozilla.com/D112231
2021-05-24 15:19:22 +00:00
Markus Stange
14d49253c8 Bug 1710474 - Don't roll up native context menus in response to wheel events. r=mac-reviewers,spohl,bradwerth
I didn't add this check originally because the thinking was that macOS wouldn't dispatch
these events to us anyway as long as a menu is open.
However, our menu opening is asynchronous. So we can still get wheel events between the
mousedown that asks to open the menu, and the delayed perform which then ends up opening
the menu for real. We don't want to cancel opening when we get these straggler events.

Differential Revision: https://phabricator.services.mozilla.com/D115763
2021-05-24 15:14:04 +00:00
Andi-Bogdan Postelnicu
0194d37673 Bug 1617369 - Reformat recent rust changes with rustfmt r=emilio
Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Differential Revision: https://phabricator.services.mozilla.com/D115805
2021-05-24 15:08:48 +00:00
Andi-Bogdan Postelnicu
1cf28e7475 Bug 1519636 - Reformat recent changes to the Google coding style. r=emilio
Updated with clang-format version 12.0.0 (taskcluster-KEgO7qdgQ8uaewA6NkRnRA)

Differential Revision: https://phabricator.services.mozilla.com/D115804
2021-05-24 15:08:47 +00:00
Eden Chuang
0447732333 Bug 1584007 - check ClientSource existence r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D85362
2021-05-24 13:55:08 +00:00
Eden Chuang
e1283fcd46 Bug 1584007 - FutureClientSourceParent should keep ClientManagerService alive r=asuth
The strong reference will be dropped when FutureClientSourceParent is removed,
and we guarantee that all FutureClientSourceParents will either be removed or
replaced with a ClientSourceParent (or at least this is a guarantee that's
supposed to be true).

Differential Revision: https://phabricator.services.mozilla.com/D68041
2021-05-24 13:55:07 +00:00
Eden Chuang
3e3456e73e Bug 1584007 - let ClientChannelHelperParent manage FutureClientSourceParent lifetime r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
ClientChannelHelperParent is the thing creating the ClientInfos which aren't
backed by existing ClientSources, so it may make sense for CCHP to tell the
ClientManagerService (CMS) to "expect" or "forget" a "future"
ClientSource(Parent).

When such a ClientInfo is created, CCHP notifies the CMS that a future
ClientSource may be created. This notification has to be observed before any
ClientHandles try to query CMS to a ClientSourceParent, which is the case
because the notification as well as ClientHandleParent constructors occur over
PBackground, and the notification sending method is called first.

CMS is told to forget the future ClientSource whenever a redirect occurs that
would result in the creation of a new ClientSource (i.e. a new ClientInfo). It's
also possible that the ClientInfo's LoadInfo's channel is cancelled. To account
for this, CHCP stores the most recent ClientInfo it's created and tells CMS
to _possibly_ forget the associated future ClientSource in its destructor. It's
possible that the channel completed its load, in which case this notification
is a no-op. This also relies on CHCP being destroyed after the reserved
ClientSource has a chance to both be created and register its
ClientSourceParent.

Differential Revision: https://phabricator.services.mozilla.com/D66529
2021-05-24 13:55:07 +00:00
Eden Chuang
9ca5730156 Bug 1584007 - allow ClientManager to register "future" ClientSources r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D66520
2021-05-24 13:55:06 +00:00
Eden Chuang
2ed195d384 Bug 1584007 - let ClientHandleParents wait on FutureClientSourceParents r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
Differential Revision: https://phabricator.services.mozilla.com/D66154
2021-05-24 13:55:06 +00:00
Eden Chuang
883943e462 Bug 1584007 - let ClientManagerService store FutureClientSourceParent r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
The changes only make it possible for ClientManagerService to store
FutureClientSourceParents, but it will not actually store them until
following changesets.

Differential Revision: https://phabricator.services.mozilla.com/D66145
2021-05-24 13:55:06 +00:00
Eden Chuang
e48c6ff8ce Bug 1584007 - initial implementation of FutureClientSourceParent r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
Also implements SourceTableEntry and nsIDHasher to switch ClientManagerService's
nsDataHashTable to a mozilla::HashMap<nsID, SourceTableEntry> in following
changesets.

Differential Revision: https://phabricator.services.mozilla.com/D66144
2021-05-24 13:55:05 +00:00
Michelle Goossens
f5a803b567 Bug 1711500 - Remove checks for gProton and gProtonDoorhangers smart pref getters from tests r=Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D115748
2021-05-24 13:46:39 +00:00
ffxbld
bf49b309c8 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D115803
2021-05-24 13:18:18 +00:00
Andreu Botella
ada7ee07a3 Bug 1697292 - Update the WebExtensions' multipart/form-data parser to match Chrome. r=mixedpuppy
This will also make the parser compatible with the changes to the multipart/form-data serializer in bug 1686765.

Differential Revision: https://phabricator.services.mozilla.com/D108679
2021-05-24 13:17:57 +00:00
Andreu Botella
ca81ae3abb Bug 1686765 - Update newline normalization in form payloads. r=smaug
This commit also changes the way escapes work in multipart/form-data names and filenames.

Differential Revision: https://phabricator.services.mozilla.com/D108000
2021-05-24 13:17:56 +00:00
Rob Wu
bdd7ad55e3 Bug 1662857 - Report blocklist.addonBlockChange to telemetry r=rpl,Gijs
Report to telemetry when add-on is blocked by the blocklist, or when an
updated/installation resutls in the unblocking of an add-on.

Differential Revision: https://phabricator.services.mozilla.com/D114820
2021-05-24 13:07:12 +00:00
Rob Wu
a4780e1253 Bug 1662857 - Avoid intermittent failures by AddonTestUtils.promiseCompleteInstall r=rpl
Tests that rely on `AddonTestUtils.promiseCompleteInstall` to await the
completion of an update may encounter intermittent test failures,
because the test helper relies on `onInstallEnded`, which is sent before
all cleanup has run (removing temp xpi, removing staged directory).

The `install()` method returns a promise that is resolved right after
the cleanup of those temporary files. So await that.

Also fixed an intermittent issue in test_system_upgrades.js that became
a permafail as the result of this patch.



fix test_system_upgrades.js / promiseCompleteAllInstalls

Differential Revision: https://phabricator.services.mozilla.com/D114819
2021-05-24 13:07:12 +00:00
Rob Wu
7afe827e79 Bug 1662857 - Put version check in getNewestCompatibleUpdate r=mixedpuppy
AddonUpdateChecker.getNewestCompatibleUpdate has only one non-test
consumer in XPIInstall.jsm. That consumer filters out older versions
after finding an update.

In order to correctly report whether an update is blocked by the
blocklist, the version comparison has been moved inside the
getNewestCompatibleUpdate method, with no other changes.

Differential Revision: https://phabricator.services.mozilla.com/D114818
2021-05-24 13:07:12 +00:00
Rob Wu
d19c77ef12 Bug 1662857 - Record blocklist source in telemetry r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D114817
2021-05-24 13:07:11 +00:00
Marco Castelluccio
6a90978c31 Bug 1709810 - Remove outdated comment in taskcluster/test/test_mach_try_auto.py about Mac shippable builds. r=ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D114492
2021-05-24 12:57:49 +00:00
Cosmin Sabou
d0588a3b18 Backed out changeset beece7a29ecd (bug 1686765) for mochitest failures on test_ext_webrequest_upload.html. CLOSED TREE 2021-05-24 14:53:38 +03:00
Andreu Botella
b1453df956 Bug 1686765 - Update newline normalization in form payloads. r=smaug
This commit also changes the way escapes work in multipart/form-data names and filenames.

Differential Revision: https://phabricator.services.mozilla.com/D108000
2021-05-24 10:51:59 +00:00
Dão Gottwald
1af3773c48 Bug 1712297 - Hide pinned search shortcut when its engine gets removed/hidden. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D115703
2021-05-24 10:41:47 +00:00
Emilio Cobos Alvarez
449a9eb878 Bug 1712278 - Prevent arrowscrollbox from scrolling more than one page at a time when using line scrolling. r=Gijs
An alternative to this is changing the line scrolling acceleration Gecko
does to double the amount-per-line, rather than the amount-of-lines that
we scroll.

(But actually, even if we determine that that is a better course of
action, we probably want this anyways).

Differential Revision: https://phabricator.services.mozilla.com/D115692
2021-05-24 09:59:21 +00:00
Emilio Cobos Alvarez
77708167cd Bug 1712278 - Unify delta -> pixels logic in arrowscrollbox. r=Gijs
And fix a couple typos while at it.

Differential Revision: https://phabricator.services.mozilla.com/D115691
2021-05-24 09:59:20 +00:00
Masayuki Nakano
277c0f6994 Bug 1712269 - Make IMContextWrapper not use a set of composition if committed string is inserted without native composition signals r=m_kato
In GTK widget, we dispatch a set of composition events when IME or something
inserts text which is different from typing character or without tying a key.
However, this causes non-cancelable beforeinput event and Chromium on Linux
does not dispatch keyboard events nor composition events in this case, and the
beforeinput event in this case is cancelable.

Therefore, we should take same behavior as on macOS which was implemented by
bug 1520983.

Differential Revision: https://phabricator.services.mozilla.com/D115681
2021-05-24 05:57:07 +00:00
Kagami Sascha Rosylight
1638851116 Bug 1712255 - Defer SetMaxLength in SetValueFromSetRangeText r=masayuki
Capping selection range in SetValue early makes the subsequent SetSelectionRange call unable to detect actual selection range change. This patch defers it so that select events can be consistently fired.

Differential Revision: https://phabricator.services.mozilla.com/D115729
2021-05-24 03:11:27 +00:00
Alexandru Michis
42a1b9d860 Backed out changeset 2b813a59026a (bug 1710015) for causing crashes. 2021-05-24 01:28:47 +03:00
Mats Palmgren
0c2b4a6155 Bug 1474774 - Remove nscoord assertion that produce false positives. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D114633
2021-05-23 01:04:18 +00:00