Commit Graph

174 Commits

Author SHA1 Message Date
Butkovits Atila
20e2d30582 Backed out 4 changesets (bug 1765430) for causing android bustage. CLOSED TREE
Backed out changeset 72e27e3813d3 (bug 1765430)
Backed out changeset 47bbf5bd9315 (bug 1765430)
Backed out changeset e8161b463a3b (bug 1765430)
Backed out changeset 30c05f76d21e (bug 1765430)
2022-04-28 01:15:37 +03:00
Eitan Isaacson
3ee5a34515 Bug 1765430 - P4: Remove RemoteAccessibleWrap. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D144483
2022-04-27 21:01:36 +00:00
Eitan Isaacson
4dd84acb54 Bug 1765430 - P3: Refactor Android Pivot methods. r=Jamie
This creates a clearer distinction between local pivots and remote
pivots. The former happens in the parent process and the latter happens
in the remote content process.

Differential Revision: https://phabricator.services.mozilla.com/D144482
2022-04-27 21:01:36 +00:00
Eitan Isaacson
a010f500aa Bug 1765430 - P2: Manage Android accessible/id mappings in SessionAccessibility. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D144481
2022-04-27 21:01:35 +00:00
Eitan Isaacson
d5e1e3314e Bug 1765430 - P1: Move ToBundle to SessionAccessibility. r=Jamie
Since remote accessibles won't share AccessibleWrap as a base class
anymore this can't be an instance method. Move it to
SessionAccessibility, the sole consumer.

Note: ToBundle will hopefully get removed entirely once CTW is fully adopted.

Differential Revision: https://phabricator.services.mozilla.com/D144480
2022-04-27 21:01:35 +00:00
Eitan Isaacson
395df0c9f2 Bug 1765651 - Put DOMNodeID in Accessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D144234
2022-04-22 16:31:42 +00:00
Eitan Isaacson
ce4771430d Bug 1713050 - P3: Add more granularities to AXSelectedTextChanged events. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D139747
2022-03-16 05:56:26 +00:00
Morgan Reschenberg
1fcc546b3a Bug 1733268: Cache states::OPAQUE1, update state on style change r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D140894
2022-03-15 18:46:46 +00:00
Eitan Isaacson
946b487baa Bug 1758811 - P3: Don't push cache when gecko cache is available. r=Jamie
This requires a little bit of decoupling of dispatching
WINDOW_CONTENT_CHANGED events when the content changes.

Differential Revision: https://phabricator.services.mozilla.com/D140751
2022-03-11 18:55:43 +00:00
Eitan Isaacson
0a81a46878 Bug 1758592 - P2: Return a value when pivoting and use it in parent-side traversal. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D140684
2022-03-10 00:11:40 +00:00
Eitan Isaacson
22a62daa19 Bug 1758592 - P1: Add IsCacheEnabled JNI method. r=Jamie
This is a simple method for checking a pref.

Differential Revision: https://phabricator.services.mozilla.com/D140683
2022-03-10 00:11:40 +00:00
Eitan Isaacson
b072f12d3c Bug 1758009 - Add a forwarder for description in RemoteAccessibleWrap. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D140259
2022-03-04 21:48:27 +00:00
Iulian Moraru
3477db368d Backed out changeset 7f96452dbcfd (bug 1758009) for causing android build bustages on RemoteAccessibleWrap. CLOSED TREE 2022-03-04 22:07:18 +02:00
Eitan Isaacson
23bf01f132 Bug 1758009 - Add a forwarder for description in RemoteAccessibleWrap. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D140259
2022-03-04 19:49:13 +00:00
Eitan Isaacson
57f4ee0c7b Bug 1757812 - P2: Move pivot in parent when caching is enabled. r=morgan
This is a baby step in the caching direction. It isn't perfect yet.
Specifically, cache we have now in Android depends on a cache push
from content that doesn't happen if we do this all parent side.

So most of the junit tests pass, except for the heading one because
we don't cache heading levels in the less complete viewport cache.

tl;dr
This will work right when the accessibles being retrieved are from our
ctw cache. This will happen in followup bugs.

Differential Revision: https://phabricator.services.mozilla.com/D140120
2022-03-03 22:04:39 +00:00
Eitan Isaacson
add4ad659f Bug 1757812 - P1: Make Android traversal rules remote friendly. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D140102
2022-03-03 22:04:38 +00:00
Emilio Cobos Álvarez
957e1363f5 Bug 1756323 - Cleanup mouse event coord code. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D139234
2022-02-21 11:53:02 +00:00
James Teh
d3319fc982 Bug 1747172: Support cached RemoteAccessible in Pivot text methods. r=eeejay
The XPCOM interface and AccVCChangeEvent still only support LocalAccessible.
These will need to be updated/refactored in the future.

Differential Revision: https://phabricator.services.mozilla.com/D138247
2022-02-15 05:35:14 +00:00
Morgan Reschenberg
57c2acce79 Bug 1748878: Use LayoutDeviceInt types for points, rects, sizes in dev pixels r=Jamie,emilio
Differential Revision: https://phabricator.services.mozilla.com/D135272
2022-01-18 23:31:21 +00:00
Butkovits Atila
e5a82d2e01 Backed out changeset 6c3a672524b7 (bug 1748878) for causing accessibility crashes. a=backout 2022-01-20 17:24:17 +02:00
Morgan Reschenberg
ac66a0e8a8 Bug 1748878: Use LayoutDeviceInt types for points, rects, sizes in dev pixels r=Jamie,emilio
Differential Revision: https://phabricator.services.mozilla.com/D135272
2022-01-18 23:31:21 +00:00
Eitan Isaacson
b11dca3e81 Bug 1744315 - P3: Do explore by touch via DOM event. r=Jamie,botond
Differential Revision: https://phabricator.services.mozilla.com/D132842
2021-12-28 20:41:23 +00:00
Eitan Isaacson
70cf770e32 Bug 1744315 - P2: Don't traverse into remote accessibles in explore by touch. r=Jamie
Our default traversal rule will eventually work with remote trees, but
explore by touch will be local-only until we do hittesting in the parent
process. This change prevents the parent process from drilling down past
outer docs into frames.

Differential Revision: https://phabricator.services.mozilla.com/D132841
2021-12-28 20:41:22 +00:00
James Teh
6309a094fe Bug 1742915 part 1: Move Attributes to base Accessible. r=morgan
The RemoteAccessibleBase implementation is a stub for now, but will be expanded in the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D132652
2021-12-07 03:37:03 +00:00
Chris Peterson
f6fdbf028a Bug 1738401 - Remove -Wno-shadow warning suppressions. r=firefox-build-system-reviewers,glandium
-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.

There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.

Differential Revision: https://phabricator.services.mozilla.com/D132289
2021-12-01 06:40:04 +00:00
James Teh
cccfd3eb4e Bug 1734517: static_cast from DocAccessible* to DocAccessibleWrap* instead of reinterpret_cast. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D127762
2021-10-08 00:52:39 +00:00
Daniel Holbert
ed93bd5007 Bug 1733465 part 2: Modernize nsViewManager::GetRootWidget() to use already_AddRefed return value, instead of requiring getter_AddRefs at callsite. r=tnikkel
This patch shouldn't change behavior at all.

This patch replaces a manual NS_ADDREF call with typesafe code that manages the
reference count for us.  This reduces repeated boilerplate code, in the
implementation as well as the callsites.

Differential Revision: https://phabricator.services.mozilla.com/D127179
2021-10-01 20:38:09 +00:00
Olli Pettay
a6ae4c4cf1 Bug 1730541, remove nsCoreUtils::IsContentDocument, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D125462
2021-09-13 21:01:23 +00:00
Morgan Reschenberg
a58920e618 Bug 1694571: Replace AccessibleOrProxy's with Accessible's r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D117927
2021-07-22 17:58:49 +00:00
Eitan Isaacson
6ac35e15fc Bug 1714390 - P7: Add custom de/serializer for AccAttributes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D116788
2021-06-10 23:07:07 +00:00
Eitan Isaacson
349592fb91 Bug 1714390 - P6: Make more attribute keys static atoms. r=Jamie
Keys should be static atoms whenever possible.

Differential Revision: https://phabricator.services.mozilla.com/D116787
2021-06-10 23:07:07 +00:00
Eitan Isaacson
474a197205 Bug 1714390 - P4: Set non-string values in AccAttributes when possible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D116785
2021-06-10 23:07:06 +00:00
Eitan Isaacson
62d0cdcad4 Bug 1714390 - P2: Use AccAttributes for accessible and text attributes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D116783
2021-06-10 23:07:05 +00:00
Simon Giesecke
91fdeec18c Bug 1695162 - Migrate from custom hashtable iteration to range-based for in accessible, dom/animation, dom/base, dom/localstorage, gfx/thebes. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D106895
2021-03-12 16:14:58 +00:00
Alexandru Michis
c691800cb0 Backed out changeset fd03162e726d (bug 1695162) for causing bustages in Document.cpp
CLOSED TREE
2021-03-12 17:10:02 +02:00
Simon Giesecke
2fb6095f16 Bug 1695162 - Migrate from custom hashtable iteration to range-based for in accessible, dom/animation, dom/base, dom/localstorage, gfx/thebes. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D106895
2021-03-12 14:54:08 +00:00
Simon Giesecke
ad01a10a3b Bug 1634281 - Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.

Differential Revision: https://phabricator.services.mozilla.com/D106008
2021-03-10 10:47:47 +00:00
Eitan Isaacson
bafd5e712b Bug 1694203 - P9: Have RemoteAccessible inherit from Accessible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D104915
2021-03-02 16:32:24 +00:00
Eitan Isaacson
457ba6f552 Bug 1694203 - P8: Rename ChildrenCount to ChildCount in RemoteAccessible. r=Jamie
This will allow us to make this an override when inheriting from Accessible.

Differential Revision: https://phabricator.services.mozilla.com/D106005
2021-03-02 16:32:23 +00:00
Simon Giesecke
1a4038f6e7 Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in accessible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D106093
2021-03-01 09:59:30 +00:00
Simon Giesecke
9af107a839 Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Eitan Isaacson
6e8749d0da Bug 1693597 - P2: Rename ProxyAccessible to RemoteAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D105671
2021-02-19 23:14:33 +00:00
Eitan Isaacson
6e49732365 Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
Alexis Beingessner
07f2f659c6 Bug 1686616 - make StringBundle use Components instead of Services. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D105531
2021-02-18 13:26:32 +00:00
Eitan Isaacson
ff59e176e4 Bug 1692523 - P2: Prefix remote heirarchy functions with 'Remote'. r=Jamie
Parent -> RemoteParent
ChildAt -> RemoteChildAt
FirstChild -> RemoteFirstChild
LastChild -> RemoteLastChild
NextSibling -> RemoteNextSibling
PrevSibling -> RemotePrevSibling

Differential Revision: https://phabricator.services.mozilla.com/D105035
2021-02-16 20:05:11 +00:00
Eitan Isaacson
8c842a59e3 Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling

Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
Emilio Cobos Álvarez
7abb275b8f Bug 1666739 - Fix android build bustage.
MANUAL PUSH: Bustage on a CLOSED TREE.
2020-12-04 02:17:00 +01:00
Simon Giesecke
971b645fe3 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Ricky Stewart
02a7b4ebdf Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00