Commit Graph

5127 Commits

Author SHA1 Message Date
Nicholas Nethercote
63e3218e4c Back out changesets 2fcef6b54be7, 2be07829fefc, 66dfe37b8532, df3fcd2be8fd, 0a436bce77a6 (bug 1050035) for causing intermittent crashes and assertion failures.
--HG--
extra : rebase_source : eb30be83c3143c6c203585a80a18f180025efaba
2015-02-10 14:39:49 -08:00
Nicholas Nethercote
242708cf72 Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
--HG--
extra : rebase_source : 488e401ff87e31a2074c4108c4df0572d9536667
2015-02-09 14:34:50 -08:00
Andrew McCreight
d3826daa16 Back out Bug 1127201 (part 2) for various problems. 2015-02-06 15:04:32 -08:00
Robert O'Callahan
7a165b59ca Bug 1129774. Part 5: Remove aContext parameter from nsIWidget::Create. r=jmathies
--HG--
extra : rebase_source : 517ff800c0307e69465a37da7e52605d2fcda0d1
2015-02-05 20:35:25 +13:00
Kan-Ru Chen (陳侃如)
9bdcbebafe Bug 1114890 - Use TabParent::GetFrom everywhere. r=billm 2015-02-05 16:47:32 -05:00
Nicholas Nethercote
d34f0301b8 Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
--HG--
extra : rebase_source : 99182e70335d2b5ff95f8c528ae992d37294be3a
2015-02-04 20:05:36 -08:00
Ryan VanderMeulen
6048189ffc Backed out changeset ab7fbaca9fdd (bug 1114890) for being the likely cause of bug 1124046. 2015-02-05 14:35:35 -05:00
Kan-Ru Chen (陳侃如)
0c04d0ee7e Bug 1114890 - Use TabParent::GetFrom everywhere. r=billm 2015-02-05 17:18:22 +08:00
Andrew McCreight
6c00639ed2 Bug 1127430, part 3 - Fix even more braces in nsWebBrowser. r=smaug 2015-02-04 15:15:12 -08:00
Andrew McCreight
c0fa6504f0 Bug 1127430, part 2 - Fix indentation in nsWebBrowser. r=smaug 2015-02-04 15:15:12 -08:00
Andrew McCreight
f4c131136e Bug 1127430, part 1 - Tuck more braces in nsWebBrowser. r=smaug 2015-02-04 15:15:12 -08:00
Nicholas Nethercote
b5913e0b3d Bug 1050035 (part 4) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.

--HG--
extra : rebase_source : eeba14d732077ef2e412f4caca852de6b6b85f55
2015-02-02 14:48:58 -08:00
David Zbarsky
c73ec42d2d Bug 1125040: Use LayoutDeviceIntPoint for nsIWidget::WidgetToScreen r=botond 2015-02-04 15:21:03 -05:00
Nicholas Nethercote
3163cfc2c1 Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.

For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.

I'll do the trickier ones in subsequent patches.

--HG--
extra : rebase_source : ab37a7a30be563861ded8631771181aacf054fd4
2015-01-22 21:06:55 -08:00
Nicholas Nethercote
48710afc66 Bug 1124920 - Remove PLDHashTable::Operate(). r=froydnj.
--HG--
extra : rebase_source : f029d3ca8835232b3c1d4188aa63a0004c1aad4b
2015-01-22 15:43:18 -08:00
Patrick McManus
175115e709 bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz
These scriptable interfaces use uint_64 arguments with sentinel values
of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot
be gatewayed to/from javascript - so they cannot be used
correctly. Change them to use signed 64 bit numbers and -1 as the
sentinnel. C++ implementations ought to be enough to audit as the
special value could never be used correctly in JS anyhow - also
audited OnProgressChange() uses for downstream use of this data.
---
 dom/base/nsXMLHttpRequest.cpp                      | 19 +++++++----
 dom/base/nsXMLHttpRequest.h                        | 10 +++---
 dom/plugins/base/nsPluginStreamListenerPeer.cpp    |  4 +--
 .../webbrowserpersist/nsWebBrowserPersist.cpp      | 14 ++++----
 image/src/imgLoader.cpp                            |  4 +--
 modules/libjar/nsJARChannel.cpp                    |  3 +-
 netwerk/base/public/nsIProgressEventSink.idl       |  8 ++---
 netwerk/base/public/nsITransport.idl               |  8 ++---
 netwerk/base/public/nsNetUtil.h                    | 24 ++++++++++++++
 netwerk/base/src/Dashboard.cpp                     |  2 +-
 netwerk/base/src/nsBaseChannel.cpp                 | 12 +++----
 netwerk/base/src/nsIncrementalDownload.cpp         |  4 +--
 netwerk/base/src/nsSocketTransport2.cpp            |  5 +--
 netwerk/base/src/nsStreamTransportService.cpp      | 38 +++++++++++++---------
 netwerk/base/src/nsTransportUtils.cpp              | 12 +++----
 netwerk/protocol/file/nsFileChannel.cpp            |  8 +++--
 netwerk/protocol/ftp/nsFtpConnectionThread.cpp     |  4 +--
 netwerk/protocol/http/Http2Push.cpp                |  2 +-
 netwerk/protocol/http/Http2Session.cpp             |  2 +-
 netwerk/protocol/http/HttpChannelChild.cpp         | 31 +++++++++---------
 netwerk/protocol/http/HttpChannelChild.h           |  6 ++--
 netwerk/protocol/http/HttpChannelParent.cpp        |  4 +--
 netwerk/protocol/http/HttpChannelParent.h          |  4 +--
 netwerk/protocol/http/NullHttpTransaction.cpp      |  2 +-
 netwerk/protocol/http/PHttpChannel.ipdl            |  2 +-
 netwerk/protocol/http/SpdyPush31.cpp               |  2 +-
 netwerk/protocol/http/SpdySession31.cpp            |  2 +-
 netwerk/protocol/http/TunnelUtils.cpp              |  2 +-
 netwerk/protocol/http/nsAHttpTransaction.h         |  4 +--
 netwerk/protocol/http/nsHttpChannel.cpp            | 30 +++++++++++------
 netwerk/protocol/http/nsHttpConnection.cpp         |  4 +--
 netwerk/protocol/http/nsHttpConnectionMgr.cpp      |  4 +--
 netwerk/protocol/http/nsHttpPipeline.cpp           |  4 +--
 netwerk/protocol/http/nsHttpPipeline.h             |  6 ++--
 netwerk/protocol/http/nsHttpResponseHead.cpp       |  2 +-
 netwerk/protocol/http/nsHttpResponseHead.h         |  2 +-
 netwerk/protocol/http/nsHttpTransaction.cpp        | 32 +++++++++---------
 netwerk/protocol/http/nsHttpTransaction.h          |  2 +-
 netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp   |  2 +-
 netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp      |  3 +-
 netwerk/test/TestIncrementalDownload.cpp           |  7 ++--
 uriloader/base/nsDocLoader.cpp                     | 14 ++++----
 42 files changed, 203 insertions(+), 151 deletions(-)
2015-01-08 14:48:52 -05:00
Nicholas Nethercote
69fe655b04 Bug 1121304 (part 2, attempt 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
--HG--
extra : rebase_source : bc119bd0d3b6944e8c5a000950e0c4052cb70aef
2015-01-14 14:35:56 -08:00
Phil Ringnalda
e39f0adeca Backed out 2 changesets (bug 1121304) for consistent b2g hangs in webgl-color-test.html?frame=1&__&preserve&premult&_____
Backed out changeset 20651ac19549 (bug 1121304)
Backed out changeset 758afec77c95 (bug 1121304)
2015-01-14 22:02:23 -08:00
Nicholas Nethercote
e9735966fa Bug 1121304 (part 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj. 2015-01-14 14:35:56 -08:00
Nicholas Nethercote
47221bc7f9 Bug 1120476 (part 4) - Remove PLDHashTableOps::finalize. r=froydnj.
--HG--
extra : rebase_source : b14dda8cdd5cd896d1e32950e38b2a9f7da4d99e
2015-01-13 19:02:35 -08:00
Nicholas Nethercote
c7538c9776 Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj.
--HG--
extra : rebase_source : 24d10af3dbce3ada5252503bc80bb1a4e31bc1c9
2015-01-13 16:42:13 -08:00
Nicholas Nethercote
699e7b5b3e Bug 1120476 (part 2) - Avoid using PLDHashTable::data in nsCommandParams. r=froydnj.
--HG--
extra : rebase_source : 892170937a41229301be81236d2517f09e20138d
2015-01-13 16:40:47 -08:00
Ehsan Akhgari
5aa084025f Bug 1119261 - Mark virtual overridden functions as MOZ_OVERRIDE in embedding; r=bsmedberg 2015-01-12 23:26:27 -05:00
Wes Kocher
ff83d4dbc2 Backout 58cb6ed02553 (bug 1120622, bug 1120620, bug 1119068, bug 1119268, bug 1119264, bug 1119261) for b2g build bustage on a CLOSED TREE 2015-01-12 14:48:13 -08:00
Ehsan Akhgari
41d5c33e31 Bug 1119261 - Mark virtual overridden functions as MOZ_OVERRIDE in embedding; r=bsmedberg 2015-01-12 16:35:04 -05:00
Ryan VanderMeulen
b4ff41d68e Bug 1119818 - Bump various UUIDs that were missed when IDL changes landed. r=jib, r=jdm, r=gavin, r=bz, a=me 2015-01-12 10:44:18 -05:00
Michael Pruett
411a94b05a Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd 2015-01-05 20:27:28 -06:00
Ehsan Akhgari
860da94550 Bug 1114999 - Part 2: Apply MOZ_NO_ADDREF_RELEASE_ON_RETURN to all smart pointer arrow operators that can return refcounted objects; r=jrmuizel 2015-01-06 16:30:03 -05:00
Andrew McCreight
2d777fa84c Bug 1064439, part 16 - Eliminate indirection in nsWebBrowser::mListenerArray. r=jst
Incidentally, this fixes a leak in nsWebBrowser::RemoveWebBrowserListener.
2014-12-16 09:18:02 -08:00
Andrew McCreight
5eb1ca5d76 Bug 1064439, part 15 - Convert nsWebBrowser::mListenerArray to an nsAutoPtr. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
fab20cd349 Bug 1064439, part 14 - Turn nsWebBrowser::mStream into an nsRefPtr and eliminate mStreamGuard. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
1f8c51305b Bug 1064439, part 13 - Use nsAutoPtr for nsWebBrowser::mInitInfo. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
796da5cb52 Bug 1064439, part 12 - Use nullptr in nsWebBrowser. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
edf00d8802 Bug 1064439, part 11 - Make nsWebBrowser::mDocShellTreeOwner into an nsRefPtr. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
f2af6c4451 Bug 1064439, part 10 - Take advantage of infallible alloc in nsWebBrowser. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
1cb173b6b4 Bug 1064439, part 9 - Get rid of a take in nsWebBrowser. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
5ac2e6b958 Bug 1064439, part 8b - Fix if( in nsWebBrowser.cpp. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
5f1a422255 Bug 1064439, part 8a - Get rid of trailing whitespace in nsWebBrowser. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
6161615840 Bug 1064439, part 7 - Surely DefaultTooltipTextProvider doesn't need threadsafe refcounting. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
b47f361ad8 Bug 1064439, part 6 - Get rid of weird C-style cast and QI of DefaultTooltipTextProvider. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
0dae524e74 Bug 1064439, part 5 - Use nsRefPtrs in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
7e5d17d702 Bug 1064439, part 4 - Use less ADDREF in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
3b279272a6 Bug 1064439, part 3 - Take advantage of infallible new in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
b58ae22b4b Bug 1064439, part 2 - Use nullptr in a few places in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
669aa09977 Bug 1064439, part 1e - Get rid of more space around parens in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
78f3159e8a Bug 1064439, part 1d - Cuddle else in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
d91383288a Bug 1064439, part 1c - Get rid of if ( foo ) in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
f7c0e804ba Bug 1064439, part 1b - Get rid of if( in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
81b90b829c Bug 1064439, part 1a - Remove trailing whitespace from nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Ehsan Akhgari
ebdf8e7c36 Bug 1109746 - Fix more bad implicit constructors in some random code across the tree
--HG--
extra : amend_source : 48ca151cb1ca2193404c65831556051c02093914
2014-12-13 14:17:04 -05:00