Commit Graph

4029 Commits

Author SHA1 Message Date
Gabriele Svelto
8cbbe7f4b5 Bug 1264367 - Upgrade breakpad to upstream revision 704f41ec901c419f8c321742114b415e6f5ceacc r=ted
* * *
Bug 1264367 - Accomodate for the new version of Breakpad
2016-10-05 11:46:07 +02:00
Kris Maglione
9174046b25 Bug 1307622: Fix handling of ignored file warnings. r=Mossop
MozReview-Commit-ID: EV3YPfsSSDS

--HG--
extra : rebase_source : f7c97a54514a65de53c8c3587ccbe386d71379cc
2016-10-04 22:44:50 +01:00
Tom Schuster
774a8bf34d Bug 1302163 - Change code to use SprintfLiteral instead of snprintf. r=ehsan 2016-10-04 17:57:51 +02:00
Tom Tromey
7bc8491bea Bug 1067547 - unify ScopedLogging implementations and use in nsEmbedFunctions; r=bsmedberg
MozReview-Commit-ID: 6hDZDaBsNFM

--HG--
extra : rebase_source : 9422c235ebdffd84e06137bb2c63ce106cb39f0b
2016-09-26 11:06:38 -06:00
Tom Tromey
1b3a828426 Bug 1067547 - add more uses of MOZ_COUNT_CTOR to tools/profiler; r=bsmedberg
MozReview-Commit-ID: 5Gf5OkydkL0

--HG--
extra : rebase_source : a32eabd5c8d051370b0f52e1b8edf8029da95a6d
2016-09-26 11:05:44 -06:00
Prabhjyot Singh Sodhi
ebb9f983f1 Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal
MozReview-Commit-ID: INBZaZzcPmF

--HG--
extra : rebase_source : c0ba416f110b2768fc744de0fbee21c765081400
2016-09-28 08:28:04 -04:00
Jan de Mooij
e079cbfe2a Bug 1302914 - Use GetThreadContext after calling SuspendThread to ensure threads are really suspended. r=froydnj 2016-09-29 20:05:36 +02:00
Jim Chen
52cdccecbf Bug 1305271 - Only enable Java profiling on Android; r=bustage on CLOSED TREE
Only enable Java profiling (and access jni::IsFennec) on Android, where
Java profiling makes sense.
2016-09-29 00:11:57 -04:00
Jim Chen
3f0f41aeb3 Bug 1305271 - 2. Add and use jni::IsFennec() for Fennec-only code; r=snorp
Add jni::IsFennec() that returns whether we're in a Fennec environment
(defined as the presence of the GeckoApp class). Then, add
jni::IsFennec() checks to places where we use JNI for Fennec-only classes.
2016-09-28 23:49:25 -04:00
Kartikaya Gupta
2a997eb496 Bug 1304694 - Fix windows builds which don't have MOZ_STACKWALKING defined. r=froydnj
MozReview-Commit-ID: I1UIlVWbu9T
2016-09-22 16:21:56 -04:00
Eric Faust
121151ec67 Bug 1263595 - Avoid deadlock between the JIT and the gecko profiler on win64. (r=froydnj) 2016-09-15 21:35:14 -07:00
Wes Kocher
765926408d Backed out changeset e1d144423657 (bug 1280571) for making leaks hard to diagnose a=backout CLOSED TREE 2016-09-21 16:56:50 -07:00
Phil Ringnalda
b9ee856eba Backed out changeset ae50c61cb134 (bug 1264367) for breaking crash stacks on at least Android and Linux 2016-09-21 13:26:24 -07:00
Gabriele Svelto
b3a7e5c8a0 Bug 1264367 - Upgrade breakpad to upstream revision 704f41ec901c419f8c321742114b415e6f5ceacc r=ted 2016-09-21 17:44:50 +02:00
Prabhjyot Singh Sodhi
58b6130e52 Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal
This also adds E402 (no imports at top of file) to the global ignore list. The
other error codes added were previously ignored by default, but now that we
have started a custom ignore list, need to be listed explicitly.

MozReview-Commit-ID: RtMuVEX6i5

--HG--
extra : rebase_source : 939bc9354f5891c680513d7e9068d0438e169132
2016-09-21 08:49:46 -04:00
Carsten "Tomcat" Book
4f900773f5 merge mozilla-inbound to mozilla-central a=merge 2016-09-21 12:03:31 +02:00
Jim Chen
27143e4fba Bug 1303806 - 3. Update sources to reflect new bindings; r=snorp r=nalexander
Update #includes to use new headers if necessary. Also remove a couple
of functions in AndroidBridge to clean up the code.
2016-09-20 17:42:08 -04:00
Philipp Kewisch
a5e487b1ed Bug 1298879 - Upgrade to ESLint 3.5.0 for faster linting. r=miker
--HG--
extra : amend_source : f9192046a1c22f631d6423ce4ffc6e4e0e11dfc1
2016-09-20 10:27:03 +01:00
Carsten "Tomcat" Book
17d545681a Merge mozilla-central to mozilla-inbound 2016-09-20 12:02:20 +02:00
Philipp Kewisch
7fca5359ea Bug 1303725 - Make mach eslint output more helpful in case of an error. r=miker
MozReview-Commit-ID: KvTrBfnPjtn

--HG--
extra : rebase_source : a8060752ea34cffb964b654535c19b04a0cb8598
2016-09-19 22:17:40 +02:00
Bryce Van Dyk
00c9132cb6 Bug 1303646 - Escape backslashes when processing flake8 output. r=ahal
During process_line each line is loaded into JSON. As it stands it is possible
to attempt loads on lines containing single backslashes. This will fail the
load as these characters are invalid in JSON. This is particularly noticeable on
Windows, where all paths will contain these characters.

This changeset escapes any back slashes in the lines. It also adds logging to
the error case for the JSON loading, so failures aren't silently swallowed.

***
Fix issues brought up in review, silly mistakes in last changeset.

- Update log message upon encountering non JSON linter output that cannot be
  handled by json.loads.
- Correct typo: formate -> format.
- Correct replace string. Was using r'\\\\', which will evaluate to 3 slashes,
  now using '\\\\', which evaluates to 2. Opting not to use a raw string here
  because of the confusion over the final backslash interaction (final one still
  needs to be escaped even in a raw string).

MozReview-Commit-ID: Hfa0jSdnege

--HG--
extra : rebase_source : bd29d2437cf61f01df6d01a70ed651b49e33656e
2016-09-20 08:41:09 +12:00
James Graham
b20e631b19 Bug 1302796 - Add --check-clean flag to mach manifest update and mozlint integration, r=ahal,Ms2ger
MozReview-Commit-ID: 8Z4ywNEbF8G

--HG--
extra : rebase_source : 029995f188d14d0b70ed6e146a0feb71a046512f
2016-09-13 14:20:20 +01:00
James Graham
bba975bca2 Bug 1302796 - Add integration between structured logging and lints, r=ahal
MozReview-Commit-ID: K3tu0Zdg5go

--HG--
extra : rebase_source : 2b78059908c3a297b8ce7d134af20733fc082df5
2016-09-13 14:18:41 +01:00
Phil Ringnalda
a6e7ea4e26 Backed out changeset af84ff6bfd7e (bug 1264367) for causing crash stacks to lack symbols
CLOSED TREE
2016-09-15 19:15:45 -07:00
Robert Strong
18c6c1312d Bug 1295542 - Update packaging accordingly. r=bhearsum 2016-09-20 13:44:25 +09:00
Gabriele Svelto
6fc3c4e6fd Bug 1264367 - Upgrade breakpad to upstream revision 704f41ec901c419f8c321742114b415e6f5ceacc r=ted 2016-09-15 17:31:13 +02:00
Christian Holler
ed2743696a Bug 1289194 - Move tools/fuzzing/libfuzzer reference to toolkit. r=ted
MozReview-Commit-ID: B5eiDyqmMXk

--HG--
extra : rebase_source : 268eb125f01d00b4d8ef1826566131cc179d7979
2016-09-10 02:27:23 +02:00
Christian Holler (:decoder)
69b3ee60b9 Bug 1289194 - Make LibFuzzerRunner use its own private ScopedXPCOM copy. r=ted
MozReview-Commit-ID: Kul2N4GA7O7

--HG--
extra : rebase_source : f2706dcf33c1d589b4f3711634c1d45c3a036f95
2016-08-24 22:35:03 +02:00
Christian Holler (:decoder)
3c7149e85d Bug 1289194 - Experimental LibFuzzer integration. r=glandium
MozReview-Commit-ID: 9njDcbltyow

--HG--
extra : rebase_source : 774d25f2ac4e4b1a876e48159333188bc722f940
2016-09-01 15:07:01 +02:00
Nathan Froyd
e5a612a8f0 Bug 1298151 - fix member initialization order in platform-win32.cc; r=BenWa 2016-09-14 19:28:26 -04:00
Jan de Mooij
7f794780e0 Bug 1302448 part 2 - Rename XPCJSRuntime to XPCJSContext. r=mrbkap
--HG--
rename : js/xpconnect/src/XPCJSRuntime.cpp => js/xpconnect/src/XPCJSContext.cpp
extra : rebase_source : e6b435ab1ca2739e340669195dff77c561ea573e
2016-09-14 15:48:17 +02:00
Jon Coppeard
d97a19687b Bug 1298639 - Use bytecode offsets rather than direct pointer in profiling API r=shu 2016-09-13 14:06:46 +02:00
Jon Coppeard
c5e590d3e6 Bug 1297360 - Copy strings returned by ProfilingFrameIterator API r=djvj 2016-09-08 13:38:37 +01:00
Aaron Klotz
f2f2b539f2 Bug 1301167: Add a GeckoProfilerWakeRAII interface to the profiler; r=BenWa
MozReview-Commit-ID: KGn9qF7fZAs
2016-09-07 14:28:50 -06:00
Sebastian Hengst
a66df0b0c2 Backed out changeset 95e68b473e91 (bug 1289194) for failure to process moz.build file. r=backout a=backout
MozReview-Commit-ID: GhfzNoiE808
2016-09-07 18:45:40 +02:00
Sebastian Hengst
24724bde80 Backed out changeset 13a770064f3e (bug 1289194)
MozReview-Commit-ID: ILJkzxfSLdU
2016-09-07 18:44:36 +02:00
Carsten "Tomcat" Book
1c61ba654e merge mozilla-inbound to mozilla-central a=merge 2016-09-07 17:20:12 +02:00
Henrik Skupin
a5a7c13571 Bug 1300776 - Add testing/marionette/harness to flake8 linter (except mixins, tests) . r=ahal
MozReview-Commit-ID: F9Hfze9zvzE

--HG--
extra : rebase_source : ddd2e63bf13967da1d66d49cbdd189b68e0e7402
2016-09-06 15:46:08 +02:00
Christian Holler (:decoder)
c0f039672e Bug 1289194 - Make LibFuzzerRunner use its own private ScopedXPCOM copy. r=ted
--HG--
extra : histedit_source : b3e8b3ced49f6aeb35a156251f37f7b463624891
2016-08-24 22:35:03 +02:00
Christian Holler (:decoder)
055c4fb1dd Bug 1289194 - Experimental LibFuzzer integration. r=glandium
--HG--
extra : histedit_source : a632f3ff76e07562d1854bc68b50499e4b4667a0
2016-09-01 15:07:01 +02:00
Andi-Bogdan Postelnicu
59f394c4bb Bug 1300080 - add to mozilla repository the modeling file for coverity. r=Ehsan
MozReview-Commit-ID: 98mbNizREWv

--HG--
extra : rebase_source : 16acc04d7fecf6c8a082288eaed0a6b61fa89a87
2016-09-03 08:55:58 +03:00
Andrew Halberstadt
1cad660f54 Bug 1299540 - Fix WindowsError when running eslint from msys, r=smacleod
This fixes a regression from bug 1258341 where the eslint binary no longer
gets run from a shell on msys. Without this, a WindowsError [Error 139] is
thrown.

MozReview-Commit-ID: FQ3LhTzd8nL

--HG--
extra : rebase_source : 33490fd9e41a2691f0b0c815916185fcf8936987
2016-08-31 14:32:44 -04:00
Andrew Halberstadt
c40eeb57dc Bug 1258341 - Merge eslint-plugin-mozilla docs with the main linting docs, r=miker
This does 3 things:

1) Moves all the long descriptions for the rules into the main index.rst
   document. This just makes it simpler, and there didn't seem to be much
   point in having a separate document for each rule.
2) Moves index.rst to tools/lint/docs/eslint-plugin-mozilla.rst
3) Creates a new eslint.rst landing page, and includes it.

MozReview-Commit-ID: 1e3QBkMFOBe

--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/docs/index.rst => tools/lint/docs/linters/eslint-plugin-mozilla.rst
extra : rebase_source : ab2c5c89bfa77da994f20fbecffed25e9f475ce8
2016-08-25 11:58:32 -04:00
Andrew Halberstadt
6bd4aab95e Bug 1258341 - Rewrite eslint taskcluster task to use |mach lint| instead of |mach eslint|, r=smacleod
This also renames the tasks:

    eslint-gecko -> mozlint-eslint
    flake8-gecko -> mozlint-flake8

MozReview-Commit-ID: KYhC6SEySC3

--HG--
rename : taskcluster/ci/legacy/tasks/tests/eslint-gecko.yml => taskcluster/ci/legacy/tasks/tests/mozlint-eslint.yml
extra : rebase_source : 3f3b4d0226bf014d49ade2eb56b67ce62197e179
2016-08-25 10:00:51 -04:00
Andrew Halberstadt
9703ac2438 Bug 1258341 - Modify 'eslint' implementation to work with the mozlint framework, r=smacleod
This integrates 'eslint' with the mozlint framework. The old |mach eslint| command is kept around
for backwards compatibility and will simply dispatch to |mach lint|. But |mach lint| should be
preferred as the old command may eventually be removed.

The old |mach eslint| command should be mostly backwards compatible with a few exceptions:

    1. Can no longer define --extensions on the command line, this is instead hardcoded into
       eslint.lint.
    2. No longer using eslint formatters. However, the default mozlint formatter should be
       identical to the default eslint formatter, so developers should not notice a change.
       This does mean that non-default eslint formatters can no longer be used unless a mozlint
       copy of them is created.
    3. Installs dependencies automatically without prompting the user. This was necessary due to
       python multiprocessing limitations, but is actually also a better UX. Because the npm
       dependencies aren't global anymore, there isn't really any reason *not* to install them
       automatically.

Apart from that, any difference from the old |mach eslint| I'd consider a bug.

The main eslint implementation now lives in tools/lint/eslint.lint instead of
tools/lint/mach_commands.py.


MozReview-Commit-ID: KYhC6SEySC3

--HG--
extra : rebase_source : 36d06b1a3fced764e17154cc53091d7722919b67
2016-08-30 14:28:56 -04:00
Nicholas Nethercote
34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Ryan VanderMeulen
e5adfbffe6 Merge m-c to autoland. a=merge
--HG--
rename : accessible/tests/browser/browser_caching_attributes.js => accessible/tests/browser/e10s/browser_caching_attributes.js
rename : accessible/tests/browser/browser_caching_description.js => accessible/tests/browser/e10s/browser_caching_description.js
rename : accessible/tests/browser/browser_caching_name.js => accessible/tests/browser/e10s/browser_caching_name.js
rename : accessible/tests/browser/browser_caching_relations.js => accessible/tests/browser/e10s/browser_caching_relations.js
rename : accessible/tests/browser/browser_caching_states.js => accessible/tests/browser/e10s/browser_caching_states.js
rename : accessible/tests/browser/browser_caching_value.js => accessible/tests/browser/e10s/browser_caching_value.js
rename : accessible/tests/browser/browser_events_caretmove.js => accessible/tests/browser/e10s/browser_events_caretmove.js
rename : accessible/tests/browser/browser_events_hide.js => accessible/tests/browser/e10s/browser_events_hide.js
rename : accessible/tests/browser/browser_events_show.js => accessible/tests/browser/e10s/browser_events_show.js
rename : accessible/tests/browser/browser_events_statechange.js => accessible/tests/browser/e10s/browser_events_statechange.js
rename : accessible/tests/browser/browser_events_textchange.js => accessible/tests/browser/e10s/browser_events_textchange.js
rename : accessible/tests/browser/browser_treeupdate_ariadialog.js => accessible/tests/browser/e10s/browser_treeupdate_ariadialog.js
rename : accessible/tests/browser/browser_treeupdate_ariaowns.js => accessible/tests/browser/e10s/browser_treeupdate_ariaowns.js
rename : accessible/tests/browser/browser_treeupdate_canvas.js => accessible/tests/browser/e10s/browser_treeupdate_canvas.js
rename : accessible/tests/browser/browser_treeupdate_cssoverflow.js => accessible/tests/browser/e10s/browser_treeupdate_cssoverflow.js
rename : accessible/tests/browser/browser_treeupdate_doc.js => accessible/tests/browser/e10s/browser_treeupdate_doc.js
rename : accessible/tests/browser/browser_treeupdate_gencontent.js => accessible/tests/browser/e10s/browser_treeupdate_gencontent.js
rename : accessible/tests/browser/browser_treeupdate_hidden.js => accessible/tests/browser/e10s/browser_treeupdate_hidden.js
rename : accessible/tests/browser/browser_treeupdate_imagemap.js => accessible/tests/browser/e10s/browser_treeupdate_imagemap.js
rename : accessible/tests/browser/browser_treeupdate_list.js => accessible/tests/browser/e10s/browser_treeupdate_list.js
rename : accessible/tests/browser/browser_treeupdate_list_editabledoc.js => accessible/tests/browser/e10s/browser_treeupdate_list_editabledoc.js
rename : accessible/tests/browser/browser_treeupdate_listener.js => accessible/tests/browser/e10s/browser_treeupdate_listener.js
rename : accessible/tests/browser/browser_treeupdate_optgroup.js => accessible/tests/browser/e10s/browser_treeupdate_optgroup.js
rename : accessible/tests/browser/browser_treeupdate_removal.js => accessible/tests/browser/e10s/browser_treeupdate_removal.js
rename : accessible/tests/browser/browser_treeupdate_table.js => accessible/tests/browser/e10s/browser_treeupdate_table.js
rename : accessible/tests/browser/browser_treeupdate_textleaf.js => accessible/tests/browser/e10s/browser_treeupdate_textleaf.js
rename : accessible/tests/browser/browser_treeupdate_visibility.js => accessible/tests/browser/e10s/browser_treeupdate_visibility.js
rename : accessible/tests/browser/browser_treeupdate_whitespace.js => accessible/tests/browser/e10s/browser_treeupdate_whitespace.js
rename : accessible/tests/browser/doc_treeupdate_ariadialog.html => accessible/tests/browser/e10s/doc_treeupdate_ariadialog.html
rename : accessible/tests/browser/doc_treeupdate_ariaowns.html => accessible/tests/browser/e10s/doc_treeupdate_ariaowns.html
rename : accessible/tests/browser/doc_treeupdate_imagemap.html => accessible/tests/browser/e10s/doc_treeupdate_imagemap.html
rename : accessible/tests/browser/doc_treeupdate_removal.xhtml => accessible/tests/browser/e10s/doc_treeupdate_removal.xhtml
rename : accessible/tests/browser/doc_treeupdate_visibility.html => accessible/tests/browser/e10s/doc_treeupdate_visibility.html
rename : accessible/tests/browser/doc_treeupdate_whitespace.html => accessible/tests/browser/e10s/doc_treeupdate_whitespace.html
rename : accessible/tests/browser/events.js => accessible/tests/browser/e10s/events.js
rename : browser/components/extensions/test/browser/browser_ext_pageAction_context.js => browser/components/extensions/test/browser/browser_ext_pageAction_title.js
rename : browser/components/extensions/test/browser/browser_ext_pageAction_context.js => browser/components/extensions/test/browser/head_pageAction.js
rename : dom/events/test/pointerevents/pointerevent_element_haspointercapture.html => dom/events/test/pointerevents/pointerevent_element_haspointercapture-manual.html
rename : dom/events/test/pointerevents/test_pointerevent_element_haspointercapture.html => dom/events/test/pointerevents/test_pointerevent_element_haspointercapture-manual.html
rename : gfx/thebes/DeviceManagerD3D11.cpp => gfx/thebes/DeviceManagerDx.cpp
rename : gfx/thebes/DeviceManagerD3D11.h => gfx/thebes/DeviceManagerDx.h
rename : media/webrtc/trunk/tools/gyp/test/compiler-override/compiler.gyp => media/webrtc/trunk/tools/gyp/test/compiler-override/compiler-exe.gyp
rename : media/webrtc/trunk/tools/gyp/test/mac/app-bundle/TestApp/English.lproj/InfoPlist.strings => media/webrtc/trunk/tools/gyp/test/ios/app-bundle/TestApp/English.lproj/InfoPlist-error.strings
rename : media/webrtc/trunk/tools/gyp/test/mac/app-bundle/TestApp/English.lproj/InfoPlist.strings => media/webrtc/trunk/tools/gyp/test/mac/app-bundle/TestApp/English.lproj/InfoPlist-error.strings
rename : media/webrtc/trunk/tools/gyp/test/mac/gyptest-postbuild-static-library.gyp => media/webrtc/trunk/tools/gyp/test/mac/gyptest-postbuild-static-library.py
rename : media/webrtc/trunk/tools/gyp/test/rules/src/subdir4/asm-function.asm => media/webrtc/trunk/tools/gyp/test/rules/src/subdir4/asm-function.assem
rename : mfbt/unused.h => mfbt/Unused.h
rename : testing/web-platform/tests/pointerevents/pointerevent_element_haspointercapture.html => testing/web-platform/tests/pointerevents/pointerevent_element_haspointercapture-manual.html
extra : rebase_source : a3de7d91a61df9b14fe07a89f5b0184a067549cf
2016-08-25 08:14:36 -04:00
Ryan VanderMeulen
69113163cf Merge m-c to inbound. a=merge 2016-08-24 09:09:05 -04:00
Michael Ratcliffe
4fab0b64e1 Bug 1270926 - Shrinkwrap eslint support on XHTML files r=mratcliffe
MozReview-Commit-ID: 8i7Rayhzob5
2016-08-23 14:20:08 -07:00
Matthew Noorenberghe
a59bf6717f Bug 1270926 - Support ESLint on XHTML files. r=ahal
MozReview-Commit-ID: 4iYODbZQiB9
2016-08-23 14:42:21 -07:00