Commit Graph

10230 Commits

Author SHA1 Message Date
Kris Maglione
f8506d46d0 Bug 1460600: Remove unsupported --enable-system-hunspell flag. r=glandium
Our bundled Hunspell now significantly differs from upstream Hunspell. Most
importantly, it supports loading dictionaries from jar: URIs, which is now a
requirement for loading bundled and extension dictionaries. This means that
system Hunspell libraries are no longer compatible with our spell checker
code. We should remove the option to use them so that users don't fall into
the trap of trying to use them.

MozReview-Commit-ID: 2ihJe6YOnGf

--HG--
extra : rebase_source : ceb091b9475a2b101156405a02a60015fc36da17
2018-05-10 10:36:53 -07:00
Kris Maglione
6b12d08f7d Bug 1462937: Update callers to use nsIFile::GetDirectoryEntries as a nsIDirectoryEnumerator. r=froydnj
MozReview-Commit-ID: Iv4T1MVAF5

--HG--
extra : rebase_source : 1c518883d082884db7f9323a5acc20361228c26b
extra : histedit_source : 70a73c23d1199d3bfbb5379c78930401166c094b
2018-05-19 20:17:45 -07:00
Boris Zbarsky
40d2bf9d7f Bug 1377980 part 1. Remove use of nsIDOMRange in xpidl. r=mcc8 2018-05-17 12:01:37 -04:00
Mark Banner
fde1cad4f2 Bug 1461966 - Enable ESLint rule mozilla/use-services for extensions/pref. r=mkaply
MozReview-Commit-ID: 77pSaX70zdJ

--HG--
extra : rebase_source : 5889808b650902f06e0a7d911fd1d23313247217
2018-05-16 14:39:29 +01:00
Kris Maglione
aa484dadb6 Bug 1460748: Load the correct affix file for WebExtension dictionaries. r=aswan
MozReview-Commit-ID: 1arZbiexgma

--HG--
extra : rebase_source : c2553ef5899a8880f3862c4bcbb32e1c23421a37
2018-05-10 15:42:29 -07:00
Kris Maglione
d9040aac36 Bug 1457072: Get rid of unpacked dictionaries and the remaining unpacked install code. r=aswan
MozReview-Commit-ID: K36cUkKtuOB

--HG--
extra : rebase_source : 860e0ebe7bc0589eadb3ddf8976d19bab01b6ce4
2018-04-26 01:27:48 -07:00
Boris Zbarsky
1fb03996f4 Bug 1387143 part 29. Remove nsISelection. r=mats 2018-05-08 13:52:42 -04:00
Chris Peterson
71422dcaa9 Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L

--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Ekanan Ketunuti
50aa52b2d5 Bug 1459097 - Add words to en-US dictionary. r=ehsan 2018-05-04 08:32:09 +07:00
Masatoshi Kimura
154c9d2855 Bug 1442275 - Stop using PR_LoadLibrary in GSSAPI. r=mayhemer
MozReview-Commit-ID: 756qF1thw7A

--HG--
extra : rebase_source : 29af5e1c4e1c871b14d5094b2c397d82e05777f1
extra : source : bc230ca6b610d00ecbac5db6d50d31729f34a48d
2018-02-25 01:32:37 +09:00
Makoto Kato
db7992dc59 Bug 1457431 - Devirtualize mozInlineSpellChecker::SpellCheckAfterEditorChange. r=masayuki
It is unnecessary to keep virtual method for
mozInlineSpellChecker::SpellCheckAfterEditorChange, so we should remove virtual
keyword.

MozReview-Commit-ID: 2ry5uhMTFVC

--HG--
extra : rebase_source : ba86bb7c4e47598f83e3869733a238a740cef6b2
2018-04-27 21:11:31 +09:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Cosmin Sabou
68fdb6cf4f Merge inbound to mozilla-central. a=merge 2018-04-27 13:04:36 +03:00
Kris Maglione
f55bef228c Bug 1410214: Part 3 - Support packed WebExtension dictionaries. r=aswan,masayuki
MozReview-Commit-ID: 6nrw0IIe4UG

--HG--
extra : rebase_source : 3e2c2b24bd7a9136d326da9bea3d1dc197cb908b
extra : absorb_source : 9f7ab2b81c220463b82a74cb64e93528a54ff2c4
2018-04-26 13:26:05 -07:00
Kris Maglione
e2d0c50adb Bug 1410214: Part 2 - Add a stub Hunspell FileMgr that allows it to read URLs. r=masayuki
This will allow us to store dictionaries in packed extension XPIs and/or
omni.ja, which should give us a significant startup performance win.

MozReview-Commit-ID: K7fzJJAywjC

--HG--
extra : rebase_source : 4022d27bc4896d8ef27d4141b6c9bc0dd9e1c0a0
extra : absorb_source : 04bdcab8ff8005a0537d1747ba52e84946e7806a
2018-04-26 13:29:04 -07:00
Kris Maglione
d3904fd92f Bug 1410214: Part 1 - Implement support for WebExtension-style dictionary add-ons. r=aswan,gandalf
MozReview-Commit-ID: 3oylyEBgrzB

--HG--
extra : rebase_source : 640a71111fb84506906a2b150ea3d18339ebbdab
2018-04-26 13:32:38 -07:00
Doug Thayer
ce5461c0d3 Bug 887889 - Fix leak in RemoteSpellCheckingEngineChild r=Ehsan
The work to migrate to Sqlite.jsm seems to have caused a timing problem
in our tests where shutdown the content process while this IPC message
is still unresolved. This causes us to destroy RemoteSpellCheckingEngineChild
without it having processed its RecvNotiy..., leading to the promise being
leaked. As far as I can tell this resolves all of our leak issues on try.

MozReview-Commit-ID: GdwVIp5dj1m

--HG--
extra : rebase_source : b7bf5838c53e40b49bea17df123028a2dbd26e5e
2018-04-19 14:33:18 -07:00
Ekanan Ketunuti
3c9d8cc991 Bug 1454527 - Add words to en-US dictionary. r=ehsan 2018-04-25 07:40:30 +07:00
Makoto Kato
d2f2ab6258 Bug 1456879 - Clean up spellchecker not to use nsIDOM* if possible. r=masayuki
Without XPCOM and related method, I want to remove dependencies of nsIDOM*
from spellchecker.  Also, it is unnecessary to use nsISelectionPrivate since
we can use mozilla::dom::Selection instead.

MozReview-Commit-ID: 1Zheq3Hsepj

--HG--
extra : rebase_source : 593134f0120cc0806e63253c586e384871463414
2018-04-25 17:39:50 +09:00
Michael Kaply
cb3b0651e7 Bug 1413600 - Add tests for basic AutoConfig function. r=kmag
MozReview-Commit-ID: DlSkKruv8qv

--HG--
extra : rebase_source : e1e4522f0ab2370fcc3eca3059f32870ddc935d1
2018-04-18 11:29:35 -05:00
Andreea Pavel
5743b5b700 Merge mozilla-inbound to mozilla-central. a=merge 2018-04-21 12:31:28 +03:00
Masayuki Nakano
043e93a8ba Bug 1451672 - part 21: Refine TextEditor::TypedText() r=m_kato
According to existing comments, TextEditor::TypedText() and
HTMLEditor::TypedText() are intentional bottleneck to debug.  However, only
for that purpose, it and its internal methods are made virtual.  This really
doesn't make sense.

So, this patch creates TextEditor::OnInputText() for callers of TypedText()
with non-empty string, TextEditor::OnInputParagraphSeparator() for callers
of TypedText() with eTypeBreak (Enter key or insertParagraphSeparator),
HTMLEditor::OnInputLineBreak() for callers of TypedText() with eTypeBR
(Shift + Enter or insertLineBreak).  Additionally, this creates internal
non-virtual methods for XPCOM methods which are used as internal methods of
TypedText().  One is InsertTextAsAction() for nsIPlatintextEditor.insertText().
the other is InsertParagraphSeparator() for nsIPlaintextEditor.insertLineBreak().

Although those new methods are not have "WithTransaction" postfix, they must
be clearer they'll use transactions since user input and actions should be
undo-able.

MozReview-Commit-ID: AmOkMqovIKA

--HG--
extra : rebase_source : 9c0f4b25fa2a36ad2f3394f72eb290824c31d82a
2018-04-16 23:43:36 +09:00
Alex Gaynor
d452b92931 Bug 1449358 - Consistently use PR memory functions. r=mayhemer
--HG--
extra : rebase_source : 99b43cdc931327c2fd3e28cba6eb76f71e3bab4b
2018-04-17 10:14:20 -04:00
Boris Zbarsky
01d792d54e Bug 1455055 part 7. Clean up remaining HandleEvent implementations. r=masayuki
MozReview-Commit-ID: LezJYKK74H5
2018-04-20 00:49:30 -04:00
Boris Zbarsky
2b6097ae6d Bug 1455055 part 1. Convert nsIDOMEventListener to taking an Event, not an nsIDOMEvent. r=masayuki
This does no cleanup other than what's needed to compile.  Cleanup coming up in
later patches.

MozReview-Commit-ID: 3sOnkj71n09
2018-04-20 00:49:29 -04:00
Kris Maglione
219ed0cc06 Bug 1454813: Part 2b - Rename SpawnTask.js to AddTask.js. r=florian
The old name no longer makes sense, since it no longer exports an spawn_task
symbol, and add_task is what we really care about.

MozReview-Commit-ID: IE7B8Czv8DH

--HG--
rename : testing/mochitest/tests/SimpleTest/SpawnTask.js => testing/mochitest/tests/SimpleTest/AddTask.js
extra : rebase_source : 03bca5aa69a7625a49b4455a6c96ce4c59de3a5a
2018-04-18 11:43:45 -07:00
Kyle Machulis
541d6f6f00 Bug 1453517 - Remove nsPopupWindowManager and related XPCOM bits; r=bz
MozReview-Commit-ID: JIDdZfnNN8E

--HG--
extra : rebase_source : 8b92fec383a21f80fceb87502e9a7accdb7dd74f
2018-04-11 16:16:13 -07:00
Emilio Cobos Álvarez
9083c33e83 Bug 1453206: Fix IsInAnonymousSubtree to account for XBL in Shadow DOM. r=smaug
MozReview-Commit-ID: B2aYury8K7i
2018-04-14 11:59:06 +02:00
Andrew McCreight
3f7472aec1 Bug 1449670, part 1 - Convert IsNodeOfType(nsINode::eTEXT) to IsText(). r=bz
This method is not a virtual call, and also looks nicer.

This patch was mostly generated by a Python script, but I manually
cleaned up the code in a few places where statements didn't need to be
split across multiple lines any more.

MozReview-Commit-ID: 8JExxqSRc59

--HG--
extra : rebase_source : df6330a89e8d65dfe7a6fda0c8cb9f9732302efc
2018-04-12 15:41:00 -07:00
Andreea Pavel
4784e6b61b Backed out 2 changesets (bug 1453206) for crashtest failures on muliple files e.g. tests/reftest/tests/layout/base/crashtests/416107.xhtml on a CLOSED TREE
Backed out changeset 1844a120acda (bug 1453206)
Backed out changeset b12b7c5b8178 (bug 1453206)
2018-04-13 23:06:55 +03:00
Emilio Cobos Álvarez
1fe3a2d36a Bug 1453206: Fix IsInAnonymousSubtree to account for XBL in Shadow DOM. r=smaug
MozReview-Commit-ID: B2aYury8K7i
2018-04-13 21:05:48 +02:00
Sebastian Hengst
0819f35e51 Backed out 4 changesets (bug 525063) on request from Andi. a=backout
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Ekanan Ketunuti
17366b0162 Bug 1450620 - Add words to en-US dictionary. r=ehsan 2018-04-03 11:42:28 +07:00
Dave Townsend
e2dffad4ac Bug 1448500: Add speculative request content policy type. r=bz, r=kmag
Adds a new TYPE_SPECULATIVE to nsIContentPolicy uses it as the type for
speculative connection channels from the IO service. I believe I've added it to
all the content policies in tree to make sure it behaves the same as TYPE_OTHER
used to.

The webextension test shows that the webextension proxy API sees speculative
lookups requested through the IO service.

MozReview-Commit-ID: DQ4Kq0xdUOD

--HG--
extra : rebase_source : d9460fdac118bc68f0db79749a16f181b580f2e7
2018-03-23 15:27:08 -07:00
Ciure Andrei
5d841a3421 Merge inbound to mozilla-central. a=merge 2018-03-30 01:06:18 +03:00
Christoph Kerschbaumer
a929955d1f Bug 1439713 - Change nsIContentPolicy shouldLoad to take an <uri, loadInfo> pair instead of the various args. r=bz 2018-03-29 12:16:23 +02:00
Boris Zbarsky
df07d2d834 Bug 1447890 part 5. Remove nsISelection::RemoveAllRanges. r=mystor
MozReview-Commit-ID: EeMje9KW6An
2018-03-27 00:35:23 -04:00
Boris Zbarsky
54d1f87ff4 Bug 1447890 part 1. Remove nsISelection::AddRange. r=mystor
MozReview-Commit-ID: 1JNLZp7tbII
2018-03-27 00:35:22 -04:00
Boris Zbarsky
cffc291dfc Bug 1447889 part 11. Remove nsIDOMRange::CloneRange. r=mystor
The GetSelection changes are so we have a Selection that we can get an nsRange
from via GetRangeAt, so we can call nsRange::CloneRange.

MozReview-Commit-ID: 6rqdJ29Yyuc
2018-03-27 00:35:21 -04:00
Boris Zbarsky
696d273ef4 Bug 1447889 part 4. Remove nsIDOMRange::GetStart/EndContainer/Offset. r=mystor
I got a bit carried away with fixing up consumers to use nsINode...  But as a
result removing these methods all together made sense.

MozReview-Commit-ID: 2z9Q6D7GY92
2018-03-27 00:35:21 -04:00
Masatoshi Kimura
bca70e335c Bug 1448071 - Support UNC paths for spell check dictionaries. r=masayuki
MozReview-Commit-ID: 5Ig2SZKf44R

--HG--
extra : rebase_source : 0070ee9d1e4af42dcaf9eff0baead5554e37c16f
2018-03-23 21:29:16 +09:00
Michael Kaply
e2275dc105 Bug 1372107 - Allow browser to be started despite Autoconfig errors. r=florian
MozReview-Commit-ID: of8cdUMedC

--HG--
extra : rebase_source : 7afa2f98c2ac57a28d32d8936251e78af37df216
2018-03-14 13:30:53 -05:00
Miko Mynttinen
65c6bee9d6 Bug 1445302 - Replace TArray.RemoveElementAt(TArray.Length() - 1) pattern with TArray.RemoveLastElement() or TArray.PopLastElement() r=froydnj
MozReview-Commit-ID: rGjabnP2iz

--HG--
extra : rebase_source : 1ef6c5ce028ac9ebd9f3176d57835c43fe46bada
2018-03-13 14:51:33 +01:00
Boris Zbarsky
dcaa6d2614 Bug 1446711 part 5. Get rid of nsIDOMMouseEvent::GetButton. r=qdot
MozReview-Commit-ID: AZWzObh01uI
2018-03-20 00:16:06 -04:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Sylvestre Ledru
fa45a3c670 Bug 1443080 - Use the static call for static methods (not instance) r=Ehsan
MozReview-Commit-ID: JwHh4bzxuTR

--HG--
extra : rebase_source : 5f5e37517aa80c2e7b5933962178d761074886e7
2018-03-16 14:29:15 +01:00
Ekanan Ketunuti
603ddf6b44 Bug 1445841 - Add words to en-US dictionary. r=ehsan 2018-03-15 08:47:36 +07:00
Ekanan Ketunuti
54fa5281d6 Bug 1442978 - Add words to en-US dictionary. r=ehsan
--HG--
extra : rebase_source : 19212c6d7051aed2a4dd9eb625e8c628b0bd8137
2018-03-04 18:49:10 +07:00
Makoto Kato
492ea93b80 Bug 1443714 - Remove already_AddRefed for GetDocument and GetPresSehll on EditorBase. r=masayuki
It is unnecessary to use already_AddRefed for GetDocument and GetPresShell.
Then, if we remove already_AddRefed, we can replace this with const method.

MozReview-Commit-ID: KTVS0rYrY2i

--HG--
extra : rebase_source : 0199026410fc674f112c960b599a09bc7906cf85
2018-03-07 18:26:00 +09:00