The help message is implicitly included in clap error descriptions, but
they are not for errors originating from this file. By introducing
a FatalError::help_included() function we make sure we print the
help message in all cases.
An alternative implementation, which perhaps would be more idiomatic,
would be to prepare the help message within the fmt::Display trait
implementation for FatalError, but I could find no way of passing
in a reference to clap::App without storing it in an atomic global const.
Depends on D19430
Differential Revision: https://phabricator.services.mozilla.com/D19431
--HG--
extra : moz-landing-system : lando
Because we emit the flag parsing errors to the log, through error!(),
they are subject to whether the logging subsystem is enabled.
Because logging is disabled by default, no error information is
currently displayed to the user.
Since we cannot initialise logging implicitly due to the risk of
emitting log messages the user did not request, this patch changes
geckodriver to print the flag parsing errors to stderr
Depends on D19429
Differential Revision: https://phabricator.services.mozilla.com/D19430
--HG--
extra : moz-landing-system : lando
We replaced --webdriver-port with --port to better match
EdgeDriver and chromedriver, but it was discovered in
https://github.com/mozilla/geckodriver/issues/154 that this broke
Selenium clients.
We decided on a two-spearhead approach by reintroducing --webdriver-port
as a temporary alias, whilst submitting fixes for the Selenium clients.
The fixes to Selenium landed over three years ago.
This patch removes the --webdriver-port alias from geckodriver.
Depends on D19427
Differential Revision: https://phabricator.services.mozilla.com/D19428
--HG--
extra : moz-landing-system : lando
Instead of returning a tuple of (i32, String), causing us to lose
details and the cause of an error, this patch formalises the error
scenarios that may occur during command-line parsing and startup
of the WebDriver server.
Exit codes are encoded with each variant of FatalError, instead of
being specified in each case.
Type conversions are implemented for clap::Error (flag parsing)
and io::Error (webdriver::server).
Depends on D19426
Differential Revision: https://phabricator.services.mozilla.com/D19427
--HG--
extra : moz-landing-system : lando
We don't need an enum for exit codes as we never have to match
on them. Converting them to consts also has the benefit that we
will not have to coerce them to i32.
i32 is the correct type to use here, since it is what std::process::exit()
takes and what the libc crate uses.
Depends on D19424
Differential Revision: https://phabricator.services.mozilla.com/D19425
--HG--
extra : moz-landing-system : lando
Making use of clap::Arg::default_value() removes duplicated magic
strings, by not having to use .unwrap_or("default value").
Depends on D19423
Differential Revision: https://phabricator.services.mozilla.com/D19424
--HG--
extra : moz-landing-system : lando
The behaviour of switching to an already opened tab for an item in the stream
list was already in place, this patch just modifies the item's layout by
adding a text hint about this possibility - "Switch to tab", dynamically,
depending on if a tab is already opened or not in the current session.
Each stream item will implement `Tabs.OnTabsChangedListener` and check if the
changed Tab had stream's Url.
If so it will pass this event to the list's Adapter which will refresh the
stream item's layout.
Differential Revision: https://phabricator.services.mozilla.com/D18997
--HG--
extra : moz-landing-system : lando
The error happened because aboutPerformance provided an unused
parameter to Classify API which is removed in Bug 1501458.
Check tracking protection tables via Classify API is not supported now.
We should use asyncClassifyLocalWithFeatures API instead.
Differential Revision: https://phabricator.services.mozilla.com/D19793
--HG--
extra : moz-landing-system : lando
Added check for AES128GCM encoding since we won't have separate enckey and cryptokey but rather encoded in the body.
Differential Revision: https://phabricator.services.mozilla.com/D19806
--HG--
extra : moz-landing-system : lando
Removed intended throw of IllegalStateException for Nightly when a page was not considered safe as a PWA.
Differential Revision: https://phabricator.services.mozilla.com/D18533
--HG--
extra : moz-landing-system : lando
Replaces custom generated hashes with the actorIDs which are stable
during the editing session enough to use as unique identifiers.
For future restore / persistence, we still have the metadata about each
rule and stylesheet to attempt to identify them again.
Differential Revision: https://phabricator.services.mozilla.com/D18660
--HG--
extra : moz-landing-system : lando
By using WebRenderTextureHostWrapper for canvas, we could avoid triggering frame build on WebRender backend if WebRenderTextureHostWrapper is only change.
Differential Revision: https://phabricator.services.mozilla.com/D19896
--HG--
extra : moz-landing-system : lando
nsWaylandDisplay needs to be allocated for each calling thread(main thread, compositor thread and render thread)
Differential Revision: https://phabricator.services.mozilla.com/D20118
--HG--
extra : moz-landing-system : lando
The appropriate case is when placeholder is not used as the absolutely last fallback for the accessible name, and the input is not labeled by the same text as in the placeholder attribute itself. So a label and the placeholder text must be different for the object attribute to be exposed.
In addition, for ATK, placeholder is being renamed to placeholder-text to comply with the platform specification.
Differential Revision: https://phabricator.services.mozilla.com/D19808
--HG--
extra : moz-landing-system : lando
Turns out hg diff works differently, and when Miko tried to use this
option last week he realized it didn't work quite as expected.
Differential Revision: https://phabricator.services.mozilla.com/D20102
--HG--
extra : moz-landing-system : lando
When registering dynamic builtin scalars and events (Build Faster support) we
didn't check whether they were expired. Let's do that.
Differential Revision: https://phabricator.services.mozilla.com/D19836
--HG--
extra : moz-landing-system : lando
This patch moves the block to compute event target of the event using
coordinates into the new method of PresShell::EventHandler::EventTargetData.
Differential Revision: https://phabricator.services.mozilla.com/D19320
--HG--
extra : moz-landing-system : lando
Otherwise the user should see and be able to interact with the whole page.
Refactored `PictureInPictureController` to check the media playing status for
only the current tab, the one the user has in front and for which we may allow
PiP because `GeckoMediaControlAgent.isMediaPlaying()` would give us false
positives in the case where the current Tab is in fullscreen but not playing
media, while at the same time a background Tab is playing media.
BrowserApp will only force fullscreen after returning from PiP if media
playback has ended, but will keep fullscreen for playing/paused media.
Differential Revision: https://phabricator.services.mozilla.com/D19750
--HG--
extra : moz-landing-system : lando
We should wait until the selected tab has been updated because we fetch tabs when the selected index changes.
Differential Revision: https://phabricator.services.mozilla.com/D19959
--HG--
extra : moz-landing-system : lando
widget/cocoa/nsChildView.mm:249:6 [-Wmissing-prototypes] no previous prototype for function 'EnsureLogInitialized'
Depends on D20087
Differential Revision: https://phabricator.services.mozilla.com/D20088
--HG--
extra : moz-landing-system : lando
widget/cocoa/nsChildView.mm:1932:21 [-Wmissing-prototypes] no previous prototype for function 'TextureSizeForSize'
widget/cocoa/nsCocoaUtils.mm:351:6 [-Wmissing-prototypes] no previous prototype for function 'data_ss_release_callback'
Differential Revision: https://phabricator.services.mozilla.com/D20087
--HG--
extra : moz-landing-system : lando
This is an hotfix for the bug, which we want to uplift.
A better fix will happen in Bug 1527903.
Depends on D19963
Differential Revision: https://phabricator.services.mozilla.com/D19965
--HG--
extra : moz-landing-system : lando
The function was returning a Promise but was also
taking a callback for old-style test.
This patch turns the function into an async one,
remove the callback param and refactor tests that
relied on it.
Differential Revision: https://phabricator.services.mozilla.com/D19963
--HG--
extra : moz-landing-system : lando
The reason why we use RelaxedAtomBoolis that
ScrollSnapUtils::GetSnapPointForDestination() is called both from the main and
the compositor threads, and the function will have a branch depending on the
pref value.
Differential Revision: https://phabricator.services.mozilla.com/D20101
--HG--
extra : moz-landing-system : lando
These assertions can happen in certain circumstances (see the referenced bug).
These assertions are not security sensitive, but they affect correctness.
They're old (from before my change), so I prefer dealing with them in a public
bug and stop crashing release for now.
Differential Revision: https://phabricator.services.mozilla.com/D20105
--HG--
extra : moz-landing-system : lando
