These are all easy cases where an nsXPIDLCString local variable is set via
getter_Copies() and then is only used in ways that nsCStrings can also be used
(i.e. no null checks or implicit conversions to |char*|).
In every case the patch trivially replaces the nsXPIDLCString with an
nsCString. (Also, there are a couple of unused nsXPIDLCString variables that
the patch simply removes.)
Iterating a LiveRange's uses in BacktrackingAllocator::computeSpillWeight() to
access UsePosition.uses_ isn't cache friendly, because it is a linked list and
each node is allocated separately. Changing the data strcture to a vector is
worse because of the overhead from frequent insertion/removing. However,
UsePostion.uses_ can't be changed after initialization, so we can pre-calculate
the spill weight when it is added to or remove from a LiveRange.
MozReview-Commit-ID: BJEvI7KBVAJ
--HG--
extra : rebase_source : 04a14fae5a455d0e70f995e80887eb09b184dc2c
Copy construction for va_list is implementation dependent, and most
likely doesn't actually work properly on some platforms. While the
wrapping in EitherParser might currently work on tier-1 platforms,
it also triggers a warning on newer GCC versions that could very well
indicate that they might not work entirely properly. Mixing va_list,
copy construction and templates variadics surely sounds like something
very fragile.
While I understand that the pending changes from bug 1351107 might be
relying on the current state of the code, I'd rather that bug be
reworked so as to please newer versions of GCC than having to figure out
what parts of that bug are still relevant after bug 1351105 and blocking
bug 1389435 further.
--HG--
extra : rebase_source : b9135990c62faf7587e646c99f3bc6ece603cb38
These tests pass when our test infrastruction is in PDT, but there are
underlying issues. Disable tests on Windows for now to allow migrating
tests to TaskCluster.
MozReview-Commit-ID: 5HigFMyyaP5
This patch moves measurement of ComputedValues objects from Rust to C++.
Measurement now happens (a) via DOM elements and (b) remaining elements via
the frame tree. Likewise for the style structs hanging off ComputedValues
objects.
Here is an example of the output.
> ├──27,600,448 B (26.49%) -- active/window(https://en.wikipedia.org/wiki/Barack_Obama)
> │ ├──12,772,544 B (12.26%) -- layout
> │ │ ├───4,483,744 B (04.30%) -- frames
> │ │ │ ├──1,653,552 B (01.59%) ── nsInlineFrame
> │ │ │ ├──1,415,760 B (01.36%) ── nsTextFrame
> │ │ │ ├────431,376 B (00.41%) ── nsBlockFrame
> │ │ │ ├────340,560 B (00.33%) ── nsHTMLScrollFrame
> │ │ │ ├────302,544 B (00.29%) ── nsContinuingTextFrame
> │ │ │ ├────156,408 B (00.15%) ── nsBulletFrame
> │ │ │ ├─────73,024 B (00.07%) ── nsPlaceholderFrame
> │ │ │ ├─────27,656 B (00.03%) ── sundries
> │ │ │ ├─────23,520 B (00.02%) ── nsTableCellFrame
> │ │ │ ├─────16,704 B (00.02%) ── nsImageFrame
> │ │ │ ├─────15,488 B (00.01%) ── nsTableRowFrame
> │ │ │ ├─────13,776 B (00.01%) ── nsTableColFrame
> │ │ │ └─────13,376 B (00.01%) ── nsTableFrame
> │ │ ├───3,412,192 B (03.28%) -- servo-style-structs
> │ │ │ ├──1,288,224 B (01.24%) ── Display
> │ │ │ ├────742,400 B (00.71%) ── Position
> │ │ │ ├────308,736 B (00.30%) ── Font
> │ │ │ ├────226,512 B (00.22%) ── Background
> │ │ │ ├────218,304 B (00.21%) ── TextReset
> │ │ │ ├────214,896 B (00.21%) ── Text
> │ │ │ ├────130,560 B (00.13%) ── Border
> │ │ │ ├─────81,408 B (00.08%) ── UIReset
> │ │ │ ├─────61,440 B (00.06%) ── Padding
> │ │ │ ├─────38,176 B (00.04%) ── UserInterface
> │ │ │ ├─────29,232 B (00.03%) ── Margin
> │ │ │ ├─────21,824 B (00.02%) ── sundries
> │ │ │ ├─────20,080 B (00.02%) ── Color
> │ │ │ ├─────20,080 B (00.02%) ── Column
> │ │ │ └─────10,320 B (00.01%) ── Effects
> │ │ ├───2,227,680 B (02.14%) -- computed-values
> │ │ │ ├──1,182,928 B (01.14%) ── non-dom
> │ │ │ └──1,044,752 B (01.00%) ── dom
> │ │ ├───1,500,016 B (01.44%) ── text-runs
> │ │ ├─────492,640 B (00.47%) ── line-boxes
> │ │ ├─────326,688 B (00.31%) ── frame-properties
> │ │ ├─────301,760 B (00.29%) ── pres-shell
> │ │ ├──────27,648 B (00.03%) ── pres-contexts
> │ │ └─────────176 B (00.00%) ── style-sets
The 'servo-style-structs' and 'computed-values' sub-trees are new. (Prior to
this patch, ComputedValues under DOM elements were tallied under the the
'dom/element-nodes' sub-tree, and ComputedValues not under DOM element were
ignored.) 'servo-style-structs/sundries' aggregates all the style structs that
are smaller than 8 KiB.
Other notable things done by the patch are as follows.
- It significantly changes the signatures of the methods measuring nsINode and
its subclasses, in order to handle the tallying of style structs separately
from element-nodes. Likewise for nsIFrame.
- It renames the 'layout/style-structs' sub-tree as
'layout/gecko-style-structs', to clearly distinguish it from the new
'layout/servo-style-structs' sub-tree.
- It adds some FFI functions to access various Rust-side data structures from
C++ code.
- There is a nasty hack used twice to measure Arcs, by stepping backwards from
an interior pointer to a base pointer. It works, but I want to replace it
with something better eventually. The "XXX WARNING" comments have details.
- It makes DMD print a line to the console if it sees a pointer it doesn't
recognise. This is useful for detecting when we are measuring an interior
pointer instead of a base pointer, which is bad but easy to do when Arcs are
involved.
- It removes the Rust code for measuring CVs, because it's now all done on the
C++ side.
MozReview-Commit-ID: BKebACLKtCi
--HG--
extra : rebase_source : 4d9a8c6b198a0ff025b811759a6bfa9f33a260ba
At the same time, simplify the definitions, as:
- per python/mozbuild/mozbuild/configure/constants.py, supported
compilers all support lowercase forms.
- all variants of powerpc, little endian or not, 32-bits or 64-bits,
define __powerpc__.
- s390x also defines __s390__.
--HG--
extra : rebase_source : 38e2ff85dc035296ea3bebe90739244eeb6eaddd
This feature isn't currently used or being planned to be used in the near
future and has some overhead that makes it hard to justify to keep around,
so it's better to remove it and revive it from VCS history if we need it
later.
This is the only approach that I managed to make work.
MozReview-Commit-ID: CUnkDoYN3di
--HG--
extra : rebase_source : 469912d015a403ef481685c617010613ea36b0b3
And also fixes unused-warning error in none-codegen mode.
MozReview-Commit-ID: HPbm7n34gaS
--HG--
extra : rebase_source : d7011a08a3439794b65a676366ba53e89e28e5b7
extra : amend_source : 90a689781c1081cc73945321b322e7fb10555e3f
