Commit Graph

4770 Commits

Author SHA1 Message Date
Neil Deakin
2483a0cbf2 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-16 20:15:31 +00:00
Gregory Pappas
1468978431 Bug 1839520 - Convert tps.jsm to ES module r=Standard8,sync-reviewers,skhamis
Co-authored-by: Mark Banner <standard8@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D181610
2023-07-14 03:31:26 +00:00
Mark Banner
182b6db303 Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw
Depends on D183308

Differential Revision: https://phabricator.services.mozilla.com/D183309
2023-07-12 08:07:23 +00:00
Sammy Khamis
525249fbdf Bug 1838974 - Bookmarks engine roundtrips data it doesn't know about r=markh,lina,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181593
2023-07-07 19:55:40 +00:00
Stanca Serban
5e0a341a67 Backed out 2 changesets (bug 1807618) for autocomplete related failures. CLOSED TREE
Backed out changeset 548365f1d102 (bug 1807618)
Backed out changeset 149b536f4fed (bug 1807618)
2023-07-06 01:27:55 +03:00
Tarik Eshaq
efc914c08e Bug 1638359: Removes kSync and kXCS from local storage. r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181789
2023-07-05 20:18:40 +00:00
Neil Deakin
4339c71887 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-05 19:24:40 +00:00
Noemi Erli
0a74430d29 Backed out changeset 3d70f2411ec6 (bug 1638359) for causing failures in test_ext_storage_sync_kinto.js CLOSED TREE 2023-07-05 01:06:24 +03:00
Tarik Eshaq
4a40d2148e Bug 1638359: Removes kSync and kXCS from local storage. r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181789
2023-07-04 21:10:16 +00:00
Mozilla Releng Treescript
b5775ab82f Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2023-07-04 08:35:07 +00:00
Marco Bonardo
ba5469f14e Bug 1816901 - Remove the Places GuidHelper. r=daisuke,sync-reviewers,skhamis
Depends on D180411

Differential Revision: https://phabricator.services.mozilla.com/D180412
2023-06-24 07:16:51 +00:00
Johannes J. Schmidt
f396154a5c Bug 1820599 - streamline addLogin storage interface - r=credential-management-reviewers,dimi
* encryption is done in storage layer
* use `LoginManager.addLoginAsync` all over the place
* use `LoginManager.addLoginsAsync`  everywhere
* remove sync `LoginManager.addLogin`

Differential Revision: https://phabricator.services.mozilla.com/D178672
2023-06-22 16:17:44 +00:00
Noemi Erli
2902d8db20 Backed out changeset 35c8b566fd53 (bug 1820599) for causing failures in browser_form_history_fallback.js 2023-06-22 16:33:46 +03:00
Johannes J. Schmidt
b6b6043ff3 Bug 1820599 - streamline addLogin storage interface - r=credential-management-reviewers,dimi
* encryption is done in storage layer
* use `LoginManager.addLoginAsync` all over the place
* use `LoginManager.addLoginsAsync`  everywhere
* remove sync `LoginManager.addLogin`

Differential Revision: https://phabricator.services.mozilla.com/D178672
2023-06-22 11:47:58 +00:00
Tarik Eshaq
902b92e52e Bug 1838708: Removes legacy webext storage keys from account state. r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181153
2023-06-19 20:29:02 +00:00
Barret Rennie
da61a22c25 Bug 1775167 - Remove OS.File error support from ErrorSanitizer r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181174
2023-06-16 18:27:58 +00:00
Stanca Serban
ee3137f15f Backed out changeset ec9815c8c589 (bug 1775167) for causing xpcshell failures in test_telemetry.js. CLOSED TREE 2023-06-16 18:23:33 +03:00
Barret Rennie
8154330f97 Bug 1775167 - Remove OS.File error support from ErrorSanitizer r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181174
2023-06-16 14:20:21 +00:00
Cosmin Sabou
3aec0f043b Backed out changeset 5be10443a2ea (bug 1807618) for mochitest failures on test_autocomplete_password_generation.html. 2023-06-16 00:48:28 +03:00
Neil Deakin
0ba4422a3b Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-06-15 20:39:05 +00:00
Mark Banner
ae619c5049 Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
2023-06-15 08:33:57 +00:00
Marco Castelluccio
21a2f56033 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-15 08:10:45 +00:00
Noemi Erli
37e0c3eb20 Backed out changeset 63ccd00a399a (bug 898315) for causing failures in test_no_window_update_restart.py CLOSED TREE 2023-06-15 03:21:27 +03:00
Marco Castelluccio
f66df9a273 Bug 1406475 - Remove Svc.Prefs as it's no longer used. r=sync-reviewers,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D180811
2023-06-14 23:15:37 +00:00
Marco Castelluccio
0c52758410 Bug 1406475 - Convert engines-related sync modules to using Services.prefs. r=sync-reviewers,skhamis
Depends on D180809

Differential Revision: https://phabricator.services.mozilla.com/D180810
2023-06-14 23:15:37 +00:00
Marco Castelluccio
d744ff76dd Bug 1406475 - Convert tps sync module to using Services.prefs. r=sync-reviewers,skhamis
Depends on D180808

Differential Revision: https://phabricator.services.mozilla.com/D180809
2023-06-14 23:15:37 +00:00
Marco Castelluccio
c85e65e2e0 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-14 20:55:52 +00:00
Marco Castelluccio
5fac802934 Bug 1406475 - Convert some sync modules to using Services.prefs. r=sync-reviewers,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D180803
2023-06-14 10:00:06 +00:00
Marco Castelluccio
3588a7d013 Bug 1406475 - Convert sync tests to use Services.prefs instead of Preferences.sys.mjs. r=sync-reviewers,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D180802
2023-06-14 10:00:06 +00:00
Marco Castelluccio
d054aad92c Bug 1406475 - Add Svc.PrefBranch to util. r=sync-reviewers,skhamis
This makes it easier to convert sync to Services.prefs from Preferences.jsm incrementally.

Differential Revision: https://phabricator.services.mozilla.com/D180801
2023-06-14 10:00:06 +00:00
Neil Deakin
26b054c025 Bug 1768792, send a notification when an logins import has completed and update the sync score when this happens, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D180751
2023-06-13 18:30:37 +00:00
Neil Deakin
b84df1a557 Bug 1752839, add more password sync tests, r=sgalich
Also, fix the rounding of the default argument to insertRecord as it can cause intermittent errors

Differential Revision: https://phabricator.services.mozilla.com/D172056
2023-06-13 13:00:42 +00:00
Neil Deakin
bbc4d2f51e Bug 1752839, improve logins sync by not using the LegacyTracker, r=sgalich,skhamis,sync-reviewers,dimi,joschmidt,markh
Instead of recording a separate list of changes that could be incorrect, determine the list of modified logins when the sync occurs. Two flags are added to login info objects, the syncStatus that identifies that a login has been synced and a counter which is incremented during a sync and decremented by the same amount when the sync is complete. Deleted logins are flagged with a deleted marker rather than deleted directly.

This behaviour mirrors the form auto fill sync method.

Differential Revision: https://phabricator.services.mozilla.com/D170817
2023-06-13 13:00:42 +00:00
Marco Castelluccio
6b639de446 Bug 898315 - Remove usage of FileUtils.getDir(..., ..., true) in production code. r=barret,application-update-reviewers,devtools-reviewers,nalexander,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D180564
2023-06-13 07:50:36 +00:00
Mark Banner
6725448902 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Mozilla Releng Treescript
5e58683eba Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2023-06-05 14:40:55 +00:00
Rob Wu
3c0c3a2676 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Mark Banner
5d59c7aecd Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
2023-06-02 20:00:35 +00:00
Saira Abdulla
9691ab4a5f Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
90b739a400 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
2e8db5969a Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Eemeli Aro
0997552230 Bug 1831872 - Migrate client.name2 string from sync.properties to Fluent. r=markh,fluent-reviewers,geckoview-reviewers,sync-reviewers,flod,m_kato
As this is the only string in `services/`, let's simplify by moving it under `toolkit/` and removing `services/sync/locales/` as empty.

On advice from markh, the ON_NEW_DEVICE_ID notification is delayed during device registration & updates until the update has been written to storage.

Differential Revision: https://phabricator.services.mozilla.com/D178805
2023-05-29 15:24:38 +00:00
Eemeli Aro
849756d484 Bug 1448444 - Drop signInToSync.description string as unused. r=markh,sync-reviewers
This was only used to format the tooltip of the "Sync now" button in the Firefox Accounts app menu pane when the UI's state was such that the whole pane would not be displayed.

Differential Revision: https://phabricator.services.mozilla.com/D178804
2023-05-29 15:24:38 +00:00
Kris Maglione
fbc33fd683 Bug 1648545: Part 2 - Load SpecialPowers in XPCShellContentUtils. r=ahal,application-update-reviewers,nalexander,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D119449
2023-05-27 03:46:44 +00:00
Mark Banner
8b4f426ecf Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
Noemi Erli
06b68d0d45 Backed out 4 changesets (bug 1648545) for causing mass failures
Backed out changeset ac3d639547fa (bug 1648545)
Backed out changeset f63760c845f3 (bug 1648545)
Backed out changeset 652b48b10d37 (bug 1648545)
Backed out changeset 1ca7abd873d1 (bug 1648545)
2023-05-26 02:12:58 +03:00
Kris Maglione
1abe5de918 Bug 1648545: Part 2 - Load SpecialPowers in XPCShellContentUtils. r=ahal,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D119449
2023-05-25 22:04:31 +00:00
Sammy Khamis
42020b7048 Bug 1829456: logins engine round trips data it doesn't know about r=sgalich
Differential Revision: https://phabricator.services.mozilla.com/D178992
2023-05-24 23:36:53 +00:00
Sammy Khamis
8d7f34feed Bug 1832714: Prevent Sync from continually syncing broken records r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177951
2023-05-24 02:38:22 +00:00
Cosmin Sabou
18ddb256a5 Backed out changeset ca712de42eca (bug 1829456) for causing xpcshell failures on test_password_engine.js. CLOSED TREE 2023-05-24 10:31:22 +03:00