Commit Graph

643105 Commits

Author SHA1 Message Date
Thomas Wisniewski
56d0741c05 Bug 980902 - log a warning recommending the use of sendBeacon during unload instead of synchronous XMLHttpRequest; r=Ehsan
log a warning recommending the use of sendBeacon during unload instead of synchronous XMLHttpRequest

Differential Revision: https://phabricator.services.mozilla.com/D23799

--HG--
extra : moz-landing-system : lando
2019-03-21 18:40:03 +00:00
Timothy Nikkel
93a1eaeaa2 Bug 1537660. Fix nsRegion::ToString(). r=bas
It never outputs the separator between rects.

Differential Revision: https://phabricator.services.mozilla.com/D24306

--HG--
extra : moz-landing-system : lando
2019-03-21 15:05:57 +00:00
Randell Jesup
4871eba443 Bug 1520587: clear memory counter values when restarting the profiler m=mstange 2019-03-21 11:03:07 -04:00
Syeda Asra Arshia Qadri
b4d493a5e8 Bug 1537728: Simplify shouldCheck variable declaration in BrowserGlue._checkForDefaultBrowser r=dao
Differential Revision: https://phabricator.services.mozilla.com/D24358

--HG--
extra : moz-landing-system : lando
2019-03-21 14:25:48 +00:00
Alexandre Poirot
17165546af Bug 1536794 - Test Page.frameStoppedLoading and Page.navigatedWithinDocument. r=ato
Depends on D24222

Differential Revision: https://phabricator.services.mozilla.com/D24223

--HG--
extra : moz-landing-system : lando
2019-03-21 14:23:20 +00:00
Alexandre Poirot
4decca62c1 Bug 1536794 - Add test to cover /json/version endpoint and Target domain. r=ato
Depends on D24221

Differential Revision: https://phabricator.services.mozilla.com/D24222

--HG--
extra : moz-landing-system : lando
2019-03-21 14:18:03 +00:00
Alexandre Poirot
7d04b7c5e0 Bug 1536794 - Moving Target's path definition to a unique place, on Target class. r=ato
Doing this helps fixing the main target's path which is meant to be:
  /devtools/browser

Depends on D24220

Differential Revision: https://phabricator.services.mozilla.com/D24221

--HG--
extra : moz-landing-system : lando
2019-03-21 14:17:30 +00:00
Alexandre Poirot
4c3f075b45 Bug 1536794 - Close httpd's Connection when closing the remote agent's server. r=ato
This fixes the browser mochitest which currently timesout when calling server.close()
It started to timeout when the patch related to websocket handshake landed.

Depends on D24219

Differential Revision: https://phabricator.services.mozilla.com/D24220

--HG--
extra : moz-landing-system : lando
2019-03-21 14:17:36 +00:00
Alexandre Poirot
8f9717d1e8 Bug 1536794 - Implement a base Target class. r=ato
In this revision it only helps sharing `handle`.
But in a followup changeset, it will also help closing all the connections
and justify the `sessions` map we keep around.

Differential Revision: https://phabricator.services.mozilla.com/D24219

--HG--
rename : remote/targets/MainProcessTarget.jsm => remote/targets/Target.jsm
extra : moz-landing-system : lando
2019-03-21 14:17:21 +00:00
Miko Mynttinen
c33cbad71c Bug 1535040 - Exclude some SVG frames from DL building fast-path r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D23810

--HG--
extra : moz-landing-system : lando
2019-03-21 14:48:54 +00:00
Gian-Carlo Pascutto
d735d8aa70 Bug 1529922 - Add guard pages following huge allocations. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D23292

--HG--
extra : moz-landing-system : lando
2019-03-20 10:45:15 +00:00
Ashley Hauck
a7b36a066c Bug 1520996 - Use AccessorType instead of JSOP for getters/setters. r=arai
This will take a very slight memory regression until JSOP is entirely
removed from ParseNode (which will regain a *lot* more memory).

Differential Revision: https://phabricator.services.mozilla.com/D24293

--HG--
extra : moz-landing-system : lando
2019-03-21 14:23:55 +00:00
tanhengyeow
70a1707897 Bug 1537566 - Fix brightness of selected netmonitor rows; r=fvsch
Remove unnecessary css

Differential Revision: https://phabricator.services.mozilla.com/D24339

--HG--
extra : moz-landing-system : lando
2019-03-21 14:19:44 +00:00
Brian Grinstead
a797a66d25 Bug 1531119 - Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM r=bdahl,NeilDeakin
This allows us to drop preprocessing and makes it simpler to add edit menu functionality to any type of document.

Differential Revision: https://phabricator.services.mozilla.com/D21446

--HG--
extra : moz-landing-system : lando
2019-03-21 14:18:48 +00:00
Dão Gottwald
92ef5c0898 Bug 1536788 - Reduce width of border between tabs and nav bar from 1 CSS pixel to 1 device pixel. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D24173

--HG--
extra : moz-landing-system : lando
2019-03-21 14:01:58 +00:00
Mike Conley
2c8a12e078 Bug 1535748 - Remove NIGHTLY_BUILD build-time switches for Picture-in-Picture. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D23948

--HG--
extra : moz-landing-system : lando
2019-03-21 13:58:17 +00:00
Mike Conley
c218b68adf Bug 1535760 - Update strings and controls for toggling Picture-in-Picture from the context menu. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D23947

--HG--
extra : moz-landing-system : lando
2019-03-21 13:58:05 +00:00
Boris Zbarsky
e1cbcd2c01 Bug 1322645. Fix intermittent test timeout by making sure our prefs are set before we start doing parts of the test. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D24307

--HG--
extra : moz-landing-system : lando
2019-03-21 13:56:05 +00:00
Byron Campen [:bwc]
7dda36141d Bug 1534683: Re-enable and fix this test-case. r=jib
Depends on D23208

Differential Revision: https://phabricator.services.mozilla.com/D24051

--HG--
extra : moz-landing-system : lando
2019-03-21 00:16:42 +00:00
Alexandre Poirot
17c4360455 Bug 1536890 - Remove the workaround in chrome-remote-interface now that remote agent supports websocket handshake. r=ato
Differential Revision: https://phabricator.services.mozilla.com/D24225

--HG--
extra : moz-landing-system : lando
2019-03-21 13:28:05 +00:00
Boris Zbarsky
ba49f4de45 Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D24258

--HG--
extra : moz-landing-system : lando
2019-03-21 11:52:50 +00:00
Boris Zbarsky
1e54f805f8 Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Since these are compile-time constants, they can't exactly go away on us due to
running script, right?

Differential Revision: https://phabricator.services.mozilla.com/D24195

--HG--
extra : moz-landing-system : lando
2019-03-21 11:52:33 +00:00
Boris Zbarsky
534495abc4 Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi
We need to typecheck the trivials too, not just the final thing after trivials
are stripped, because casts are trivials.

Differential Revision: https://phabricator.services.mozilla.com/D24186

--HG--
extra : moz-landing-system : lando
2019-03-21 11:50:55 +00:00
Boris Zbarsky
b25b0dd1a9 Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D24120

--HG--
extra : moz-landing-system : lando
2019-03-21 11:49:11 +00:00
Boris Zbarsky
081fa29a04 Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
The old code for member method calls did the following:

 1) Find the member method calls.
 2) Look at their "this" expression.
 3) If the "this" is an operator call, check for any of the arguments of the
    operator call being invalid.
 4) Otherwise (if not an operator call) check for the "this" value being
    invalid.

This wasn't right, because the "is invalid" check checks the type and only
considers refcounted things.  So if the code looked something like
"foo[i]->call_method()", we would look at the types of "foo" and "i" and
determine that none of those are refcounted types so there is nothing invalid
here (since "foo" is some sort of array type and "i" is an integer).  The new
setup just checks whether the "this" value is invalid, which does the type
check on the "this" value itself; in the "foo[i]->call_method()" case on
"foo[i]".  We then adjust the exclusions in InvalidArg to consider operator->
on known-live things valid, to allow the thing that we were really trying to
accomplish with the "check for an operator call" bits:
"stackRefPtr->some_method()".

The test coverage being added for the made-up TArray type is meant to catch
things like the geolocation issue that was being hidden by the buggy behavior.
I'm not using nsTArray itself because some header included by nsTArray.h
tries to define operator new/delete bits inline and that triggers warnings that
then cause a clang-plugin test failure, because they're unexpected.

Differential Revision: https://phabricator.services.mozilla.com/D24117

--HG--
extra : moz-landing-system : lando
2019-03-21 11:48:33 +00:00
Boris Zbarsky
640cb8470a Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi
"this" is guaranteed to stay alive as long as other MOZ_CAN_RUN_SCRIPT
conditions hold, and its const members can't change value and drop
their refs.

Differential Revision: https://phabricator.services.mozilla.com/D23997

--HG--
extra : moz-landing-system : lando
2019-03-21 11:47:22 +00:00
Ian Moody
7f284be66e Bug 1536653 - browser/ manual ESLint no-throw-literal fixes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D24111

--HG--
extra : moz-landing-system : lando
2019-03-20 10:15:03 +00:00
Ian Moody
67fb55f3b9 Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs
Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110

--HG--
extra : moz-landing-system : lando
2019-03-20 10:17:42 +00:00
Ian Moody
4bb3237beb Bug 1536648 - accessible/ manual ESLint no-throw-literal fixes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D24107

--HG--
extra : moz-landing-system : lando
2019-03-20 00:23:17 +00:00
Tom Tung
e51da80607 Bug 1423917 - P10 - Remove .tmp file in idb drectories in the 2_1to2_2 upgrade; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D21733

--HG--
extra : moz-landing-system : lando
2019-03-20 13:32:49 +00:00
Nicholas Cowles
81ddec3340 Bug 1517528 - Capstone: convert about:privatebrowsing using gandalf's conversion script, r=Gijs,jaws,zbraniecki,flod
Differential Revision: https://phabricator.services.mozilla.com/D19250

--HG--
extra : moz-landing-system : lando
2019-03-18 18:05:13 +00:00
Tom Tung
ffb9d8c55b Bug 1529122 - P1 - Remove the origin directory if the requesting client is the only client in the directroy; r=asuth
This patch do:
- Removing the directroy if the requesting client is the only client.
- Avoid unnecessary initialization for a client if it hasn't been initialized.

Differential Revision: https://phabricator.services.mozilla.com/D24371

--HG--
extra : moz-landing-system : lando
2019-03-21 17:18:23 +00:00
Valentin Gosu
046880c0ea Bug 1527316 - Setup MOZ_NODE_PATH as part of bootstrapping r=gbrown
Depends on D24291

Differential Revision: https://phabricator.services.mozilla.com/D24301

--HG--
extra : moz-landing-system : lando
2019-03-21 16:19:15 +00:00
Henri Sivonen
dbf7d64095 Bug 1536730 - Avoid using keyboard focus for routing mouse events meant for a sidebar. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D24237

--HG--
extra : moz-landing-system : lando
2019-03-21 15:59:02 +00:00
Dan Minor
803d8e1547 Bug 1535584 - Restore UpdateCodecFrameSize to vp9_impl.cc; r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D23713

--HG--
extra : moz-landing-system : lando
2019-03-21 15:48:46 +00:00
Kartikaya Gupta
522737691b Bug 1536807 - Expand fuzziness annotation to include macOS. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D24183

--HG--
extra : moz-landing-system : lando
2019-03-21 20:41:14 +00:00
Boris Chiou
87c575a7ac Bug 1533594 - Set performance warning by a property set. r=hiro
We want to set the performance warning by a property set, so update it.
Besides, add more tests for individual transforms (translate, rotate,
scale).

Differential Revision: https://phabricator.services.mozilla.com/D19633

--HG--
extra : moz-landing-system : lando
2019-03-21 17:40:11 +00:00
Ashley Hauck
3643bf6dc4 Bug 1537936 part 3 - Remove ParseNode::pn_op. r=jorendorff
Depends on D24410

Differential Revision: https://phabricator.services.mozilla.com/D24411

--HG--
extra : moz-landing-system : lando
2019-03-21 20:25:59 +00:00
Ashley Hauck
37134a5a04 Bug 1537936 part 2 - Move pn_op for calls to CallNode::callOp. r=jorendorff
Depends on D24409

Differential Revision: https://phabricator.services.mozilla.com/D24410

--HG--
extra : moz-landing-system : lando
2019-03-21 20:30:03 +00:00
Ashley Hauck
8c5c123e4e Bug 1537936 part 1 - Remove miscellaneous uses of pn_op. r=jorendorff
Differential Revision: https://phabricator.services.mozilla.com/D24409

--HG--
extra : moz-landing-system : lando
2019-03-21 20:16:53 +00:00
paarmita
cc8f215561 Bug 1483364 - Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences; r=johannh
Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences (and should use 'options' on Windows)

Differential Revision: https://phabricator.services.mozilla.com/D21856

--HG--
extra : moz-landing-system : lando
2019-03-21 13:40:54 +00:00
Matt Brubeck
db15c0c9c7 Bug 1527778 - Fix reloading of content modules on procses switching. r=snorp
Differential Revision: https://phabricator.services.mozilla.com/D24102

--HG--
extra : moz-landing-system : lando
2019-03-21 16:25:50 +00:00
Eitan Isaacson
05665102b2 Bug 1536123 - Move virtual cursor to caret offset. r=yzen
Differential Revision: https://phabricator.services.mozilla.com/D23911

--HG--
extra : moz-landing-system : lando
2019-03-21 16:20:51 +00:00
Mark Banner
c9241477a7 Bug 1534735 - Force the URL to be displayed in LTR mode on QuantumBar results. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D24162

--HG--
extra : moz-landing-system : lando
2019-03-21 15:51:30 +00:00
John Lin
7dd2bbf7e9 Bug 1499224 - p2: Keep remote decoder process alive when client record is good. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D23738

--HG--
extra : moz-landing-system : lando
2019-03-21 15:49:23 +00:00
John Lin
61cf142d51 Bug 1499224 - p1: keep record of active remote objects in MediaManager. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D23736

--HG--
extra : moz-landing-system : lando
2019-03-21 15:49:36 +00:00
Imanol Fernandez
a3e06efc18 Bug 1537899 - Add neck model capability for VRPose position. r=kip
Add neck model capability for VRPose position.

Differential Revision: https://phabricator.services.mozilla.com/D24386

--HG--
extra : moz-landing-system : lando
2019-03-21 19:38:18 +00:00
Tom Tung
3b352c7bbf Bug 1423917 - P9 - Remove asmjs client in the 2_1to2_2 upgrade for QuotaManager; r=luke
Differential Revision: https://phabricator.services.mozilla.com/D21732

--HG--
extra : moz-landing-system : lando
2019-03-13 15:59:34 +00:00
Tom Tung
2019dc0bc0 Bug 1423917 - P7 - Ignore invalid origin files during upgrading; r=asuth
After this patch, invalid origin shouldn't block upgrade anymore. However, we
should be aware of that if an invild origin somehow can be recoverd to a valid
origin, then upgrade that origin is required.

Depends on D21730

Differential Revision: https://phabricator.services.mozilla.com/D21731

--HG--
extra : moz-landing-system : lando
2019-03-20 13:32:47 +00:00
Tom Tung
9fd3c80fee Bug 1423917 - P6 - Having a test to verify the version2_1To2_2 upgrade removes obsolete origins and isn't blocked by an invalid origin; r=asuth
Depends on D21729

Differential Revision: https://phabricator.services.mozilla.com/D21730

--HG--
extra : moz-landing-system : lando
2019-03-20 13:32:45 +00:00