Commit Graph

1443 Commits

Author SHA1 Message Date
Marco Bonardo
25b6fcfef8 Bug 474582 - With initial migration Shiretoko doesn't import favorites from Internet Explorer 7 anymore, r=dietrich 2009-02-04 13:47:13 +01:00
Shawn Wilsher
63d8572077 Bug 476292 - Crashes on startup on OS X and Linux [@ nsNavBookmarks::IsRealBookmark] [@ PL_DHashTableOperate]
This fixes a crash when we initialize nsNavBookmarks with a database that is out
of date (the schema version is less than the current one).  Because the bookmark
service initializes the history service in its Init method, and the history
service tries to get the bookmark service if the database needs an upgrade, we
try to re-enter the bookmark service's constructor.  Bad things happen.

Adds a test to ensure that we don't do this again.

r=dietrich
r=MaK77
2009-02-03 21:58:21 -05:00
Drew Willcoxon
e6800cf24a Bug 444179 - Library>Views>Sort>Sort by Tags does nothing, r=mak77 2009-01-30 13:34:38 +01:00
Jeff Muizelaar
16fff652b0 nsNavHistory::AddDocumentRedirect doesn't handle INTERNAL redirects - bug 475069 r=mak77 2009-01-29 14:26:04 -05:00
Shawn Wilsher
30a3eb4e26 Bug 449406 - bookmarks of TRANSITION_DOWNLOAD and TRANSITION_EMBED don't show up in the location bar if they've been visited
This adds a new function to nsNavBookmarks that determines if a place id is a
"real" bookmark (not a livemark child).  It also makes a number of places use
this new function to unify and simplify a number of code paths.

Additionally, it changes how frecency is calculated for bookmarked items.  If a
visit is bookmarked (aIsBookmarked is true in CalculateFrecencyInternal), the
visited bookmark bonus is now added for all visits.  The visit bonus was also
cut in half for bookmarks so TRANSITION_BOOKMARK will still end up with the same
value (150).

r=dietrich
r=MaK77
2009-01-27 21:01:33 -05:00
Gavin Sharp
a66d512bae Bug 474538 - nsIBrowserHistory::removePagesFromHost documentation is crazy, r=sdwilsh 2009-01-23 12:52:14 +01:00
Daniel Holbert
4301671b45 Bug 473236 - Remove executable bit from files that don't need it. (Only changes file mode -- no code changes.) r=bsmedberg 2009-01-21 22:55:08 -08:00
Drew Wilcoxon
6ea2fab760 Bug 370197 - Places query serialization needs tests . r=mak77 2009-01-21 12:39:07 +01:00
Marco Bonardo
626228fe8e Bug 466422 - Clicking history - show all history doesn't show any history, r=dietrich 2009-01-21 12:39:07 +01:00
Marco Bonardo
d1b215d29b Bug 474334 - "place:" is a valid query to deserialize and should not cause an "ignoring unknown key:" warning, r=dietrich 2009-01-21 12:39:07 +01:00
Edward Lee
1a84fc47cd Bug 471903 - pref urlbar.autocomplete.enabled is no longer implemented. r=dietrich
Bug 472943 - Two confusable preferences, "browser.urlbar.search.sources" and "browser.urlbar.default.behavior", should be unified

--HG--
rename : toolkit/components/places/tests/autocomplete/test_search_sources.js => toolkit/components/places/tests/autocomplete/test_enabled.js
2009-01-21 02:00:04 -06:00
Fred Jendrzejewski
d8f1bff747 Bug 461047 - Replace nsStringArray with nsTArray<nsString>. r+sr=roc 2009-01-18 21:14:14 +01:00
Marco Bonardo
3819e4a7ae Bug 471084 - Importing a large bookmarks JSON backup makes Firefox crash (out of memory), r=dietrich 2009-01-17 15:45:37 +01:00
Marco Bonardo
9c21642d6a Bug 452000 - Sort by keyword in Library does not work, r=dietrich 2009-01-17 15:45:37 +01:00
Robert O'Callahan
804cc7ee91 Backed out changeset 8019a959aade 2009-01-16 22:20:33 +13:00
Fred Jendrzejewski
065bde22f3 Bug 461047. Replace nsStringArray with nsTArray<nsString>. r+sr=roc
--HG--
extra : rebase_source : 7a20af24c97867efbb28dafa6a70ea1b4cf00e58
2009-01-16 20:51:04 +13:00
Neil Rashbrook
1c174bbec1 Bug 470586 - Crash calling removePagesFromHost when sidebar is showing pages grouped by day and site, r=sdwilsh 2009-01-15 15:37:33 +01:00
Drew Willcoxon
7321622b64 Bug 463674 - changeBookmarkURI() doesn't update internal bookmark hash, r=mak77 2009-01-15 15:37:33 +01:00
Ben Turner
b28ea75f40 Merge backout 2009-01-14 18:24:18 -08:00
Ben Turner
b439b74cb4 Backed out changeset 96a66c1a50bd for failing unit tests. 2009-01-14 18:23:21 -08:00
Neil Rashbrook
7fad8f76a1 Bug 473157 Sorting shouldn't affect grouping containers, only uris r=dietrich 2009-01-14 22:38:30 +00:00
Neil Rashbrook
a3132fc3e0 Bug 470586 Can crash removing all pages from a host when the sidebar is grouped r=sdwilsh 2009-01-14 22:33:37 +00:00
Drew Willcoxon
98a9f9bb8d Bug 412132 - after changing a bookmark's location, need to update the frecency of the "old" uri, r=dietrich 2009-01-13 11:48:27 +01:00
Marco Bonardo
28e10ad2a2 Bug 454977 - remove INSERT OR REPLACE to avoid error prone paths with views, r=dietrich 2009-01-13 11:48:25 +01:00
Phil Ringnalda
c0c4db15f5 I would not have choosen the weekend before a freeze for so much CLOSED TREE 2009-01-11 20:12:32 -08:00
Robert Kaiser
f757a751ea bug 471886 - Make places autocomplete tests even more robust against default prefs, r=Mardak 2009-01-10 16:29:17 +01:00
Edward Lee
afc13be206 Bustage fix Bug 463483 (finalized typed query statement) 2009-01-07 16:53:54 -08:00
Edward Lee
c40eef5e18 Bug 426864 - Only show user typed history pages for the urlbar dropdown. r=dietrich 2009-01-07 15:47:58 -08:00
Edward Lee
288184e803 Bug 463483 - matchOnlyTyped no longer honored with special filters. r=dietrich
Bug 463558 - Switch matchOnlyTyped to restrict.typed "~" (default.behavior + 32)
2009-01-07 15:47:56 -08:00
Marco Bonardo
584d77afc2 Bug 468400 - xpcshell-simple/test_places/unit/test_adaptive.js | *** TIMEOUT ***: The test timed out while polling database, r=sdwilsh 2009-01-08 00:37:01 +01:00
Marco Bonardo
a08240cc9f Bug 466407 - History menu often shows duplicated items, r=dietrich 2009-01-08 00:37:01 +01:00
Marco Bonardo
3b181c3b6e Bug 471547 - move PlacesDBUtils getters to avoid possible leaks, r=sdwilsh 2009-01-08 00:37:01 +01:00
Marco Bonardo
ec9e34388f Bug 470429 - nsPlacesDBFlush::onItemAdded should not sync if the item is a container, r=sdwilsh 2009-01-08 00:37:00 +01:00
Marco Bonardo
f58153f58e Bug 462765 - instant-apply muddies the MRU folder list in the bookmark properties dialog, r=dietrich 2009-01-08 00:37:00 +01:00
mak77@bonardo.net
e147492d21 Bug 470348 - clear private data on shutdown does not delete history if "ask me before..." is enabled (r=dietrich, gavin) 2009-01-06 12:41:08 -08:00
Dietrich Ayala
24c7e5d7a0 Bug 464486 - lots of bookmark corruption reported via user support (r=marco, sdwilsh) 2009-01-03 09:26:11 -08:00
Ehsan Akhgari
63d1be936d Bug 471018 - Warning: nsFaviconService.cpp: outparam 'aHasData' not written on NS_SUCCEEDED(return value); r=dietrich 2009-01-03 07:42:34 +03:30
Dietrich Ayala
75962c75b4 Bug 432706 - Deleting/adding/updating a large quantity of bookmarks/history is very slow due to updating observers (r=marco) 2009-01-02 11:03:38 -08:00
Marco Bonardo
663e1d48ad Bug 470707 - [SeaMonkey] test_download_history.js fails now, r=dietrich 2008-12-30 22:42:23 +01:00
Marco Bonardo
98efaef25b Bug 466564 - RemoveDuplicateURIs is not aware of temp views, r=dietrich 2008-12-30 22:42:23 +01:00
Marco Bonardo
4dda69cade Bug 464438 - move EnsureCurrentSchema into migration path, r=dietrich 2008-12-30 22:42:23 +01:00
Marco Bonardo
2e9e9fadf4 Bug 439129 - Clearing browsing history does not hide livemarks children from the location bar, r=dietrich 2008-12-30 22:42:22 +01:00
Dietrich Ayala
36c00fde37 Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike) 2008-12-30 13:44:55 +01:00
Dietrich Ayala
5cb43235f7 backout bug 414715 due to leaks 2008-12-29 17:22:39 -08:00
Dietrich Ayala
0f17e9ca54 Bug 414715 - Notify the user if places.sqlite is locked and bookmarks and history will not work (relanding w/ leak fix, r=marco, r=gavin, l10n-r=pike) 2008-12-29 14:49:05 -08:00
Robert Kaiser
c0dec50ee4 bug 469593 - test_423060.xul fails on SeaMonkey, r=gavin
--HG--
rename : toolkit/components/places/tests/chrome/Makefile.in => browser/components/feeds/test/chrome/Makefile.in
rename : toolkit/components/places/tests/chrome/sample_feed.atom => browser/components/feeds/test/chrome/sample_feed.atom
rename : toolkit/components/places/tests/chrome/test_423060.xul => browser/components/feeds/test/chrome/test_423060.xul
2008-12-23 15:58:44 +01:00
Marco Bonardo
53b546dfd4 Bug 470455 - test_database_sync_embed_visits.js leaks, r=sdwilsh 2008-12-22 11:07:21 +01:00
Shawn Wilsher
4079f2d44e Bug 469972 - leaking the places database connection in strange situations; r=dietrich 2008-12-20 01:46:04 +01:00
Marco Bonardo
6d6a704efd Bug 458849 - transition download visits saved when "Keep my history..." is unchecked, r=sdwilsh 2008-12-19 13:36:15 +01:00
Dietrich Ayala
440d3c07bc imported patch backout-bug414715 2008-12-18 17:09:25 -08:00