Commit Graph

69222 Commits

Author SHA1 Message Date
Kartikaya Gupta
25cb12eaba Bug 1558645 - Adjust fuzz for selector-read-write-type-change-001.html on geckoview. r=gbrown
Depends on D34724

Differential Revision: https://phabricator.services.mozilla.com/D34725

--HG--
extra : moz-landing-system : lando
2019-06-12 15:35:54 +00:00
Kartikaya Gupta
93e64d8483 Bug 1558660 - Adjust fuzz for bugs/391994-1.html on geckoview. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D34724

--HG--
extra : moz-landing-system : lando
2019-06-12 15:36:32 +00:00
Dorel Luca
fe1531cfc1 Merge mozilla-inbound to mozilla-central. a=merge 2019-06-12 15:05:58 +03:00
Emilio Cobos Álvarez
a45852130e Bug 1558352 - Ensure canvas anonymous content is always created before constructing the document element frame's children. r=TYLin
Right now that doesn't happen, so you can run into problems like the one
described in bug 1492582 comment 30 for popups.

This is a bit annoying, but it's more consistent with how regular anonymous
content works already:

  https://searchfox.org/mozilla-central/rev/0da35261b6789eec65476dbdd4913df6e235af6d/layout/base/nsCSSFrameConstructor.cpp#9644

It's still not 100% consistent, since the root element's frame would still end
up first in the frame tree, but I think that's both less important and harder to
change. I've left a comment to that effect in the code.

Differential Revision: https://phabricator.services.mozilla.com/D34434

--HG--
extra : moz-landing-system : lando
2019-06-12 10:09:28 +00:00
Hiroyuki Ikezoe
56cfdf6c52 Bug 1554022 - Use the current position in CSS pixels for the start point of ScrollBy. r=botond,mstange
Otherwise clamped positions in layer pixels might cause 1-pixel difference
in CSS pixels on Android.

Note that there is a fundamental issue on the interaction between
the layer-pixel alignment and scrolling APIs (bug 1556685), once we fix the bug
properly, we should use the scrolled position, which was given by the scrolling
APIs, for the current position.

Differential Revision: https://phabricator.services.mozilla.com/D32779

--HG--
extra : moz-landing-system : lando
2019-06-11 22:43:34 +00:00
Sean Feng
36865676e1 Bug 1512388 - Add loading cross domain iframes in background r=smaug
This patch adds the ability to load cross domain iframes in the
background to make the top level documents finish earlier.

This is an experiment feature that we'll keep it disabled by default.

Differential Revision: https://phabricator.services.mozilla.com/D24938

--HG--
extra : moz-landing-system : lando
2019-06-11 20:43:40 +00:00
Will Hawkins
f7a08bd7ed Bug 1550437: Make sure that About dialog animates the throbber. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D34429

--HG--
extra : moz-landing-system : lando
2019-06-11 14:19:43 +00:00
Kartikaya Gupta
9671e837c3 Bug 1558607 - Allow smaller fuzz for reftest on GeckoView. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D34604

--HG--
extra : moz-landing-system : lando
2019-06-11 21:20:22 +00:00
Gurzau Raul
577021c8c2 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-06-12 00:36:41 +03:00
Gurzau Raul
227f5329f7 Merge inbound to mozilla-central. a=merge 2019-06-12 00:34:32 +03:00
Emilio Cobos Álvarez
a0516ce321 Bug 1505489 - Invalidate the style of the element when the part attribute changes. r=heycam
I think that, given ::part() right now (without forwarding) cannot affect
descendants (and eager pseudo-elements are handled as part of the normal element
restyling process), it is not worth the effort to add more complex invalidation.

But we can always re-evaluate.

Depends on D32642

Differential Revision: https://phabricator.services.mozilla.com/D32643

--HG--
extra : moz-landing-system : lando
2019-06-11 17:42:00 +00:00
Ting-Yu Lin
307ef73912 Bug 1524431 Part 2 - Check IsBidiSplittable() before processing the ancestor frames. r=jfkthame
The idea is to check IsBidiSplittable() in more places to prevent fixed
continuations created by column-span from becoming fluid ones.

Differential Revision: https://phabricator.services.mozilla.com/D34093

--HG--
extra : moz-landing-system : lando
2019-06-11 19:27:57 +00:00
Ting-Yu Lin
6904399bd9 Bug 1524431 Part 1 - Revert Bug 1520722 Part 2. r=jfkthame
This reverts the modification to nsBidiPresUtils.cpp in Bug 1520722 Part
2, but keeps the test added. Next part will fix the problem in a proper
way.

Differential Revision: https://phabricator.services.mozilla.com/D34092

--HG--
extra : moz-landing-system : lando
2019-06-11 16:21:57 +00:00
Kartikaya Gupta
d202cea0f0 Bug 1501582 - Increase position-dynamic-changes to a blanket fuzz. r=gbrown
The fuzziness in the position-dynamic-changes reftests seems nondeterministic.
The fuzziness annotations in the previous patch were what I got after a few
iterations of do-a-try-push-and-update-annotations, but there are still more
failures showing up in subsequent try pushes. I visually checked all the
failures and they are all just fuzzy in different places, but intermittent.
This patch updates the fuzziness annotations on these tests to the maximum
that I encountered on any test, which is (2, 1382).

I'm keeping this as a separate patch because I think it might be valuable
in version control history to have the actual numbers seen on try which
are in the previous patch.

Depends on D34538

Differential Revision: https://phabricator.services.mozilla.com/D34539

--HG--
extra : moz-landing-system : lando
2019-06-11 16:13:41 +00:00
Kartikaya Gupta
97d708b2a2 Bug 1501582 - Mark geckoview failures. r=gbrown
There are a number of failures, for which I've filed separate bugs.
And then a lot of fuzziness. I manually inspected the reftest analyzer
results on try pushes to distinguish failures vs fuzziness.

Depends on D34537

Differential Revision: https://phabricator.services.mozilla.com/D34538

--HG--
extra : moz-landing-system : lando
2019-06-11 16:12:03 +00:00
Kartikaya Gupta
9d4b493f9c Bug 1501582 - Add a geckoview condition to the reftest sandbox. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D34537

--HG--
extra : moz-landing-system : lando
2019-06-11 16:06:41 +00:00
Boris Zbarsky
d5a8a4a595 Bug 1557793 part 3. Change the signatures of various nsContentUtils localization methods to play nicer with the new stringbundle API. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D34201

--HG--
extra : moz-landing-system : lando
2019-06-08 21:26:12 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Botond Ballo
c0ca36e4fd Bug 1554813 - Size the scroll parts clip to the scroll frame's true outer size. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D33377

--HG--
extra : moz-landing-system : lando
2019-06-10 16:30:42 +00:00
Cameron McCormack
c52feec966 Bug 1557962 - Buffer OTS messages and report them once we're back on the main thread. r=jfkthame
And turn OMT OTS back on.

Differential Revision: https://phabricator.services.mozilla.com/D34439

--HG--
extra : moz-landing-system : lando
2019-06-11 15:56:31 +00:00
Olli Pettay
963b9d833d Bug 1556769, ensure UnsuppressAndInvalidate is called even if paint suppression isn't used, r=emilio
UnsuppressAndInvalidate updates focus state among others, so it needs to be called even if paint suppression itself
isn't used. An example of a such case is when PresShell is created after Document's readyState is already Document::READYSTATE_COMPLETE.

Differential Revision: https://phabricator.services.mozilla.com/D34426

--HG--
extra : moz-landing-system : lando
2019-06-11 11:03:38 +00:00
Emilio Cobos Álvarez
b4225d4d66 Bug 1558357 - Should update layout when the hypothetical display of an element changes, even though the final computed display doesn't. r=dbaron
Differential Revision: https://phabricator.services.mozilla.com/D34443

--HG--
extra : moz-landing-system : lando
2019-06-11 09:12:10 +00:00
Emilio Cobos Álvarez
26ce24d0a8 Bug 1558357 - Remove unused nsStyleDisplay::mOriginalFloat. r=dbaron
The original float is not needed for layout, and thus there's no need to keep it
around.

This was presumably used by the old style system, but now it doesn't seem
useful, and is always `none`.

Differential Revision: https://phabricator.services.mozilla.com/D34442

--HG--
extra : moz-landing-system : lando
2019-06-11 01:03:30 +00:00
Matt Woodrow
d35146931b Bug 1555819 - Remove invalidated display items during PreProcessDisplayLists, since we might not merge their display list. r=miko
Differential Revision: https://phabricator.services.mozilla.com/D33881

--HG--
extra : moz-landing-system : lando
2019-06-11 04:39:17 +00:00
Matt Woodrow
f6b0435e84 Bug 1547802 - Compute a single caret frame for the entire display list, and remove the option to invalidate frames during painting. r=miko,smaug
Previously we computed a caret frame each time we started display list building for a pres shell, and tracked a stack of these as we descended through subdocuments.
This meant that we couldn't know if the caret frame had changed before we started building, and we instead had to support invalidations in the middle of building.

Since there should only ever be one focused document, we can instead retrieve this from the focus manager, and find the sole caret frame for all documents we want to paint.

Differential Revision: https://phabricator.services.mozilla.com/D33880

--HG--
extra : moz-landing-system : lando
2019-06-11 04:39:00 +00:00
Cosmin Sabou
3d72a8ffe7 Backed out 2 changesets (bug 1547802, bug 1555819) for build bustages on nsDisplayList.
Backed out changeset aea91be6ce82 (bug 1555819)
Backed out changeset 11a69daedddb (bug 1547802)
2019-06-11 06:52:46 +03:00
Matt Woodrow
5dc2d83f7b Bug 1555819 - Remove invalidated display items during PreProcessDisplayLists, since we might not merge their display list. r=miko
Differential Revision: https://phabricator.services.mozilla.com/D33881

--HG--
extra : moz-landing-system : lando
2019-06-11 02:20:21 +00:00
Matt Woodrow
72068e14f5 Bug 1547802 - Compute a single caret frame for the entire display list, and remove the option to invalidate frames during painting. r=miko,smaug
Previously we computed a caret frame each time we started display list building for a pres shell, and tracked a stack of these as we descended through subdocuments.
This meant that we couldn't know if the caret frame had changed before we started building, and we instead had to support invalidations in the middle of building.

Since there should only ever be one focused document, we can instead retrieve this from the focus manager, and find the sole caret frame for all documents we want to paint.

Differential Revision: https://phabricator.services.mozilla.com/D33880

--HG--
extra : moz-landing-system : lando
2019-06-11 02:20:09 +00:00
Brindusan Cristian
d957131916 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-06-11 12:44:12 +03:00
Jonathan Watt
d46e1691fe Bug 1558349. Stop calling SetIsPrintPreview in nsDocumentViewer::PrepareToStartLoad. r=bobowen
This code predates our use of a static clone to print.  Nowadays we never
navigate in the (dedicated) print preview tab.

Differential Revision: https://phabricator.services.mozilla.com/D34433

--HG--
extra : rebase_source : f4b8c03e0dde5b96e2e848892623e6f88a365095
2019-06-04 22:53:09 +01:00
longsonr
8f38a4df8e Bug 1553460 - get text content via base class r=heycam
--HG--
extra : amend_source : 566bdf2d4e931b5bba3590ed1daf0e5bd59fdef8
2019-06-11 23:08:19 +01:00
Noemi Erli
fbb074d165 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-06-11 00:53:34 +03:00
Noemi Erli
9cc480e673 Merge inbound to mozilla-central. a=merge 2019-06-11 00:47:19 +03:00
Jonathan Kew
870189af7d Bug 1552121 - Reftest for suppression of auto-hyphenation in words with internal capitals. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D33956

--HG--
extra : moz-landing-system : lando
2019-06-10 15:00:29 +00:00
Mihai Alexandru Michis
6c1bc67848 Backed out 3 changesets (bug 1557291, bug 1552121) for causing reftest failures in hyphenation-caps-1.html
Backed out changeset 3dd86c6f8468 (bug 1552121)
Backed out changeset c333e3fc63ca (bug 1552121)
Backed out changeset 0b09ba0356f8 (bug 1557291)
2019-06-10 14:47:58 +03:00
Masayuki Nakano
94e3b7524c Bug 1529884 - part 1: Make Document use hashtable to map HTML command and internal command data r=smaug
Currently, `Document` converts HTML command (e.g., used by `execCommand()`) to
internal XUL command with array in the global space.  However, it requires scan
of the array for every command access.

This patch makes `Document` use hashtable to make the conversion faster.

New mapping info comes from:

- `mXULCommandName` is same as `internalCommandString`
- `mCommand` is mapped in CommandList.h from `mXULCommandName`
- `mGetEditorCommandFunc` is mapped from `mXULCommandName` in:
  - https://searchfox.org/mozilla-central/rev/d143f8ce30d1bcfee7a1227c27bf876a85f8cede/editor/libeditor/EditorController.cpp#31-32,34-38,40-41,43,45-51,54-57,67-112
  - https://searchfox.org/mozilla-central/rev/75294521381b331f821aad3d6b60636844080ee2/editor/libeditor/HTMLEditorController.cpp#26-28,31-39,48,51-52,55-58,60-63,65-73,76-80,83-88,90-91,93-94,97-100,102-104
- `mExecCommandParam` is converted from `useNewParam` and `convertToBoolean`:
  - If corresponding editor command class's `DoCommandParam()` just calls
    `DoCommand()`, `ExecCommandParam::Ignore`.
  - If `useNewParam` is `true` and `convertToBoolean` is `false`, given value
    should be ignored and may set constant instead.  In this case,
    `ExecCommandParam::Ignore`.
  - If `useNewParam` is `false` and `convertToBoolean` is `false`, given value
    should be treated as string.  In this case, `ExecCommandParam::String`.
  - If `useNewParam` is `false` and `convertToBoolean` is `true`, given value
    should be treated as bool.  In this case, if given command is not a legacy
    one, `ExecCommandParam::Boolean`.  Otherwise, i.e., if given command
    is a legacy one, `ExecCommandParam::InvertedBoolean`.
  - Otherwise, `ExecCommandParam::String`.

Differential Revision: https://phabricator.services.mozilla.com/D29628

--HG--
extra : moz-landing-system : lando
2019-06-10 10:23:59 +00:00
Jonathan Kew
4ccbc22e38 Bug 1552121 - Reftest for suppression of auto-hyphenation in words with internal capitals. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D33956

--HG--
extra : moz-landing-system : lando
2019-06-10 09:38:47 +00:00
Andreea Pavel
2c4bcdbd1d Backed out 3 changesets (bug 1488953) for failing bc at browser_windowopen.js on a CLOSED TREE
Backed out changeset 8646ea969443 (bug 1488953)
Backed out changeset 519acd8e145f (bug 1488953)
Backed out changeset 3a5cbbb9bc48 (bug 1488953)
2019-06-10 11:48:07 +03:00
Emilio Cobos Álvarez
ea497c3671 Bug 1488953 - Use a script runner for scrollport events. r=mats
This is consistent with the scroll area events too, and allows us to
remove the WillPaintObserver stuff.

Differential Revision: https://phabricator.services.mozilla.com/D5271

--HG--
extra : moz-landing-system : lando
2019-06-10 03:06:25 +00:00
Jonathan Watt
48364b8cbb Bug 1558210. Make various nsPrintJob methods private. r=bobowen
Also removes two unused (not even defined) method declarations.

Differential Revision: https://phabricator.services.mozilla.com/D34357

--HG--
extra : rebase_source : bd03bbe8f6a532aa38f9ae871e0b60ca9fa088a7
extra : amend_source : 758bb89dbe6413116647f78ced8afa41b9ce422e
2019-06-04 17:03:35 +01:00
Jonathan Watt
88e7ba6db9 Bug 1558180. Comment the mysterious OnPageHide() call in nsPrintJob and move it somewhere that makes sense. r=bobowen
Differential Revision: https://phabricator.services.mozilla.com/D34347

--HG--
extra : rebase_source : 4799985e94b29c2ef522d2d0ea69009fd72473ec
extra : amend_source : 5700597b2644267a6fecbd7e654e6162f3862bea
2019-06-04 16:01:33 +01:00
Jonathan Watt
9ff8f044a3 Bug 1558071. Rename nsIWebBrowserPrint.printPreviewNavigate to printPreviewScrollToPage. r=bobowen
Differential Revision: https://phabricator.services.mozilla.com/D34297

--HG--
extra : rebase_source : 58343bee2ce7e2761fcc93b8e842051a14cf3684
extra : amend_source : ff72ab52d1274f0bcfad59f30c43364af05a0310
2019-06-03 12:48:21 +01:00
Jonathan Watt
02015da744 Bug 1558072. Inline the nsDocumentViewer::ReturnToGalleyPresentation code to its single caller. r=bobowen
Differential Revision: https://phabricator.services.mozilla.com/D34296

--HG--
extra : rebase_source : 51d3d47d6c2e24ae49247cc8496afa5924ab9eda
extra : amend_source : 6cdc328683a450001ca50f783c803d865483e219
2019-06-03 10:10:42 +01:00
Jonathan Watt
cdbcb71463 Bug 1558079. Add a comment to the mozPrintCallback invoking code warning about its non-obvious behavior. r=bobowen
Differential Revision: https://phabricator.services.mozilla.com/D34298

--HG--
extra : rebase_source : 523c19cc0b63d08a5701f9a2d4148b146529827c
extra : amend_source : c3b5b7e85a1b9bc64e76524f974a96ad93201886
2019-05-31 16:18:51 +01:00
Jonathan Watt
79cd40383d Bug 1558057. Remove nsPrintJob::CleanupDocTitleArray. r=bobowen
Differential Revision: https://phabricator.services.mozilla.com/D34289

--HG--
extra : rebase_source : 0f65d809f1946fa1f555d24d364d49e294657ffb
extra : amend_source : 08fcb1420e8083573f7d783005eabbb7cc75dfd5
2019-05-30 14:03:36 +01:00
Emilio Cobos Álvarez
95bca607dd Bug 1487216 - Measure memory usage of RDL. r=mattwoodrow,miko
For now I added everything to the same bucket, but I wrote this so it should be
easy to add more buckets as needed (either to mArenaSizes, or more specific ones
like the style system has). But this is probably enough for now.

Differential Revision: https://phabricator.services.mozilla.com/D34126

--HG--
extra : moz-landing-system : lando
2019-06-09 22:58:24 +00:00
Brindusan Cristian
e97b017e63 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-06-10 00:47:15 +03:00
Brindusan Cristian
1d5124f5f9 Merge inbound to mozilla-central. a=merge 2019-06-10 00:43:09 +03:00
Emilio Cobos Álvarez
351d40e7c3 Bug 1557430 - Add memory reporters for SVG mapped attribute declarations. r=njn,heycam
These are owned by the element and not referenced from the stylesheets.

They're referenced from the rule tree, but the rule nodes don't measure their
style source (since they're non-owning).

So unconditionally reporting them even though it's a refcounted object is ok.

While at it, remove some other fields from the old style system that are no
longer used.

Differential Revision: https://phabricator.services.mozilla.com/D34014

--HG--
extra : moz-landing-system : lando
2019-06-08 18:58:57 +00:00
Csoregi Natalia
ee806041c6 Merge inbound to mozilla-central. a=merge 2019-06-09 12:06:26 +03:00