This allows subclasses to override the implementation,a nd avoids leaking ColorPicker
specific implementation details to the base class.
MozReview-Commit-ID: 6KHaFPd5xHt
--HG--
extra : rebase_source : d6bddd7d65d6c384b5a5c66d7b646110ca90c8c6
When exiting RDM with a device applied, we clear the UA override, but we did not
force a refresh of the page. This means that the customized UA was still
accessible via `navigator.userAgent` and the page might have a non-default
layout if it tests the UA value.
To ensure there's no chance of confusion after exiting RDM, force a reload if
clearing emulation values determines it is needed.
MozReview-Commit-ID: Fkji12Utmis
--HG--
extra : rebase_source : a7ae8851165fae7aec5875d10f51cbb703b3f870
Tests copied directly from older versions and adapted for React 16.
React source downloaded from https://github.com/facebook/react/releases/tag/v16.2.0
MozReview-Commit-ID: 80zwHIK16Cz
--HG--
extra : rebase_source : 0329b8407e38cf5757281456c62ff42c3846d8b2
There was an exception thrown by the netProviderEnhancer because it
retrieves the networkMessageUpdate and access a property on it.
On non-network message, the networkMessageUpdate is undefined, and
accessing the property throws.
We fix this by simply checking if message is not falsy before accessing
the property.
A couple of tests were added to make sure we don't regress this case. This
required changing the setupStore helper a bit to pass a hud stub to the
createStore function (the net enhancer is called only if the hud has a proxy
object). This made some test fail because they weren't dispatching enough
argument to the networkMessageUpdate action.
MozReview-Commit-ID: 7h35ebHSdbF
--HG--
extra : rebase_source : 089dce93d1de60e4b44936b514627803aa2c5100
Message icons now get the aria-live="off" attribute.
This stops screen readers from automaticaly reading icon descriptions, which might be interesting to read later but make things inefficient when automatically reading new output.
MozReview-Commit-ID: BQOUnTRVkBE
--HG--
extra : rebase_source : 47f1df96910a92961fc739582ffb49956735fdb3
Commands entered by the user now get the aria-live="off" attribute.
This stops screen readers from echoing commands the user typed, which is redundant and inefficient.
MozReview-Commit-ID: GJXiBPMe0W5
--HG--
extra : rebase_source : 9fac3b14115a9f2f54bc8180bed6c0442e0da3f0
Replace `loader.lazyGetter` pattern with normal variable assignment
MozReview-Commit-ID: JJTXKgXRgBZ
--HG--
extra : rebase_source : 91e63d7515573a3c55756fd04811fe61515b3cf8
The test was failing because it still had pending request to the server while shutting
down the toolbox. This request was probably the one to retrieve the properties of the
object we put in the sidebar.
By waiting the object properties to be fully loaded when opening the sidebar, we should
make the intermittent go away.
MozReview-Commit-ID: 7tY8hvbDVRp
--HG--
extra : rebase_source : cc5479f21c91df1fc0967900fb1022e3ec6dff3d
If the toolbox is open when a stylesheet is loaded, the network monitor should
have recorded the response content. When a tool asks for stylesheet text, try
asking the network monitor first before falling back to an extra fetch as a last
resort.
MozReview-Commit-ID: E2pQ04ARfQo
--HG--
extra : rebase_source : b10fb44e313ece5757961ca81a3bc0f76753ed8e
This changes the code of the test since it was relying on direct access to the content page.
In order to be able to interact with the element picker, the test-actor and test-actor-registery
files are loaded by head.js.
MozReview-Commit-ID: FyebIiyF31j
--HG--
extra : rebase_source : 83d7304303edc8e8a54cbcc2cc535987b8368207
The patch changes how log we wait before polling again in waitFor, since the timeout
is happening here.
MozReview-Commit-ID: 4ZteEmMBOZk
--HG--
extra : rebase_source : 44078fa03df8ce7650d71ac0ad401a30827f2d83
