Commit Graph

17953 Commits

Author SHA1 Message Date
Valentin Gosu
269fbdbecf Bug 1518730 - Wait for both A and AAAA responses to come back before notifying the listeners r=dragana
This way we preserve the behaviour of getaddrinfo, where both A and AAAA
responses come back at the same time.
Without this Firefox will always be biased, as the first request will usually
be resolved first. So if we requested IPv4 first, we'd mostly be using IPv4.
If we requested IPv6 first, normally we'll wait for the IPv4 response to come
back too, which is functionally equivalent to the new behaviour.
However, if the pref is set network.trr.early-AAAA;true then we'd use the IPv6
response immediately, possibly leading to a failed request if the IPv6
connection fails before we have an IPv4 address to fall back to.

A test for this patch was added in bug 1542561.

Depends on D33476

Differential Revision: https://phabricator.services.mozilla.com/D33477

--HG--
extra : moz-landing-system : lando
2019-06-03 21:13:22 +00:00
Valentin Gosu
c3ee743b2d Bug 1518730 - Only send AAAA TRR requests when the system has IPv6 connectivity r=dragana
This is an optimization. If we detect that the system can't use the IPv6
address, there's no point in making a request for it.

Depends on D33475

Differential Revision: https://phabricator.services.mozilla.com/D33476

--HG--
extra : moz-landing-system : lando
2019-06-03 21:17:08 +00:00
Valentin Gosu
b0786cdfb7 Bug 1518730 - Disable TRR for connectivity checks r=dragana
Depends on D33473

Differential Revision: https://phabricator.services.mozilla.com/D33475

--HG--
extra : moz-landing-system : lando
2019-06-03 21:17:57 +00:00
Valentin Gosu
1bb0e080b4 Bug 1542561 - Test that a IPv4 NXDOMAIN still uses the IPv6 response, regardless which one comes back first r=dragana
This test uses prefs added in Bug 1518730, but the pref is ignored when it
doesn't exist, so the test is still valid.

Depends on D33471

Differential Revision: https://phabricator.services.mozilla.com/D33473

--HG--
extra : moz-landing-system : lando
2019-06-03 21:20:39 +00:00
Valentin Gosu
15ababeb71 Bug 1542561 - TRR: Don't return NS_ERROR_UNKNOWN_HOST when a AAAA response comes back first, but the second A response is NXDOMAIN r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D33471

--HG--
extra : moz-landing-system : lando
2019-06-03 21:05:27 +00:00
Coroiu Cristina
73edc6621b Backed out 4 changesets (bug 1554847) for wpt failures at /service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html
Backed out changeset 17e36d139ac2 (bug 1554847)
Backed out changeset 101bd1c2d688 (bug 1554847)
Backed out changeset 3ff9a221f3e5 (bug 1554847)
Backed out changeset 946e4d9420dd (bug 1554847)
2019-06-04 03:24:42 +03:00
shindli
b83baa135f Backed out changeset 32f9907bf1f7 (bug 1555302) for causing permafailures in dom/url/tests/test_url.html CLOSED TREE 2019-06-03 23:33:14 +03:00
Valentin Gosu
8c0163caeb Bug 1555302 - Ensure that nsStandardURL::Resolve() doesn't parse URLs with a different scheme as relative r=mayhemer
Normally, this method will return the entire in string if it has a scheme.
However, mParser->ParseURL may fail, leading to the scheme to be cleared,
and the result will be the same HTTP URL with the input appended to the
path. This triggers the assertion in NS_NewURI that the scheme should not
change.

As a fix, we bail out of nsStandardURL::Resolve() if the parsed scheme of
the input is different than the base URIs current scheme. This condition
is necessary, because we still need to support a deprecated form of relative
URLs like http:file or http:/path/file

Differential Revision: https://phabricator.services.mozilla.com/D33003

--HG--
extra : moz-landing-system : lando
2019-06-03 19:30:42 +00:00
shindli
18d693fe12 Backed out 5 changesets (bug 1533877) for causing wpt permafailure in /html/cross-origin/anonymous.tentative.html CLOSED TREE
Backed out changeset 1804d3178cd4 (bug 1533877)
Backed out changeset b5a3e938f421 (bug 1533877)
Backed out changeset 08efb10cceb2 (bug 1533877)
Backed out changeset c4b8d755873b (bug 1533877)
Backed out changeset e53056e11429 (bug 1533877)
2019-06-03 22:06:38 +03:00
Valentin Gosu
e1092f8add Bug 1533877 - Frame navigations should check their parent's Cross-Origin policy r=nika
Differential Revision: https://phabricator.services.mozilla.com/D32972

--HG--
extra : moz-landing-system : lando
2019-06-03 14:57:13 +00:00
ffxbld
5cd2a9bc7d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D33506

--HG--
extra : moz-landing-system : lando
2019-06-03 15:44:26 +00:00
Andrea Marchesini
0a9fe4ff98 Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32364

--HG--
extra : moz-landing-system : lando
2019-06-03 11:14:38 +00:00
Andrea Marchesini
21cf95c1c2 Bug 1554847 - Improve cross-origin checks in canvas API - propagate allRedirectsSameOrigin to HttpChannelChild actor, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D32793

--HG--
extra : moz-landing-system : lando
2019-06-03 09:55:08 +00:00
Csoregi Natalia
de697c360a Merge mozilla-central to mozilla-inbound. CLOSED TREE
--HG--
rename : layout/generic/nsFrameIdList.h => layout/generic/FrameIdList.h
2019-06-02 00:37:53 +03:00
Valentin Gosu
3cacbcf87b Bug 1552438 - Remove TRR mode 4 (MODE_SHADOW) r=agrover
Differential Revision: https://phabricator.services.mozilla.com/D32997

--HG--
extra : moz-landing-system : lando
2019-06-01 09:44:20 +00:00
Valentin Gosu
4882c4f4ea Bug 1552438 - Remove TRR mode 1 (MODE_PARALLEL) r=agrover
Differential Revision: https://phabricator.services.mozilla.com/D32996

--HG--
extra : moz-landing-system : lando
2019-06-01 09:44:06 +00:00
arthur.iakab
36d75a7e56 Merge mozilla-central to mozilla-inbound 2019-06-01 01:30:47 +03:00
Kartikaya Gupta
0d8a0d2546 Bug 1555966 - Back out cset ecceef291b89 (bug 1551601) for regressions. rs=valentin 2019-05-31 16:07:18 -04:00
Honza Bambas
c35df87597 Bug 1545421 - New nsresult error codes for 407, 502 and 504 http response codes returned by proxies + test, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D32817

--HG--
extra : moz-landing-system : lando
2019-05-31 17:29:53 +00:00
Sebastian Hengst
78e651853f Merge mozilla-central to autoland. CLOSED TREE 2019-05-31 19:07:44 +02:00
Sebastian Hengst
5c434d0aa6 Merge autoland to mozilla-central. a=merge 2019-05-31 19:00:53 +02:00
Jorg K
be25a0ae54 Bug 1550945 - Follow-up to part 2, M-C: Move hook in nsNetUtil::NS_NewURI(). r=valentin a=Aryx DONTBUILD NPOTB 2019-05-31 11:53:59 +02:00
Ehsan Akhgari
d74c1d4a0f Bug 1555846 - Block cookies from trackers with dynamic FPI; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33227

--HG--
extra : moz-landing-system : lando
2019-05-31 14:33:36 +00:00
Dorel Luca
5a3296d55a Backed out changeset 910f7703f9f3 (bug 1555846) for Build bustages. CLOSED TREE 2019-05-31 17:24:43 +03:00
Ehsan Akhgari
62aa7c0ec3 Bug 1555846 - Block cookies from trackers with dynamic FPI; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33227

--HG--
extra : moz-landing-system : lando
2019-05-31 06:14:14 +00:00
Ehsan Akhgari
58702e4a1d Bug 1555715 - Remove WebSocketChannelParent::mIPCOpen; r=valentin
It is no longer necesssary for individual actors to do this book-keeping
manually.

Differential Revision: https://phabricator.services.mozilla.com/D33159

--HG--
extra : moz-landing-system : lando
2019-05-31 12:08:02 +00:00
ffxbld
669d19df08 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D33154

--HG--
extra : moz-landing-system : lando
2019-05-30 13:07:37 +00:00
Honza Bambas
d47b46c009 Bug 1553927 - Do not do immediate captive portal check on certificate/ssl errors when connecting a plain URL to prevent loops, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D33032

--HG--
extra : moz-landing-system : lando
2019-05-29 16:13:46 +00:00
Christian Holler
d67b031492 Bug 1528950 - Implement HTTP fuzzing target for Necko. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D32755

--HG--
extra : moz-landing-system : lando
2019-05-31 09:34:00 +00:00
Andrea Marchesini
aa84d3c812 Bug 1436674 - nsICookieService.idl should use ACString XPIDL type in place of the string type, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32662

--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
Andrea Marchesini
b1b122fb20 Bug 1554464 - Merge nsICookie2 and nsICookie in 1 single interface, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33031

--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
Andrea Marchesini
68fbe6f8ca Bug 1554377 - Cleanup nsCookie implementation - Removed mIPCOpen, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32616

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:51 +00:00
Andrea Marchesini
fd927a96aa Bug 1554377 - Cleanup nsCookie implementation - network_cookie_thirdparty_nonsecureSessionOnly to StaticPrefs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32615

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:33 +00:00
Andrea Marchesini
1040f3de6a Bug 1554377 - Cleanup nsCookie implementation - network.cookie.thirdparty.sessionOnly to StaticPrefs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32614

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:13 +00:00
Andrea Marchesini
ff8aaf2236 Bug 1554377 - Cleanup nsCookie implementation - simpler nsCookie, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32562

--HG--
extra : moz-landing-system : lando
2019-05-31 09:31:47 +00:00
Andrea Marchesini
8bcf905e12 Bug 1554377 - Cleanup nsCookie implementation - Get rid of nsCookieAttributes, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32561

--HG--
extra : moz-landing-system : lando
2019-05-31 09:31:30 +00:00
Andrea Marchesini
a1e12567f6 Bug 1554377 - Cleanup nsCookie implementation - Get rid of ConstCookie, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32560

--HG--
extra : moz-landing-system : lando
2019-05-31 09:31:12 +00:00
Thomas Nguyen
cd48bd6695 Bug 1554289 - Add non-null checks around assignment referrerInfo to preflight HTTP channel r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D32976

--HG--
extra : moz-landing-system : lando
2019-05-31 09:39:51 +00:00
Gijs Kruitbosch
e561d233e9 Bug 1552993 - r=valentin,dragana
Differential Revision: https://phabricator.services.mozilla.com/D32066

--HG--
extra : moz-landing-system : lando
2019-05-27 09:14:33 +00:00
Csoregi Natalia
a51ae3670f Backed out 5 changesets (bug 1551798) for failures on test_rawSameSite.js. CLOSED TREE
Backed out changeset 11ddc433b632 (bug 1551798)
Backed out changeset f2ac8efb023d (bug 1551798)
Backed out changeset 0f6e797b434f (bug 1551798)
Backed out changeset eae7f88660c8 (bug 1551798)
Backed out changeset 2ba747afb3d0 (bug 1551798)
2019-05-30 10:17:01 +03:00
Andrea Marchesini
ef73f6105f Bug 1551798 - Add comments about the next removing patches, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33037

--HG--
extra : moz-landing-system : lando
2019-05-29 16:34:27 +00:00
Andrea Marchesini
d513a67ed4 Bug 1551798 - Test for cookie migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32483

--HG--
extra : moz-landing-system : lando
2019-05-29 15:56:22 +00:00
Andrea Marchesini
84e139e50b Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-05-29 16:34:33 +00:00
Andrea Marchesini
ae8ab513d8 Bug 1551798 - SameSite=lax by default and SameSite=none only if secure, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31215

--HG--
extra : moz-landing-system : lando
2019-05-30 00:48:41 +00:00
Byron Campen [:bwc]
2d6cf50175 Bug 1551589: readyState fixes r=ng
Depends on D31085

Differential Revision: https://phabricator.services.mozilla.com/D31123

--HG--
extra : moz-landing-system : lando
2019-05-29 21:27:18 +00:00
Andrea Marchesini
4c6ace6ac6 Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31214

--HG--
extra : moz-landing-system : lando
2019-05-29 15:55:03 +00:00
arthur.iakab
944263f18a Backed out 5 changesets (bug 1551798) for multiple build bustages on StaticPrefList.h CLOSED TREE
Backed out changeset c89daff34d97 (bug 1551798)
Backed out changeset bbc3f88b8c03 (bug 1551798)
Backed out changeset b87996b8a411 (bug 1551798)
Backed out changeset d88b0002d736 (bug 1551798)
Backed out changeset 0fe740c90e2b (bug 1551798)
2019-05-29 18:07:26 +03:00
Andrea Marchesini
08c8aa4d6d Bug 1551798 - Test for cookie migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32483

--HG--
extra : moz-landing-system : lando
2019-05-27 01:46:11 +00:00
Andrea Marchesini
d5fdfc9e8c Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-05-27 05:11:54 +00:00
Andrea Marchesini
7a79f55da4 Bug 1551798 - SameSite=lax by default and SameSite=none only if secure, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31215

--HG--
extra : moz-landing-system : lando
2019-05-24 15:44:00 +00:00