Commit Graph

9080 Commits

Author SHA1 Message Date
Dorel Luca
27321e1f00 Backed out 3 changesets (bug 1636251) for phyton failures in python/mach/mach/test/test_conditions.py. CLOSED TREE
Backed out changeset a033282e742d (bug 1636251)
Backed out changeset ce8cb6373f88 (bug 1636251)
Backed out changeset ae78c0a50575 (bug 1636251)
2020-06-11 19:49:44 +03:00
Mitchell Hentges
34d2e43294 Bug 1636251: document mach error reporting r=rstewart
Differential Revision: https://phabricator.services.mozilla.com/D78409
2020-06-10 19:50:59 +00:00
Mitchell Hentges
2b514aa148 Bug 1636251: Patch Sentry events to ensure a raw username isn't sent to Sentry r=rstewart
To avoid sending identifying information, common absolute paths are patched with placeholder values. For example, devs
may place their Firefox repository within their home dir, so absolute paths are doctored to be prefixed with
"<topsrcdir"> instead.

Additionally, any paths including the user's home directory are patched to instead be a relate path from "~".

Differential Revision: https://phabricator.services.mozilla.com/D78962
2020-06-10 19:50:57 +00:00
Mitchell Hentges
47c53b361d Bug 1636251: report |./mach| errors with Sentry r=rstewart
These errors are reported to the "mach" project here:
https://sentry.prod.mozaws.net/operations/mach/

Should only report exceptions caused by a failure in `mach` or its subcommands. Build/test/etc failures
should not be sent to Sentry.

Depends on D74737

Differential Revision: https://phabricator.services.mozilla.com/D74738
2020-06-10 19:50:55 +00:00
Tom Ritter
47fe961b00 Bug 1637845 - Move all mach vendor files to a subdirectory r=glob
Differential Revision: https://phabricator.services.mozilla.com/D75693
2020-06-10 14:38:57 +00:00
Mitchell Hentges
4183da479b Bug 1621960: upload_generated_sources uses py3-compatible import r=rstewart
Differential Revision: https://phabricator.services.mozilla.com/D79155
2020-06-10 16:13:05 +00:00
Mike Hommey
70653120cb Bug 1622963 - Require python 3.6 for the build system. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D77754
2020-06-09 21:22:32 +00:00
Mitchell Hentges
c28298cb71 Bug 1621960: Improves genpgocert compatibility with Python 3 r=rstewart
Depends on D77965

Differential Revision: https://phabricator.services.mozilla.com/D77966
2020-06-09 18:48:19 +00:00
Noemi Erli
9017f973e3 Backed out 4 changesets (bug 1621960) for causing Android bustages CLOSED TREE
Backed out changeset f36a95234a5f (bug 1621960)
Backed out changeset 0e4661c9061d (bug 1621960)
Backed out changeset 3e2cbe4dd777 (bug 1621960)
Backed out changeset d7eb101e5df7 (bug 1621960)
2020-06-09 20:59:26 +03:00
Mitchell Hentges
1c169fac1c Bug 1621960: Improves genpgocert compatibility with Python 3 r=rstewart
Depends on D77965

Differential Revision: https://phabricator.services.mozilla.com/D77966
2020-06-09 16:44:40 +00:00
Mitchell Hentges
ed90a04ad1 Bug 1632874: |mach bootstrap| should write mozconfig file if it doesn't exist r=rstewart
Rather than always printing instructions at the end of the bootstrap phase, we will now create a mozconfig
file if one doesn't exist and there's configuration to be written.

Differential Revision: https://phabricator.services.mozilla.com/D78417
2020-06-08 19:36:56 +00:00
Sylvestre Ledru
be715d2f73 Bug 1644123 - mach doc: Provides the full path to logo and favicon + update of the build sparse config r=firefox-source-docs-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D78671
2020-06-08 19:06:44 +00:00
Jan de Mooij
518531d1aa Bug 1642893 - Don't build NSPR by default for standalone JS builds. r=glandium
For standalone JS builds there are three possibilities: no-NSPR (the default),
build NSPR, or use system NSPR.

This patch makes no-NSPR the default again when not overridden by --enable-nspr-build
or --with-system-nspr. This was likely regressed by bug 1641775.

Differential Revision: https://phabricator.services.mozilla.com/D78001
2020-06-05 07:52:37 +00:00
Mitchell Hentges
e8ffc3e0cb Bug 1641806: configure should look for libclang >= 5.0 r=rstewart
clang_getAddressSpace was found as a clang 5.0+ API by comparing the "tools/libclang/libclang.exports" files in the clang source code.
"clang_getAddressSpace" exists for 5.0.0 and 10.0.0, but not for 4.0.1.

Differential Revision: https://phabricator.services.mozilla.com/D78374
2020-06-04 20:15:20 +00:00
Makoto Kato
598e50d2c3 Bug 1642658 - Android SDK/NDK root should replace file separator with '/'. r=froydnj
When not using --with-android-ndk, NDK root is `~/.mozbuild/android-ndk-r20`.
When building this NDK path, since we use `os.path.join`, so it may include "\"
as file separator on Windows host. Then some options such as `-gcc-toolchain`
become invalid path (ex. `C:/users/makoto.mozbuildandroid-ndk-r20/`..).

So we should replace file separator with "/".

Differential Revision: https://phabricator.services.mozilla.com/D77820
2020-06-03 15:32:30 +00:00
John Paul Adrian Glaubitz
e1b5790f4d Bug 1325771 - build: Add m68k as target architecture to mozbuild r=glandium
Adds the basic definitions for m68k to mozbuild, allowing to build Spidermonkey.

Differential Revision: https://phabricator.services.mozilla.com/D77285
2020-06-03 18:30:50 +00:00
Coroiu Cristina
3cce853af2 Backed out 4 changesets (bug 1641291) for build bustages and SM failures on a CLOSED TREE
Backed out changeset 9c0a44614576 (bug 1641291)
Backed out changeset 0dcf604b880e (bug 1641291)
Backed out changeset d830bee40b5c (bug 1641291)
Backed out changeset fe38c82c2dad (bug 1641291)
2020-06-03 22:09:52 +03:00
Nick Alexander
916d838f9c Bug 1641291 - Part 1: Allow cross-compiling from host macOS -> Windows target. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D77117
2020-06-03 18:18:15 +00:00
Mitchell Hentges
291e3e141e Bug 1632429: "enum34" and "enum" virtualenv packages are now only available to the python2 env r=rstewart
When running |mach python| with python 3, it was failing when importing "enum", since it would get the python 2 backport. By making these packages only
available to python 2, we allow python 3 to import standard library packages properly.

Differential Revision: https://phabricator.services.mozilla.com/D77960
2020-06-03 18:15:38 +00:00
Dorel Luca
0154691eae Backed out 5 changesets (bug 1325771) for Spidermonkey failures and build bustage in build/src/mfbt/tests/TestCompactPair.cpp. CLOSED TREE
Backed out changeset ace40545b46c (bug 1325771)
Backed out changeset b3e0fb410a1c (bug 1325771)
Backed out changeset d69ac62c063f (bug 1325771)
Backed out changeset 24e6299e112d (bug 1325771)
Backed out changeset 393a6ff847ce (bug 1325771)
2020-06-03 20:23:08 +03:00
John Paul Adrian Glaubitz
25481ca65b Bug 1325771 - build: Add m68k as target architecture to mozbuild r=glandium
Adds the basic definitions for m68k to mozbuild, allowing to build Spidermonkey.

Differential Revision: https://phabricator.services.mozilla.com/D77285
2020-06-02 07:00:48 +00:00
Bogdan Tara
979c77d94e Backed out changeset 83ee79caab92 (bug 1622963) for python related bustages CLOSED TREE 2020-06-03 10:23:57 +03:00
Mike Hommey
323ea73e5a Bug 1622963 - Require python 3.6 for the build system. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D77754
2020-06-03 02:16:48 +00:00
Mike Hommey
98b889cf83 Bug 1622963 - Install python 3.6 in build docker images. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D77753
2020-06-02 03:51:14 +00:00
Ricky Stewart
c3ad21f99d Bug 1642015 - Don't dump a raw bytestring to the terminal in RunCbindgen.py r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D77556
2020-06-01 15:50:29 +00:00
Mike Hommey
038f9f8138 Bug 1641790 - Move --with-system-nss to python configure. r=firefox-build-system-reviewers,rstewart
Version of NSS >= 3.27 have a pkg-config file. We're now requiring 3.53,
so while moving, just use pkg-config, which is simpler.

The old-configure check that rejected some untested platforms for
in-tree NSS is actually rejecting none: the accepted platforms cover all
the supported ones, so we remove that check.

And because building with system NSS without system NSPR doesn't make
sense, imply the latter when the former is used.

Differential Revision: https://phabricator.services.mozilla.com/D77428
2020-05-29 17:02:09 +00:00
Mike Hommey
9088528947 Bug 1635764 - Move --with-system-icu and --with-intl-api to python configure. r=firefox-build-system-reviewers,rstewart
At the same time, because it's now simpler to do so, set the right data
file name for big-endians, even though we don't have or produce it
(bug #1264836). Also remove USE_ICU, which is redundant with
JS_HAS_INTL_API, and actively break the build at configure time when
using --without-intl-api with Firefox because this hasn't actually
worked for close to 3 years (since bug 1402048).

Differential Revision: https://phabricator.services.mozilla.com/D77416
2020-05-29 21:29:52 +00:00
Mike Hommey
8a9448c75b Bug 1641785 - Move --with-jitreport-granularity to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D77415
2020-05-29 12:17:26 +00:00
Mike Hommey
623e778ff2 Bug 1641786 - Move --with-debug-label to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D77414
2020-05-29 12:17:24 +00:00
Mike Hommey
313131917e Bug 1641775 - Move --with-system-nspr to python configure. r=firefox-build-system-reviewers,rstewart
Versions of NSPR >= 4.10 come with a pkg-config file. We currently
depend on 4.9.2 for spidermonkey, but much more recent versions for
Firefox. 4.10 is less than a year newer than 4.9.2, and 4.10 is 7 years
old, so bumping the requirement to 4.10 is not really a big deal.

With the use of pkg-config, --with-nspr-cflags and --with-nspr-libs are
not needed.

None of the AC_TRY_COMPILE tests were any useful because
PR_STATIC_ASSERT and PR_UINT64 have been when we look for them since
4.8.6 and 4.9 respectively.

Differential Revision: https://phabricator.services.mozilla.com/D77412
2020-05-29 17:11:27 +00:00
Mike Hommey
eba22e2279 Bug 1641760 - Move --with-system-zlib to python configure. r=froydnj
As all versions of zlib >= 1.2.3.1 have a pkg-config file, and 1.2.3.1
is close to 14 years old, let's drop 1.2.3 and just use pkg-config, which
simplifies what we need to do dramatically.

Differential Revision: https://phabricator.services.mozilla.com/D77404
2020-05-29 20:59:00 +00:00
Axel Hecht
1343d506c0 Bug 1641184, use only the merge dir for repacks, r=nalexander
l10n-merge creates a full merge dir for a while now, let's
simplify the build logic to only read from that directory
during repacks and langpacks.

Differential Revision: https://phabricator.services.mozilla.com/D77023
2020-05-27 17:04:06 +00:00
Cameron McCormack
4d86697e24 Bug 1641108 - Add perf-reftest-singleton for bug 1640545 changes. r=emilio,perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D76966
2020-05-27 12:01:53 +00:00
julianwels
2cb5d08b1f Bug 1625156 - Added tests for HTTPS Only Mode error page. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D75793
2020-05-26 11:45:34 +00:00
Kartikaya Gupta
cc4b5edc35 Bug 1638664 - Improve the way MozsearchIndexer merges analysis data. r=asuth
Instead of doing this:
a) read existing file into memory
b) append new entries
c) sort all entries
d) write unique entries back to file

We now do this:
a) sort new entries
b) loop through existing file entries, one at a time, writing them to a tmp file
c) insert the new entries in between the existing file entries in lexicographic order,
   and deduplicating the new entries
d) write any remaining new entries (that are lexicographically after the last
   entry in the pre-existing file), again deduplicating the entries
e) move tmp file back to original file location

This avoids reading the entire file into memory which could be potentially
hundreds of MB large.

The changes in FileOperations.* are needed to support these changes, as we now
have two files that we're dealing with - reading from one and writing to the
other. We still use a Mutex (Windows) or exclusive-flock (POSIX) on the file
for the duration of the entire operation, so we should still be robust in the
face of multiple concurrently running clang processes.

Differential Revision: https://phabricator.services.mozilla.com/D76202
2020-05-25 18:53:36 +00:00
Mike Hommey
dcc0980530 Bug 1636574 - Fixup for configure lint happiness.
Differential Revision: https://phabricator.services.mozilla.com/D76423
2020-05-22 01:24:09 +00:00
Mike Hommey
f2056ea3ec Bug 1636574 - Do not actually inject early options from mozconfig. r=rstewart
The configure sandbox has a list of arguments to handle, and removes
each of them when it resolves the corresponding options through e.g. a
`@depends`. When the configure sandbox is finished, what's supposed to
be left is unknown options.

The mozconfig injections adds elements to that list of arguments to
handle. The problem is that by the time the mozconfig injection happens,
some early options have already been handled by the sandbox and won't be
re-handled. Which means by the end of configure, the arguments are still
there, and the sandbox throws an error because it thinks they are for
unknown options.

Things were actually working before bug 1264527, essentially because we
had an explicit list of mozconfig variables that would be injected, and
that didn't include those early options.

So what we now do is to not actually inject those early options from
mozconfig.

Differential Revision: https://phabricator.services.mozilla.com/D76276
2020-05-21 15:28:13 +00:00
Mike Hommey
da55054404 Bug 1639569 - Define PYTHON3 in old-configure. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D76260
2020-05-21 15:28:25 +00:00
Cosmin Sabou
3a5c48b16c Bug 1639815 - Fix for win asan build bustages. r=glandium
CLOSED TREE
2020-05-22 03:23:16 +03:00
Mike Hommey
6ba1065508 Bug 1639815 - Move --enable-strip and --enable-install-strip to python configure. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D76291
2020-05-21 23:51:58 +00:00
Mike Hommey
711ffb4939 Bug 1639815 - Move --disable-icf to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76290
2020-05-21 22:38:47 +00:00
Mike Hommey
03b3bd5a35 Bug 1639815 - Move --enable-dtrace to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76289
2020-05-21 22:38:47 +00:00
Mike Hommey
114f6b0f27 Bug 1639815 - Move --enable-cpp-rtti to python configure. r=froydnj
This only moves the option, but still leaves it to the old-configure code to
add the appropriate flags to CXXFLAGS.

Differential Revision: https://phabricator.services.mozilla.com/D76288
2020-05-21 22:38:46 +00:00
Mike Hommey
79feb07ead Bug 1639815 - Move --enable-readline to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76287
2020-05-21 22:38:46 +00:00
Mike Hommey
0e16889c8a Bug 1639815 - Move --with-sixgill to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76286
2020-05-21 22:38:46 +00:00
Mike Hommey
af5718ca89 Bug 1639815 - Move --with-qemu-exe and --with-cross-lib to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76285
2020-05-21 22:38:46 +00:00
Bogdan Tara
0bff3c4d0b Backed out 7 changesets (bug 1639815) for --disable-install-strip related bustages CLOSED TREE
Backed out changeset 04a1388fc17d (bug 1639815)
Backed out changeset d48eea557b6d (bug 1639815)
Backed out changeset 6fba10f61bd2 (bug 1639815)
Backed out changeset cfb945f6c82f (bug 1639815)
Backed out changeset 16447c678749 (bug 1639815)
Backed out changeset 89475adf15b6 (bug 1639815)
Backed out changeset 94877a079054 (bug 1639815)
2020-05-22 01:33:22 +03:00
Mike Hommey
9725d351de Bug 1639815 - Move --enable-strip and --enable-install-strip to python configure. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D76291
2020-05-21 20:39:54 +00:00
Mike Hommey
1f62799146 Bug 1639815 - Move --disable-icf to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76290
2020-05-21 10:13:48 +00:00
Mike Hommey
1304fec22e Bug 1639815 - Move --enable-dtrace to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76289
2020-05-21 10:13:35 +00:00