Commit Graph

7 Commits

Author SHA1 Message Date
Jim Blandy
7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Neil Rashbrook
eaedd546e8 Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-26 00:11:16 +01:00
Ed Morley
f58ad725ea Backout ec9451e9e830 (bug 758354) for PGO linux permaorange in browser_bug422590.js and friends 2012-06-25 19:14:43 +01:00
Neil Rashbrook
aee62bb4bd Bug 758354 Stop unnecessarily preprocessing chrome r=dolske 2012-06-25 09:24:49 +01:00
Gervase Markham
82ff7027aa Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Felix Fung
bf48e869bf Bug 727901 - Fixed gImageView.data[row] is undefined when sorting. r=dao 2012-02-17 06:13:41 -05:00
Felix Fung
6b2098fe3a Bug 275223 - Enable Tree View Columns to be Sorted in Page Info. r=db48x 2012-01-26 16:10:00 -05:00