Commit Graph

697931 Commits

Author SHA1 Message Date
Tom Schuster
366a89593e Bug 1622562 - Remove flags from JSErrorReport. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D67143

--HG--
extra : moz-landing-system : lando
2020-03-23 07:08:48 +00:00
Tom Schuster
77e3057b6d Bug 1622562 - Remove flags parameter from ReportError functions r=tcampbell
Depends on D67140

Differential Revision: https://phabricator.services.mozilla.com/D67141

--HG--
extra : moz-landing-system : lando
2020-03-23 23:04:07 +00:00
Tom Schuster
4c087e6905 Bug 1622562 - Cleanup exnType initialization r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D67140

--HG--
extra : moz-landing-system : lando
2020-03-24 06:41:58 +00:00
Tom Schuster
505dd78fef Bug 1622562 - Move some fundamental error reporting functions to ErrorReporting.h r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D67138

--HG--
extra : moz-landing-system : lando
2020-03-20 19:02:31 +00:00
Gabriele Svelto
1974b2ed47 Bug 1622316 - Add buffering to the PlatformWriter to reduce the number of syscalls required to write the .extra file r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D67588

--HG--
extra : moz-landing-system : lando
2020-03-24 11:17:23 +00:00
Tooru Fujisawa
c8a4b4806e Bug 1624529 - Add null-check before Box::from_raw. r=nbp
Differential Revision: https://phabricator.services.mozilla.com/D68002

--HG--
extra : moz-landing-system : lando
2020-03-24 10:31:07 +00:00
Carolina
38ccd74df2 Bug 1585620 - Creates a standalone page (about:certificate) for the new certificate viewer.r=johannh,fluent-reviewers,flod
WIP - I want to have some insights before continue developing this patch

Differential Revision: https://phabricator.services.mozilla.com/D56413

--HG--
extra : moz-landing-system : lando
2020-03-24 08:57:42 +00:00
Andrea Marchesini
6040af7a0d Bug 1622306 - Group cookie console info/warning logs - tests, r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D67904

--HG--
extra : moz-landing-system : lando
2020-03-24 10:18:47 +00:00
Andrea Marchesini
4fa365563a Bug 1622306 - Group cookie console info/warning logs, r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D66890

--HG--
extra : moz-landing-system : lando
2020-03-24 09:41:07 +00:00
Sylvestre Ledru
ec872314a4 Bug 1624355 - coding style doc: Remove some leftover files r=sg
Moved to docs/code-quality/coding-style

Differential Revision: https://phabricator.services.mozilla.com/D67880

--HG--
extra : moz-landing-system : lando
2020-03-24 09:35:23 +00:00
Mihai Alexandru Michis
b6435f7773 Backed out 5 changesets (bug 1584007) for causing crashes in ClientManagerService.
CLOSED TREE

Backed out changeset e8e6a6bb50ff (bug 1584007)
Backed out changeset 9468d92f2a55 (bug 1584007)
Backed out changeset 19ed74a7ea6f (bug 1584007)
Backed out changeset 6c35d3d0f747 (bug 1584007)
Backed out changeset ea67977a5cdd (bug 1584007)
2020-03-24 11:29:22 +02:00
Frederic Wang
df18ec3853 Bug 1623623 - Enable dom.IntersectionObserverExplicitDocumentRoot by default r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67472

--HG--
extra : moz-landing-system : lando
2020-03-24 08:48:16 +00:00
Jan de Mooij
9ac848694a Bug 1618198 part 25 - Support FunCall/FunApply and spread calls. r=iain
This needs more work to make it fast, especially JSOp::OptimizeSpreadCall.

Differential Revision: https://phabricator.services.mozilla.com/D67835

--HG--
extra : moz-landing-system : lando
2020-03-23 18:58:20 +00:00
Jan de Mooij
997a680d00 Bug 1618198 part 24 - Implement JSOp::{Lambda,LambdaArrow,FunWithProto}. r=iain
This requires some changes to LambdaFunctionInfo:

* Don't use LambdaFunctionInfo for MFunctionWithProto as the JSFunction is just passed to a C++ call.
* Make the callers pass the values to the constructor so that WarpBuilder can construct LambdaFunctionInfo from the snapshot.
* Use better static types now that we have FunctionFlags and BaseScript.
* Move the assert in LambdaFunctionInfo's constructor to CodeGenerator::visitLambda.

It's not clear if LambdaFunctionInfo is still required now that the function's
BaseScript* pointer is a constant, but long-term we probably want to move to a
model like this for all template objects anyway.

Differential Revision: https://phabricator.services.mozilla.com/D67814

--HG--
extra : moz-landing-system : lando
2020-03-24 06:54:58 +00:00
Jan de Mooij
59e54831fd Bug 1618198 part 23 - Implement InitProp* and InitElem* ops. r=iain
This adds buildInitPropOp instead of reusing buildSetPropOp because there are
some subtle differences between Init and Set. Longer term we should consider
splitting the MIR and CacheIR code as well so it becomes easier to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D67804

--HG--
extra : moz-landing-system : lando
2020-03-24 07:04:44 +00:00
Jan Varga
5ce327d92a Bug 1619948 - Put LSNG behind the EARLY_BETA_OR_EARLIER flag; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D67892

--HG--
extra : moz-landing-system : lando
2020-03-24 03:58:10 +00:00
Tarek Ziadé
997e37880d Bug 1621275 - adding support for bookmarks r=tublitzed,pjenvey
Adds bookmarks to the full scenario (every 5 visited pages)

Differential Revision: https://phabricator.services.mozilla.com/D66929

--HG--
extra : moz-landing-system : lando
2020-03-24 08:23:50 +00:00
Csoregi Natalia
9e5e4b59da Backed out changeset 1e70c2d4173d (bug 1561362) for eslint failure on JsonToolbar.js. CLOSED TREE 2020-03-24 10:21:30 +02:00
aarushivij
48f369daff Bug 1408779 - link to report why page has been classified as malicious/deceptive/... should have variables %NAME% and %LOCALE% replaced r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D67769

--HG--
extra : moz-landing-system : lando
2020-03-23 07:17:14 +00:00
Zachary Svoboda
e84ecffbb6 Bug 1561362 - Implement slow label on JSON viewer expand all button r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D67766

--HG--
extra : moz-landing-system : lando
2020-03-24 07:54:36 +00:00
Nicolas Chevobbe
3d2bbd8d77 Bug 1623910 - Make toolbox selectThread more explicit. r=jlast.
This patch adds a few JSDoc comments, renames some variables,
and changes the structure of the stored thread (`actor` becomes
`actorID`), in order to make it more clear what we're dealing
with and avoid confusion.

Differential Revision: https://phabricator.services.mozilla.com/D67627

--HG--
extra : moz-landing-system : lando
2020-03-23 20:08:35 +00:00
Nicolas Chevobbe
09f8c97773 Bug 1624308 - Select top-level context if selected context is removed from the context list. r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D67865

--HG--
extra : moz-landing-system : lando
2020-03-23 20:34:52 +00:00
Julian Descottes
702320920f Bug 1395843 - Remove DevTools shared-head observable explicitly r=ochameau
Depends on D67845

Differential Revision: https://phabricator.services.mozilla.com/D67891

--HG--
extra : moz-landing-system : lando
2020-03-24 06:59:21 +00:00
Perry Jiang
373ae45772 Bug 1584007 - let ClientChannelHelperParent manage FutureClientSourceParent lifetime r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
ClientChannelHelperParent is the thing creating the ClientInfos which aren't
backed by existing ClientSources, so it may make sense for CCHP to tell the
ClientManagerService (CMS) to "expect" or "forget" a "future"
ClientSource(Parent).

When such a ClientInfo is created, CCHP notifies the CMS that a future
ClientSource may be created. This notification has to be observed before any
ClientHandles try to query CMS to a ClientSourceParent, which is the case
because the notification as well as ClientHandleParent constructors occur over
PBackground, and the notification sending method is called first.

CMS is told to forget the future ClientSource whenever a redirect occurs that
would result in the creation of a new ClientSource (i.e. a new ClientInfo). It's
also possible that the ClientInfo's LoadInfo's channel is cancelled. To account
for this, CHCP stores the most recent ClientInfo it's created and tells CMS
to _possibly_ forget the associated future ClientSource in its destructor. It's
possible that the channel completed its load, in which case this notification
is a no-op. This also relies on CHCP being destroyed after the reserved
ClientSource has a chance to both be created and register its
ClientSourceParent.

Differential Revision: https://phabricator.services.mozilla.com/D66529

--HG--
extra : moz-landing-system : lando
2020-03-24 02:34:20 +00:00
Perry Jiang
54f6dbaac3 Bug 1584007 - allow ClientManager to register "future" ClientSources r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D66520

--HG--
extra : moz-landing-system : lando
2020-03-24 02:34:12 +00:00
Perry Jiang
6b14fd7ea2 Bug 1584007 - let ClientHandleParents wait on FutureClientSourceParents r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
Differential Revision: https://phabricator.services.mozilla.com/D66154

--HG--
extra : moz-landing-system : lando
2020-03-24 02:34:10 +00:00
Perry Jiang
d1cc3d5d84 Bug 1584007 - let ClientManagerService store FutureClientSourceParent r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
The changes only make it possible for ClientManagerService to store
FutureClientSourceParents, but it will not actually store them until
following changesets.

Differential Revision: https://phabricator.services.mozilla.com/D66145

--HG--
extra : moz-landing-system : lando
2020-03-24 02:34:35 +00:00
Perry Jiang
b5b13cec75 Bug 1584007 - initial implementation of FutureClientSourceParent r=dom-workers-and-storage-reviewers,mattwoodrow,asuth
Also implements SourceTableEntry and nsIDHasher to switch ClientManagerService's
nsDataHashTable to a mozilla::HashMap<nsID, SourceTableEntry> in following
changesets.

Differential Revision: https://phabricator.services.mozilla.com/D66144

--HG--
extra : moz-landing-system : lando
2020-03-24 02:33:54 +00:00
Gerald Squelart
c80fa7258c Bug 1623228 - ProfileBufferChunk - r=canaltinova
A `ProfileBufferChunk` represents a single chunk of memory, with an optional
link to the next chunk.

In the new Fission-compatible profiler storage, chunks will be allocated by a
chunk manager, filled with data by the profiler, and then released back to the
chunk manager.
The chunk manager may decide to destroy or recycle old chunks based on memory
limits (per process, or for the entire Firefox app).

Differential Revision: https://phabricator.services.mozilla.com/D67272

--HG--
extra : moz-landing-system : lando
2020-03-24 01:04:33 +00:00
Chris Fronk
048799bff2 Bug 1490781 - Add FunctionRef, a non-owning reference to a callable value (function pointer, lambda, etc.). r=botond
Differential Revision: https://phabricator.services.mozilla.com/D62684

--HG--
extra : moz-landing-system : lando
2020-03-24 00:12:41 +00:00
Perry Jiang
3d1637251d Bug 1622924 - destroy CheckedUnsafePtr before pointee deletes itself r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D67427

--HG--
extra : moz-landing-system : lando
2020-03-23 14:51:59 +00:00
Kartikaya Gupta
d33180ab09 Bug 1622360 - Downgrade WRRootId to LayersId in some of APZCTreeManager. r=botond
Depends on D67868

Differential Revision: https://phabricator.services.mozilla.com/D67869

--HG--
extra : moz-landing-system : lando
2020-03-23 22:05:48 +00:00
Kartikaya Gupta
f5680c938b Bug 1622360 - Remove RenderRoot propagation in APZCTreeManager. r=botond
Depends on D67867

Differential Revision: https://phabricator.services.mozilla.com/D67868

--HG--
extra : moz-landing-system : lando
2020-03-24 00:18:20 +00:00
Kartikaya Gupta
f6825449bf Bug 1622360 - Remove rest of the RenderRootBoundary stuff. r=botond
Depends on D67866

Differential Revision: https://phabricator.services.mozilla.com/D67867

--HG--
extra : moz-landing-system : lando
2020-03-23 22:05:15 +00:00
Kartikaya Gupta
dd636055af Bug 1622360 - Remove WebRenderScrollDataCollection::AppendWrapper and the boundary root setters in WebRenderScrollData. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D67866

--HG--
extra : moz-landing-system : lando
2020-03-23 22:05:13 +00:00
caroline
d602c6ed74 Bug 1619011 - Reorder immutable flags into categories. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D65028

--HG--
extra : moz-landing-system : lando
2020-03-24 00:04:47 +00:00
Makoto Kato
dc6a8410d1 Bug 1618763 - Part 2. Use GtkInputPurpose and GtkInputHints by inputmode. r=masayuki
Let's use GtkInputPurpose and GtkInputHints by inputmode for software keyboard.

Differential Revision: https://phabricator.services.mozilla.com/D67771

--HG--
extra : moz-landing-system : lando
2020-03-23 10:36:53 +00:00
Makoto Kato
21e2657268 Bug 1618763 - Part 1. mHTMLInputInputmode should be lower case except to mozAwesomebar. r=masayuki
Since we cannot use HTMLInputElement.GetInputMode since we still support
mozAwesomebar, inputmode attribute isn't sanitized. Since I would like to reduce
comparing cost, it should be lower case except to mozAwesomebar.

Differential Revision: https://phabricator.services.mozilla.com/D67770

--HG--
extra : moz-landing-system : lando
2020-03-23 10:36:25 +00:00
jayati
801dd8219d Bug 1616324 - Add focus ring for sidebar drop down menu and close icon. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D67583

--HG--
extra : moz-landing-system : lando
2020-03-24 00:56:34 +00:00
Andrew Osmond
5bef59c8fd Bug 1622254 - Match repeating tile sizes more aggresively to their snapped bounds. r=kvark
When we calculate the repeating tile size, errors can be introduced,
such that there are cases it should be the same as the bounds, but is
slightly different. This can cause a new repetition where we did not
expect one. This patch makes the comparison when may force the tile size
to be the same as the snapped bounds more fuzzy.

Differential Revision: https://phabricator.services.mozilla.com/D67620

--HG--
extra : moz-landing-system : lando
2020-03-23 23:55:25 +00:00
Jeff Walden
361725476a Bug 1624473 - Use #include <type_traits> in Codegen.py instead of #include "mozilla/TypeTraits.h", as a step toward removing the latter now that it's no longer needed. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67951

--HG--
extra : moz-landing-system : lando
2020-03-23 23:05:55 +00:00
Razvan Maries
3c20c122d2 Backed out changeset ba7de7a93a71 (bug 1622474) for perma failures on browser_ext_themes_ntp_colors.js. CLOSED TREE 2020-03-24 01:23:08 +02:00
Botond Ballo
7c3a542e38 Bug 1623476 - Scroll element into view before simulating a click on it in test_bug500885.html. r=kats
The top-level document containing the iframe in which the test runs can be
scrolled by things that happen in previous tests (e.g. a zoomToFocusedInput
in a previous test), causing the target element to be outside of the visual
viewport.

After bug 1556556, event synthesization functions will no longer support
targeting elements outside the visual viewport.

Differential Revision: https://phabricator.services.mozilla.com/D67523

--HG--
extra : moz-landing-system : lando
2020-03-23 22:24:42 +00:00
Botond Ballo
7208849141 Bug 1623476 - Disable zoom-to-focused-input behaviour in clipboard tests. r=kats
The tests don't have a reliable mechanism to wait for a potential zoom
animation to end, leading to flakiness due to a zoom animation form a previous
sub-case interfering with the current sub-case.

Differential Revision: https://phabricator.services.mozilla.com/D67522

--HG--
extra : moz-landing-system : lando
2020-03-23 22:24:40 +00:00
Botond Ballo
3dfece9cbe Bug 1623476 - Use a roundish resolution in test_event_target_radius.html, to avoid rounding errors. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D67521

--HG--
extra : moz-landing-system : lando
2020-03-23 22:24:37 +00:00
Botond Ballo
3228bec83b Bug 1623476 - Adjust coordinate values in test_user_select.html. r=mstange
The coordinate values are chosen to target the first pixel of a target frame.
However, due to rounding error during the event synthesization code path,
they can miss the frame by a fraction of a pixel.

Differential Revision: https://phabricator.services.mozilla.com/D67520

--HG--
extra : moz-landing-system : lando
2020-03-23 22:22:52 +00:00
Botond Ballo
cb71f443fb Bug 1623476 - Use initial-scale=1 in clickToReload.html. r=snorp
This ensures that CSS coordinates (which is what the synthesizeTap test case
passes to GeckoSessionTestRule.synthesizeTap()) are equal to Screen coordinates
(which is what that function expects).

An alternative approach would be to query the resolution and convert from CSS
to Screen coordinates, either in the test case or inside synthesizeTap().

Differential Revision: https://phabricator.services.mozilla.com/D67519

--HG--
extra : moz-landing-system : lando
2020-03-23 22:22:19 +00:00
Botond Ballo
bdd33701db Bug 1623476 - Fix event targeting in a click_events_on_input.html. r=jgraham
Presumably, the intention of the test is to hit the middle of the target. To
this end, the test specifies an offset of half the target's dimensions
relative to the origin of the target.

However, when pointerMove() is given an element as origin, it already uses
the element's center as the origin point, so we end up actually targeting
the bottom right pixel which is prone to rounding issues.

Differential Revision: https://phabricator.services.mozilla.com/D67518

--HG--
extra : moz-landing-system : lando
2020-03-23 22:21:46 +00:00
Botond Ballo
c8a0ab983b Bug 1623476 - Minor style fixes to test_bug370436.html. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D67517

--HG--
extra : moz-landing-system : lando
2020-03-23 22:21:12 +00:00
Botond Ballo
c2743ac5d0 Bug 1623476 - Fix an incorrect assertion in PresShell about capturing content. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67516

--HG--
extra : moz-landing-system : lando
2020-03-23 22:20:44 +00:00