Commit Graph

9506 Commits

Author SHA1 Message Date
Blake Kaplan
e2d7482db4 Bug 917515 - Check for null before checking the document. r=ehsan 2013-09-26 18:42:53 +02:00
L. David Baron
d01753dad0 Bug 828312 patch 11: Don't generate change hints for restyling of later continuations, since the handling of the change hints from the first continuation is required to do the necessary work. r=bzbarsky
This depends on bug 898333 in order to avoid causing:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/chrome/test_focused_link_scroll.xul | Assertion count 1 is greater than expected range 0-0 assertions.
due to the assertion:
###!!! ASSERTION: Shouldn't be trying to restyle non-elements directly: '!aContent || aContent->IsElement()', file ../../../layout/base/nsStyleChangeList.cpp, line 62

The assertion count change in layout/generic/crashtests/571995.xhtml is
expected because it changes us from having 7 of:
###!!! ASSERTION: Shouldn't be trying to restyle non-elements directly: '!aContent || aContent->IsElement()', file ../../../layout/base/nsStyleChangeList.cpp, line 62
with the stack:
  mozilla::ElementRestyler::CaptureChange(nsStyleContext*, nsStyleContext*, nsChangeHint) [layout/base/nsChangeHint.h:191]
  mozilla::ElementRestyler::RestyleSelf(nsRestyleHint) [layout/base/RestyleManager.cpp:2304]
to only having one.  This is expected since this patch changes
RestyleSelf to only call CaptureChange for the first continuation or
block-in-inline sibling.
2013-09-25 12:28:08 -07:00
L. David Baron
d0255c650f Bug 828312 patch 9a: Make sticky positioning handle block-in-inline splits correctly. r=dholbert
This assumes that the specification for how position:sticky behaves for
block-in-inline splits matches the specification for position:relative,
in other words, matches
http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level .

It's also necessary for patch 9b since the new rule for handling of
style change hints is that a style change hint applies to all
continuations and all block-in-inline siblings ("special siblings").

The change in StickyScrollContainer::GetScrollRanges is really the fix
for bug 918994, but adjusted for the change here to use block-in-inline
siblings ("special siblings") in addition to continuations.
2013-09-25 12:28:08 -07:00
Daniel Holbert
ffdecec1a8 Bug 919813 part 2: Upgrade NS_ERROR to MOZ_ASSERT in nsFrame's impl of SetPrevInFlow, SetNextInFlow, SetPrevContinuation, SetNextContinuation. rs=mats 2013-09-25 10:54:56 -07:00
Daniel Holbert
aa859ecb8b Bug 919813 part 1: Remove never-checked return value from frame methods SetPrevInFlow, SetNextInFlow, SetPrevContinuation, SetNextContinuation. r=mats 2013-09-25 10:54:55 -07:00
Birunthan Mohanathas
64f8d6e459 Bug 919729 - Remove unnecessary MOZILLA_INTERNAL_API checks from nsIFrame.h. r=bz 2013-09-25 09:48:20 -04:00
Mats Palmgren
eb2304a29c Bug 919318 - A few cosmetic changes after dropping the Get prefix on some methods. r=dholbert 2013-09-25 11:42:35 +00:00
Mats Palmgren
4974add798 Bug 919318 - Drop the Get prefix on the frame methods GetFirstContinuation, GetLastContinuation, GetFirstInFlow, GetLastInFlow and also on nsLayoutUtils::GetLastContinuationWithChild, because they never return null. r=dholbert 2013-09-25 11:42:34 +00:00
Masayuki Nakano
f90a5b1125 Bug 912956 part.18 Remove nsGUIEvent.h r=roc 2013-09-25 20:21:22 +09:00
Masayuki Nakano
80d3ef9ea0 Bug 912956 part.17 mozilla/ContentEvents.h should be included directly r=roc 2013-09-25 20:21:20 +09:00
Masayuki Nakano
015140fe0d Bug 912956 part.15 mozilla/TextEvents.h should be included directly r=roc 2013-09-25 20:21:19 +09:00
Masayuki Nakano
4983de6d4c Bug 912956 part.14 mozilla/MouseEvents.h should be included directly r=roc 2013-09-25 20:21:18 +09:00
Daniel Holbert
90f7eae182 Bug 919871: Make .cpp files in layout/generic #include their corresponding .h file first. r=mats 2013-09-24 18:43:43 -07:00
Benoit Jacob
55d6cf1e20 Bug 913872 - Take nested enums out of gfxASurface - 1/3 : automatic changes - r=jrmuizel
Generated by these regexes:

find . -name '*.h' -o -name '*.cpp' -o -name '*.mm' | grep -v '\.hg' | grep -v '^\.\/obj' | xargs sed -i 's/gfx[A-Za-z0-9_]*Surface\:\:[a-z]*\(\(ImageFormat\|SurfaceType\|ContentType\|MemoryLocation\)[0-9A-Za-z_]*\)/gfx\1/g'

find . -name '*.h' -o -name '*.cpp' -o -name '*.mm' | grep -v '\.hg' | grep -v '^\.\/obj' | xargs sed -i 's/gfx[A-Za-z0-9_]*Surface\:\:[a-z]*\(\(CONTENT_\|MEMORY_\)[0-9A-Za-z_]*\)/GFX_\1/g'

find . -name '*.h' -o -name '*.cpp' -o -name '*.mm' | grep -v '\.hg' | grep -v '^\.\/obj' | xargs sed -i 's/\(^\|[^A-Za-z0-9_]\)\(CONTENT_COLOR\|CONTENT_ALPHA\|CONTENT_COLOR_ALPHA\|CONTENT_SENTINEL\|MEMORY_IN_PROCESS_HEAP\|MEMORY_IN_PROCESS_NONHEAP\|MEMORY_OUT_OF_PROCESS\)\($\|[^A-Za-z0-9_]\)/\1GFX_\2\3/g'

find . -name '*.h' -o -name '*.cpp' -o -name '*.mm' | grep -v '\.hg' | grep -v '^\.\/obj' | xargs sed -i 's/\(^\|[^A-Za-z0-9_]\)\(ImageFormatARGB32\|ImageFormatRGB24\|ImageFormatA8\|ImageFormatA1\|ImageFormatRGB16_565\|ImageFormatUnknown\|SurfaceTypeImage\|SurfaceTypePDF\|SurfaceTypePS\|SurfaceTypeXlib\|SurfaceTypeXcb\|SurfaceTypeGlitz\|SurfaceTypeQuartz\|SurfaceTypeWin32\|SurfaceTypeBeOS\|SurfaceTypeDirectFB\|SurfaceTypeSVG\|SurfaceTypeOS2\|SurfaceTypeWin32Printing\|SurfaceTypeQuartzImage\|SurfaceTypeScript\|SurfaceTypeQPainter\|SurfaceTypeRecording\|SurfaceTypeVG\|SurfaceTypeGL\|SurfaceTypeDRM\|SurfaceTypeTee\|SurfaceTypeXML\|SurfaceTypeSkia\|SurfaceTypeSubsurface\|SurfaceTypeD2D\|SurfaceTypeMax\)\($\|[^A-Za-z0-9_]\)/\1gfx\2\3/g'
2013-09-24 16:45:13 -04:00
Masayuki Nakano
c28e4cad25 Bug 912956 part.12 All event utils (macros and inline methods) should be methods of mozilla::WidgetEvent r=roc 2013-09-24 19:04:16 +09:00
Masayuki Nakano
0fbfe07d7e Bug 912956 part.2 Rename nsEvent.h to mozilla/EventForwards.h and sort out it r=roc
--HG--
rename : widget/nsEvent.h => widget/EventForwards.h
2013-09-24 19:04:14 +09:00
Daniel Holbert
f0029d8a39 (no bug) Replace two c-style casts in nsFrame.cpp with const_cast<>. (no review; trivial/non-functional) 2013-09-23 21:04:08 -07:00
Ehsan Akhgari
3c5faf2f1e Bug 919355 - Part 2: Don't #include nsDeviceContext.h in Units.h; r=roc 2013-09-23 07:55:35 -04:00
Daniel Holbert
68a29ddc8c Bug 918519 part 2: Replace GetMainComponent/GetCrossComponent invocations with macros to avoid unnecessarily constructing nsSize() on-the-fly. r=mats 2013-09-20 13:26:52 -07:00
Daniel Holbert
5cab3033a5 Bug 918519 part 1: Add macros GET_MAIN_COMPONENT and GET_FLEX_COMPONENT to nsFlexContainerFrame.cpp, and use them to implement existing utility methods. r=mats 2013-09-20 13:26:52 -07:00
Ehsan Akhgari
7e1838537c Bug 886781 follow-up: Disable the test properly, we can't return from the global scope
Landed on a CLOSED TREE
2013-09-19 11:49:04 -04:00
Ed Morley
5a8c8a92ae Bug 886781 - Disable test_movement_by_characters.html on Windows 8 for too many intermittent failures
--HG--
extra : rebase_source : 608a5680e1e7bcd9ab87b732b0366512abbc1529
2013-09-19 14:25:23 +01:00
Corey Ford
7597b90beb Bug 904197 - Use the union of continuations' rects in sticky positioning calculations. r=dholbert
Reftest inline-3.html fails because handling the sticky element's margin correctly will take more work; similarly, border/padding on containing-block continuations won't be handled quite right. Reftest column-contain-1a fails because some of the anonymous blocks inside an nsColumnSetFrame have 0 height.
2013-09-13 16:53:48 -07:00
Steven Michaud
54b03ac5a0 Bug 909678 - Send right-mouse-dragged and other-mouse-dragged events to plugins. r=spohl,roc 2013-09-17 18:36:03 -05:00
Corey Ford
e8889d55a9 Bug 915475 - Don't sticky position frames with NS_FRAME_IS_NONDISPLAY. r=dholbert 2013-09-17 14:11:12 -07:00
Daniel Holbert
ccc1948ea0 Bug 917032 part 3: Move flex item physicalPosn computation up a bit higher. r=mats 2013-09-17 14:54:07 -07:00
Daniel Holbert
158e1f5c90 Bug 917032 part 2: Make PhysicalPositionFromLogicalPosition() take the content-box size, so it can do polarity-flipping if necessary. r=mats 2013-09-17 14:54:02 -07:00
Daniel Holbert
9e48d8ee46 Bug 917032 part 1: Do flex layout in content-box space, rather than in frame-rect (border-box) space, and adjust for border/padding at the end of reflow. r=mats 2013-09-17 14:53:56 -07:00
Martijn Wargers
4d7138739f Bug 916086 - Remove some more enablePrivilege calls. r=jmaher
CLOSED TREE

--HG--
rename : layout/base/tests/test_bug458898.html => layout/base/tests/chrome/test_bug458898.html
2013-09-16 22:12:29 +02:00
Ehsan Akhgari
359464e128 Bug 917301 - Remove some dead code in layout/; r=dholbert 2013-09-17 13:02:02 -04:00
L. David Baron
f3bf848317 Bug 911786 part 3: Add an assertion to check that part 2 only changes things for position:sticky. r=dholbert
I'm worried that part 2 was the cause of bug 916751.  If it was, I think
this assertion should catch the problem.  Even if it's not, I think it's
a good assertion to have.
2013-09-17 04:44:16 -07:00
L. David Baron
6d628a60bd Bug 916751: Do not use nsIFrame::MovePositionBy from nsLineLayout. r=dholbert
Since bug 916751 is hard (for me) to test, I haven't confirmed for sure
that this fixes the bug.

However, it fixes the assertions that bug 911786 part 3 triggers in
layout/base/crashtests/317934-1.html through this codepath.
2013-09-17 04:44:16 -07:00
L. David Baron
7cbd1b75f2 Bug 917021: We should not store the NormalPositionProperty on all frames, only relatively positioned ones. r=dholbert
This also fixes nsHTMLReflowState::ApplyRelativePositioning to no-op for
svg:text, as it should (since nsIFrame::IsRelativelyPositioned() checks
more than nsStyleDisplay::IsRelativelyPositionedStyle()).
2013-09-17 04:44:16 -07:00
Cameron McCormack
633b59f1ac Bug 874507 - Make clip-path, filter, mask and opacity work on <marker> elements. r=longsonr 2013-09-16 15:06:29 +10:00
Rik Cabanier
fc566afdce Bug 902525 - Part 3: create a layer for content that stores the blend mode r=roc 2013-09-14 20:40:11 -07:00
Rik Cabanier
0383e51844 Bug 902525 - Part 2: Create layers for isolated groups when blending is involved r=roc 2013-09-14 20:30:00 -07:00
Ryan VanderMeulen
a3f1ea6990 Backed out 7 changesets (bug 902525) for B2G reftest failures.
Backed out changeset bbca63772c83 (bug 902525)
Backed out changeset edb386989dbd (bug 902525)
Backed out changeset 3137dadb4fcd (bug 902525)
Backed out changeset e562afcb3c89 (bug 902525)
Backed out changeset 8ef3a516bd68 (bug 902525)
Backed out changeset 520fcd422150 (bug 902525)
Backed out changeset 4e553e8da44e (bug 902525)
2013-09-15 18:59:27 -04:00
Phil Ringnalda
7455f4624c Bug 914919 followup followup, increase the assertion range for everyone 2013-09-15 13:34:08 -07:00
Rik Cabanier
c25a2667f4 Bug 902525 - part 3: Create a layer for content that stores the blend mode. r=roc 2013-09-15 16:24:16 -04:00
Rik Cabanier
80eedaeab4 Bug 902525 - Part 2: Create layers for isolated groups when blending is involved. r=roc 2013-09-15 16:24:06 -04:00
Timothy Nikkel
d747f1829c Bug 915526. Take into account display port and scroll port clamping in image visibility. r=roc f=kats 2013-09-15 13:51:35 -05:00
Phil Ringnalda
99cefd26cd Bug 914919 followup, increase the assertion range for Windows 2013-09-14 21:39:16 -07:00
Corey Ford
f17aaa5a04 Bug 914919 - Downgrade BaseRect::Set*Edge assertions to be non-fatal. r=dholbert 2013-09-11 16:27:14 -07:00
Timothy Nikkel
f538f22d78 Bug 847223. Part 10. Make the new code work when we have the image visibility analysis prefed off. r=mats 2013-09-14 19:05:06 -05:00
Timothy Nikkel
84c603d990 Bug 847223. Part 6. Use the first reflow of relevant image frames to add/remove them from the visible list. r=mats 2013-09-14 19:05:05 -05:00
Timothy Nikkel
37170c5e70 Bug 847223. Part 4. Tweak the ExpandRect function to not expand in a direction that we cannot scroll. r=mats 2013-09-14 19:05:04 -05:00
Timothy Nikkel
b7e5e88bcc Bug 847223. Part 3. Factor out the expand the scrollport code so we can use it on individual images later. r=mats 2013-09-14 19:05:04 -05:00
Masayuki Nakano
776acd167e Bug 912956 part.1 Rename all event stuff in mozilla::widget to mozilla::* r=roc 2013-09-14 11:39:41 +09:00
Ryan VanderMeulen
17009bfe41 Backed out 6 changesets (bug 914826) for bustage.
Backed out changeset a4a029c13179 (bug 914826)
Backed out changeset d16460fc0518 (bug 914826)
Backed out changeset b28cb0ae1853 (bug 914826)
Backed out changeset 5b4ce1d4d09b (bug 914826)
Backed out changeset 58d96448609a (bug 914826)
Backed out changeset 52b319afe965 (bug 914826)
2013-09-13 16:32:42 -04:00
Nathan Froyd
9a8580e6d3 Bug 914826 - part 4 - fix source files that were bootlegging XPCOM do_* functions via generated ipdl headers; r=ehsan 2013-09-10 16:56:05 -04:00