Commit Graph

12435 Commits

Author SHA1 Message Date
Csoregi Natalia
28fe656de6 Merge inbound to mozilla-central. a=merge 2018-10-12 13:14:37 +03:00
Patrick Brosset
5deff44e6f Bug 1497521 - Force the new flexbox inspector ON before running its tests; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D8089

--HG--
extra : moz-landing-system : lando
2018-10-12 05:04:39 +00:00
Narcis Beleuzu
e09f2e2622 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-10-12 06:53:11 +03:00
Michael Ratcliffe
d2d39186f6 Bug 1478481 - Flexbox highlighter overlay is wrong size, in page with full-page-zoom applied r=gl
- Added AutoRefreshHighlighter flag to AutoRefreshHighlighter. This ensures that getQuads() ignores the zoom factor.

Differential Revision: https://phabricator.services.mozilla.com/D7599

--HG--
extra : moz-landing-system : lando
2018-10-10 23:59:45 +00:00
Narcis Beleuzu
c31a01ef52 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-12 00:57:21 +03:00
Narcis Beleuzu
d30168f45c Merge inbound to mozilla-central. a=merge 2018-10-12 00:48:03 +03:00
Brindusan Cristian
e1f4f3ac73 Backed out changeset 0ff0cb536428 (bug 1497969) for devtools failures on browser_rules_add-rule-pseudo-class.js. CLOSED TREE 2018-10-12 00:00:47 +03:00
Gabriel Luong
48144773f9 Bug 1497187 - Hide the flexbox container properties in the flex item accordion. r=pbro 2018-10-11 12:05:08 -04:00
Gabriel Luong
65571e884a Bug 1495775 - Flex items should be highlighted when hovered over in the flex item list. r=pbro 2018-10-11 12:00:37 -04:00
Gabriel Luong
5b7da2a429 Bug 1497210 - Ensure a valid flex item prop is provided to the FlexItemSelector. r=pbro 2018-10-11 11:59:08 -04:00
Patrick Brosset
ff2ee04ec2 Bug 1490101 - Avoid overflowing the layout tab when flex elements are long; r=rcaliman
Fixes the 3 places where long element Reps can appear:
- as a accordion header as "flex item of div..."
- as a flex item in the list of items for a container
- as a flex container
To fix this, I added text-overflow:ellipsis in a few places and made sure the Rep
was not pushing other things too far behind the viewport.
I also made the layout sidebar overflow-x:hidden, because it doesn't need to
scroll sideways (if the sidebar is too thin, then the box-model diagram might
overflow, but it has its own horizontal scrollbar).

Finally, I removed the inspector select icon next to the Flex Container Rep
because usually the element is already selected anyway. If it's not, then you
can use the back arrow to go back to the container.

Differential Revision: https://phabricator.services.mozilla.com/D8364

--HG--
extra : moz-landing-system : lando
2018-10-11 15:31:53 +00:00
Martin Stransky
d6abc8d98d Bug 1496349 - Add background to connection info box, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D8209

--HG--
extra : moz-landing-system : lando
2018-10-11 12:28:42 +00:00
yulia
7b4018cba7 Bug 1488375 - make lazyLoadFront errors more specific; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D8197

--HG--
extra : moz-landing-system : lando
2018-10-10 15:39:32 +00:00
yulia
55c6df01ea Bug 1488377 - remove outdated backwards compat code; r=ochameau
Depends on D7886

Differential Revision: https://phabricator.services.mozilla.com/D7994

--HG--
extra : moz-landing-system : lando
2018-10-10 15:37:11 +00:00
Noemi Erli
4e75dfc2f6 Backed out changeset 06f4b6597f74 (bug 1497969) for failures in devtools/client/inspector/rules/test/browser_rules_pseudo_lock_options.js 2018-10-11 15:18:45 +03:00
Tim Nguyen
a59e428226 Bug 1497969 - Add a way to emulate :focus-within pseudo-class. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D8275

--HG--
extra : moz-landing-system : lando
2018-10-11 09:23:09 +00:00
Belén Albeza
3e5e927ab1 Bug 1498182 - Fix network locations form React warning. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D8375

--HG--
extra : moz-landing-system : lando
2018-10-11 12:55:07 +00:00
Tim Nguyen
c74ececee9 Bug 1497969 - Add a way to emulate :focus-within pseudo-class. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D8275

--HG--
extra : moz-landing-system : lando
2018-10-11 18:51:01 +00:00
Brindusan Cristian
c328bc1cdf Backed out 8 changesets (bug 1485660) for damp failures on front.hasRequests. CLOSED TREE
Backed out changeset 7a2f29bbe2a8 (bug 1485660)
Backed out changeset 26e82fa62444 (bug 1485660)
Backed out changeset 9bb2f56f219d (bug 1485660)
Backed out changeset 40a3c2dd1b38 (bug 1485660)
Backed out changeset cfb160882db9 (bug 1485660)
Backed out changeset 3642f2d66777 (bug 1485660)
Backed out changeset 9026679753b2 (bug 1485660)
Backed out changeset dccca441b980 (bug 1485660)
2018-10-11 22:33:35 +03:00
Alexandre Poirot
8a6814c2df Bug 1497644 - Ensure that RootClient is used for all requests made to the root actor. r=yulia
MozReview-Commit-ID: HJm7yQCMbkg

Depends on D8141

Differential Revision: https://phabricator.services.mozilla.com/D8142

--HG--
extra : moz-landing-system : lando
2018-10-11 16:25:23 +00:00
Alexandre Poirot
cf0d0480eb Bug 1497644 - Always call Root actor's getProcess request via RootClient.getProcess r=yulia
I also made its argument mandatory, so that later in root spec we can use a non-nullable number.

MozReview-Commit-ID: BUPgI1ww1gC

Differential Revision: https://phabricator.services.mozilla.com/D8141

--HG--
extra : moz-landing-system : lando
2018-10-11 16:26:45 +00:00
Alexandre Poirot
813f924c73 Bug 1485660 - Remove gcli leftover. r=jdescottes
MozReview-Commit-ID: FMuFBTseBIx

Depends on D7461

Differential Revision: https://phabricator.services.mozilla.com/D7462

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:37 +00:00
Alexandre Poirot
5df601ee2f Bug 1485660 - Convert browser_db_listtabs-03.js to async and make it use TargetFront. r=jdescottes
MozReview-Commit-ID: KLqx50gwSXS

Depends on D7460

Differential Revision: https://phabricator.services.mozilla.com/D7461

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:35 +00:00
Alexandre Poirot
99a923c818 Bug 1485660 - Special test fixes. r=jdescottes
* browser_addons_debug_webextension_popup: It looks like frame-update events are now fired earlier.
I had to move the listener to an earlier step in order to make it work.
* helper_disable_cache + toolbox.js: this test wasn't correctly listening for reconfigure request's end.
  Not clear how this test was passing before without high rate of intermittent...
* test_webextension-addon-debugging-connect.html: We can no longer listen for frame-update *before* the target object is created.
  (because we now need a TabTarget object or the TargetFront and not just the DebuggerClient)

MozReview-Commit-ID: 49qvWSCn6nq

Depends on D8066

Differential Revision: https://phabricator.services.mozilla.com/D7460

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:32 +00:00
Alexandre Poirot
289ee36566 Bug 1485660 - Adapt TabClient API to protocol one. r=jdescottes
MozReview-Commit-ID: 1dC5opkgLcQ

Depends on D7459

Differential Revision: https://phabricator.services.mozilla.com/D8066

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:30 +00:00
Alexandre Poirot
8c5e401017 Bug 1485660 - Switch from listening from DebuggerClient to TargetFront. r=jdescottes
* debugger-controller and events.js are special and require to support two cases because this is
the only production codepath that can have a TabTarget or a WorkerTarget.
Thus, leading to either TargetFront or WorkerClient on target.activeTab.
* webide.js doesn't need to listen for tabNavigated, this is redundant with tabListChanged.
* application's initializer. In case you are wondering this code can't be spawn against a WorkerTarget.
The application panel doesn't work in worker toolboxes.
* The code modified in target is in TabTarget, so we don't have to support the WorkerClient case, we always have a TargetFront here.
* I tried to update the doc file the best I can but this all feel outdated.

MozReview-Commit-ID: 2hGchebfIub

Depends on D7458

Differential Revision: https://phabricator.services.mozilla.com/D7459

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:28 +00:00
Alexandre Poirot
4790bc0138 Bug 1485660 - Convert TabClient to a front. r=jdescottes
TabClient appears to be a client for any actor that inherits from browsing context target actor.
So let it be a front for that.

MozReview-Commit-ID: KmpClxJ53N7

Depends on D7457

Differential Revision: https://phabricator.services.mozilla.com/D7458

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:26 +00:00
Alexandre Poirot
e98e7b66be Bug 1485660 - Avoid exceptions when the connection is closed in middle of the actor's id retrieval. r=jdescottes
MozReview-Commit-ID: KvwkISz7OVe

Depends on D7456

Differential Revision: https://phabricator.services.mozilla.com/D7457

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:24 +00:00
Alexandre Poirot
d99221792f Bug 1485660 - Allows calling DebuggerClient.close twice in a row. r=jdescottes
MozReview-Commit-ID: uACM0VtJ5E

Differential Revision: https://phabricator.services.mozilla.com/D7456

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:22 +00:00
Yura Zenevich
b0746404ef Bug 1492866 - add accessible relations to accessibility panel sidebar. r=pbro
MozReview-Commit-ID: 5u8SRnlnFyN

Differential Revision: https://phabricator.services.mozilla.com/D7208

--HG--
extra : moz-landing-system : lando
2018-10-11 14:51:35 +00:00
Tiberius Oros
f9b1b2831d Merge inbound to mozilla-central. a=merge 2018-10-11 00:57:47 +03:00
David Walsh
e31a432ca5 Bug 1314057 - Move worker actor and console tests to shared. r=loganfsmyth
--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_WorkerTargetActor.attach.js => devtools/client/shared/test/browser_dbg_WorkerTargetActor.attach.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_worker-console-01.js => devtools/client/shared/test/browser_dbg_worker-console-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_worker-console-02.js => devtools/client/shared/test/browser_dbg_worker-console-02.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_worker-console-03.js => devtools/client/shared/test/browser_dbg_worker-console-03.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_worker-console-04.js => devtools/client/shared/test/browser_dbg_worker-console-04.js
rename : devtools/client/debugger/test/mochitest/code_WorkerTargetActor.attach-worker1.js => devtools/client/shared/test/code_WorkerTargetActor.attach-worker1.js
rename : devtools/client/debugger/test/mochitest/code_WorkerTargetActor.attach-worker2.js => devtools/client/shared/test/code_WorkerTargetActor.attach-worker2.js
rename : devtools/client/debugger/test/mochitest/code_WorkerTargetActor.attachThread-worker.js => devtools/client/shared/test/code_WorkerTargetActor.attachThread-worker.js
rename : devtools/client/debugger/test/mochitest/code_frame-script.js => devtools/client/shared/test/code_frame-script.js
rename : devtools/client/debugger/test/mochitest/doc_WorkerTargetActor.attach-tab1.html => devtools/client/shared/test/doc_WorkerTargetActor.attach-tab1.html
rename : devtools/client/debugger/test/mochitest/doc_WorkerTargetActor.attach-tab2.html => devtools/client/shared/test/doc_WorkerTargetActor.attach-tab2.html
rename : devtools/client/debugger/test/mochitest/doc_WorkerTargetActor.attachThread-tab.html => devtools/client/shared/test/doc_WorkerTargetActor.attachThread-tab.html
2018-10-08 20:23:46 -05:00
David Walsh
ad8f91e70d Bug 1314057 - Move old debugger's multiple-windows, tab and target actors tests. r=loganfsmyth
--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_multiple-windows.js => devtools/client/shared/test/browser_dbg_multiple-windows.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_navigation.js => devtools/client/shared/test/browser_dbg_navigation.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js => devtools/client/shared/test/browser_dbg_target-scoped-actor-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js => devtools/client/shared/test/browser_dbg_target-scoped-actor-02.js
rename : devtools/client/debugger/test/mochitest/doc_script-switching-01.html => devtools/client/shared/test/doc_script-switching-01.html
rename : devtools/client/debugger/test/mochitest/doc_script-switching-02.html => devtools/client/shared/test/doc_script-switching-02.html
2018-10-08 13:21:41 -05:00
David Walsh
33a0d24ede Bug 1314057 - Remove duplicated test between old and new debugger. r=loganfsmyth 2018-10-08 13:04:50 -05:00
David Walsh
694b266a85 Bug 1314057 - Move listtabs and listaddons tests to shared. r=loganfsmyth
--HG--
rename : devtools/client/debugger/test/mochitest/addon1.xpi => devtools/client/shared/test/addon1.xpi
rename : devtools/client/debugger/test/mochitest/addon2.xpi => devtools/client/shared/test/addon2.xpi
rename : devtools/client/debugger/test/mochitest/browser_dbg_listaddons.js => devtools/client/shared/test/browser_dbg_listaddons.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_listtabs-01.js => devtools/client/shared/test/browser_dbg_listtabs-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_listtabs-02.js => devtools/client/shared/test/browser_dbg_listtabs-02.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_listtabs-03.js => devtools/client/shared/test/browser_dbg_listtabs-03.js
rename : devtools/client/debugger/test/mochitest/doc_empty-tab-01.html => devtools/client/shared/test/doc_empty-tab-01.html
rename : devtools/client/debugger/test/mochitest/doc_empty-tab-02.html => devtools/client/shared/test/doc_empty-tab-02.html
2018-10-08 13:02:13 -05:00
David Walsh
41cf7a9677 Bug 1314057 - Move globalactor and global method override tests. r=loganfsmyth
--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_global-method-override.js => devtools/client/debugger/new/test/mochitest/browser_dbg_global-method-override.js
rename : devtools/client/debugger/test/mochitest/doc_global-method-override.html => devtools/client/debugger/new/test/mochitest/examples/doc_global-method-override.html
rename : devtools/client/debugger/test/mochitest/browser_dbg_globalactor.js => devtools/client/shared/test/browser_dbg_globalactor.js
rename : devtools/client/debugger/test/mochitest/testactors.js => devtools/client/shared/test/testactors.js
2018-10-08 12:08:05 -05:00
Ryan VanderMeulen
def6058f00 Merge m-c to inbound. a=merge 2018-10-10 12:31:21 -04:00
Ryan VanderMeulen
ea3d29a96f Merge inbound to m-c. a=merge 2018-10-10 12:30:22 -04:00
Gabriel Luong
08752585fb Bug 1496990 - Move the onSidebarSelect event handler before adding the sidebar tabs. r=pbro 2018-10-10 11:40:30 -04:00
Coroiu Cristina
9a32880ddc Backed out 5 changesets (bug 1493104) for ESlint failure at builds/worker/checkouts/gecko/devtools/client/webide/content/addons.js on a CLOSED TREE
Backed out changeset a6cbba097c8a (bug 1493104)
Backed out changeset 8df2a288391c (bug 1493104)
Backed out changeset cb9f55dd4257 (bug 1493104)
Backed out changeset f7ecf841eb8f (bug 1493104)
Backed out changeset fa20c2c68c42 (bug 1493104)
2018-10-10 14:49:13 +03:00
Julian Descottes
2b20cddf86 Bug 1493104 - Add unit test for AddonAwareADBScanner;r=ladybenko,daisuke
Depends on D7876

Differential Revision: https://phabricator.services.mozilla.com/D7877

--HG--
extra : moz-landing-system : lando
2018-10-10 11:32:11 +00:00
Julian Descottes
057087015c Bug 1493104 - Add ADBScanner decorator to listen to addon status udpates;r=ladybenko,daisuke
Depends on D7875
I would like to make the adb addon dependency transparent to the scanner consumers

Differential Revision: https://phabricator.services.mozilla.com/D7876

--HG--
extra : moz-landing-system : lando
2018-10-10 11:31:25 +00:00
Julian Descottes
bf7acbf719 Bug 1493104 - Add adbScanner to WebIDE scanners if status is already installed;r=ladybenko,daisuke
Depends on D7873.
This fixes the following scenario:
- install ADB
- connect a Device
- start about:debugging
=> device shows up in sidebar
- start WebIDE
=> device should show up in WebIDE

Differential Revision: https://phabricator.services.mozilla.com/D7875

--HG--
extra : moz-landing-system : lando
2018-10-10 11:29:58 +00:00
Julian Descottes
cc74868ab0 Bug 1493104 - Listen to ADB extension updates in about:debugging usb-runtime helper;r=ladybenko,daisuke
Depends on D7872. This fixes the bug where about:debugging thinks the addon
is uninstalled the first time it starts.

Differential Revision: https://phabricator.services.mozilla.com/D7873

--HG--
extra : moz-landing-system : lando
2018-10-10 11:30:36 +00:00
Julian Descottes
605247446e Bug 1493104 - Convert ADBScanner from a singleton to a class;r=ladybenko,daisuke
This allows to cleanly disable the scanner when you have several users.
Without this if you start both WebIDE and about:debugging, the first listeners
set in enable() can never be removed.

Differential Revision: https://phabricator.services.mozilla.com/D7872

--HG--
extra : moz-landing-system : lando
2018-10-10 11:08:28 +00:00
Tom Glowka
00d2bc66d4 Bug 1490092 - Clean opened tabs after Open request in tab test; r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D5511

--HG--
extra : moz-landing-system : lando
2018-10-10 10:18:07 +00:00
Vincent Lequertier
f71621d402 Bug 1451494 - Simplify edition of the "method" field in netmonitor edit and resend panel; r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D6981

--HG--
extra : moz-landing-system : lando
2018-10-10 10:08:38 +00:00
tanhengyeow
fd2da88b97 Bug 1437435 - Added isBase64, isEmpty method, cleaned up typos and format of comments. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D6148

--HG--
extra : moz-landing-system : lando
2018-10-09 15:56:18 +00:00
Dorel Luca
c5bc5672ed Backed out 4 changesets (bug 1314057) for devtool failures. a=backout
Backed out changeset f46426835026 (bug 1314057)
Backed out changeset 90480b4b4c43 (bug 1314057)
Backed out changeset fa0d46e77437 (bug 1314057)
Backed out changeset 241f876d557f (bug 1314057)

--HG--
rename : devtools/client/shared/test/addon1.xpi => devtools/client/debugger/test/mochitest/addon1.xpi
rename : devtools/client/shared/test/addon2.xpi => devtools/client/debugger/test/mochitest/addon2.xpi
rename : devtools/client/debugger/new/test/mochitest/browser_dbg_global-method-override.js => devtools/client/debugger/test/mochitest/browser_dbg_global-method-override.js
rename : devtools/client/shared/test/browser_dbg_globalactor.js => devtools/client/debugger/test/mochitest/browser_dbg_globalactor.js
rename : devtools/client/shared/test/browser_dbg_listaddons.js => devtools/client/debugger/test/mochitest/browser_dbg_listaddons.js
rename : devtools/client/shared/test/browser_dbg_listtabs-01.js => devtools/client/debugger/test/mochitest/browser_dbg_listtabs-01.js
rename : devtools/client/shared/test/browser_dbg_listtabs-02.js => devtools/client/debugger/test/mochitest/browser_dbg_listtabs-02.js
rename : devtools/client/shared/test/browser_dbg_listtabs-03.js => devtools/client/debugger/test/mochitest/browser_dbg_listtabs-03.js
rename : devtools/client/shared/test/browser_dbg_multiple-windows.js => devtools/client/debugger/test/mochitest/browser_dbg_multiple-windows.js
rename : devtools/client/shared/test/browser_dbg_navigation.js => devtools/client/debugger/test/mochitest/browser_dbg_navigation.js
rename : devtools/client/shared/test/browser_dbg_target-scoped-actor-01.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js
rename : devtools/client/shared/test/browser_dbg_target-scoped-actor-02.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js
rename : devtools/client/debugger/new/test/mochitest/examples/doc_global-method-override.html => devtools/client/debugger/test/mochitest/doc_global-method-override.html
2018-10-10 09:16:11 +03:00
Gurzau Raul
fa37566219 Merge inbound to mozilla-central. a=merge 2018-10-10 07:35:14 +03:00