DONTBUILD because it only changes comments.
This will hopefully prevent confusion like that in bug 1215903.
--HG--
extra : rebase_source : f0a601d77b5f42b4fbe090693234f934e3becc42
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
Like the last patch, the motivation is to remove a GetVersionEx() call which
triggers deprecation warnings.
Because Windows XP SP2 is the earliest Windows version we support, two of the
existing uses of GetWinVersion() could be removed, because they were checking
for XP or earlier. One other Vista check could be replaced with
mozilla::IsVistaOrLater().
--HG--
extra : rebase_source : 48f032fe92c3897a91866c7ff786a635479c0389
The motivation here is to remove the GetVersionEx() calls in the
Windows-specific code, because that function is deprecated and causes warnings.
The non-Windows versions come along for the ride.
--HG--
extra : rebase_source : ea50b4ce8271ea7281b901eac0542ab4a154adc6
The warning is "the address of NuwaMarkCurrentThread() will always evaluate to
'true'".
--HG--
extra : rebase_source : c66bd111a3a57b08095dbbbe043806cc2caf8c13
Two parts.
- Most of the common stuff goes into the new libeventcommon.mozbuild file.
- A little bit of common bsd/linux stuff factored out in
ipc/chromium/moz.build.
--HG--
extra : rebase_source : a4bb56a444ad5b0d5d808e5d58dd7abe7dd81dbe
I originally tried putting it in ipc/chromium/src/third_party/libevent/, but
that directory already has a Makefile.in file, which caused problems, so I
moved it down one directory.
--HG--
extra : rebase_source : 63024d67c7b0f9215474cc85b475a4740ce51dc0
The patch also adds the CHECK_EVENT_SIZEOF macro which checks that the
_EVENT_SIZEOF_* constants have the right values.
--HG--
extra : rebase_source : 36a41bb25adcef55814aa51a280cad91062d2147
Add a missing one to the docs, and move them from their current two locations
into a new patches/ directory.
--HG--
rename : ipc/chromium/src/third_party/libevent-avoid-empty-sighandler.patch => ipc/chromium/src/third_party/libevent/patches/avoid-empty-sighandler.patch
rename : ipc/chromium/src/third_party/libevent-dont-use-issetugid-on-android.patch => ipc/chromium/src/third_party/libevent/patches/dont-use-issetugid-on-android.patch
rename : ipc/chromium/src/third_party/libevent/mac-arc4random-buf.patch => ipc/chromium/src/third_party/libevent/patches/mac-arc4random-buf.patch
rename : ipc/chromium/src/third_party/libevent/openbsd-no-arc4random_addrandom.patch => ipc/chromium/src/third_party/libevent/patches/openbsd-no-arc4random_addrandom.patch
rename : ipc/chromium/src/third_party/libevent-use-non-deprecated-syscalls.patch => ipc/chromium/src/third_party/libevent/patches/use-non-deprecated-syscalls.patch
extra : rebase_source : 2b434e627b6fcbf699ab50c51356a986391dcd1c
We get the following warnings with clang.
> ipc/chromium/src/base/time_posix.cc:103:57: error: overflow in expression; result is 0 with type 'long' [-Werror,-Winteger-overflow]
> ipc/chromium/src/base/time_posix.cc:106:58: error: overflow in expression; result is -1000 with type 'long' [-Werror,-Winteger-overflow]
This is a genuine bug. The upstream code in Chromium has changed (commit
2a278516943eee02e0206506a4b907fc0b55f27b) and this patch changes our code to be
similar. I did tests and confirmed that instead of getting 0 or -1 for
|milliseconds|, we now get -2147483648000 or 2147483647999, which is much
better.
--HG--
extra : rebase_source : f01a4f03bc1576980010426328116d03eb71079b
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
Make it harder for users to accidentally reintroduce usage of the PR_LOG macros
when using 'mozilla/Logging.h'. This can still be worked around by directly
including 'prlog.h' (and not 'mozilla/Logging.h') if absolutely necessary.
Make it harder for users to accidentally reintroduce usage of the PR_LOG macros
when using 'mozilla/Logging.h'. This can still be worked around by directly
including 'prlog.h' (and not 'mozilla/Logging.h') if absolutely necessary.
Make it harder for users to accidentally reintroduce usage of the PR_LOG macros
when using 'mozilla/Logging.h'. This can still be worked around by directly
including 'prlog.h' (and not 'mozilla/Logging.h') if absolutely necessary.
