Commit Graph

11486 Commits

Author SHA1 Message Date
Mats Palmgren
e818007e69 Bug 1461039 - Inlinify display:list-item to display:inline for now, until we support 'display:inline list-item' properly. r=xidorn 2018-05-17 17:30:35 +02:00
Xidorn Quan
9ab2784516 Bug 1461858 followup - Use RefPtr::new instead of RefPtr::from_ptr_ref + clone.
--HG--
extra : source : 4a743827a83a7130ea8de9916cf3f83448596ffb
2018-05-16 22:21:57 +10:00
Xidorn Quan
f42f8f59ab Bug 1461858 part 4 - Rename from_url_value_data to from_url_value and reuse URLValue passed in for ComputedUrl. r=emilio
MozReview-Commit-ID: LJGm3lUS9mD

--HG--
extra : rebase_source : 02bcbfd349b54ab7d72bbfcda69b5664549ca37b
2018-05-16 14:35:37 +10:00
Xidorn Quan
07df897bae Bug 1461858 part 3 - Have from_image_request reuse ImageValue from image request directly. r=emilio
And also remove ComputedImageUrl::from_url_value_data.

MozReview-Commit-ID: 5zifQlU7tOz

--HG--
extra : rebase_source : 23631ad2e9144cf30951a3d07421a8e5ae0ba8ec
2018-05-16 14:01:25 +10:00
Xidorn Quan
9886a02dbd Bug 1461858 part 2 - Make from_image_request infallible. r=emilio
All callsites already assert, so moving the assertion into the method
should be fine. It is not expected to handle a null image value anyway.

MozReview-Commit-ID: J8CA8m22eSv

--HG--
extra : rebase_source : e4d524263363393d3d0388ede8efcae096917546
2018-05-16 13:39:58 +10:00
Xidorn Quan
28bb73ac18 Bug 1461858 part 1 - Make creating CssUrl infallible. r=emilio
There were a check in CssUrl::parse_from_string for extra data, which
was removed as part of servo/servo#16241, so it never fails now.

CssUrl::from_url_value_data doesn't seem to need Result from the very
beginning. It is unclear why it was made that way.

MozReview-Commit-ID: LXzKlZ6wPYW

--HG--
extra : rebase_source : baa4eb68b7c6b0042bd01108d3e6631c3cdf01a8
2018-05-16 12:19:31 +10:00
Emilio Cobos Álvarez
5bfb2e13b8 No bug - Fix Servo build. r=me
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>

MozReview-Commit-ID: DpRWVlcU0ki
2018-05-15 12:09:26 +02:00
Emilio Cobos Álvarez
07c301c809 No bug - Make servo-tidy happy. r=me
MozReview-Commit-ID: HDlgkGdvdBg
2018-05-15 12:09:25 +02:00
Emilio Cobos Álvarez
add7370903 Bug 1442195: Don't crash when finding an unexpected default font type. r=xidorn
For now just return sans-serif, though as the FIXME comment indicates we should
probably just carry around the font-name instead.

MozReview-Commit-ID: CIPbV3R5Ul

--HG--
extra : rebase_source : ce8666e747341d203d655e937501806c1646331b
2018-05-14 15:19:34 +02:00
Emilio Cobos Álvarez
a6a7ba02de Bug 1461288: Distinguish between specified and computed URLs. r=xidorn
This is needed to serialize computed URLs correctly from getComputedStyle.

MozReview-Commit-ID: 9wakhqNrszb

--HG--
extra : rebase_source : 7d120ac0917a5e13de4e52b7dfa0d784495fd8f7
2018-05-14 12:29:40 +02:00
Emilio Cobos Álvarez
4ac7b84022 Bug 1461296: Ensure all lonhands have a working clone(), and to_css. r=xidorn
This removes some dubious font-family code too.

It ensures that vector longhands have a proper clone implementation
auto-generating it using `collect()`.

MozReview-Commit-ID: FkdnbTkeF6E

--HG--
extra : rebase_source : 8574eda5b65be614fc2daea8b2ded4c09f0a186e
2018-05-14 12:40:31 +02:00
Emilio Cobos Álvarez
f78be9e725 Bug 1460655: Support x as a resolution unit. r=xidorn
MozReview-Commit-ID: TjU0FLCLMN

--HG--
extra : rebase_source : 63da5bdd570587f82b370e8819d9e0fc7220e9c2
2018-05-10 18:11:52 +02:00
Emilio Cobos Álvarez
3cb1708084 Bug 1460655: Make resolutions more like the rest of the CSS values. r=xidorn
MozReview-Commit-ID: 3Gt8VX1KhjC

--HG--
extra : rebase_source : 10521fb5ec015f9e76456e20cc279808668486ba
2018-05-10 18:06:27 +02:00
Kristen Wright
031610cc8e Bug 1459367 - Convert NS_STYLE_IMAGELAYER_ATTACHMENT_* to enum class. r=manishearth
Converted NS_STYLE_IMAGELAYER_ATTATCHMENT_* vals to enum class, StyleImageLayerAttachment.
2018-05-08 15:05:33 -07:00
Emilio Cobos Álvarez
a5e7a3aec3 Bug 509958: Unprefix :-moz-selection. r=dbaron,xidorn
Our implementation is totally not what the spec says, but totally what other
UAs do, see https://github.com/w3c/csswg-drafts/issues/2474.

So given this is causing webcompat pain, I think we should be pragmatic and just
unprefix this.

We could keep serialization and getComputedStyle with ::selection working with a
bit more effort, like we do for :-moz-placeholder, but I'd prefer not doing at
least the serialization bit, and just alias in nsCSSPseudoElements
:-moz-selection to selection too.

MozReview-Commit-ID: 6lxctozRDqv
2018-05-10 17:19:25 +02:00
Xidorn Quan
38152a41e1 Bug 1460192 - Rename pointing to inherited_ui. r=heycam
And also merge values::*::pointing into values::*::ui.

MozReview-Commit-ID: FM4gWEszahB

--HG--
rename : servo/components/style/properties/longhand/pointing.mako.rs => servo/components/style/properties/longhand/inherited_ui.mako.rs
rename : servo/components/style/values/generics/pointing.rs => servo/components/style/values/generics/ui.rs
extra : rebase_source : c69db288acdf60b2e480a61dc6637b427aa9a5e3
2018-05-09 16:07:36 +10:00
Xidorn Quan
8de2621296 Bug 1454591 part 3 - Consistently use top-right-bottom-left order for physical sides. r=heycam
MozReview-Commit-ID: 6pLRSO8YNDI

--HG--
extra : rebase_source : 4c8ce8560c2112d2378a12b34ae2241e2e25eed4
2018-05-04 15:15:56 +10:00
Emilio Cobos Álvarez
0baa408319 Bug 1459436: Remove a useless unit test that no longer compiles. r=emilio
We have WPT and integration tests for the functionality in mozilla-central.

MozReview-Commit-ID: L0vdF3tfT83
2018-05-05 18:07:56 +02:00
Emilio Cobos Álvarez
71a7af886c Bug 1459436: Remove some unneeded cfg(..). r=emilio
The less not-compiled code in common builds, the better for everybody.

MozReview-Commit-ID: 3JQfz6AYhPG
2018-05-05 18:07:46 +02:00
Emilio Cobos Álvarez
d6f79cd48e Bug 1459436: Implement Debug for KeyframeAnimationStyle by hand. r=emilio
The ComputedValues format is huge and unneeded.

Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>

MozReview-Commit-ID: 44OuCMWJPLk
2018-05-05 18:07:37 +02:00
Emilio Cobos Álvarez
6ee6a58a0f Bug 1459436: Fix servo build. r=emilio
MozReview-Commit-ID: Ex5RKgPgd8x
2018-05-05 18:07:28 +02:00
Emilio Cobos Álvarez
68affa51a4 Bug 1459436: Fix tidy issues. r=emilio
MozReview-Commit-ID: KXInHzAiiD8
2018-05-05 18:07:18 +02:00
Emilio Cobos Álvarez
73331875c7 Bug 1458814: followup: remove some unused imports. r=me
MozReview-Commit-ID: KMmH0ATu5Df
2018-05-05 17:55:52 +02:00
Emilio Cobos Álvarez
27ca8b58c8 Bug 1458814: Remove code that is no longer called. r=hiro
Au revoir!

MozReview-Commit-ID: DjqszUSIzXs
2018-05-05 16:31:20 +02:00
Emilio Cobos Álvarez
ceca84ff64 Bug 1458814: Remove a bit of trivially dead code. r=hiro
MozReview-Commit-ID: GG41v4TejBU
2018-05-05 16:31:19 +02:00
Emilio Cobos Álvarez
d7f92df0f2 Bug 1458814: Make SMIL values not roundtrip through strings. r=hiro
MozReview-Commit-ID: DpbFSutIv3t
2018-05-05 16:31:17 +02:00
Xidorn Quan
5bba37b212 Bug 1457524 part 4 - Allow 16% false positives in test bloom::create_and_insert_some_stuff. r=heycam
It seems that the result of hash algorithm used in bloom filter depends
on the pointer length. On 64bit platforms, there are 135 false positives
in the first part of that test, and 8 in the second part. However, on
32bit platforms, the numbers become 157 and 16 correspondingly.

16 is still less than 20% in the second part, so all fine, but 157 is
slightly larger than 15% in the test assertion. Given it is what we are
shipping, we probably should just accept this and loosen the assertion.

MozReview-Commit-ID: 9kFXBzLFAzE

--HG--
extra : rebase_source : 41fa45dc3c59b2f44d33bdbe86b3eb2e29a31319
2018-05-02 21:07:07 +10:00
shindli
8fad8a2218 Merge inbound to mozilla-central. a=merge 2018-05-04 11:35:37 +03:00
Noemi Erli
6e6ddaaf1f Backed out 4 changesets (bug 1458814) for failres in builds/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/smil/style/anim-css-strokewidth-1-to-pct-pct.svg on a CLOSED TREE
Backed out changeset d0990dff4fc4 (bug 1458814)
Backed out changeset c61d211a9f1d (bug 1458814)
Backed out changeset e7f7ea7ab4af (bug 1458814)
Backed out changeset 9ac18a3eeaa5 (bug 1458814)
2018-05-04 08:39:52 +03:00
Ciure Andrei
9be98c9d63 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-05-04 00:56:01 +03:00
Jonathan Watt
cfe84bdd1c Bug 1458219 - Remove the 'property_name' macro. r=xidorn 2018-04-25 14:54:26 +01:00
Emilio Cobos Álvarez
391b338b94 Bug 1457678: Make the font canvas code not mess with the rule tree. r=xidorn,hiro
Inserting a lot of rules in the root level is super-inefficient. This fixes it
by not doing it.

It gives the root rule node to the style, but that's fine, since it's useless.
All this code-path is already pretty messy.

MozReview-Commit-ID: GoGHI4YJbKr
2018-05-04 05:50:21 +02:00
Emilio Cobos Álvarez
a3a9886c6b Bug 1458814: Remove code that is no longer called. r=hiro
Au revoir!

MozReview-Commit-ID: DjqszUSIzXs

--HG--
extra : rebase_source : b81bb905449eb1e4d7cbc1094da9a151011b0350
2018-05-03 18:47:47 +02:00
Emilio Cobos Álvarez
0566c42687 Bug 1458814: Remove a bit of trivially dead code. r=hiro
MozReview-Commit-ID: GG41v4TejBU

--HG--
extra : rebase_source : 5dc1f255178ae723eed47ec3fdbd6595fa84da62
2018-05-03 18:41:17 +02:00
Emilio Cobos Álvarez
d97d041be2 Bug 1458814: Make SMIL values not roundtrip through strings. r=hiro
MozReview-Commit-ID: DpbFSutIv3t

--HG--
extra : rebase_source : 034bb584fcb3f6b67a6b38f70149e167ba0c300c
2018-05-03 18:27:44 +02:00
Emilio Cobos Álvarez
da45aa5fed Bug 1458927: Fix perspective squared distance computation. r=hiro
MozReview-Commit-ID: YwjTheRonB

--HG--
extra : rebase_source : d3734aad5d37dda1ccaf24f1f84e2f0972e45f5d
2018-05-03 17:43:30 +02:00
Emilio Cobos Álvarez
b448f93568 Bug 1458715: followup: don't fix distance computation so fast. r=me
On a CLOSED TREE

MozReview-Commit-ID: 1Y3As81hnRx
2018-05-03 17:38:42 +02:00
Emilio Cobos Álvarez
b22479d43d Bug 1458715: Fix perspective interpolation. r=hiro
It's not sound to insert random matrices in random positions in the transform
operation list.

I cannot make any sense of what the old code was trying to do.

MozReview-Commit-ID: 5BtCiueEPlR
2018-05-03 16:45:07 +02:00
Emilio Cobos Álvarez
c556ec7ad0 Bug 1457920: Remove ServoStyleSheet usage. r=xidorn
MozReview-Commit-ID: LIBkovuQ6MB
2018-05-02 04:13:26 +02:00
Emilio Cobos Álvarez
2a42c4ed18 Bug 1457920: Merge ServoStyleSheet and StyleSheet. r=xidorn
These are the most minimal changes I could make. More cleanups incoming.

MozReview-Commit-ID: AdMOA1acQIH
2018-05-02 04:13:10 +02:00
Emilio Cobos Álvarez
adc46229a3 Bug 1018269: Handle Shadow DOM in keyframes lookup. r=heycam
MozReview-Commit-ID: AeUmsOHOUYR
2018-05-01 13:01:23 +02:00
Emilio Cobos Álvarez
8da32ee8b3 Bug 1457635: Remove values::Verbatim. r=xidorn
No point of having two things that do the same.

MozReview-Commit-ID: Do1L4bvOeVQ
2018-04-30 05:10:48 +02:00
Emilio Cobos Álvarez
3058209ae5 Bug 1457635: Move represents_keyword to the css attributes. r=xidorn
MozReview-Commit-ID: 21yuU4h34AQ
2018-04-30 05:10:37 +02:00
Emilio Cobos Álvarez
42257e0c21 Bug 1457332: Derive ToCss for Counters. r=xidorn
MozReview-Commit-ID: 1jOglcqt1Dd
2018-04-30 05:10:22 +02:00
Xidorn Quan
f2ba299166 Bug 1448759 part 1 - Make KTableEntry an independent type. r=heycam
MozReview-Commit-ID: oZfJAigThN

--HG--
extra : rebase_source : 6a0efbf40fed8c9eaba7bb3af74d281b536677c8
2018-04-29 21:17:26 +10:00
Emilio Cobos Álvarez
b52948e2af No bug - Fix tidy issues and Servo build, and fix unit test bustage. r=me
MozReview-Commit-ID: 7MFLnVZmZUg
2018-04-29 05:20:27 +02:00
Emilio Cobos Álvarez
c2ca86b566 No bug - Change the configuration of some properties for servo. r=me
MozReview-Commit-ID: FxJQrXziRK0
2018-04-29 02:43:47 +02:00
Emilio Cobos Álvarez
289dbdc04a No bug - Derive an attribute for servo. r=me
MozReview-Commit-ID: DQBJeg3xbuM
2018-04-29 02:30:59 +02:00
Emilio Cobos Álvarez
4fa6110947 No bug - Reorder an import to sync with servo. r=me
MozReview-Commit-ID: 4BLELl3T54p
2018-04-29 02:29:39 +02:00
Emilio Cobos Álvarez
3485ba7bff No bug - Get rid of an import and sync with servo. r=me
MozReview-Commit-ID: 5aGNna6ulsM
2018-04-29 02:29:36 +02:00