Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-07 12:15:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
373,213 Commits 615 Branches 98 Tags 5.9 GiB
2a41ec8218
Commit Graph

3416 Commits

Author SHA1 Message Date
Ryan VanderMeulen
4f6ccf8cd8 Merge m-c to b2g-inbound. 2014-05-13 16:27:50 -04:00
Steve Singer
abc85b65e4 Bug 1009291 - Forward declare ProfilerBacktrace before it is used. r=BenWa 2014-05-12 17:11:00 -04:00
Julian Seward
e012f2a4d8 Bug 999348 - [flatfish] Build faild in gecko/tools/profiler/LulElf.cpp. r=glandium. 2014-05-13 21:26:33 +02:00
Aaron Klotz
249ed48c5d Bug 977446 - Fix erroneous assertion triggered during SyncProfile destruction; r=sewardj 2014-04-22 12:42:15 +02:00
Benoit Girard
7e6ec54552 Bug 1004899 - Add stderr to profile output. r=ehsan 
--HG--
extra : rebase_source : e21a60c60521bcd0471c36645378ef9231c9e243
 2014-05-01 22:05:49 -04:00
Benoit Girard
7bc6762bed Bug 926922 - Log reason for layout flushes in profiles. r=ehsan,bz 
--HG--
extra : rebase_source : 5383b80a1d0d1ddb36351dea1ad44f27b93001a2
 2014-04-22 14:13:00 -04:00
Roberto A. Vitillo
27a423ebef Bug 880864 - User dictionary (persdict.dat) read on main thread. r=mayhemer 2014-05-07 06:35:00 -04:00
Robert O'Callahan
7043c985ba Bug 1006248. Part 1: Add MOZ_EXPORT in various places. r=glandium 
--HG--
extra : rebase_source : cfe209a412cae28d405eae413415cebb6959072a
 2014-05-06 17:26:46 +12:00
Ehsan Akhgari
57c249bbff Backed out changeset 70946e64e8f8 (bug 1005704) because it caused bug 1006541 2014-05-06 16:39:39 -04:00
Ehsan Akhgari
15aa0ce41b Bug 1005704 - Enable installing files dist files without preprocessing; r=mshal 2014-05-05 21:26:11 -04:00
Benoit Girard
cf49cd697a Bug 1005204 - Enable JSStreamWriterTest. no reviews, just enabling a test. 2014-05-02 13:34:29 -04:00
Viktor Stanchev
72b8f5c8ae Bug 986160 - Create unit tests for the Gecko Profiler. r=benwa 2014-04-07 15:29:07 -04:00
Benoit Girard
7d7a2f9d30 Bug 1004716 - Adjust marker timestamps when merging profiles. r=ehsan DONTBUILD because NPOTB 
--HG--
extra : rebase_source : 446f59d60e1508a9d05b7e55f2793ba6556e09ad
 2014-05-01 17:53:23 -04:00
Benoit Girard
1064619116 Bug 1004677 - Restore double precision startTime. r=bjacob 
--HG--
extra : rebase_source : 1579e50c3fcf44053ed83dc2411941120229729d
 2014-05-01 16:27:36 -04:00
Jim Chen
e8ad92a6ac Bug 999071 - Don't notify observers in profiler when used by Android ANR reporter; r=BenWa 2014-04-28 22:20:51 -04:00
Birunthan Mohanathas
5f1fde8824 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Wes Kocher
45d885681c Backed out changeset 60b6bdaafba7 (bug 999071) for android 2.3 rc1 orange 2014-04-25 14:50:31 -07:00
Jim Chen
f3a501bb51 Bug 999071 - Don't notify observers in profiler when used by Android ANR reporter; r=BenWa 2014-04-25 12:38:18 -04:00
Wes Kocher
d477a31fd8 Backed out 3 changesets (bug 999071) for Android rc1 failures 
Backed out changeset ddf970be0abd (bug 999071)
Backed out changeset 8d2738b22275 (bug 999071)
Backed out changeset b82a8c50aa90 (bug 999071)
 2014-04-24 18:12:46 -07:00
Jim Chen
c9f29c93c9 Bug 999071 - Don't notify observers in profiler when used by Android ANR reporter; r=BenWa 2014-04-24 17:49:01 -04:00
Shelly Lin
6437f8163e Bug 908995 - Part 2: Track runnables, tasks and timer events with TaskTracer. r=khuey. 2014-03-27 16:49:06 +08:00
Shelly Lin
31efa9372b Bug 908995 - Part 1: The core implementation of TaskTracer. r=khuey. 2014-03-27 16:44:30 +08:00
Viktor Stanchev
11dae83d41 Bug 867728 - Add tests for JSStreamWriter. r=bgirard 
--HG--
extra : rebase_source : ee679794165b171ec89dfc2785647ffa7cb7f009
 2014-04-21 16:52:40 -04:00
Viktor Stanchev
549fb2406d Bug 867728 - Stream profiler JSON directly to a file. r=bgirard,terrence 
--HG--
extra : rebase_source : 3472eb981d0c8778be318b3d51b51edfe8c1c96a
 2014-04-21 16:48:47 -04:00
Viktor Stanchev
0f296aff8a Bug 996285 - Profiler stops duplicating samples during sleeping periods after buffer wraps. r=benwa 2014-04-21 11:46:48 -04:00
Aaron Klotz
5eb20f9c87 Bug 935482: New IOInterposer observer for recording main thread I/O to file; r=froydnj 2014-04-19 14:28:02 -06:00
Julian Seward
061965db8b Bug 997700 - Fix build issues with LUL and --enable-warnings-as-errors. r=nfroyd. 2014-04-19 01:30:46 +02:00
Terrence Cole
581c606391 Bug 959787 - Handlify JS_DefineProperty; r=Waldo, r=bz 
--HG--
extra : rebase_source : 87991ed47ed071550af4e4125eea54a66fdb0071
 2014-01-21 18:11:17 -08:00
Viktor Stanchev
fc25e0ce54 Bug 962262 - Profiler - Use float instead of double to pack circular buffer. r=benwa 
--HG--
extra : rebase_source : 62429abbb05c199ed714ecec2f6b000296b94deb
 2014-04-10 10:52:23 -04:00
Julian Seward
9bd60ea2d4 Bug 938157 - Lightweight CFI/EXIDX unwinding library for SPS. r=n.nethercote, nfroyd, bgirard. 
--HG--
extra : rebase_source : bd427749667ddd6641eff414879c3706a5cb5f5e
 2013-12-18 13:02:34 +01:00
Gregory Szorc
e177929bf7 Bug 994359 - Update Bitbucket certificate fingerprint; r=edmorley 
Certificate updated per
http://blog.bitbucket.org/2014/04/08/bitbuckets-ssl-certificates-are-changing/

DONTBUILD (NPOTB)

--HG--
extra : rebase_source : 7b2acdad8221d40629a0fff7b9b9fcfbd51eb1a5
extra : amend_source : 2138af8ab774420f466e33914f2abdb82a52df25
 2014-04-09 15:33:16 -07:00
Gregory Szorc
f9ca77bae1 NO BUG - Install RBTools 0.6 
We were previously installing a pre-release of RBTools from Git. The
patches we were waiting on are now in RBTools 0.6. So, install the
released version from PyPI.

DONTBUILD (NPOTB)

--HG--
extra : rebase_source : 0c3c13c6e9ec24ae7ebcabe5b2e4fa64441b2332
 2014-04-08 16:03:35 -07:00
Masatoshi Kimura
988da5b46e Bug 992503 - Remove the MSVC exemption for FAIL_ON_WARNINGS in tools/profiler. r=BenWa 2014-04-08 21:22:14 +09:00
Phil Ringnalda
abdac31cf1 Merge m-i to a CLOSED TREE m-c 2014-04-06 09:51:58 -07:00
Wes Kocher
1a4b234833 Backed out changeset 1e38b4aa8889 (bug 986160) for breaking Nightly builds 2014-04-04 14:54:19 -07:00
Eric Faust
edf5e61761 Bug 890686 - Implement JS_GlobalObjectTraceHook, and install it appropriately. (r=billm) 2014-04-04 16:58:08 -07:00
Viktor Stanchev
8f6b3cf1ab Bug 986160 - Create unit tests for the Gecko Profiler. r=benwa 
--HG--
extra : rebase_source : b73d3af33ddbf032a01067c9d92ea6a6e441cdba
 2014-04-04 10:11:41 +08:00
snigdha
9cc482da68 Bug 798033 - Headers should generally not do "using namespace" at file scope. r=jib, r=jmathies, r=rjesup, r=ekr, r=ncameron, r=blassey 2014-04-01 08:29:25 -04:00
Viktor Stanchev
efc233bd6d Bug 987297 - Improve memory usage of profiler by packing ProfileEntry structs together better. r=bgirard 2014-03-31 14:19:00 +02:00
Jacek Caban
046703f3a5 Bug 820048 - Added missing math.h (mingw fixup). 2014-03-31 13:21:59 +02:00
Viktor Stanchev
ffd378ba44 Bug 963158 - Profiler shouldn't sample sleeping threads multiple times. r=bgirard,roc,bent,froydnj 
--HG--
extra : rebase_source : 75789c4359a2cb02b2588cfbc9b6b3cbd1e79c78
 2014-03-28 16:08:22 -04:00
Jed Davis
bcb7b2cc3a Bug 914561: Use SPS EnterJIT marks to unwind past jitcode. r=BenWa 2014-03-27 19:20:20 -07:00
Jed Davis
a3824f224b Bug 914561: Record EnterJIT trampoline frame address on SPS pseudostack. r=nbp 2014-03-27 19:20:20 -07:00
Anthony Jones
ec9a27854b Bug 983633 - Error if filterdiff is required; r=gps 2014-03-21 17:43:28 +13:00
Aaron Klotz
4ebf28f26c Bug 972577: Consolidate IOInterposer initialization code; r=froydnj,BenWa,jimm 
--HG--
rename : tools/profiler/IOInterposer.cpp => xpcom/build/IOInterposer.cpp
rename : tools/profiler/IOInterposer.h => xpcom/build/IOInterposer.h
rename : tools/profiler/NSPRInterposer.cpp => xpcom/build/NSPRInterposer.cpp
rename : tools/profiler/NSPRInterposer.h => xpcom/build/NSPRInterposer.h
rename : toolkit/xre/nsWindowsDllInterceptor.h => xpcom/build/nsWindowsDllInterceptor.h
 2014-03-14 16:35:01 -06:00
Wes Kocher
a20307b017 Backed out changeset 2bdd2d042847 (bug 972577) for non-unified bustage on a CLOSED TREE 
--HG--
rename : xpcom/build/nsWindowsDllInterceptor.h => toolkit/xre/nsWindowsDllInterceptor.h
rename : xpcom/build/IOInterposer.cpp => tools/profiler/IOInterposer.cpp
rename : xpcom/build/IOInterposer.h => tools/profiler/IOInterposer.h
rename : xpcom/build/NSPRInterposer.cpp => tools/profiler/NSPRInterposer.cpp
rename : xpcom/build/NSPRInterposer.h => tools/profiler/NSPRInterposer.h
 2014-03-14 15:27:21 -07:00
Aaron Klotz
ae4aa8bc28 Bug 972577: Consolidate IOInterposer initialization code; r=froydnj,BenWa,jimm 
--HG--
rename : tools/profiler/IOInterposer.cpp => xpcom/build/IOInterposer.cpp
rename : tools/profiler/IOInterposer.h => xpcom/build/IOInterposer.h
rename : tools/profiler/NSPRInterposer.cpp => xpcom/build/NSPRInterposer.cpp
rename : tools/profiler/NSPRInterposer.h => xpcom/build/NSPRInterposer.h
rename : toolkit/xre/nsWindowsDllInterceptor.h => xpcom/build/nsWindowsDllInterceptor.h
 2014-03-14 13:47:24 -06:00
Viktor Stanchev
378c2034e1 Bug 981132 - set up atfork on the main thread. r=bgirard 
--HG--
extra : rebase_source : adbbf08a081dac84de6e1c2d001f32c786b38dc5
 2014-03-12 16:32:40 -04:00
Brian R. Bondy
5af5d81828 Bug 974570 - Sign MAR files on all platforms. r=catlee, ted 2014-02-20 10:00:53 -05:00
Gregory Szorc
77f31d4d20 Bug 981724 - Update fingerprint for bitbucket; r=edmorley 
DONTBUILD (NPOTB)

--HG--
extra : rebase_source : b69aeae32da1099a9ee195847d8daf02d38d4f7d
extra : amend_source : 294da8b00aeafb061c336be0b3c2b291ff3bf933
 2014-03-10 10:35:40 -07:00
Viktor Stanchev
61ed9edf45 Bug 979566 - Profiler: Convert usleep to nanosleep. r=bgirard 2014-03-07 15:43:34 -05:00
Robert Strong
00eb9e322d Followup for Bug 900251 - remove check for extra channel-prefs.js and update-settings.ini files in the mar generation scripts. r=nthomas 2014-03-05 17:04:21 -08:00
Robert Strong
40e187af87 Bug 900251 - Add support for add-if-not instruction added by bug 759469 to the mar generation scripts. r=nthomas 2014-03-05 11:42:56 -08:00
Robert Strong
376e960b5a bug 896223 - Remove the version 1 manifest from the mar creation scripts. r=nthomas 2014-03-05 11:42:48 -08:00
Ehsan Akhgari
17f4a32d8b Bug 976896 - Port STL_FLAGS to moz.build; r=mshal 2014-03-04 19:39:06 -05:00
Viktor Stanchev
17777910b1 Bug 978292 - Turn on sps profiler leaf data collection on linux. r=bgirard 2014-03-04 10:35:36 -05:00
Kannan Vijayan
64dbdf9caf Bug 976260 - Register javascript performance events with the profiler, second attempt at pushing. r=jandem 2014-03-03 14:36:08 -05:00
L. David Baron
32f0fef7ac Bug 855081 patch 2: Use a single buffer for the demangled names. r=jesup 2014-03-03 00:54:38 -08:00
Ryan VanderMeulen
1662c5c020 Backed out changesets 1b4b7d198185 and 8529b074a2f3 (bug 976260) for adding new rooting hazards. 
CLOSED TREE
 2014-02-28 16:04:49 -05:00
Viktor Stanchev
e243b1a2cf Bug 969456 - Add pause/resume API to profiler. r=bgirard 
--HG--
extra : rebase_source : 3c72e4b6b87f629fd1a289ddb4bbc94b582a0b4b
 2014-02-28 15:16:38 -05:00
Kannan Vijayan
88eff64bd1 Bug 976260 - Register javascript performance events with the profiler. r=jandem 2014-02-28 14:02:46 -05:00
Ed Morley
75251a8149 Backed out changeset 84663a25b44e (bug 976260) for compilation failures 2014-02-28 18:42:34 +00:00
Kannan Vijayan
853bcf6e79 Bug 976260 - Register javascript performance events with the profiler. r=jandem 2014-02-28 13:22:03 -05:00
Ed Morley
575e4b2042 Bug 977961 - mach mercurial-setup: Avoid prompting to enable mqext auto-commit when already enabled; r=gps 
DONTBUILD (NPOTB)
 2014-02-28 16:43:01 +00:00
Ed Morley
46c09350dc Bug 977414 - mach mercurial-setup: Fix hgrc paths for extensions on Windows; r=gps 2014-02-27 10:10:22 +00:00
Ed Morley
1386611e1d Bug 977384 - mach mercurial-setup: Remaining cleanup; r=gps 2014-02-27 10:10:22 +00:00
Ed Morley
947aafcf25 Bug 977384 - mach mercurial-setup: Refactor part 2; r=gps 2014-02-27 10:10:21 +00:00
Ed Morley
8f447b8f21 Bug 977384 - mach mercurial-setup: Refactor part 1; r=gps 2014-02-27 10:10:20 +00:00
L. David Baron
a8b24763d3 Bug 331743 patch 5: Fix -Wformat warnings in leaksoup.cpp related to 32-bit vs. 64-bit sizes. r=khuey 2014-02-26 13:36:36 -08:00
L. David Baron
a897bb7059 Bug 331743 patch 4: Fix -Wshadow warning in leaksoup.cpp. r=khuey 2014-02-26 13:36:36 -08:00
L. David Baron
b0d0022c36 Bug 331743 patch 3: Improve trace-malloc memory dumps and their handling on 64-bit. r=khuey 
There are three categories of improvements:

 (1) using size_t* rather than unsigned long* (and "%zX" rather than
     "%lX"), to better support platforms where sizeof(long) !=
     sizeof(void*), such as Win64 (untested, though).  This is a
     non-issue for 64-bit Linux (where I tested) and Mac.

 (2) Using the correct amount of 0-padding when printing addresses to
     show how much memory space is being printed.  In other words, using
     "%016zX" on 64-bit platforms instead of "%08zX".  This change is
     cosmetic-only, though it makes the logs much more understandable.

 (3) [in leaksoup.cpp only] Fixing an occurrence of assuming that
     sizeof(int) == sizeof(void*).  This occurrence led to printing only
     the lower half of each word in the output, after doing a correct
     analysis of the memory graph.

This patch is patching three files:

 (A) nsTraceMalloc.cpp, which is the in-process Gecko trace-malloc code
     that generates the memory dumps.

 (B) adreader.cpp, which is shared utility code for reading such a
     memory dump (currently used only by leaksoup.cpp)

 (C) leaksoup.cpp, which reads in such a memory dump, performs a
     strongly connected components analysis of the memory graph, and
     writes it back out, HTML-ized, with the roots listed at the top.

A fourth file appears to need no modification since it only looks at the
stack part of the dump and not the contents of the memory:

 (D) diffbloatdump.pl, which diffs two bloat dumps and produces a stack
     tree showing the change in allocations between them
 2014-02-26 13:36:36 -08:00
L. David Baron
c91b8791d1 Bug 976350 patch 2: Rename nsTraceRefcntImpl to nsTraceRefcnt. r=bsmedberg 
Now that bug 975295 removed the obsolete wrapper class, we can rename
nsTraceRefcntImpl back to its correct pre-XPCOM-glue name,
nsTraceRefcnt.

The best part is that the one place where indentation should have needed
fixing, nsTraceRefcnt::DemangleSymbol, never had its indentation fixed
for the previous renaming.

--HG--
rename : xpcom/base/nsTraceRefcntImpl.cpp => xpcom/base/nsTraceRefcnt.cpp
rename : xpcom/base/nsTraceRefcntImpl.h => xpcom/base/nsTraceRefcnt.h
 2014-02-26 13:36:36 -08:00
Ed Morley
2df90d1cdd Bug 976892 - Update mach mercurial-setup to use qimportbz from it's new home in version-control-tools; r=gps 
qimportbz is now pulled from its new canonical home. The old location can
be cleaned if the user agrees to it. The new location is updated in the
hgrc.

DONTBUILD (NPOTB)
 2014-02-26 17:28:09 +00:00
Viktor Stanchev
0f7d95f413 Bug 970494 - Markers should be time based and not sample based. r=bgirard 
--HG--
extra : rebase_source : 5401e1145c771878a1caa384d79e2dc1d0a1855c
 2014-02-25 10:40:45 -05:00
L. David Baron
0026a0fe5d Back out changeset 72c0c955cf53 (no bug) now that bug 939610 is fixed. 2014-02-24 15:27:53 -08:00
Jim Chen
bfa117a21f Bug 974986 - Always specify stack address in SamplerStackFramePrintfRAII; r=BenWa 2014-02-24 12:27:58 -05:00
Jim Chen
dca2479fd2 Bug 974980 - Always push a js:RunScript frame in pseudostack; r=BenWa 2014-02-24 12:27:58 -05:00
Chris Peterson
91d5779d1b Bug 712939 - Replace JS_STATIC_ASSERT with static_assert outside js/ directory. r=BenWa r=bsmedberg r=mccr8 2014-02-17 22:10:50 -08:00
Ryan VanderMeulen
048505064d Merge inbound to m-c. 2014-02-20 15:13:01 -05:00
Dave Huseby
4f30f241e5 Bug 972536 - Add a tool for gathering USS memory data for a process over time for memory leak detection. r=dbaron 2014-02-20 08:50:54 -05:00
Chris Peterson
56af4fda84 Bug 712939 - Replace JS_STATIC_ASSERT with static_assert outside js/ directory. r=mccr8 2014-02-17 23:56:19 -08:00
Andrew McCreight
344c61d00e Back out bug 712939 for not getting fully reviewed. 2014-02-20 06:40:56 -08:00
Emanuel Hoogeveen
00487ce6f9 Bug 971094 - Part 0: Add some null checks to the profiler's usage of Observation::Filename(). r=BenWa 2014-02-20 08:43:55 -05:00
Daniel Holbert
c516662c22 back out 3a8893b28489 (bug 712939) and 39adab158c17,16add78c43e3,37193db7e15b (bug 712873), for build bustage. 2014-02-19 00:15:51 -08:00
Chris Peterson
dcfc7e9c20 Bug 712939 - Replace JS_STATIC_ASSERT with static_assert outside js/ directory. r=mccr8 2014-02-17 23:56:19 -08:00
Aaron Klotz
065c3ca8a2 Bug 973899: Fix usage of temporary string that was causing crashes; r=ehsan 2014-02-18 10:13:51 -07:00
L. David Baron
e4e2cc5501 Make fix-linux-stack handle addresses with lowercase hexidecimal, since that seems to be the thing these days. No bug. 
(mrbkap, I, and ehoogeveen have all seen lowercase lately.)
 2014-02-17 20:07:45 -08:00
Masatoshi Kimura
8ddf7de8a5 Bug 969918 - Use decltype to declare pointers for dynamic-loaded functions. r=jimm sr=roc 2014-02-18 07:32:52 +09:00
Benoit Girard
11680762e6 backout e9c0d692b2cf (bug 970494) for warning failures. r=backout 
CLOSED TREE
 2014-02-13 16:13:32 -05:00
Viktor Stanchev
cc4777dcd4 Bug 970494 - Markers should be time based and not sample based. r=bgirard 
--HG--
extra : rebase_source : c1e3e77fa8f7ad2c5eec7f092d96bf3719db3a8c
 2014-02-13 13:43:48 -05:00
Viktor Stanchev
18aeb9dd4e Bug 962325 - Add filename to profiler I/O markers. r=bgirard 
--HG--
extra : rebase_source : 6ec4d08834f57946681b65064c1e5764572d28e7
 2014-02-13 13:32:38 -05:00
Gregory Szorc
bb4b656c3b Bug 971683 - Remove tools/l10n; r=bsmedberg 
--HG--
extra : rebase_source : 12c3b29df1e7333c5abc6768f853ed41291b1ddb
extra : amend_source : 7d0566143465dea662e05bd9351cb02c3eb9e8d4
 2014-02-12 14:20:15 -08:00
Jon Coppeard
d0e56d0b88 Bug 969812 - Convert JS_NewArrayObject to use HandleValueArray r=terrence r=bz 2014-02-12 10:50:46 +00:00
Ehsan Akhgari
e4f4a283cc Bug 970727 - Move DEFFILE to moz.build; r=mshal 2014-02-11 11:28:54 -05:00
Brian O'Keefe
56341318f9 Bug 772828 - Part b: use RESOURCE_FILES in moz.build instead of manual rules in Makefile.in; r=mshal 2013-11-05 13:37:54 -05:00
Ehsan Akhgari
d91d200572 Bug 969757 - Remove the dead code in our tree which pretends to support OS/2; r=roc,mcmanus,gps,jorendorf,bsmedberg sr=bsmedberg 2014-02-10 17:57:01 -05:00
Nathan Froyd
0144542cd7 Bug 968932 - remove unused <*stream> headers from platform-linux.cc; r=BenWa 2014-02-06 12:49:32 -05:00
Ryan VanderMeulen
c38a20a8ce Merge m-c to inbound on a CLOSED TREE. 2014-02-06 16:29:41 -05:00
Gregory Szorc
100c3f1d85 Bug 968259 - Update mach mercurial-setup to work with new unified VCS tools repo; r=ted 
bzexport is now pulled from its new canonical home. The old location can
be cleaned if the user agrees to it. The new location is updated in the
hgrc.

DONTBUILD (NPOTB)

--HG--
extra : rebase_source : f7737bcf7b528df9b8130ecb3cf73f4d74280d3b
extra : amend_source : b9a1a0b656b1e350cf161db386cf7986cac6a430
 2014-02-05 14:12:15 -08:00
Ryan VanderMeulen
3ac56bf193 Backed out changeset f4c91d9262f1 (bug 965373) for test_profiler_activation.js timeouts on Windows debug. 2014-02-06 14:34:05 -05:00