Commit Graph

11447 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
2a42c4ed18 Bug 1457920: Merge ServoStyleSheet and StyleSheet. r=xidorn
These are the most minimal changes I could make. More cleanups incoming.

MozReview-Commit-ID: AdMOA1acQIH
2018-05-02 04:13:10 +02:00
Emilio Cobos Álvarez
adc46229a3 Bug 1018269: Handle Shadow DOM in keyframes lookup. r=heycam
MozReview-Commit-ID: AeUmsOHOUYR
2018-05-01 13:01:23 +02:00
Emilio Cobos Álvarez
8da32ee8b3 Bug 1457635: Remove values::Verbatim. r=xidorn
No point of having two things that do the same.

MozReview-Commit-ID: Do1L4bvOeVQ
2018-04-30 05:10:48 +02:00
Emilio Cobos Álvarez
3058209ae5 Bug 1457635: Move represents_keyword to the css attributes. r=xidorn
MozReview-Commit-ID: 21yuU4h34AQ
2018-04-30 05:10:37 +02:00
Emilio Cobos Álvarez
42257e0c21 Bug 1457332: Derive ToCss for Counters. r=xidorn
MozReview-Commit-ID: 1jOglcqt1Dd
2018-04-30 05:10:22 +02:00
Xidorn Quan
f2ba299166 Bug 1448759 part 1 - Make KTableEntry an independent type. r=heycam
MozReview-Commit-ID: oZfJAigThN

--HG--
extra : rebase_source : 6a0efbf40fed8c9eaba7bb3af74d281b536677c8
2018-04-29 21:17:26 +10:00
Emilio Cobos Álvarez
b52948e2af No bug - Fix tidy issues and Servo build, and fix unit test bustage. r=me
MozReview-Commit-ID: 7MFLnVZmZUg
2018-04-29 05:20:27 +02:00
Emilio Cobos Álvarez
c2ca86b566 No bug - Change the configuration of some properties for servo. r=me
MozReview-Commit-ID: FxJQrXziRK0
2018-04-29 02:43:47 +02:00
Emilio Cobos Álvarez
289dbdc04a No bug - Derive an attribute for servo. r=me
MozReview-Commit-ID: DQBJeg3xbuM
2018-04-29 02:30:59 +02:00
Emilio Cobos Álvarez
4fa6110947 No bug - Reorder an import to sync with servo. r=me
MozReview-Commit-ID: 4BLELl3T54p
2018-04-29 02:29:39 +02:00
Emilio Cobos Álvarez
3485ba7bff No bug - Get rid of an import and sync with servo. r=me
MozReview-Commit-ID: 5aGNna6ulsM
2018-04-29 02:29:36 +02:00
Emilio Cobos Álvarez
afc1297f6d No bug - sync some changes from servo. r=me
MozReview-Commit-ID: HyRI5CfZh5w
2018-04-29 01:59:00 +02:00
Xidorn Quan
9d288a4ae2 Bug 1434130 part 12 - Manually implement collect_completion_keywords for some types. r=emilio
MozReview-Commit-ID: 6T35uylxgho

--HG--
extra : source : b638793227b9f6317b540670227d68ad90a76173
2018-04-29 09:03:31 +10:00
Xidorn Quan
c873376fd5 Bug 1434130 part 11 - Add some attributes for SpecifiedValueInfo to help deriving more from types. r=emilio
MozReview-Commit-ID: IyohSTbUO31

--HG--
extra : source : 2af95ecd7e1f48bf54a93573a68a9d3f29393e42
2018-04-29 09:03:31 +10:00
Xidorn Quan
cd8a6cc5fc Bug 1434130 part 10 - Handle keywords for color values. r=emilio
MozReview-Commit-ID: 5GvIHSeQuCX

--HG--
extra : source : 524796e355b2221343b96a77c7a00abd2eb41af7
2018-04-29 09:03:31 +10:00
Xidorn Quan
bb381a4356 Bug 1434130 part 9 - Use unified list for TextDecorationLine and implement its SpecifiedValueInfo. r=emilio
MozReview-Commit-ID: 2sCnK1AecFk

--HG--
extra : source : adc038d9c64ae32ca74ecaa46ca5cf0b9d5fdb77
2018-04-29 09:03:31 +10:00
Xidorn Quan
ab9de25533 Bug 1434130 part 8 - Have TextAlign derive ToCss and unship char value from it. r=emilio
MozReview-Commit-ID: CXDnyqzjQkq

--HG--
extra : source : a78f97b583f55fb2373d9629b16883584d93cfd1
2018-04-29 09:03:31 +10:00
Xidorn Quan
2cddea6516 Bug 1434130 part 7 - Have Parse derive respect #[css(skip)] on variant as well and derive Parse for KeywordSize. r=emilio
MozReview-Commit-ID: evSvk1RQGe

--HG--
extra : source : 19f96541b1c1d147d92bf055b36abe4a7ed5c43d
2018-04-29 09:03:31 +10:00
Xidorn Quan
46ea7a41bd Bug 1434130 part 6 - Allow shorthands to specify their own impl of SpecifiedValueInfo and manual impl it for font and border. r=emilio
MozReview-Commit-ID: 3B9OfkWU0Eq

--HG--
extra : source : fe72d293e8420ddb903883fb6c0b5970aead6a26
2018-04-29 09:03:31 +10:00
Xidorn Quan
7fc9b978c6 Bug 1434130 part 5 - Derive ToCss for values::generics::font::KeywordSize. r=emilio
MozReview-Commit-ID: 9ek3PcqYiU3

--HG--
extra : source : 29990f9171efe771ea4d09fd129d37a4a1ec3870
2018-04-29 09:03:31 +10:00
Xidorn Quan
af03b6b3eb Bug 1434130 part 4 - Use unified lists to impl several bitflag font-variant properties. r=emilio
This also changes their ToCss impl to use SequenceWriter instead of
checking has_value manually.

SpecifiedValueInfo for those types are also implemented in this patch.

MozReview-Commit-ID: 23h2VWS417H

--HG--
extra : source : f2c10917b105912bbe5fa06a986bbce08ebceac4
2018-04-29 09:03:31 +10:00
Xidorn Quan
9842a32733 Bug 1434130 part 3 - Add SequenceWriter::item_str for writing str items. r=emilio
This will be used in the next patch for font-variant bitflag types.

MozReview-Commit-ID: 2IvcsnYBNqA

--HG--
extra : source : a4cd0a8db99c2a46af183d44807dffb2a1a88e3f
2018-04-29 09:03:31 +10:00
Xidorn Quan
aa75ec745f Bug 1434130 part 2 - Add collect_values function to SpecifiedValueInfo trait for collecting possible values. r=emilio
This is the basic structure of the stuff. Following patches will fill
the gap between Gecko and Servo on value generating, and finally hook
it into InspectorUtils.

MozReview-Commit-ID: KNLAfFBiY6e

--HG--
extra : source : e9e5d72857746710ead3cd42481b805efc771389
2018-04-29 09:03:31 +10:00
Xidorn Quan
0192f05add Bug 1434130 part 1 - Skip system font variant for ToCss in font subproperties. r=emilio
System font keywords are not a valid value for those properties.

The newly-added #[css(skip)] would be reused by deriving algorithm of
SpecifiedValueInfo to skip them as well.

MozReview-Commit-ID: EmnhkaA9RR5

--HG--
extra : source : d2fc92ed32f497ff6826228181b19787c1b48cc4
2018-04-29 09:03:31 +10:00
Emilio Cobos Álvarez
1915a41571 Bug 1457652: Fix serialization order of the outline shorthand. r=xidorn
This is going to be tested in
https://github.com/w3c/web-platform-tests/pull/10700.

MozReview-Commit-ID: 7Oi1it70YFw
2018-04-28 15:41:17 +02:00
Dorel Luca
69408b00d8 Backed out changeset 2a03e9effe84 (bug 1457652) for WPT failures on /css/cssom/shorthand-values.html 2018-04-28 14:54:16 +03:00
Emilio Cobos Álvarez
573ab1cdee Bug 1457652: Fix serialization order of the outline shorthand. r=xidorn
This is going to be tested in
https://github.com/w3c/web-platform-tests/pull/10700.

MozReview-Commit-ID: 7Oi1it70YFw

--HG--
extra : rebase_source : 4c4e738ceaec32750ae0c5aa0308c17346806b3a
2018-04-28 09:41:48 +02:00
Cosmin Sabou
db4c6f9696 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-04-27 13:13:54 +03:00
Gerald Squelart
89f75361b3 Bug 1417761 - Remove "layout.css.text-combine-upright.enabled" pref - r=xidorn
Shipped since Firefox 48, other browsers have similar impls, and the related
spec has been in CR since a while ago.
The syntax of this property as implemented should be considered to be pretty
stable, so we can remove this pref.

MozReview-Commit-ID: H7lDsdbUamD

--HG--
extra : rebase_source : fda63805d9dea49a55d57153c841426508a882f6
2018-04-27 11:31:25 +10:00
sotaro
666719aa81 Bug 1456350 - Forward webrender error log to gfxCriticalNote r=bholley 2018-04-27 16:48:39 +09:00
Emilio Cobos Álvarez
c5da849604 Bug 1457026: followup: Skip a rustest that depends on include order and isn't super-useful. r=bholley on a CLOSED TREE
MozReview-Commit-ID: 3lwAyl8aztW
2018-04-26 19:16:52 +02:00
Andreea Pavel
a21531022b Merge mozilla-inbound to mozilla-central. a=merge
--HG--
rename : toolkit/components/extensions/test/xpcshell/test_ext_browserSettings.js => toolkit/components/extensions/test/xpcshell/test_ext_proxy_config.js
2018-04-26 09:04:59 +03:00
Xidorn Quan
cd1312cc66 Bug 1455576 part 3 - Use Servo side data to back InspectorUtils::CssPropertySupportsType. r=emilio
The only difference in the final result is "all" shorthand, for which
the original result is wrong because "all" shorthand doesn't accept any
value other than the CSS-wide keywords.

MozReview-Commit-ID: BmT7kGwC0ZQ

--HG--
extra : rebase_source : 094d764007359cb928f4c31a3818448f254a4043
extra : source : 10d25cf7b4ff2b5615a638031f98dc6163708545
2018-04-26 09:01:02 +10:00
Xidorn Quan
68b65ee807 Bug 1455576 part 2 - Add a ValueInfo trait for exposing types needed by devtools. r=emilio
Most of types just derive it using proc_macro directly. Some of value
types need manual impl.

In my current plan, this new trait will be used in bug 1434130 to expose
values as well.

MozReview-Commit-ID: LI7fy45VkRw

--HG--
extra : rebase_source : a765e43b0c615e5f47bddb90ba6fa24bfc06959e
extra : source : 60812c1b190d90602bc6d49477fe1f558a53cd51
2018-04-26 09:01:02 +10:00
Emilio Cobos Álvarez
986f7acaf7 No bug - Cherry-pick servo build fixes for style and fix style unit tests. r=me
MozReview-Commit-ID: 857HqA1oK66
2018-04-25 16:51:29 +02:00
Emilio Cobos Álvarez
ec8bd0a587 Bug 1456471: Unify MediaList and ServoMediaList. r=xidorn
MozReview-Commit-ID: KFWxoohpGlb
2018-04-25 10:37:04 +02:00
Brad Werth
a8b478eae0 Bug 1265342 Part 0: Servo changes to add shape-margin. r=xidorn
MozReview-Commit-ID: 99pLZsFA9mj

--HG--
extra : rebase_source : 0bae04ddf428eb8ee54d91d13401b756b9951cfd
2018-02-08 11:00:56 -08:00
Bobby Holley
e7c9ddc0cf Bug 1455784 - Update StyleSource to use ArcUnion. r=Manishearth
MozReview-Commit-ID: AT4sud9goGV
2018-04-25 09:23:01 -07:00
Bobby Holley
fd27f59cc5 Bug 1455784 - ArcUnion. r=Manishearth
MozReview-Commit-ID: Jxp2A7cj6CV
2018-04-25 09:22:49 -07:00
Narcis Beleuzu
a07765b336 Backed out 20 changesets (bug 1265342) for mochitest-plain-headless failures on layout/style/test/test_first_letter_restrictions.html. CLOSED TREE
Backed out changeset 6c80ec2d0398 (bug 1265342)
Backed out changeset 62d571916086 (bug 1265342)
Backed out changeset fd247f38f8a7 (bug 1265342)
Backed out changeset 83aee3dafe4b (bug 1265342)
Backed out changeset 9b200122014e (bug 1265342)
Backed out changeset a90aa063b2fd (bug 1265342)
Backed out changeset 0791ff3d9194 (bug 1265342)
Backed out changeset 7109288f10b3 (bug 1265342)
Backed out changeset 048cce2fb99f (bug 1265342)
Backed out changeset c8e3dbc6c729 (bug 1265342)
Backed out changeset 09da0968333a (bug 1265342)
Backed out changeset d16f7ff85677 (bug 1265342)
Backed out changeset 53eb7f14463d (bug 1265342)
Backed out changeset 64fc631ef122 (bug 1265342)
Backed out changeset 332382c708e1 (bug 1265342)
Backed out changeset a8695981eec0 (bug 1265342)
Backed out changeset ce473fa5f1f4 (bug 1265342)
Backed out changeset 5ee470e75a53 (bug 1265342)
Backed out changeset 802aa95a52d9 (bug 1265342)
Backed out changeset 5da0c34c9600 (bug 1265342)
2018-04-24 22:31:15 +03:00
Brad Werth
ccd77e590d Bug 1265342 Part 0: Servo changes to add shape-margin. r=xidorn
MozReview-Commit-ID: 99pLZsFA9mj

--HG--
extra : rebase_source : 5f97af5d405bbec811b166326ebeb4c09e7cf9a8
2018-02-08 11:00:56 -08:00
Margareta Eliza Balazs
fa0ffa186e Merge mozilla-central to autoland. a=merge CLOSED TREE
--HG--
rename : toolkit/mozapps/extensions/internal/XPIProviderUtils.js => toolkit/mozapps/extensions/internal/XPIDatabase.jsm
2018-04-24 14:51:28 +03:00
Mats Palmgren
314470600f Bug 1398482 part 1 - [css-grid][css-flexbox][css-multicol] Add 'row-gap' and 'gap' properties; make 'grid-[column|row]-gap' and 'grid-gap' alias the respective unprefixed properties (Stylo part). r=emilio
This also makes 'normal' the initial value for the grid-*
properties, per:
https://github.com/w3c/csswg-drafts/issues/2294#issuecomment-369313438
2018-04-24 01:52:51 +02:00
Emilio Cobos Álvarez
158c258b7e Bug 1426516: Remove Valgrind workaround to make ::slotted use the rule hash. r=me
MozReview-Commit-ID: 2q14kHjajIr
2018-04-23 20:37:11 +02:00
Emilio Cobos Álvarez
4939ae347e Bug 1455032: Pack the shadow cascade order in ApplicableDeclarationBlock. r=heycam
I didn't bother not shifting there. We need to load the whole thing and shift
for at least one of cascade level / shadow cascade order.

Callers of level() other than for_rule_tree are non-existent in release builds,
so we'd be doing the shift anyway. I can implement the same thing for
shadow_cascade_order too, but I don't think that optimization is measurable in
any way, either, the compiler should make the decision.

And just in case, the simpler version actually generated less instructions in:

  https://play.rust-lang.org/?gist=ceadb0d3cbce4eeca76e4d9ab9a1c744&version=nightly

with the simple thing.

MozReview-Commit-ID: 8xPBJmlcyKh
2018-04-24 10:44:57 +02:00
Emilio Cobos Álvarez
6064fc5ef9 Bug 1454883: Only parse font-stretch keywords in the font shorthand. r=xidorn
MozReview-Commit-ID: 4BqnOSz83w4
2018-04-23 18:22:08 +02:00
Jonathan Watt
156c4af1ec Bug 1436048: Use user defined types for font-stretch / font-style. r=jfkthame,jwatt
Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io>

MozReview-Commit-ID: 7ONYtICeAqb
2018-04-23 18:22:05 +02:00
Emilio Cobos Álvarez
0c4a2fffdf Bug 1455358: Cleanup (a bit) system font copypasta. r=xidorn
If I had to write that again I would've killed myself :).

This is still not perfect, and the system font code is still quite a mess, but
well, little steps.

MozReview-Commit-ID: BmrZlCSejo7
2018-04-23 16:56:58 +02:00
Emilio Cobos Álvarez
5f8d28da11 Bug 1455358: Fix clamping on animations. r=xidorn
MozReview-Commit-ID: Awyub0dMOmq
2018-04-23 16:56:57 +02:00
Emilio Cobos Álvarez
e826b60e6a Bug 1455358: Use a generic type in preparation to fix animation. r=xidorn
Apart from a bit more code reuse.

MozReview-Commit-ID: 2BNOK6v30lX
2018-04-23 16:56:56 +02:00