Commit Graph

18645 Commits

Author SHA1 Message Date
Greg Tatum
2ade1a1b96 Bug 1597376 - Implement the new about:profiling page; r=julienw
This patch adds a new context for the performance-new components. It's
eventually the only place where the settings will live, but for now
the components share the settings between the popup, the devtools panel,
and the about:profiling page.

This page uses the base styling that the preferences page uses. The styles
should obey the theming for the browser, and ignore the devtools theming
colors.

Differential Revision: https://phabricator.services.mozilla.com/D55010

--HG--
extra : moz-landing-system : lando
2019-12-04 22:23:46 +00:00
Greg Tatum
c29911fdb8 Bug 1597376 - Make the summary dropdowns conditional in the profiler settings; r=julienw
This is probably the biggest change to the existing components, as it makes the
summary dropdowns conditional based on the page context. This keeps the old
workflow working, but allows for the new about:profiling page's design. Most
of the diff here is creating the new _renderSection method which consolidates
this logic, and also handles the summary div structure.

Differential Revision: https://phabricator.services.mozilla.com/D55009

--HG--
extra : moz-landing-system : lando
2019-12-04 22:23:31 +00:00
Greg Tatum
6cba996a44 Bug 1597376 - Change the isPopup flag to a PageContext; r=julienw
The new about:profiling page creates some more complexity around what
the page context is. It is simpler to handle the different cases with
a union, rather than booleans.

Differential Revision: https://phabricator.services.mozilla.com/D55008

--HG--
extra : moz-landing-system : lando
2019-12-04 22:23:17 +00:00
Greg Tatum
805e67f354 Bug 1597376 - Break out profiler event handling into a separate component; r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D55007

--HG--
rename : devtools/client/performance-new/components/Perf.js => devtools/client/performance-new/components/DevToolsAndPopup.js
extra : moz-landing-system : lando
2019-12-04 22:23:02 +00:00
Greg Tatum
086d2b5725 Bug 1598320 - Add types to the performance-new components; r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D54771

--HG--
extra : moz-landing-system : lando
2019-12-04 22:22:42 +00:00
Greg Tatum
246f170a3d Bug 1597373 - Create a minimal about:profiling page; r=jdescottes,mconley
This commit is fairly trivial, but creates the about:profiler page to
start the new about:profiler work.

Differential Revision: https://phabricator.services.mozilla.com/D53729

--HG--
extra : moz-landing-system : lando
2019-12-04 22:22:30 +00:00
Patrick Brosset
8eaec07a8d Bug 1601219 - Use the right PageStyleFront instance when querying computed styles from the color picker; r=rcaliman
It looks like we left out some places in the inspector when we made it fission-compatible.
The color-picker, in particular, needs access to the selected node's computed style for its
color contrast logic.
We used to access this on the top-level target PageStyleFront. We just need to change this so
it uses the one contextual to the selected node.

Differential Revision: https://phabricator.services.mozilla.com/D55962

--HG--
extra : moz-landing-system : lando
2019-12-05 14:04:57 +00:00
Julian Descottes
81e34d9437 Bug 1600333 - Remove all tags = clipboard from the codebase r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D55305

--HG--
extra : moz-landing-system : lando
2019-12-05 11:07:10 +00:00
Julian Descottes
00ecd06c21 Bug 1600185 - Fix DevTools inplace editor single line mode detection r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D55847

--HG--
extra : moz-landing-system : lando
2019-12-05 11:08:16 +00:00
Michael Ratcliffe
f1c47b5478 Bug 1597890 - [Storage] Don't log an error if private field headers are not localized r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D55935

--HG--
extra : moz-landing-system : lando
2019-12-05 10:50:41 +00:00
Michael Ratcliffe
feebcdd788 Bug 1599408 - Fix scrolling at narrow widths in the Changes View r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D55654

--HG--
extra : moz-landing-system : lando
2019-12-03 14:53:59 +00:00
Daisuke Akatsuka
cc09f182eb Bug 1589178: Use TargetList api for markup view. r=jdescottes,rcaliman
Depends on D54872

Differential Revision: https://phabricator.services.mozilla.com/D55616

--HG--
extra : moz-landing-system : lando
2019-12-05 09:19:52 +00:00
Logan Smyth
5b6b224f2a Bug 1592431 - Part 1: Rename Debugger.Frame.prototype.live to .onStack. r=jimb
Differential Revision: https://phabricator.services.mozilla.com/D54488

--HG--
rename : js/src/jit-test/tests/debug/Frame-live-01.js => js/src/jit-test/tests/debug/Frame-onStack-01.js
rename : js/src/jit-test/tests/debug/Frame-live-02.js => js/src/jit-test/tests/debug/Frame-onStack-02.js
rename : js/src/jit-test/tests/debug/Frame-live-03.js => js/src/jit-test/tests/debug/Frame-onStack-03.js
rename : js/src/jit-test/tests/debug/Frame-live-04.js => js/src/jit-test/tests/debug/Frame-onStack-04.js
rename : js/src/jit-test/tests/debug/Frame-live-05.js => js/src/jit-test/tests/debug/Frame-onStack-05.js
rename : js/src/jit-test/tests/debug/Frame-live-06.js => js/src/jit-test/tests/debug/Frame-onStack-06.js
rename : js/src/jit-test/tests/debug/Frame-live-07.js => js/src/jit-test/tests/debug/Frame-onStack-07.js
extra : moz-landing-system : lando
2019-12-05 04:28:00 +00:00
Jonathan Kew
c66ada7245 Bug 770780 - Enable CSS text-underline-position property on Nightly builds. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D54724

--HG--
extra : moz-landing-system : lando
2019-12-04 11:37:25 +00:00
Jonathan Kew
3b87f01682 Bug 770780 - Add support for parsing of the CSS text-underline-position property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D54722

--HG--
extra : moz-landing-system : lando
2019-12-04 11:39:15 +00:00
Micah Tigley
36fbdc3e9d Bug 1599635 - Return the root node if no valid iframe nodeFront can be found after a reload. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D55564

--HG--
extra : moz-landing-system : lando
2019-12-04 18:52:02 +00:00
Ciure Andrei
7229b5803b Backed out 5 changesets (bug 1595154) for causing talos performance tests failures CLOSED TREE
Backed out changeset 498f750ed88a (bug 1595154)
Backed out changeset 45481561c120 (bug 1595154)
Backed out changeset 8ca3c106fc8d (bug 1595154)
Backed out changeset 7ffa8f958d0a (bug 1595154)
Backed out changeset 444505b4936b (bug 1595154)

--HG--
rename : browser/extensions/formautofill/FormAutofillChild.jsm => browser/extensions/formautofill/content/FormAutofillFrameScript.js
2019-12-04 21:07:05 +02:00
Brian Hackett
bb5b75599f Bug 1594617 - Watch for missing targets, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D55657

--HG--
extra : moz-landing-system : lando
2019-12-04 16:55:34 +00:00
Coroiu Cristina
19afee19fd Backed out changeset 55171ff3d0f3 (bug 1600979) for devtools failures at devtools/client/debugger/test/mochitest/browser_dbg-event-breakpoints.js on a CLOSED TREE 2019-12-04 19:14:31 +02:00
Brian Hackett
ced26dd8f6 Bug 1596934 - Fix attaching to inactive service workers, r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D53280

--HG--
extra : moz-landing-system : lando
2019-12-04 16:22:28 +00:00
Micah Tigley
4be2734cca Bug 1595800 - Part 4: Update RDM to use setRDMPaneOrientation from BrowsingContext r=bradwerth
Depends on D55002

Differential Revision: https://phabricator.services.mozilla.com/D55017

--HG--
extra : moz-landing-system : lando
2019-12-04 14:58:20 +00:00
Neil Deakin
0fe11bd612 Bug 1595154, replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D52721

--HG--
rename : browser/extensions/formautofill/content/FormAutofillFrameScript.js => browser/extensions/formautofill/FormAutofillChild.jsm
extra : moz-landing-system : lando
2019-12-04 11:45:10 +00:00
Brian Hackett
6638ae836c Bug 1600979 - Ignore exceptions from getFrames call when thread context is invalid, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D55692

--HG--
extra : moz-landing-system : lando
2019-12-03 20:10:27 +00:00
Julian Descottes
7a0e6b4873 Bug 1509804 - Add smoke test for HAR automation r=Honza
Depends on D55204

This is just a smoke test to verify that the HAR file is created.
We should probably expand this and test the content as well, but we can handle that in follow up bugs

Differential Revision: https://phabricator.services.mozilla.com/D55271

--HG--
extra : moz-landing-system : lando
2019-12-04 13:15:08 +00:00
Julian Descottes
175613ea9d Bug 1509804 - Temporary fix for HAR automation r=Honza
This fixes several gaps:
- event api changes
- networkEvent no longer emitted by debugger client
- shape of expected HAR items changed
- use the connector from the netmon api

This is the minimum set of changes I could do to get HAR automation to save valid HAR files again.

Differential Revision: https://phabricator.services.mozilla.com/D55204

--HG--
extra : moz-landing-system : lando
2019-12-04 12:59:21 +00:00
Edward Billington
db694deaca Bug 1579663 - Allow data url background-image in styled console logs r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D55376

--HG--
extra : moz-landing-system : lando
2019-12-04 09:31:54 +00:00
Nicolas Chevobbe
798dfc896c Bug 1567849 - Use ad-hoc console front for calls to evaluateJSAsync with selectedObjectActor. r=jdescottes.
When the selectedObjectActor options is passed to the evaluateJSAsync
command in the console, we now try to retrieve the corresponding console
front to send the request to the correct target.
This makes the "Copy Object" context menu entry works in the Browser Console
on content objects.
A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D55258

--HG--
extra : moz-landing-system : lando
2019-12-04 09:06:00 +00:00
Nicolas Chevobbe
0084d6e4c0 Bug 1579090 - Fix how ObjectFronts are created in the inspector. r=rcaliman.
The objectFront constructor signature changed, so this patch adapt
the inspector to the new one.

Differential Revision: https://phabricator.services.mozilla.com/D54512

--HG--
extra : moz-landing-system : lando
2019-12-04 09:05:43 +00:00
Nicolas Chevobbe
a9cd0bb1d3 Bug 1579090 - Fix DOM panel after WebConsoleFronts changes. r=Honza.
This makes the DOM panel handle ObjectFronts.

Differential Revision: https://phabricator.services.mozilla.com/D54511

--HG--
extra : moz-landing-system : lando
2019-12-04 09:05:19 +00:00
Nicolas Chevobbe
a96016d5aa Bug 1579090 - Fix debugger after changes made to WebConsoleFront methods. r=jlast.
This makes the Preview popup and the Watch Expression panel works
with ObjectFronts.

Differential Revision: https://phabricator.services.mozilla.com/D54510

--HG--
extra : moz-landing-system : lando
2019-12-04 09:05:17 +00:00
Nicolas Chevobbe
b4b0150837 Bug 1579090 - Support ObjectFronts in WebConsole. r=Honza.
Since we may now have ObjectFronts in console messages as
well as in evaluation results, we need to make the webconsole
consume those fronts.

And because we have ObjectFronts, we can now avoid using the
DebuggerClient to release the actors, and simply call front.release.
This simplifies how we track created object, since we only need
to release "root" objects, which will also cause all the sub-fronts
to be released as well. Sadly, this was causing some test failures
in mochitests because some objects were released while the connection
was closed, so we now emit an event when all the actors are released,
which we track in tests to wait until everything is over.

As a side effect, we need to change how we handle stubs for
our tests, since fronts have cycical references and can't
be serialized directly. In order to handle that, we serialize
all front as a plain object with a `_grip` property, containing
the object grip. In the stub file, we don't expose the grips
directly, but Maps that contain those stubs "rehydrated": when
a _grip object is encountered, it's turned back into a front.

Differential Revision: https://phabricator.services.mozilla.com/D54509

--HG--
extra : moz-landing-system : lando
2019-12-04 09:03:53 +00:00
Nicolas Chevobbe
5359a3b7e8 Bug 1579090 - Make ObjectInspector and Reps work with object fronts. r=Honza,jlast.
This patch make it so ObjectInspector can handle both simple grips and fronts.
The main idea is that we can now pass a `front` property to ObjectInspector nodes,
that will then be used to retrieve properties on the object.

Differential Revision: https://phabricator.services.mozilla.com/D54508

--HG--
extra : moz-landing-system : lando
2019-12-04 09:03:20 +00:00
Nicolas Chevobbe
757afcf029 Bug 1579090 - Fix server and shared tests that were failing because of the webConsoleFront changes. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D54507

--HG--
extra : moz-landing-system : lando
2019-12-04 09:02:47 +00:00
Nicolas Chevobbe
b2e044ccd4 Bug 1579090 - Make WebConsoleFront, PropertyIteratorFront, SymbolIteratorFront and ObjectFront return adhoc fronts (or primitive) when needed. r=jlast.
This is the first part of a bigger patch to make WebConsoleFront methods
consumers handle fronts instead of plain grips.
The main challenge with most of console methods is that the server
can return either a primitive, an object that represent a primitive
(undefined, null, Infinity, ...), a longString grip or an object grip.

Since this would be complex to map as a protocol.js type, this patch
either override the methods where we want to return fronts, or intercept
events with the `before` method on them.

The response is then handled to a function that will iteratore of the
result object in a recursive manner, and create fronts when needed.

Differential Revision: https://phabricator.services.mozilla.com/D54506

--HG--
extra : moz-landing-system : lando
2019-12-04 09:02:24 +00:00
Nicolas Chevobbe
fc6a8e2c21 Bug 1579090 - Change how ObjectFront is exported. r=rcaliman.
We export it as a named property to match other fronts, and
also because we plan to add a helper function in the file
that will need to be exported as well.

Differential Revision: https://phabricator.services.mozilla.com/D54136

--HG--
extra : moz-landing-system : lando
2019-12-04 09:01:57 +00:00
Razvan Caliman
8ff3343c9b Bug 1566891 - Remove expired telemetry probes for export options. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D55073

--HG--
extra : moz-landing-system : lando
2019-12-03 11:08:55 +00:00
Nicolas Chevobbe
843d235c75 Bug 1591874 - Move VariablesView files to devtools/client/storage. r=miker.
Since the storage inspector is the last consumer of the VariablesView,
it makes sense to move the component directly in the storage inspector
folder.
Since it can't have a controller, the bits where we were checking this
are removed.

Differential Revision: https://phabricator.services.mozilla.com/D54734

--HG--
rename : devtools/client/shared/widgets/VariablesView.jsm => devtools/client/storage/VariablesView.jsm
extra : moz-landing-system : lando
2019-12-04 07:30:26 +00:00
Nicolas Chevobbe
bb864342f1 Bug 1529917 - Remove VariablesViewController.jsm. r=miker.
It isn't used anywhere, so we can safely remove it.

Differential Revision: https://phabricator.services.mozilla.com/D54733

--HG--
extra : moz-landing-system : lando
2019-12-04 07:30:08 +00:00
Daisuke Akatsuka
c1a5f78cf6 Bug 1306198: Add a test to confirm the content of device item in the modal. r=pbro,mtigley
Depends on D55255

Differential Revision: https://phabricator.services.mozilla.com/D55256

--HG--
extra : moz-landing-system : lando
2019-12-03 21:11:26 +00:00
Daisuke Akatsuka
2e58dbc7f8 Bug 1306198: Add an unit test for user agent parser. r=pbro,mtigley
Depends on D55254

Differential Revision: https://phabricator.services.mozilla.com/D55255

--HG--
extra : moz-landing-system : lando
2019-12-04 05:59:22 +00:00
Daisuke Akatsuka
5b8c84f292 Bug 1306198: Change the tooltip of device items in the device modal. r=pbro,mtigley,flod
Depends on D55253

Differential Revision: https://phabricator.services.mozilla.com/D55254

--HG--
extra : moz-landing-system : lando
2019-12-03 21:05:17 +00:00
Daisuke Akatsuka
b16e4c7bf1 Bug 1306198: Show device info on device selector button. r=pbro,mtigley
Depends on D55252

Differential Revision: https://phabricator.services.mozilla.com/D55253

--HG--
extra : moz-landing-system : lando
2019-12-04 05:27:01 +00:00
Daisuke Akatsuka
50e7c1750d Bug 1306198: Show browser and os info on the device menu item. r=pbro,mtigley
Depends on D55251

Differential Revision: https://phabricator.services.mozilla.com/D55252

--HG--
extra : moz-landing-system : lando
2019-12-03 21:10:28 +00:00
Daisuke Akatsuka
d929922b9c Bug 1306198: Show browser and os info which is from the UA in the device list. r=pbro,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D55250

--HG--
extra : moz-landing-system : lando
2019-12-03 20:01:58 +00:00
Daisuke Akatsuka
ec62ad99c9 Bug 1306198: Introduce user agent parser. r=pbro,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D55607

--HG--
extra : moz-landing-system : lando
2019-12-04 06:00:37 +00:00
Gurzau Raul
9510cd391a Backed out 4 changesets (bug 1595800) for failing at browser_orientationchange_event.js on a CLOSED TREE.
Backed out changeset c78cb9bbddb9 (bug 1595800)
Backed out changeset 558449ce7d0a (bug 1595800)
Backed out changeset ef7f9e251137 (bug 1595800)
Backed out changeset 2167343f5bd3 (bug 1595800)
2019-12-04 02:27:04 +02:00
Micah Tigley
70e381a66a Bug 1595800 - Part 4: Update RDM to use setRDMPaneOrientation from BrowsingContext r=bradwerth
Depends on D55002

Differential Revision: https://phabricator.services.mozilla.com/D55017

--HG--
extra : moz-landing-system : lando
2019-12-03 20:00:13 +00:00
Michael Hoffmann
7011479978 Bug 1595677 - Support dark mode profiler popup in default theme for Win and Mac r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D55116

--HG--
extra : moz-landing-system : lando
2019-12-03 13:32:12 +00:00
Brindusan Cristian
4709de082d Backed out 4 changesets (bug 1595800) for devtools failures at browser_contextual_identity.js. CLOSED TREE
Backed out changeset 7d6f51331aed (bug 1595800)
Backed out changeset d44c8dde04be (bug 1595800)
Backed out changeset 2f607bbc19b9 (bug 1595800)
Backed out changeset 196ca9fefb06 (bug 1595800)
2019-12-03 19:44:37 +02:00
Brindusan Cristian
eaecab785f Backed out 2 changesets (bug 1529917, bug 1591874) for ESlint failure on VariablesView.jsm. CLOSED TREE
Backed out changeset a7f97f586d04 (bug 1591874)
Backed out changeset acbd48303fb3 (bug 1529917)

--HG--
rename : devtools/client/storage/VariablesView.jsm => devtools/client/shared/widgets/VariablesView.jsm
2019-12-03 19:20:19 +02:00