As audio track sample and video track sample are both using the same code pattern, we can eliminate
redundant codes.
Differential Revision: https://phabricator.services.mozilla.com/D6216
--HG--
extra : moz-landing-system : lando
`webExtension` in bootstrap.js's `start` and `stop` functions is an `EmbeddedExtension`, and `startupReason` and the `reason` argument passed to `stop` is a numeric reason. `EmbeddedExtension.startup` and `shutdown` take string reasons, not numeric reasons, contrary to their jsdocs.
Also, we can use `AddonManagerPrivate` instead of hardcoding `APP_STARTUP` and `APP_SHUTDOWN`.
This patch fixes bug 1483033.
Differential Revision: https://phabricator.services.mozilla.com/D6114
--HG--
extra : moz-landing-system : lando
The jsdoc params for `EmbeddedExtension.startup` and `shutdown` don't seem to be right. These methods expect string reasons, not numeric reasons.
Also, when `startup` creates a new `Extension`, it passes only one argument, the add-on data, and when it calls `extension.startup`, it passes a reason, but that's wrong. `Extension`'s constructor expects the reason as its second argument, and `startup` doesn't take any arguments at all.
Differential Revision: https://phabricator.services.mozilla.com/D6113
--HG--
extra : moz-landing-system : lando
* We get the shared colours (including hover) and dropmarker.
* Makes it harder to regress the clickable area of the <rich-select> since the problem will be visible.
* Hides the text for the closed state of the <select> so the <rich-option> text can be presented.
Differential Revision: https://phabricator.services.mozilla.com/D6330
--HG--
extra : moz-landing-system : lando
The site identity security indicator machinery treats connections where the TLS
handshake failed as insecure (also referred to as "unknown identity"). Before
bug 1468222, such cases were easily detectable as the SSLStatus field of the
relevant nsITransportSecurityInfo would be null. When we merged nsISSLStatus
into nsITransportSecurityInfo, we didn't take this differentiation into account.
This patch brings back the prior behavior by checking if the securityInfo's
securityState indicates that the handshake failed (i.e. it is
STATE_IS_INSECURE).
Differential Revision: https://phabricator.services.mozilla.com/D6316
--HG--
extra : moz-landing-system : lando
This change is mainly to avoid the use of SetAllFDsToCloseOnExec, which
has an unavoidable race condition that can leak file descriptors into
child processes. The "Linux" implementation of child process creation,
now that B2G support has been removed, is essentially a generic Unix
fork+dup2+execve which works on BSD (and is already used on Solaris).
3% download protection remote lookup failures are from timeout.
Increase the timeout from 10sec to 15sec to see if this help.
Differential Revision: https://phabricator.services.mozilla.com/D5265
--HG--
extra : moz-landing-system : lando
Telemetry::APPLICATION_REPUTATION_REMOTE_LOOKUP_RESPONSE_TIME can be
used to give us an idea how could we adjust the timeout accordingly.
Differential Revision: https://phabricator.services.mozilla.com/D5264
--HG--
extra : moz-landing-system : lando
Right now no matter it is timeout or not, we will always add the counter
to the false case of APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT.
We should only set the counter(false) when it is not timeout.
Differential Revision: https://phabricator.services.mozilla.com/D5263
--HG--
extra : moz-landing-system : lando
The content of e.target has been changed in bug 1375319 from document
to the fullscreen element, so the current code makes it never dispatch
DOMFullScreen:Start, so the Java side would not be aware of such state.
This code was initially added in bug 859683 for supporting scrolling
when the fullscreen element is the document element. Since then, it
seems that the related code had been refactored, and the only usage
of rootElement was removed in bug 1416330.
Because of that, it is no longer necessary to use event target, and
we can just use document directly, which would fix this issue.
Differential Revision: https://phabricator.services.mozilla.com/D6221
--HG--
extra : moz-landing-system : lando
WebMs with encrypted tracks may have unencrypted samples in these tracks.
Previously we would populate some of the crypto metadata on these samples. This
data was correct, but it was potentially misleading to include crypto metadata on
clear samples.
This changeset alters the behaviour so that we do not populate any such data for
unencrypted packets. This should not alter existing behaviour, notably the
Widevine CDM version 9 should continue to work. However, this change makes our
samples easier to feed to version 10 of the CDM. Without this change, we would
need to do extra conversion steps to appease the new CDM.
Differential Revision: https://phabricator.services.mozilla.com/D6183
--HG--
extra : moz-landing-system : lando
This links together the controller with the input and view. It moves the fake results generation to the controller. As a result, there is now an input -> controller -> view round-trip in place.
Also hooks up the input with determining if we're in private browsing mode or not.
Differential Revision: https://phabricator.services.mozilla.com/D6261
--HG--
extra : moz-landing-system : lando
Changes the wpt manifest path to the topobjdir instead so it can be moved out of tree.
Other changes so that the manifest download and update, and |mach wpt| and |mach test <wpt-test>| work with the new path.
The manifest is also downloaded and updated when creating the tests-archive to ensure that it exists when we run tests on TC.
MozReview-Commit-ID: Fp6UsKJjhTU
Differential Revision: https://phabricator.services.mozilla.com/D5312
--HG--
extra : moz-landing-system : lando
nsITableEditor::InsertTableCell() is an XPCOM method but used internally. So,
HTMLEditor should implement it with a non-virtual method and all internal users
should use it instead.
Differential Revision: https://phabricator.services.mozilla.com/D6259
--HG--
extra : moz-landing-system : lando
In the Wayland we don't know the absolute position of the window, so we cannot
use it to determine on which monitor the window is. We need to use parent window
scale factor to scale popup windows, otherwise popup windows will be wrongly
placed in the hi+normal dpi monitor setup.
Differential Revision: https://phabricator.services.mozilla.com/D5528
--HG--
extra : moz-landing-system : lando
Because firefox can be closed with the toolbox in a half initialized state telemetry can throw if it expects a tool to be closing when no tools are fully initialized although this is completely expected. Here we simply choose not to report those errors because this is expected behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D4869
--HG--
extra : moz-landing-system : lando
This links together the controller with the input and view. It moves the fake results generation to the controller. As a result, there is now an input -> controller -> view round-trip in place.
Also hooks up the input with determining if we're in private browsing mode or not.
Differential Revision: https://phabricator.services.mozilla.com/D6261
--HG--
extra : moz-landing-system : lando
- Added definitions for the new telemetry events
- Send telemetry events for each AddonManager action on an extension.
- Ensure that telemetry events are sent also for the extension prompts.
Differential Revision: https://phabricator.services.mozilla.com/D4448
--HG--
extra : moz-landing-system : lando
nsITableEditor::InsertTableColumn() is an XPCOM method but it's used internally.
So, HTMLEditor should implement it with a non-virtual method and internal
users should use it instead.
Differential Revision: https://phabricator.services.mozilla.com/D6257
--HG--
extra : moz-landing-system : lando
