Commit Graph

1213 Commits

Author SHA1 Message Date
Cosmin Sabou
2bcf67572f Backed out changeset b67d5ecb31b3 (bug 1524261) for reftest failures on 1524261.html 2019-02-01 01:17:34 +02:00
Cosmin Sabou
033c6df6fc Backed out changeset 0cd1b2fd6e27 (bug 1524353) for reftest failures on 1524353.html 2019-02-01 01:04:22 +02:00
Kartikaya Gupta
3a44308a01 Bug 1524353 - Add a reftest to prevent regression. r=jrmuizel
The Google weather search result widget has an SVG inside a transform,
inside a scrollframe. The patch in bug 1523776 broke the clipping in
that the SVG elements would not get clipped by the scrollframe. This
reftest exercises that scenario.

Differential Revision: https://phabricator.services.mozilla.com/D18273
2019-01-31 16:57:37 -05:00
Kartikaya Gupta
0d86d135a8 Bug 1524261 - Add a reftest to prevent regression. r=jrmuizel
WhatsApp Web has emojis in divs with border-radius, inside a transform,
inside a scrollframe. The patch in bug 1523776 broke the clipping in
that scrolling the scrollframe would make the emoji visible outside the
scrollframe. This reftest replicates that scenario.

Differential Revision: https://phabricator.services.mozilla.com/D18272
2019-01-31 16:56:54 -05:00
Kartikaya Gupta
2030952357 Back out two changesets from bug 1523776 for causing multiple regressions. r=backout 2019-01-31 14:44:33 -05:00
Kartikaya Gupta
c8c588bf80 Bug 1523776 - Don't set the parent link when creating a new clip chain. r=kvark
It turns out that setting the parent link on a clip chain is no longer
needed (and probably hasn't been since WR started applying a stacking
context's clip to the SC's contents). In fact it can produce incorrect
behaviour in some cases, because it doesn't match the semantics of
Gecko's clip chains. This removes the parent link on the Gecko side and
adds a test for this scenario.

Differential Revision: https://phabricator.services.mozilla.com/D18101

--HG--
extra : moz-landing-system : lando
2019-01-30 21:39:38 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Dave Townsend
e81988481b Bug 1523738: Fix Version comparison functions. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D17978

--HG--
extra : moz-landing-system : lando
2019-01-29 21:03:33 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Andrew Osmond
b04c5a5091 Bug 1501195 - Fix snapping issues caused by translation only transforms. r=jrmuizel
In nsDisplayTransform::CreateWebRenderCommands we should be rounding the
translation from the reference frame if there is no other transformation
to better match non-WebRender which performs similar rounding in
ChooseScaleAndSetTransform.

Differential Revision: https://phabricator.services.mozilla.com/D14265
2019-01-23 12:15:41 -05:00
Andrew Osmond
dbc1b3ebee Bug 1494062 - Part 1. Add new crashtest reproducing the blob image wraplist clipping crash. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D16879
2019-01-18 07:59:56 -05:00
Ehsan Akhgari
e5e885ae31 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset

--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Dzmitry Malyshau
1ab11075de Bug 1520301 - Fix scroll frame default positioning r=jrmuizel
When scroll frames are created, and no explicit parent is provided,
the old code used to take the ClipID from the c/s stack. The stack
has been removed on WR side, and this parent assignment got lost.

This change takes the SpatialID from the top of the stack on Gecko
side to replicate the old behavior.

Differential Revision: https://phabricator.services.mozilla.com/D16732

--HG--
extra : moz-landing-system : lando
2019-01-17 16:43:08 +00:00
Cosmin Sabou
d28e15a531 Backed out changeset d4b7dbc0379f (bug 1520301) for reftest failures on gfx/tests/reftest/1519754.html. 2019-01-17 02:40:32 +02:00
Dzmitry Malyshau
ce39249b85 Bug 1520301 - Fix scroll frame default positioning r=jrmuizel
When scroll frames are created, and no explicit parent is provided,
the old code used to take the ClipID from the c/s stack. The stack
has been removed on WR side, and this parent assignment got lost.

This change takes the SpatialID from the top of the stack on Gecko
side to replicate the old behavior.

Differential Revision: https://phabricator.services.mozilla.com/D16732

--HG--
extra : moz-landing-system : lando
2019-01-16 21:00:05 +00:00
Dzmitry Malyshau
75e5c0c1d0 Bug 1505934 - WR: Don't establish a raster root in pictures with sufficiently large local bounds (take 2) r=jrmuizel
re-open of D16335, which got backed out due to Wrench test failing.
The test was failing because of different AA on a plane-splitting case, which isn't guaranteed anyway.
This revision updates the test.

Differential Revision: https://phabricator.services.mozilla.com/D16560

--HG--
extra : moz-landing-system : lando
2019-01-15 15:23:28 +00:00
Narcis Beleuzu
0e42fd473e Backed out changeset 58ebeaf27cf6 (bug 1505934) for wrench bustages. CLOSED TREE 2019-01-14 21:57:30 +02:00
Dzmitry Malyshau
afdaf603bf Bug 1505934 - WR: Don't establish a raster root in pictures with sufficiently large local bounds r=gw
Differential Revision: https://phabricator.services.mozilla.com/D16335

--HG--
extra : moz-landing-system : lando
2019-01-14 19:29:53 +00:00
Christoph Kerschbaumer
6756032512 Bug 1513241: Update frontend consumers of loadURI and pass loadURIOptions dictionary. r=gijs 2019-01-11 12:44:20 +01:00
Razvan Maries
665c57df8d Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-01-09 05:55:28 +02:00
Kartikaya Gupta
271033048d Bug 1513133 - Guard against creating an excessively large drawtarget. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D15254

--HG--
extra : moz-landing-system : lando
2019-01-09 01:41:47 +00:00
Jeff Muizelaar
fbf8ff4b88 Bug 1513017. Add crash test. 2019-01-08 18:39:26 -05:00
Kartikaya Gupta
f25b1be3f5 Bug 1509123 - Add crashtest. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D15461

--HG--
extra : moz-landing-system : lando
2018-12-28 16:09:58 +00:00
Mark Banner
ce668e4afd Bug 1515942 - Enable ESLint for gfx/ (manual fixes). r=kats
Differential Revision: https://phabricator.services.mozilla.com/D15206

--HG--
extra : moz-landing-system : lando
2018-12-27 09:45:01 +00:00
Mark Banner
4388f2968a Bug 1515942 - Enable ESLint for gfx/ (automatic fixes). r=kats
Differential Revision: https://phabricator.services.mozilla.com/D15205

--HG--
extra : moz-landing-system : lando
2018-12-27 09:44:38 +00:00
Kartikaya Gupta
09dccca832 Bug 1496194 - Ensure the inner sticky rect stays inside the outer sticky rect. r=botond
Depends on D15136

Differential Revision: https://phabricator.services.mozilla.com/D15137

--HG--
extra : moz-landing-system : lando
2018-12-21 22:37:28 +00:00
Kartikaya Gupta
b184eedbf0 Bug 1496194 - Add a RectAbsolute implementation for MoveInsideAndClamp. r=botond
Depends on D15135

Differential Revision: https://phabricator.services.mozilla.com/D15136

--HG--
extra : moz-landing-system : lando
2018-12-21 22:31:55 +00:00
Boris Chiou
c35f47093e Bug 1322780 - Part 2: Support unprefixed min-content and max-content. r=mats,emilio
Support unprefixed min-content and max-content and treat the prefixed
version as aliases for
1. width, min-width, max-width if inline-axis is horizontal, and
2. height, min-height, max-height if inline-axis is vertical, and
3. inline-size, min-inline-size, max-inline-size, and
4. flex-basis.

Besides, update the test cases to use unprefixed max-content and
min-content.

Depends on D7535

Differential Revision: https://phabricator.services.mozilla.com/D7536

--HG--
extra : moz-landing-system : lando
2018-12-18 18:47:37 +00:00
Bobby Holley
53a7fef91f Bug 1509099 - Crashtest. r=me 2018-12-13 13:57:39 -08:00
Mark Banner
8c00ef3f30 Bug 1512052 - Add more .eslintrc.js files for test directories. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D13746

--HG--
extra : moz-landing-system : lando
2018-12-11 13:15:08 +00:00
Bobby Holley
aa6f44ee39 Bug 1512799 - Update expected status in test_pref_rollout_workaround.py. r=kats 2018-12-10 13:35:53 -08:00
Matt Woodrow
e3453844bf Bug 1510853 - Introduce VsyncId and VsyncEvent for identifying vsyncs without timestamp comparisons. r=jrmuizel
MozReview-Commit-ID: 6TO6hYOdJYo

Differential Revision: https://phabricator.services.mozilla.com/D13757

--HG--
extra : moz-landing-system : lando
2018-12-07 23:27:28 +00:00
Ciure Andrei
22c96f2cb4 Backed out 4 changesets (bug 1510853) for TelemetryHistogramEnums.h build bustages CLOSED TREE
Backed out changeset 80baa7b09930 (bug 1510853)
Backed out changeset d1ef6db7fc28 (bug 1510853)
Backed out changeset ae190948ad73 (bug 1510853)
Backed out changeset 0ade0aa77b2f (bug 1510853)
2018-12-07 19:38:47 +02:00
Matt Woodrow
6c3cd9bd00 Bug 1510853 - Introduce VsyncId and VsyncEvent for identifying vsyncs without timestamp comparisons. r=jrmuizel
MozReview-Commit-ID: 6TO6hYOdJYo

Differential Revision: https://phabricator.services.mozilla.com/D13757

--HG--
extra : moz-landing-system : lando
2018-12-07 17:06:11 +00:00
Ciure Andrei
ed617be144 Backed out 2 changesets (bug 1512052)for causing build bustages CLOSED TREE
Backed out changeset 4773a3f46c22 (bug 1512052)
Backed out changeset 2f48c5afbe57 (bug 1512052)

--HG--
rename : browser/components/attribution/test/xpcshell/.eslintrc.js => browser/components/attribution/test/.eslintrc.js
2018-12-05 05:47:39 +02:00
Mark Banner
8256078237 Bug 1512052 - Add more .eslintrc.js files for test directories. r=mossop
Depends on D13745

Differential Revision: https://phabricator.services.mozilla.com/D13746

--HG--
extra : moz-landing-system : lando
2018-12-04 22:27:35 +00:00
Jonathan Kew
09aff89697 Bug 1458364 - Re-enable test_font_whitelist.asan on Windows/ASAN, as it no longer seems to fail there. r=dmajor 2018-12-01 15:29:10 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Kartikaya Gupta
573d3aec36 Bug 1508822 - Guard against trying to create an oversized DrawTargetRecording with WebRender. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D12950

--HG--
extra : moz-landing-system : lando
2018-11-26 18:14:59 +00:00
Kartikaya Gupta
bc812d01bd Bug 1508811 - Guard against trying to create an oversized DrawTargetRecording with WebRender. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D12677

--HG--
extra : moz-landing-system : lando
2018-11-23 16:43:48 +00:00
Chris Pearce
16512588df Bug 1503776 - Add marionette-gpu job. r=jmaher
In order to reduce the cost of running marionette tests on a virtual machine
with a GPU, add a marionette-gpu job, and run the WebRender rollout test added
in the previous patch in this new job.

Depends on D10528

Differential Revision: https://phabricator.services.mozilla.com/D12241

--HG--
extra : moz-landing-system : lando
2018-11-22 21:36:46 +00:00
Chris Pearce
f67b247a62 Bug 1503776 - Add test to verify WR qualified pref default value saved and respected on restart. r=bryce
Add test that when we restart the browser with a default value set on
gfx.webrender.all.qualified, Firefox saves that value and checks respects
the saved value when initializing WebRender.

Depends on D10527

Differential Revision: https://phabricator.services.mozilla.com/D10528

--HG--
extra : moz-landing-system : lando
2018-11-22 21:36:16 +00:00
Lee Salzman
7db9336472 Bug 1505426 - initialize SkMaskFilter flattenables. r=rhunt 2018-11-20 15:19:33 -05:00
Jeff Muizelaar
3654ccade6 Bug 1507686 - Record LayerManager URL for each paint so that we can correlate it with slow paints. r=mattwoodrow
MozReview-Commit-ID: 2RUWkboAOJz

--HG--
extra : rebase_source : 397fd432b4e9cba37a1ebca9dcc5a949f290c9d0
2018-11-19 20:55:28 +13:00
Ciure Andrei
d4102b2e26 Backed out changeset 01aa0dc6d098 (bug 1505426) for skia bustages CLOSED TREE 2018-11-20 07:03:08 +02:00
Lee Salzman
95c55ba47c Bug 1505426 - initialize SkMaskFilter flattenables. r=rhunt 2018-11-19 23:00:51 -05:00
Joel Maher
65cec285ac Bug 1507161 - adjust fuzzy-if statements for win10 tests that are failing on new windows10 ami image. r=ahal
adjust fuzzy-if statements for win10 tests that are fialing on new windows 10 ami image

Differential Revision: https://phabricator.services.mozilla.com/D11914

--HG--
extra : moz-landing-system : lando
2018-11-14 18:37:30 +00:00
Kartikaya Gupta
17eea57296 Bug 1466613 - Robustify DrawTargetRecording codepaths that create new drawtargets. r=mstange
Badly-behaved consumers of DrawTargetRecording can trigger recording of
draw calls that will fail to allocate required draw targets when the
recording is replayed. This patch tries to guard against this by
detecting these situations at record-time rather than crashing at
replay-time. When such a situation is detected, it will crash (for
content processes, to catch such scenarios) or gracefully fail (for
other processes).

Differential Revision: https://phabricator.services.mozilla.com/D11527

--HG--
extra : moz-landing-system : lando
2018-11-13 10:39:02 +00:00
Lee Salzman
0be53a4c8c Bug 1490704 - check rect size in RectIsInt32Safe. r=mattwoodrow 2018-11-12 17:09:12 -05:00
Csoregi Natalia
62d62e3e66 Backed out 2 changesets (bug 1503776) for marionette failures on gfx\tests\marionette\test_pref_rollout_workaround.py. CLOSED TREE
Backed out changeset 56f6234b17fc (bug 1503776)
Backed out changeset 838d9917f028 (bug 1503776)
2018-11-12 07:35:56 +02:00