Commit Graph

107 Commits

Author SHA1 Message Date
Mark Banner
15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Marcos Cáceres
65ea85a94c Bug 1603673 - Signal that we support web manifest processing in Fenix r=snorp,agi,ladybenko
When enabled, `link.relList.supports("manifest")` will return `true`.

Differential Revision: https://phabricator.services.mozilla.com/D58181

--HG--
extra : moz-landing-system : lando
2020-03-04 05:02:27 +00:00
Razvan Maries
e5f96b8645 Backed out changeset 27b9929438f8 (bug 1603673) for perma failures on browser_ssb_manifest_scope.js. CLOSED TREE 2020-03-04 06:34:48 +02:00
Marcos Cáceres
635fd4573d Bug 1603673 - Signal that we support web manifest processing in Fenix r=snorp,agi,ladybenko
When enabled, `link.relList.supports("manifest")` will return `true`.

Differential Revision: https://phabricator.services.mozilla.com/D58181

--HG--
extra : moz-landing-system : lando
2020-03-04 03:10:06 +00:00
Narcis Beleuzu
b2ccce862e Backed out changeset 2c1dd534e937 (bug 1603673) for geckoview failures on webAppManifestPref. CLOSED TREE 2020-02-27 08:50:39 +02:00
Marcos Cáceres
2cc840acbb Bug 1603673 - Signal that we support web manifest processing in Fenix r=snorp,agi,ladybenko
When enabled, `link.relList.supports("manifest")` will return `true`.

Differential Revision: https://phabricator.services.mozilla.com/D58181

--HG--
extra : moz-landing-system : lando
2020-02-26 18:41:59 +00:00
Noemi Erli
c534f17571 Backed out changeset fa5ee85e20a5 (bug 1603673) for causing lint failure in GeckoRuntimeSettings.java CLOSED TREE 2020-02-18 08:39:30 +02:00
Marcos Cáceres
ccfa51c524 Bug 1603673 - Signal that we support web manifest processing in Fenix r=snorp
When enabled, `link.relList.supports("manifest")` will return `true`.

Differential Revision: https://phabricator.services.mozilla.com/D58181

--HG--
extra : moz-landing-system : lando
2020-02-18 03:43:48 +00:00
shindli
ba0dcaf78d Backed out changeset 061d47c2c5c7 (bug 1603673) for mozlint failure in /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java CLOSED TREE 2020-02-18 05:39:05 +02:00
Marcos Cáceres
b5521fbef4 Bug 1603673 - Signal that we support web manifest processing in Fenix r=snorp
When enabled, `link.relList.supports("manifest")` will return `true`.

Differential Revision: https://phabricator.services.mozilla.com/D58181

--HG--
extra : moz-landing-system : lando
2020-02-18 03:11:12 +00:00
Coroiu Cristina
9490b63809 Backed out changeset b634b7b787d5 (bug 1609491) for wpt failures at /cookies/http-state/general-tests.html on a CLOSED TREE 2020-01-20 20:57:54 +02:00
Ehsan Akhgari
5a2d4ea5a4 Bug 1609491 - Stop accepting cookie name-value pairs without an equal sign; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D60040

--HG--
extra : moz-landing-system : lando
2020-01-20 15:59:12 +00:00
James Willcox
4400a92a46 Bug 1604917 - Coerce WebManifest colors to rrggbbaa ?marcosc,jdescottes r=marcosc,jdescottes
We then convert that to `#aarrggbb` in GeckoView for convenient use
with `android.graphics.Color`.

Differential Revision: https://phabricator.services.mozilla.com/D57689

--HG--
extra : moz-landing-system : lando
2019-12-23 15:29:08 +00:00
Kris Maglione
0b1a146519 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:36 +00:00
Kris Maglione
94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-13 20:36:16 +00:00
shindli
91924fedc7 Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Kris Maglione
356e59c6bc Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-10 23:07:22 +00:00
Kris Maglione
16a9b29848 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-10 23:07:13 +00:00
Marcos Cáceres
00bbf304ee Bug 1548424 - Check that Web App Manifest does not fetch using credentials by default r=baku
tests that confirm we are not sending credentials by default

Differential Revision: https://phabricator.services.mozilla.com/D49580

--HG--
extra : moz-landing-system : lando
2019-12-05 13:19:00 +00:00
Noemi Erli
82d41a33b2 Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione
bd497b1a21 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-07 18:44:34 +00:00
Kris Maglione
910eab35d2 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-07 19:11:58 +00:00
Daniel Varga
84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione
73e3d8bcf6 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744

--HG--
extra : moz-landing-system : lando
2019-12-06 22:15:25 +00:00
Kris Maglione
20da940e14 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
2019-12-06 22:14:14 +00:00
Marcos Cáceres
78f831bf6c Bug 1596040 - Teach HTMLLinkElement's relList about 'manifest' r=bzbarsky
Fenix wants to ship Web Manifest support, while other Firefox products (e.g., Desktop) don't support it.

With the pref enabled, developers can check, via `link.relList.supports()`, if manifest processing is supported by a particular product.

Differential Revision: https://phabricator.services.mozilla.com/D55064

--HG--
extra : moz-landing-system : lando
2019-12-06 04:17:04 +00:00
Dave Townsend
6379bd94ae Bug 1601526: Manifest scope should default to the directory of the resolved start_url. r=marcosc
Differential Revision: https://phabricator.services.mozilla.com/D55903

--HG--
extra : moz-landing-system : lando
2019-12-05 06:13:10 +00:00
Marcos Cáceres
0c3fbc1b1d Bug 1587793 - re-associate manifest with a browser when getting them from cache r=snorp
Addresses the problem of cached manifests having the wrong associated browser.
However, this is only temporary solution, as cached manifests can have different
associated browsers (e.g., if 3x more tabs are open, this will still potentially be racy).

Differential Revision: https://phabricator.services.mozilla.com/D49706

--HG--
extra : moz-landing-system : lando
2019-10-24 04:58:13 +00:00
Marcos Cáceres
f5706147e3 Bug 1575140 - Manifest ImageResource sizes should be an array r=baku
per spec, the ImageResource sizes member should be returned as an array.

Differential Revision: https://phabricator.services.mozilla.com/D42813

--HG--
extra : moz-landing-system : lando
2019-08-21 10:29:16 +00:00
Belén Albeza
5ac210ec83 Bug 1573786 - ManifestProcessor should throw error when parsing invalid JSON r=marcosc
Differential Revision: https://phabricator.services.mozilla.com/D42627

--HG--
extra : moz-landing-system : lando
2019-08-20 13:30:12 +00:00
Mark Banner
b1970e6a2f Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
These are raised as redeclares or unused variables by ESLint 6.

Differential Revision: https://phabricator.services.mozilla.com/D37268

--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
Marcos Cáceres
26bc3a959f Bug 1559412 - Support web app manifest ImageResource.purpose r=baku
implementation of purpose member

Differential Revision: https://phabricator.services.mozilla.com/D38627

--HG--
extra : moz-landing-system : lando
2019-08-15 12:55:35 +00:00
Marcos Cáceres
69d2abd930 Bug 1540695 - Omit credentials when fetching web manifest r=baku
Credentials should be excluded when requesting a web manifest.

Differential Revision: https://phabricator.services.mozilla.com/D29607

--HG--
extra : moz-landing-system : lando
2019-08-06 15:33:02 +00:00
Edwin Gao
b270bb1353 Bug 1561046 - remove API 17 from manifest files r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D39809

--HG--
extra : moz-landing-system : lando
2019-08-02 20:10:06 +00:00
André Bargull
1fe1b5271f Bug 1522070 - Part 18: Update 'lang' member test for Web manifest to match latest ECMA-402. r=marcosc
ECMA-402 changed the language tag specification from RFC-5646 BCP-47 language
tags to UTS 35 Unicode BCP-47 locale identifiers. Update the expected
canonicalisation results accordingly.

Depends on D37450

Differential Revision: https://phabricator.services.mozilla.com/D38642

--HG--
extra : moz-landing-system : lando
2019-07-19 13:37:47 +00:00
Marcos Cáceres
4d6c019baa Bug 1566018 - Return the URL of the manifest from manifest validation in object r=Ola,baku
returns a moz_manifest_url member when `{checkConformance: true}`

Differential Revision: https://phabricator.services.mozilla.com/D38311

--HG--
extra : moz-landing-system : lando
2019-07-17 14:04:19 +00:00
Marcos Cáceres
1118e89526 Bug 1563460 - Collect console messages generated by processing manifest for Dev Tools r=baku
This gets rid  of the sending warnings to the browser console. Instead, when the processor is explicitly asked to do so, it now collects spec violations into a `moz_validation` member.

To access the new manifest member, you can now pass a second argument to `ManifestObtainer.contentObtainManifest()` like so:

```
const manifest = await ManifestObtainer.contentObtainManifest(
      this.targetActor.window,
      { checkConformance: true }
);
manifest. moz_validation; // 🎉
```

Differential Revision: https://phabricator.services.mozilla.com/D36885

--HG--
extra : moz-landing-system : lando
2019-07-09 02:33:39 +00:00
Victor Porof
0a8ff0ad85 Bug 1561435 - Format dom/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35951

--HG--
extra : source : 62f3501af4bc1c0bd1ee1977a28aee04706a6663
2019-07-05 10:44:55 +02:00
Brian Grinstead
0d460e3432 Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky
This is split from the previous changeset since if we include dom/ the file size is too
large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27457

--HG--
extra : moz-landing-system : lando
2019-04-16 03:53:28 +00:00
Marcos Cáceres
6a3953940b Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp
We now return null when the manifest lacks a href or is missing.

Differential Revision: https://phabricator.services.mozilla.com/D26873

--HG--
extra : moz-landing-system : lando
2019-04-10 12:46:41 +00:00
Marcos Cáceres
f78caebcd5 Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp
Implement language tag validation and canonicalization for lang member

Differential Revision: https://phabricator.services.mozilla.com/D25713

--HG--
extra : moz-landing-system : lando
2019-04-11 01:35:21 +00:00
Brindusan Cristian
369ab2687e Backed out changeset ea2baf2c9ae7 (bug 1534756) for mochitest failures at test_ManifestProcessor_JSON.html. 2019-04-10 05:29:46 +03:00
Marcos Cáceres
585f841266 Bug 1534756 - Don't throw exception in ManifestObtainer if a document has no manifest r=snorp
We now return null when the manifest lacks a href or is missing.

Differential Revision: https://phabricator.services.mozilla.com/D26448

--HG--
extra : moz-landing-system : lando
2019-04-09 20:32:54 +00:00
Cosmin Sabou
e4a2cb3ab3 Backed out changeset c0394b2d9173 (bug 1534677) for m-e10s failures on test_ManifestProcessor_lang.html CLOSED TREE 2019-04-09 08:54:41 +03:00
Marcos Cáceres
e64738e122 Bug 1534677 - Verify lang member in ManifestProcessor.jsm r=snorp
Implement language tag validation and canonicalization for lang member

Differential Revision: https://phabricator.services.mozilla.com/D25713

--HG--
extra : moz-landing-system : lando
2019-04-08 17:08:51 +00:00
James Willcox
cf8b03cc76 Bug 1522451 - Resolve named CSS colors to RGB in Web Manifests r=marcosc
Differential Revision: https://phabricator.services.mozilla.com/D23025

--HG--
extra : moz-landing-system : lando
2019-03-20 14:44:29 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Julia
7e1563241b Bug 1508991 - Enable ESLint for dom/manifest/ (manual changes) r=Standard8,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13208

--HG--
extra : moz-landing-system : lando
2018-12-18 20:39:42 +00:00
Julia
d252be35ef Bug 1508991 - Enable ESLint for dom/manifest/ (automatic changes) r=Standard8,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D13207

--HG--
extra : moz-landing-system : lando
2018-12-18 20:38:43 +00:00