66 Commits

Author SHA1 Message Date
Nathan Froyd
cfb8fb313f Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg
This patch was generated by running:

```
perl -p -i \
     -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \
     -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \
     $FILE
```

against every .cpp and .h in mozilla-central, and then fixing up the
inevitable errors that happen as a result of matching C++ expressions with
regexes.  The errors fell into three categories:

1. Calling the convert functions with `std::string::c_str()`; these were
   changed to simply pass the string instead, relying on implicit conversion
   to `mozilla::Span`.
2. Calling the convert functions with raw pointers, which is not permitted
   with the copy functions; these were changed to invoke `MakeStringSpan` first.
3. Other miscellaneous errors resulting from over-eager regexes and/or the
   replacement not being type-aware.  These changes were reverted.

Differential Revision: https://phabricator.services.mozilla.com/D88903
2020-09-02 09:54:37 +00:00
Andrea Marchesini
5fa9480158 Bug 1658878 - Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D87059
2020-08-17 09:57:04 +00:00
Andrea Marchesini
27d564c279 Bug 1658878 - Isolate BlobURLs per agent-cluster, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D86914
2020-08-14 19:45:52 +00:00
Bogdan Tara
694be205aa Backed out 4 changesets (bug 1658878) for blob related leaks CLOSED TREE
Backed out changeset 0288ef9ab65b (bug 1658878)
Backed out changeset a5af0e097560 (bug 1658878)
Backed out changeset 33c4b81f99a1 (bug 1658878)
Backed out changeset 16a33c7b4ff3 (bug 1658878)
2020-08-14 22:41:05 +03:00
Andrea Marchesini
a4f8193237 Bug 1658878 - Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D87059
2020-08-14 17:39:26 +00:00
Andrea Marchesini
91ce718928 Bug 1658878 - Isolate BlobURLs per agent-cluster, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D86914
2020-08-14 16:59:44 +00:00
Mihai Alexandru Michis
33c1daa575 Backed out 4 changesets (bug 1658878) for causing failures in browser_blobURLIsolation.js
CLOSED TREE

Backed out changeset f69f80e5659f (bug 1658878)
Backed out changeset 20401a2adaa6 (bug 1658878)
Backed out changeset a8620aecc29f (bug 1658878)
Backed out changeset 3609760c1e5d (bug 1658878)
2020-08-14 19:55:25 +03:00
Andrea Marchesini
0920dd26fe Bug 1658878 - Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D87059
2020-08-14 15:57:45 +00:00
Andrea Marchesini
5c2811edd6 Bug 1658878 - Isolate BlobURLs per agent-cluster, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D86914
2020-08-14 10:41:22 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Andrea Marchesini
cdc1e1cd9a Bug 1612519 - Fix "Terminating worker revokes its URLs" WPT, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D61360

--HG--
extra : moz-landing-system : lando
2020-02-02 09:24:37 +00:00
Coroiu Cristina
1b1308abac Backed out changeset a422cac07967 (bug 1612519) for ESlint failure at browser/components/originattributes/test/browser/worker_blobify.js 2020-02-02 10:55:25 +02:00
Andrea Marchesini
167432e4c6 Bug 1612519 - Fix "Terminating worker revokes its URLs" WPT, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D61360

--HG--
extra : moz-landing-system : lando
2020-02-02 08:24:55 +00:00
Oana Pop Rus
d83b12a77d Backed out changeset c6b4bb8a2736 (bug 1612519) for bc failures in browser_blobURLIsolation.js on a CLOSED TREE 2020-02-01 17:04:17 +02:00
Andrea Marchesini
35bce0bd9c Bug 1612519 - Fix "Terminating worker revokes its URLs" WPT, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D61360

--HG--
extra : moz-landing-system : lando
2020-02-01 10:53:54 +00:00
Andrea Marchesini
2616cac8b3 Bug 1030481 - Remove nsIMutable, r=smaug
nsIMutable is used only by DOM Blob/File. But Blobs are immutable by spec.
FileBlobImpl has a couple of lazy member values, but those are called when
the object is cloned in order to be sent to a different thread/process.

Differential Revision: https://phabricator.services.mozilla.com/D58946

--HG--
extra : moz-landing-system : lando
2020-01-07 15:02:00 +00:00
Brindusan Cristian
ed883ce3f4 Backed out changeset 61101e3eebb3 (bug 1030481) for mochitest failures at test_file.xhtml. CLOSED TREE 2020-01-07 16:30:53 +02:00
Andrea Marchesini
4059db5bc7 Bug 1030481 - Remove nsIMutable, r=smaug
nsIMutable is used only by DOM Blob/File. But Blobs are immutable by spec.
FileBlobImpl has a couple of lazy member values, but those are called when
the object is cloned in order to be sent to a different thread/process.

Differential Revision: https://phabricator.services.mozilla.com/D58716

--HG--
extra : moz-landing-system : lando
2020-01-07 12:37:12 +00:00
Andrea Marchesini
7009293bd7 Bug 1558923 - Simplify URL API, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34766

--HG--
extra : moz-landing-system : lando
2019-06-13 19:45:19 +00:00
Narcis Beleuzu
8e2da98d46 Backed out 2 changesets (bug 1558923) for mochitest crashes on AssertIsOnMainThread(). CLOSED TREE
Backed out changeset 643de99320a8 (bug 1558923)
Backed out changeset f758b5ccd0c0 (bug 1558923)
2019-06-13 20:59:33 +03:00
Andrea Marchesini
ac563a2551 Bug 1558923 - Simplify URL API, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34766

--HG--
extra : moz-landing-system : lando
2019-06-13 16:23:11 +00:00
Noemi Erli
dec16f16c7 Backed out 2 changesets (bug 1558923) for failures in nsContentUtils.cpp
Backed out changeset 12c977801cb2 (bug 1558923)
Backed out changeset d8a688f1b7ce (bug 1558923)
2019-06-13 19:19:05 +03:00
Andrea Marchesini
b35598172a Bug 1558923 - Simplify URL API, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34766

--HG--
extra : moz-landing-system : lando
2019-06-13 15:10:24 +00:00
Cosmin Sabou
934be35969 Backed out 2 changesets (bug 1558923) for build bustages on dom/URL.h. CLOSED TREE
Backed out changeset 0bb5857422f2 (bug 1558923)
Backed out changeset d0411a373ace (bug 1558923)
2019-06-13 13:35:54 +03:00
Andrea Marchesini
ddcdb92776 Bug 1558923 - Simplify URL API, r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D34766

--HG--
extra : moz-landing-system : lando
2019-06-13 10:19:03 +00:00
Valentin Gosu
124a1062f6 Bug 1536744 - Rename NS_NewURIOnAnyThread to NS_NewURI. r=baku
The only protocol that can't be created off the main thread at the moment is
moz-extension, and that can be handled at a later time.

Differential Revision: https://phabricator.services.mozilla.com/D30713

--HG--
extra : moz-landing-system : lando
2019-05-28 14:17:04 +00:00
Andrea Marchesini
372070277d Bug 1543321 - Use nsContentUtils::GetThreadSafeUTFOrigin in the URL API, r=smaug
Depends on D26862

Differential Revision: https://phabricator.services.mozilla.com/D26863

--HG--
extra : moz-landing-system : lando
2019-04-10 08:05:00 +00:00
Andrea Marchesini
1fb706a4f0 Bug 1540514 - Use NS_NewURIOnAnyThread in URL API, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25534

--HG--
extra : moz-landing-system : lando
2019-03-31 17:21:17 +00:00
Ryan Hunt
00e98538aa Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D21106

--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Andrea Marchesini
bc5414c5f3 Bug 1471189 - Removing 'Terminating' state in workers, r=mrbkap 2018-07-12 19:33:41 +02:00
Andrea Marchesini
7ba8b77e07 Bug 1466023 - Separate FontTableURI and BlobURL, r=qdot
This patch splits FontTableURI and BlobURL in 2 classes:
FontTableURIProtocolHandler and BlobURLProtocolHandler
both under mozilla::dom.

It also removes a memory reporter because that report is already covered by the
BlobURL one.

--HG--
rename : dom/file/nsHostObjectProtocolHandler.cpp => dom/file/BlobURLProtocolHandler.cpp
rename : dom/file/nsHostObjectProtocolHandler.h => dom/file/BlobURLProtocolHandler.h
2018-06-02 15:51:42 +02:00
Emilio Cobos Álvarez
fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Andrea Marchesini
027c6e34d8 Bug 1454656 - Unify URLWorker and URLMainThread, r=smaug 2018-04-24 12:01:46 +02:00
Andrea Marchesini
48bf20fde9 Bug 1448328 - Use thread-safe nsIURI in the URI API - part 2 - No teardown runnable, r=valentin 2018-04-14 01:07:08 +02:00
Andrea Marchesini
4b23deda27 Bug 1448328 - Use thread-safe nsIURI in the URI API - part 1 - No getter/setter runnables, r=valentin 2018-04-14 01:06:35 +02:00
Henri Sivonen
ebe845c3c9 Bug 1448586 - Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark. r=smaug.
MozReview-Commit-ID: Cy8zkNWjsXM

--HG--
extra : rebase_source : 7d8669b096a0f7ca7a3788f82ba66c9cacdb93b8
2018-03-24 21:16:51 +02:00
Valentin Gosu
ed218f0a19 Bug 1433958 - Change code that sets nsIURI.scheme to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: GgyIkZSG2y3

--HG--
extra : rebase_source : 5398a29d8cb910c909ed88e1a6cbd9fd63e6b745
2018-02-26 20:43:47 +01:00
Valentin Gosu
7f3b09b694 Bug 1433958 - Change code that sets nsIURI.port to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: 7Lu7JJvDUGF

--HG--
extra : rebase_source : 8d5a9bb1c4a5a525f7c5bc8d07c1e7029d2029a3
2018-02-26 20:43:46 +01:00
Valentin Gosu
ec9082b60a Bug 1433958 - Change code that sets nsIURI.query to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: JKW8IsaFY10

--HG--
extra : rebase_source : 45ffa07c34739adf4de681fec1370645b0f74985
2018-02-26 20:43:46 +01:00
Valentin Gosu
63d237395d Bug 1433958 - Change URLWorker to use NS_MutateURI r=mayhemer
* Also makes mStdURL be a nsCOMPtr<nsIURI> in order to avoid static_casts

MozReview-Commit-ID: BagXxecHCSK

--HG--
extra : rebase_source : 476fc079fab1375f33dc285c978fa9e3f469ee01
2018-02-26 20:43:46 +01:00
Valentin Gosu
55a7a824c6 Bug 1435671 - Reduce binary size by making NS_MutateURI.Apply not be a templated method r=mayhemer
We instead add a templated method NS_MutatorMethod that returns a std::function<nsresult(nsIURIMutator*)> which Apply then calls with mMutator as an argument.
The function returned by NS_MutatorMethod performs a QueryInterface, then calls the passed method with arguments on the result.

MozReview-Commit-ID: Jjqp7gGLG1D

--HG--
extra : rebase_source : f2a17aee7bb66a7ba8652817d43b9aa7ec7ef710
2018-02-21 01:00:54 +01:00
nbeleuzu@mozilla.com
01eef6aff1 Backed out changeset c9dcce0a1068 (bug 1435671) for build bustages on nsIURIMutator.h. CLOSED TREE 2018-02-21 00:06:46 +02:00
Valentin Gosu
f1850e9354 Bug 1435671 - Reduce binary size by making NS_MutateURI.Apply not be a templated method r=mayhemer
We instead add a templated method NS_MutatorMethod that returns a std::function<nsresult(nsIURIMutator*)> which Apply then calls with mMutator as an argument.
The function returned by NS_MutatorMethod performs a QueryInterface, then calls the passed method with arguments on the result.

MozReview-Commit-ID: Jjqp7gGLG1D

--HG--
extra : rebase_source : 592d13349a8c4627c7ce3146ec592f577b39f3cc
2018-02-20 22:39:40 +01:00
Andrea Marchesini
8cdf705535 Bug 1435174 - Remove the renaming 'using namespace workers', r=bkelly 2018-02-05 19:55:07 +01:00
Andrea Marchesini
26352bfee1 Bug 1432963 - Fixing workers headers - part 17 - no LIBS=[workers] in moz.build files, r=smaug 2018-01-31 08:25:30 +01:00
Andrea Marchesini
a5bed23bd8 Bug 1432963 - Fixing workers headers - part 15 - static function in a workers namespace, r=smaug 2018-01-31 08:24:30 +01:00
Andrea Marchesini
2c7c69af24 Bug 1432963 - Fixing workers headers - part 14 - WorkerPrivate without workers namespace, r=smaug 2018-01-31 08:24:08 +01:00
Andrea Marchesini
6ab3b67d62 Bug 1433723 - URL in workers should use a proxy if the protocol is not http nor https, r=valentin 2018-01-29 20:51:32 +01:00
Valentin Gosu
b53812bfed Bug 1432187 - Change code to use nsIStandardURLMutator.{init,setDefaultPort} r=mayhemer
MozReview-Commit-ID: K2Uy9ET3Ay6

--HG--
extra : rebase_source : fb5e19bc7b71a6f0264471bf8f07febf1bc55900
2018-01-24 20:33:02 +01:00