Commit Graph

630938 Commits

Author SHA1 Message Date
Bryce Van Dyk
150ebe3741 Bug 1487416 - Index.cpp's SampleIterator populates cbcs data. r=jya
Rework our mp4 sample iterator to handle cbcs crypto data.

To support this we populate the following new data for samples:
- Crypto pattern information, this is split into a count of encrypted blocks
  and a count of clear blocks.
- A constant IV.

This information is available at a track level and a sample group level. The
sample group level supersedes track level information if both a present.

Prior to this patch, some crypto information was written to samples in
the SampleIterator in Index.cpp, and some in the MP4Demuxer (based on if the
SampleIterator had not populated the data). This patch moves all these
operations into the SampleIterator -- the idea being that the sample iterator
should be the component responsible for setting up sample meta data.

Differential Revision: https://phabricator.services.mozilla.com/D15877

--HG--
extra : moz-landing-system : lando
2019-01-10 18:39:02 +00:00
Bryce Van Dyk
c774b56446 Bug 1487416 - Support different encryption schemes in mp4 parser's GetAuxInfo. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D15876

--HG--
extra : moz-landing-system : lando
2019-01-10 18:38:36 +00:00
Bryce Van Dyk
fc1f753612 Bug 1487416 - Parse pattern encryption information from the seig box. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D15875

--HG--
extra : moz-landing-system : lando
2019-01-10 18:38:14 +00:00
Bryce Van Dyk
1a3a965df3 Bug 1487416 - Replace mValid and mMode with mCryptoScheme for track and sample crypto structs. r=jya
Explicitly store the crypto scheme being used on our crypto structs to let us
differentiate between cenc and cbcs data. In doing so remove mMode and replace
mValid with IsEncrypted() for the following reasons:
- Different modes within the existing schemes are not currently utilized by the
  spec of implementation. Having a mode and a scheme could lead to confusion
  between the two. We can return mMode if ever needed by the spec.
- mValid was typically used to check if these structs contained valid crypto
  data or not. With only one scheme this was often shorthand for 'IsEncrypted',
  but with multiple schemes what is considered valid data for one may not be for
  another. Do away with this and just explicitly have an 'IsEncrypted'.

Differential Revision: https://phabricator.services.mozilla.com/D15874

--HG--
extra : moz-landing-system : lando
2019-01-10 18:37:48 +00:00
Bryce Van Dyk
a30bb45d3c Bug 1487416 - Read pattern information in Sinf parser. r=jya
Differential Revision: https://phabricator.services.mozilla.com/D15873

--HG--
extra : moz-landing-system : lando
2019-01-10 18:37:20 +00:00
Ricky Rosario
cff14c7e15 Bug 1518866 - Land strings for new UI for Private Browsing with Search r=flod,Gijs
MozReview-Commit-ID: EGUdZ6WJJij

Differential Revision: https://phabricator.services.mozilla.com/D16144

--HG--
extra : moz-landing-system : lando
2019-01-10 16:43:08 +00:00
Punam
ad397059a0 Bug 1518804 - Devtools debugger panel button tooltip shows undefined r=jlast
Devtools debugger panel button tooltip showing shortcut undefined

Differential Revision: https://phabricator.services.mozilla.com/D16226

--HG--
extra : moz-landing-system : lando
2019-01-10 20:20:40 +00:00
Daniel Varga
10fe290de6 Backed out changeset 49be7aaa199c (bug 1449736) for mochitest failure at layout/generic/test/test_plugin_focus.html on a CLOSED TREE 2019-01-10 22:56:40 +02:00
Michael Froman
1a75356195 Bug 1514874 - start RDD process on-demand r=jya,jld
Differential Revision: https://phabricator.services.mozilla.com/D15775

--HG--
extra : moz-landing-system : lando
2019-01-10 18:35:06 +00:00
Dave Townsend
91b4da5027 Bug 1519184: Fix cache purging on windows. r=Gijs
When Firefox runs we cache a number of things, JS, XUL, XBL, CSS etc. Whenever
a new build of Firefox runs against a profile we clear the cache to rebuild with
the new information.

On the first run of a profile where compatibility.ini doesn't exist (presumably
to cover the case of upgrading from a very old versions of Firefox, but also
affects new profiles) we attempt to clear the cache as well.

If any attempt to clear the cache fails we set a flag in compatibility.ini
telling us to clear the cache on next startup.

Unfortunately nsIFile.remove returns different error codes on different
platforms when the file in question already doesn't exist. So an attempt to
remove a cache that does't exist is counted as a failure on Windows and so the
cache will be cleared again on second run.

This change counts the file not found return code as counting as a success when
clearing the cache.

Differential Revision: https://phabricator.services.mozilla.com/D16224

--HG--
extra : moz-landing-system : lando
2019-01-10 20:10:04 +00:00
Cosmin Sabou
d67c07e5d3 Backed out 3 changesets (bug 1510695, bug 1510696, bug 1510693) for causing marionette reftest failures.
Backed out changeset daf05866f9dd (bug 1510696)
Backed out changeset aa26fbe413c4 (bug 1510695)
Backed out changeset bd2cb6b0a391 (bug 1510693)
2019-01-10 22:04:11 +02:00
Matthew Noorenberghe
8ac0a7753f Bug 1386283 - Enable eslint 'brace-style' and 'curly' rules on passwordmgr with --fix. r=mconley
ignore-this-changeset for blame

Differential Revision: https://phabricator.services.mozilla.com/D16110

--HG--
extra : moz-landing-system : lando
2019-01-10 19:26:48 +00:00
Matthew Noorenberghe
3f7baf5de6 Bug 1386283 - Enable eslint 'indent' rule on passwordmgr with --fix. r=mconley
ignore-this-changeset for blame

Differential Revision: https://phabricator.services.mozilla.com/D16109

--HG--
extra : moz-landing-system : lando
2019-01-10 19:26:17 +00:00
Matthew Noorenberghe
d9469a1400 Bug 1386283 - Test: Only consider connected <input>s for username/password fields. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D15997

--HG--
extra : moz-landing-system : lando
2019-01-10 19:25:37 +00:00
Matthew Noorenberghe
8d0849c371 Bug 1386283 - Only consider connected <input>s for username/password fields. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D15887

--HG--
extra : moz-landing-system : lando
2019-01-10 19:25:01 +00:00
Xidorn Quan
12de3945a4 Bug 1514498 - Hide rather than collapse scrollbar thumb when scrollbar is disabled. r=NeilDeakin
Collapsing thumb causes frame of scrollbar to cache an incorrect pref
size, which makes it not able to appear in certain cases.

This patch changes it to use "visibility: hidden" instead so that the
thumb is hidden but still contributes to the width of scrollbar.

An alternative would be also change the code in nsScrollbarFrame to set
something other than collapsed attribute instead, but I'm not sure
whether doing that is any better than just adding a rule. We need the
rule anyway regardless of what we set on the element.

Differential Revision: https://phabricator.services.mozilla.com/D15244

--HG--
extra : moz-landing-system : lando
2019-01-10 14:15:30 +00:00
David Parks
4ff2f5dfa4 Bug 1449736: Properly detect failure in receiving plugin NPObjects (r=jmathies)
We need to recognize IPDL errors in order to return the proper error status when the right PluginScriptableObject could not be found.

Differential Revision: https://phabricator.services.mozilla.com/D15469

--HG--
extra : moz-landing-system : lando
2019-01-09 16:36:59 +00:00
Jeff Muizelaar
17b5ec3dd2 Bug 1509182. Switch from using WrFilterOp to using FilterOp directly. r=nical
This avoids code duplication and simplifies push_stacking_context

Differential Revision: https://phabricator.services.mozilla.com/D16050

--HG--
extra : moz-landing-system : lando
2019-01-10 19:41:08 +00:00
Andrew McCreight
a3f7eb4598 Bug 1517577 - DataTransferItemList::Add should use nsVariantCC. r=nika
nsVariant isn't cycle collected, so this can cause a leak.

Differential Revision: https://phabricator.services.mozilla.com/D16124

--HG--
extra : moz-landing-system : lando
2019-01-10 19:23:43 +00:00
Tim D. Smith
a95f1a031b Bug 1519170 - Re-renew GEOLOCATION_REQUEST_GRANTED probe r=chutten
The `GEOLOCATION_REQUEST_GRANTED` probe was renewed in Bug #1494496 to support targeting for a survey project that I originally expected to launch in November. Thanks to the usual vagaries of IRBs, holidays, and other priorities, we haven't launched yet, and the probe expiry is configured to stop collecting in 65. To mitigate the risk of failing to deploy the survey before the targeting probe expires, I'd like to bump the probe expiration out another couple of releases and uplift to beta.

I think we're actually ready to launch now so I'm confident another 12 weeks will be more than enough time and we won't have to repeat this exercise again.

I expect the data review in Bug #1494496 provides coverage for this change.

Differential Revision: https://phabricator.services.mozilla.com/D16211

--HG--
extra : moz-landing-system : lando
2019-01-10 19:20:02 +00:00
Luca Greco
0a6194aedc Bug 1519121 - Fix browser_ext_optionsPage_popups.js test failure on 66 Beta due to userContext feature disabled. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D16219

--HG--
extra : moz-landing-system : lando
2019-01-10 19:12:41 +00:00
Cosmin Sabou
88993e172c Backed out changeset 10dedfde1015 (bug 1509182) for causing build bustages.
--HG--
extra : rebase_source : 4389819cbb88af16724480f571b0abcd027015ba
2019-01-10 20:52:49 +02:00
Matthew Noorenberghe
fdacc288b7 Bug 1477798 - Treat sensitive @autocomplete field names like 'off' in FormData.jsm. r=Felipe
Differential Revision: https://phabricator.services.mozilla.com/D15780

--HG--
extra : moz-landing-system : lando
2019-01-10 18:49:46 +00:00
Matthew Noorenberghe
37427a1506 Bug 1477798 - Treat sensitive @autocomplete field names like 'off' in satchel. r=Felipe
This also has the side-effect of fixing autocomplete parsing for 'off' to ignore whitespace:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D15779

--HG--
extra : moz-landing-system : lando
2019-01-10 18:49:10 +00:00
Matthew Noorenberghe
9fd4c34227 Bug 1477798 - Expose whether a fieldName should be automatically persisted on getAutocompleteInfo(). r=baku
This allows us to centralize the logic about which field names are "sensitive" and shouldn't be saved in things like form history or session history.

Differential Revision: https://phabricator.services.mozilla.com/D16128

--HG--
extra : moz-landing-system : lando
2019-01-10 18:48:39 +00:00
Vlad Baicu
791441364d Bug 1508279 - Handle persistent notification actions. r=geckoview-reviewers,snorp
Handle persistent notifications click actions in NotificationReceiver.

Differential Revision: https://phabricator.services.mozilla.com/D16062

--HG--
extra : moz-landing-system : lando
2019-01-10 17:05:32 +00:00
André Bargull
6de4d9b81c Bug 1518764: Handle dead proxies in intrinsic_ConstructorForTypedArray by switching to UnwrapAndDowncastValue. r=jandem 2019-01-09 08:13:05 -08:00
Olli Pettay
7a31419242 Bug 1518038 - Add nsIThread.hasPendingHighPriorityEvents, r=froydnj
--HG--
extra : rebase_source : 47de7758f551bfe873426c8f92e27ac84ad4d260
2019-01-10 19:07:34 +02:00
Bogdan Tara
3ca870b28b Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2019-01-10 19:27:05 +02:00
Bogdan Tara
c3653f9be3 Merge inbound to mozilla-central. a=merge 2019-01-10 19:20:47 +02:00
Bogdan Tara
6d78d1e2c9 Backed out 15 changesets (bug 1305957) for ASAN failures CLOSED TREE
Backed out changeset 4d5eb85d3155 (bug 1305957)
Backed out changeset 51c86d025ecb (bug 1305957)
Backed out changeset d8eef8f3e396 (bug 1305957)
Backed out changeset 950bf6ad1ef2 (bug 1305957)
Backed out changeset b4cb2cbebdb6 (bug 1305957)
Backed out changeset bfca5019a9cc (bug 1305957)
Backed out changeset e76b842c7b7f (bug 1305957)
Backed out changeset d9445a5f3458 (bug 1305957)
Backed out changeset d9052f7b34d9 (bug 1305957)
Backed out changeset e7124fecb721 (bug 1305957)
Backed out changeset bdb766faa867 (bug 1305957)
Backed out changeset 3033401ef320 (bug 1305957)
Backed out changeset 6b96050386f6 (bug 1305957)
Backed out changeset c66c00f73296 (bug 1305957)
Backed out changeset 6bd0bdab93cb (bug 1305957)
2019-01-10 18:49:22 +02:00
Kartikaya Gupta
fa555ac02c Bug 1507522 - Drop revision.txt and WR update process. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D16105

--HG--
extra : moz-landing-system : lando
2019-01-10 14:14:13 +00:00
Kartikaya Gupta
ef25cd53ed Bug 1507522 - Add a note to the WebRender README about the new upstream. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D16104

--HG--
extra : moz-landing-system : lando
2019-01-10 14:14:00 +00:00
Jon Coppeard
d087597227 Bug 981991 - Make most poisoning unconditional r=jandem 2019-01-10 13:21:46 +00:00
Jon Coppeard
cde26c3387 Bug 981991 - Replace JS_*_POISON macros with inline functions r=jandem 2019-01-10 13:21:45 +00:00
Jon Coppeard
57b972724c Bug 1518824 - Poison old ObjectGroup properties array during sweeping r=tcampbell 2019-01-10 11:00:20 +00:00
Jon Coppeard
2755f84c3d Bug 1518193 - Use new free task to also free nursery buffers r=sfink 2019-01-10 11:00:20 +00:00
Jon Coppeard
f0e4f0cea3 Bug 1518193 - Use new free task to also free JIT LIFO data freed after minor GC r=sfink 2019-01-10 11:00:20 +00:00
Jon Coppeard
ba9d0adc5b Bug 1518193 - Add a new parallel task for freeing LIFO data r=sfink 2019-01-10 11:00:20 +00:00
Jon Coppeard
1ea829b0da Bug 1518193 - Move BackgroundSweepTask functionality into GCParallelTask base class r=sfink 2019-01-10 11:00:19 +00:00
Tom Ritter
ba7c4014b7 Bug 1509829 - Spoof OS in HTTP User-Agent header for desktop platforms r=timhuang,baku
In 1404608, the OS was revealed in both the HTTP User-Agent
header and to JavaScript code via navigator.userAgent. To avoid
leaking the OS inside each HTTP request (which many web servers
log), always use the Windows 7 OS value in the desktop User-Agent
header. We continue to allow access to the actual OS via JavaScript,
since doing so improves compatibility with web applications such
as GitHub and Google Docs.

This is an uplift of Tor's 26146
2019-01-09 12:53:30 -06:00
Kestrel
14467a827a Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor r=jmathies
Differential Revision: https://phabricator.services.mozilla.com/D14723

--HG--
extra : moz-landing-system : lando
2019-01-09 16:37:34 +00:00
Alex Chronopoulos
96cd8b2f6a Bug 1515549 - Avoid resetting volume in every AudioSink restart in case volume has changed outside firefox. r=jya
Avoid resetting volume in every AudioSink restart to stop unexpected volume change during play/pause and seek. Volume changes could occur if the volume has been modified outside firefox (for example pavucontrol in Linux).

Differential Revision: https://phabricator.services.mozilla.com/D15210

--HG--
extra : moz-landing-system : lando
2019-01-10 11:24:29 +00:00
Henri Sivonen
b10e89785b Bug 1515351 - Update encoding_rs to 0.8.14. r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D15934

--HG--
extra : moz-landing-system : lando
2019-01-10 09:42:39 +00:00
André Bargull
47a7b89662 Bug 1394386: Don't enforce tenure allocation for TypedArrays from inlined constructor ool-path. r=jandem 2019-01-09 01:52:31 -08:00
André Bargull
085ce9ea7b Bug 1518837: Reuse input register in LGuardToClass. r=jandem 2019-01-09 09:04:15 -08:00
Oriol Brufau
f49f3db6d7 Bug 1515046 - Let reps invoke the right getter when it's shadowed. r=nchevobbe
Depends on D15788

Differential Revision: https://phabricator.services.mozilla.com/D15789

--HG--
extra : moz-landing-system : lando
2019-01-09 01:47:34 +00:00
Oriol Brufau
69e25dc980 Bug 1515046 - Add receiverId parameter in objectClient.getPropertyValue. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D15788

--HG--
extra : moz-landing-system : lando
2019-01-09 06:42:58 +00:00
Henrik Skupin
c820e2d61d Bug 1504756 - [marionette] Added opening a new browsing context to Marionette client. r=ato
The patch updates the Marionette client and all Marionette unit
tests to make use of the new `Create Window` command as much as
possible.

Depends on D13663

Differential Revision: https://phabricator.services.mozilla.com/D13664

--HG--
extra : moz-landing-system : lando
2019-01-10 10:13:17 +00:00
Henrik Skupin
c631c98202 Bug 1504756 - [marionette] Added "WebDriver:NewWindow" command to open a new top-level browsing context. r=ato
The patch adds the end-point for the recently defined `New Window`
command (https://github.com/w3c/webdriver/issues/1138). It allows
to open a new top-level browsing context as tab or as window.

Depends on D13662

Differential Revision: https://phabricator.services.mozilla.com/D13663

--HG--
extra : moz-landing-system : lando
2019-01-10 10:14:24 +00:00