179 Commits

Author SHA1 Message Date
bbaetz%student.usyd.edu.au
4b3fa0a5f9 Bug 157085 - verify-new-product doesn't set defaults
r=jouni, gerv
2002-06-25 10:07:59 +00:00
bbaetz%student.usyd.edu.au
693d63dda2 Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni
2002-06-17 09:39:00 +00:00
bbaetz%student.usyd.edu.au
dd519e4374 Bug 151369 - need to trim the entered assignee's email address
r=mattyt x2
2002-06-16 05:26:50 +00:00
gerv%gerv.net
c4d9231226 Bug 144728 - Midair collision doubles line feeds. Patch by jouni@heikniemi.net; 2xr=justdave. 2002-05-29 07:21:44 +00:00
gerv%gerv.net
db55935a5f Bug 125066 - remove the need to set a milestone on accept for products with just one milestone. Patch by zeroj; r=justdave, gerv. 2002-04-24 20:07:57 +00:00
gerv%gerv.net
3bc9d4ca2b Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke. 2002-04-24 07:24:50 +00:00
gerv%gerv.net
5820179602 Bug 137954 - Empty "move-button-text" field blocks changing bugs. Patch by gerv, 2xr=justdave. 2002-04-17 22:59:07 +00:00
bbaetz%student.usyd.edu.au
b8049151a5 bug 117718 - Mass Change removes a bugs groupset if the bug was in the
wrong product group
r=justdave x2
2002-04-16 08:29:01 +00:00
myk%mozilla.org
a26bc29e52 Fix for bug 125660: Templatizes process_bug.cgi.
Patch by Myk Melez <myk@mozilla.org>
r=gerv,bbaetz
2002-04-12 21:02:00 +00:00
gerv%gerv.net
20b99d16c6 Bug 124937 - templatise show_activity.cgi. Patch by me, r=myk, bbaetz. 2002-04-03 18:54:18 +00:00
justdave%syndicomm.com
a2f9effc6e Fix for bug 82143 and bug 95594: Attempting to reverse dependencies falsely reported a circular dependency loop, and setting
both the blocks and depends at the same time allowed a real dependency loop to be created.
Patch by Stephen Lee <slee@wilcoxassoc.com>
r= myk, justdave
2002-04-03 00:55:56 +00:00
gerv%gerv.net
d391f38ecb Bug 110012 - show_bug templatisation. r=bbaetz, afranke. 2002-03-23 17:58:41 +00:00
myk%mozilla.org
7395f6773d Fix for bug 72184: prevents users from entering too-large comments/descriptions that get rejected by MySQL's MAX_PACKET_SIZE restrictions.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv
2002-03-11 07:33:03 +00:00
bbaetz%student.usyd.edu.au
fdfcfb96fd Bug 97471 - The assignee and qa contact should always be able to see their
bugs
r=justdave, afranke
2002-02-13 03:05:15 +00:00
bbaetz%student.usyd.edu.au
0c682418d4 Bug 119715 - strictvaluechecks should always be enabled
r=justdave, gerv
2002-02-05 00:20:09 +00:00
bbaetz%student.usyd.edu.au
d9d0617952 Bug 121074 - taint error after changing bug
r=daa@distributed.net,jake
2002-01-22 15:12:11 +00:00
justdave%syndicomm.com
e24c04e22a Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave
2002-01-20 01:44:52 +00:00
jake%acutex.net
6f658a8b68 Bug 113975 - Changing only cc on mass change page incorrectly gives an error that you didn't select anything to change.
r= myk x2
2002-01-06 14:36:00 +00:00
justdave%syndicomm.com
840d1c4527 Fix for bug 102487: If you had "comment on product change required" turned on in your installation, Bugzilla would warn you of
a forgotten comment AFTER allowing you to choose new components, versions, and milestones, forcing you to hit your back button
TWICE to correct your mistake.  This checkin corrects that.
Patch by David Kilzer <ddkilzer@theracingworld.com>
r= caillon, gerv
2001-12-16 00:05:54 +00:00
justdave%syndicomm.com
d89032c7bf Fix for bug 73502: midair collision wasn't catching other bugs changing dependencies
Patch by Dave Miller
r= bbaetz, jake
2001-12-11 02:38:18 +00:00
jake%acutex.net
c7e781a010 Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it.
r=louie, myk
2001-11-27 15:04:52 +00:00
justdave%syndicomm.com
5a3a1fe26f Backing out previous checkin, it broke the tree. :( 2001-11-17 21:28:24 +00:00
justdave%syndicomm.com
5828cbd866 Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk
2001-11-17 21:12:53 +00:00
bbaetz%cs.mcgill.ca
91fafca168 Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older
mysql versions don't support. Remove the checksetup.pl restriction, too.

r=jake x2
2001-11-14 15:12:23 +00:00
justdave%syndicomm.com
52073d81d4 Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
2001-11-08 03:38:12 +00:00
justdave%syndicomm.com
99906b233b SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2
2001-11-05 20:47:17 +00:00
bbaetz%cs.mcgill.ca
8d60ac104d Bug 107718 - mass changes give all changed bugs the groupset of the first
bug in the list.

Do bit fiddling instead of adding groupsets from the first bug.

r=justdave, jake
2001-11-03 05:49:23 +00:00
jake%acutex.net
57021053de Bug 104065 - Stop uninitilized string warnings from getting into the error log when the login cookie doesn't exist.
Patch by Dave Miller <justdave@syndicomm.com>
r= gerv@mozilla.org, jake@acutex.net
2001-10-25 14:46:58 +00:00
bbaetz%cs.mcgill.ca
543d7e522a Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave
2001-10-23 15:44:53 +00:00
justdave%syndicomm.com
93a2f50358 Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2
2001-10-13 01:36:17 +00:00
myk%mozilla.org
792932cb8f Fix for bug 98744: No more software error when the user clicks "remove cc" without specifying users to remove.
Fix by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.
2001-09-28 19:49:53 +00:00
myk%mozilla.org
4e68305b35 Fix for bug 90333: Bugzilla now displays an appropriate error message if a user hits process_bug.cgi without specifying any bugs to change.
Patch by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
2001-09-17 18:55:31 +00:00
jake%acutex.net
f1aceec2a8 Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new.
r= myk@mozilla.org, zach@zachlipton.com
2001-09-14 21:50:08 +00:00
justdave%syndicomm.com
42a7dcc52c Fix for bug 92266: Prevent dataloss in the bugs_activity table by wrapping
entries into additional entries if they're too long to fit.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-08-26 22:58:34 +00:00
jake%acutex.net
7750d44cdd Bug 96085 - bypassing group security checks using duplicate bugs
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
2001-08-26 18:51:45 +00:00
justdave%syndicomm.com
6aaa134676 Fix for bug 95235: variables with untrusted content were being echoed back to the user in error messages. Those variables are now run through html_quote() first.
Patch by Gavin Shelley <gavins@iplbath.com>
r= justdave@syndicomm.com
2001-08-24 17:32:25 +00:00
jake%acutex.net
ce973b6c4b Refixing bug 95875 - The code that breakes the typed in CC list into individual lists is now slightly more robust and allows perl to handle the splitting more efficiently (by using a space as the delimiter).
r= myk@mozilla.org
2001-08-18 03:35:36 +00:00
justdave%syndicomm.com
6264032f3e Fix for bug 95857: process_bugs.cgi sees blank address in cc: line (would show up as __UNKNOWN__)
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-18 01:49:02 +00:00
jake%acutex.net
af1bd70cd7 Fix for bug 95747 - CC List validation (for additions) wasn't happening until after the bug's changes were in the process of being commited. This caused problems if a typo was made in the e-mail address.
r= myk@mozilla.org
2001-08-17 20:18:33 +00:00
justdave%syndicomm.com
67893f32dd Fix for bug 95743: the role-accessible checkboxes were getting cleared if a user with group access had to log in to make changes to a public bug.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-17 11:15:04 +00:00
justdave%syndicomm.com
43755341de Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-13 00:46:20 +00:00
zach%zachlipton.com
1ecf08a901 fix for bug 66235: process_bug.cgi: multiple product change misses the groupset bit. Patch by Myk <myk@mozilla.org> r=Jake, oh, and it's my first checkin, yahoo! 2001-08-11 01:18:24 +00:00
justdave%syndicomm.com
99dccbf9c5 Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com
2001-07-22 00:29:45 +00:00
jake%acutex.net
ed69b4acf1 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
8efbae9be1 Fix for bug 80289: Group restrictions are now identified with checkboxes instead of select widgets. Also, product groups are now only offered if they are either already set, or match the current product (i.e. the option to set a product bit for a product other than the one the bug is in is no longer available) This results in much less clutter for the admin folks on sites with lots of products.
Patch by Joe Robbins <jmrobins@tgix.com>
r= justdave@syndicomm.com
2001-06-27 01:44:34 +00:00
justdave%syndicomm.com
3b98736d18 Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
336d245aa5 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-06 21:17:42 +00:00
tara%tequilarista.org
eda44f5b9f Landing Myk's patch for bug #71767 2001-06-02 22:02:02 +00:00
jake%acutex.net
d520cdb669 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
2001-05-31 15:52:25 +00:00
justdave%syndicomm.com
8e2cc80353 Correcting my email address in the comments 2001-04-17 02:26:16 +00:00