Commit Graph

11 Commits

Author SHA1 Message Date
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Andrew McCreight
70fe7daafb Bug 1489690, part 4 - Fix some misc. issues with the XUL sort service r=bzbarsky
Depends on D5593

Differential Revision: https://phabricator.services.mozilla.com/D5616

--HG--
extra : moz-landing-system : lando
2018-09-13 18:37:50 +00:00
Andrew McCreight
c7b30c67ec Bug 1489690, part 3 - De-COM the XUL sort service r=bzbarsky
There's only one method that is used, and we never need to create any
instances of the object, so turn it into a single method.

Depends on D5592

Differential Revision: https://phabricator.services.mozilla.com/D5593

--HG--
extra : moz-landing-system : lando
2018-09-13 18:37:48 +00:00
Andrew McCreight
4db3f10eaa Bug 1489690, part 2 - Move everything not in the nsI interface into the cpp file r=bzbarsky
There's no state on the object, so all of the methods can be turned
into static methods in the CPP files. I leave the one public method,
Sort, alone for simplicity. The internal data structure definitions
also don't need to be publicly exposed.

This patch is a bit messy because I had to rearrange methods so they
were defined before they were used. This makes the resulting code a
little nicer (as compared to forward declaring methods), but makes the
VCS history worse.

Depends on D5591

Differential Revision: https://phabricator.services.mozilla.com/D5592

--HG--
extra : moz-landing-system : lando
2018-09-13 18:37:46 +00:00
Andrew McCreight
4a93f15458 Bug 1489690, part 1 - Remove the registration for the sort service r=bzbarsky
This is only used in a single place, so having a service for it is overkill.

Differential Revision: https://phabricator.services.mozilla.com/D5591

--HG--
extra : moz-landing-system : lando
2018-09-13 18:37:44 +00:00
Boris Zbarsky
9748db120d Bug 1455676 part 8. Remove nsIDOMNode usage from layout/. r=qdot 2018-05-29 22:58:48 -04:00
Boris Zbarsky
25aa42d9a4 Bug 1455674 part 16. Remove most use of nsIDOMElement in dom. r=qdot 2018-04-26 23:37:34 -04:00
Andrea Marchesini
499f1c1314 Bug 1425440 - Replace RemoveChildAt_Deprecated with RemoveChildNode in nsXULSortService, r=catalinb 2018-01-16 14:17:10 +01:00
Cosmin Sabou
81a8319b46 Merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
--HG--
rename : dom/xul/templates/nsXULSortService.cpp => dom/xul/nsXULSortService.cpp
2018-01-03 23:59:59 +02:00
Gijs Kruitbosch
5e38a0cf55 Bug 1425356 - remove various dead XUL sort attributes, r=bz,florian
- sort-statics-last is no longer meaningful now non-static (ie template) items don't exist
- we don't use the 'resource' attribute anywhere in XUL.
- sortResource/sortResource2 are unused.
- we don't have meaningful consumers for sortSeparators

MozReview-Commit-ID: C31vC9MCrDo

--HG--
extra : rebase_source : 539fd84201eaeead62ac73b3213bfdf6f4333e9a
2017-12-20 15:08:27 +00:00
Gijs Kruitbosch
a8bb5924c6 Bug 1425356 - remove XUL template support, r=bz
MozReview-Commit-ID: HdBoQ15DFOu

--HG--
rename : dom/xul/templates/nsIXULSortService.idl => dom/xul/nsIXULSortService.idl
rename : dom/xul/templates/nsXULContentUtils.cpp => dom/xul/nsXULContentUtils.cpp
rename : dom/xul/templates/nsXULContentUtils.h => dom/xul/nsXULContentUtils.h
rename : dom/xul/templates/nsXULSortService.cpp => dom/xul/nsXULSortService.cpp
rename : dom/xul/templates/nsXULSortService.h => dom/xul/nsXULSortService.h
extra : rebase_source : e3f3504c529e7bd9aa52aecf34b94bb5b0ff92b4
2017-12-19 14:11:06 +00:00