In bug 1551585 we added a new inactivity warning shown on top,
right, bottom, left and z-index properties when they are used on elements
that are not positioned.
Turns out that z-index *can* be used on unpositioned elements if these
elements are grid or flex items.
In grid layouts it's useful to determine which item shows on top when
several overlap in a grid cell.
In flex layouts, z-index values other than auto create a stacking context
even if position is static.
So this change simply avoids showing the warning for z-index if the element
is a flex or a grid item.
Differential Revision: https://phabricator.services.mozilla.com/D60673
--HG--
extra : moz-landing-system : lando
Second part: trace the updates that are sent to the DataStore, and save
at least the Insert/Remove and ItemUID as part of the wr-capture.
(We could expand this with more info, eg. the actual Keys, later).
TileView then reads them back and generates a color coded report to
overlay with the page view. This helps to see the types and amounts of
interned primitives that lead to cache invalidations.
Differential Revision: https://phabricator.services.mozilla.com/D60619
--HG--
extra : moz-landing-system : lando
This test also has the same dashed border and occasional fuzziness
that grid-track-intrinsic-sizing-003.html does with DC enabled.
Differential Revision: https://phabricator.services.mozilla.com/D60947
--HG--
extra : moz-landing-system : lando
Changes:
Migrate over the platform of `mochitest-chrome` to ubuntu1804:
Mark as expected failure one test, and expand the disable annotation of another test to include all platform variants of linux.
Resulting runs have some intermittent failures but nothing significant.
Differential Revision: https://phabricator.services.mozilla.com/D60612
--HG--
extra : moz-landing-system : lando
Inside of PictureInPictureChild's willDestroy, we were calling removeMouseButtonListeners();,
which gets rid of all of the event listeners that we use to detect clicks on the page to
check for clicking on the PiP toggle.
There are, however, other event listeners that weren't being removed, and more importantly,
there were DeferredTask's that weren't being disarmed and torn down. This was causing us to
sometimes log error messages to the console when navigating between pages, because the
JSWindowActorChild has gone away by the time the DeferredTask runs.
So now we call stopTrackingMouseOverVideos instead, which also shuts down the DeferredTask's
(and also calls removeMouseButtonListeners).
Differential Revision: https://phabricator.services.mozilla.com/D52903
--HG--
extra : moz-landing-system : lando
This causes us to automatically deny the `desktop-notification`
permission if there is no user interaction, like desktop Firefox. This is
not enforced if the `dom.webnotifications.requireuserinteraction`
preference is set to `false`
Differential Revision: https://phabricator.services.mozilla.com/D60758
--HG--
extra : moz-landing-system : lando
This causes us to automatically deny the `desktop-notification`
permission if there is no user interaction, like desktop Firefox. This is
not enforced if the `dom.webnotifications.requireuserinteraction`
preference is set to `false`
Differential Revision: https://phabricator.services.mozilla.com/D60758
--HG--
extra : moz-landing-system : lando
Move allocation into a function call can prevent JIT keeps the return
value of weakRef.deref().
Differential Revision: https://phabricator.services.mozilla.com/D60662
--HG--
extra : moz-landing-system : lando
This also fixes the tests, and adds a utility method for waiting one
round trip between the UI and Gecko thread.
Differential Revision: https://phabricator.services.mozilla.com/D60724
--HG--
extra : moz-landing-system : lando
This is a ride-along commit that would have made debugging the problem solved
by this bug easier.
Depends on D60688
Differential Revision: https://phabricator.services.mozilla.com/D60689
--HG--
extra : moz-landing-system : lando
This can sometimes reduce ESLint's runtime by 10 minutes!
Depends on D60686
Differential Revision: https://phabricator.services.mozilla.com/D60688
--HG--
extra : moz-landing-system : lando
This prevents eslint from dumping an error and bailing when a path was specified that
doesn't contain any lintable files.
This patch fixes a bad interaction with 'mozlint' where passing a directory containing
failures alongside a directory that doesn't have lintable files results in the errors
being hidden and mozlint reporting that everying is OK.
Differential Revision: https://phabricator.services.mozilla.com/D60686
--HG--
extra : moz-landing-system : lando
The computation of the repetition depends on the aspect ratio of the segment's uv rectangle, which was previously represented by the dx/dy variables in the shader. These were mistakenly computing the ratio of the normalized uvs within the primitive's total uv rect, which was incorrect since the normalization introduces a non-uniform scale.
This patch fixes it by taking the uv size in device pixels instead of the the normalized textel rect. dx and dy are also renamed into segment_uv_size which is a more informative name.
Differential Revision: https://phabricator.services.mozilla.com/D60768
--HG--
extra : moz-landing-system : lando
Unlike the border areas that only nead their own dimensions, the middle area of a border-image determines its repetition parameter based on the size of the borders. A new flag is provided for the brush_image shader to know whether to use the segment's own rect or look at the borders when computing the pattern's size.
Differential Revision: https://phabricator.services.mozilla.com/D59675
--HG--
extra : moz-landing-system : lando
border-image-repeat: Round is equivalent to Repeat with the pattern size adjusted to fill the area with a whole number of repetitions. This is done by adjusting the segment's stretch_size in the shader so that it fits a whole number of times in the segment's size.
Differential Revision: https://phabricator.services.mozilla.com/D59370
--HG--
extra : moz-landing-system : lando
There's no need for two explicit APIs as we get safety from the IDL layer. And
treating a SharedArrayBuffer as an empty buffer is wrong too.
Differential Revision: https://phabricator.services.mozilla.com/D60003
--HG--
extra : moz-landing-system : lando
Now we support [AllowShared] in WebIDL, we don't need to manually check shareness
and throw exception if API don't accept SharedArrayBuffer, the binding will handle
it.
Differential Revision: https://phabricator.services.mozilla.com/D60001
--HG--
extra : moz-landing-system : lando
