Commit Graph

2993 Commits

Author SHA1 Message Date
kestes%walrus.com
3f5b7c678e parsing of arguments was buggy. I did not get the arguments into the script. 2002-02-11 23:08:44 +00:00
bbaetz%student.usyd.edu.au
cf8e2d560b Correct date on logincookies schema change. 2002-02-08 11:16:05 +00:00
justdave%syndicomm.com
dd92b52de9 Fix for bug 97966: Changing the product in the query page would remove your component, version, and milestone selections, even if the other product used the same ones, or you were selecting an additional product without unselecting the first one.
Patch by Christian Reis <kiko@async.com.br>
r= caillon, justdave
2002-02-08 03:31:10 +00:00
ian%hixie.ch
e96a0843d8 Fixes a copy-paste error in the help line. r=timeless; b=123708 2002-02-07 08:36:23 +00:00
ian%hixie.ch
ba09233316 Lets the invite command accept the more natural syntax 'invite user in #channel' rather than just 'invite user channel'. r=zach; b=72949 2002-02-07 08:33:17 +00:00
justdave%syndicomm.com
a0dd58d6e4 Fix for bug 122897: Comments entered on the bug form are now added to the bug before it is closed and moved when moving a bug
to another Bugzilla install.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless, bbaetz
2002-02-06 04:34:10 +00:00
justdave%syndicomm.com
916bf2b36a Fix for bug 119005: The instructions in editgroups.cgi incorrectly state that you can't use spaces in a group name. You in
fact can.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz x 2
2002-02-06 02:54:08 +00:00
justdave%syndicomm.com
a4a033f5d4 Fix for bug 117055: Emails were being truncated if they contained a line with nothing but a period on them. We now pass -i to
sendmail and its clones to tell it to ignore periods (since we close the pipe when we're done, rather than signalling it with
a period).  Has been tested with sendmail and postfix.
Patch by Dave Miller <justdave@syndicomm.com>
r= afranke, bugzilla@bkor.dhs.org, jake
2002-02-06 02:47:00 +00:00
bbaetz%student.usyd.edu.au
0c682418d4 Bug 119715 - strictvaluechecks should always be enabled
r=justdave, gerv
2002-02-05 00:20:09 +00:00
bbaetz%student.usyd.edu.au
289e7236a2 Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave
a taint error.
2002-02-05 00:11:48 +00:00
gerv%gerv.net
e0a5210fa6 Remove JS strict warning. 2002-02-04 22:47:26 +00:00
bbaetz%student.usyd.edu.au
b56c24f1b4 bug 122418 - setting attachment status fails taint checks. Just needed to
detaint after checking.
r=gerv,kiko
2002-02-04 22:16:18 +00:00
gerv%gerv.net
32dc696315 show_bug.cgi templatisation. 2002-02-04 21:17:17 +00:00
zach%zachlipton.com
adf57d19ba Fix for bug 87398: checksetup.pl should warn if not run as root. Patch
adds a warning if the user has webservergroup set but does not run
checksetup.pl as root.

r1=kiko, r2=justdave
2002-02-04 16:38:33 +00:00
bbaetz%student.usyd.edu.au
12965a910a Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko
2002-02-04 12:23:05 +00:00
justdave%syndicomm.com
c35da50db3 Fix for bug 14461: QA contact is no longer required. You can still leave it blank in editing and creating components if you
want, even if it's enabled now.  This is consistant with the behavior of this field everywhere else in Bugzilla now.
Eventually this will be a per-product setting whether to enforce having one or not.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x 2
2002-02-04 00:41:40 +00:00
myk%mozilla.org
b6fa253e93 Fix for bug 121747: Stops every script before it does anything else if Bugzilla is currently shut down. Also adds global template
instantiation code to globals.pl.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv,kiko
2002-02-03 09:28:48 +00:00
myk%mozilla.org
fd16f86957 Fix for bug 98021: Cleans up "edit attachment" interface on NS4.x by removing text of buttons that do not work in that browser.
Patch by Myk Melez <myk@mozilla.org>.
r=kiko x 2
2002-02-01 17:50:00 +00:00
jake%acutex.net
1b6ad69f01 Bug 122154 part 2 - Eliminiate the use of the "usetms" Javascript cache variable.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz, jake
2002-02-01 14:52:37 +00:00
jake%acutex.net
e193dc9fd4 Bug 121636 - Provide support for cvsgraph (requires the cvsgraph binary, see bug 121636 for more information).
r= kiko
2002-02-01 14:32:55 +00:00
timeless%mac.com
0625a92542 Bug 109138 platform detection not working on macintosh
r=bbaetz r=gerv
adds another regexp for MacOSX
2002-02-01 10:05:04 +00:00
ian%hixie.ch
a89dffc374 * Added getGroupMembers() to the User data source.
* Fixed a bug in the MySQL implementation of User data source's getGroupName() method. It treated 'row' as an array ref instead of a normal array.
* Made the MySQL User data source automatically add a group with ID 1, named 'Administrators'.
* Special-cased the group with ID 1 in the user object so that if a user is in that group, he automatically is assumed to have all rights.
* Fixed a bug with the saving of the original groups in the user object (the backup object was simply a reference to the original object, which was later changed in place, causing the backup to change too).
* Fixed the handling of rights in the user object constructor to simply set the rights in one line instead of using indirection.
* Fixed the invalidateRights() method of the user object to correctly re-set the rights (previously it was not turning the generated array into a hashref).
* Added a setup.install implementation to the login component. It now queries the user for an administration username and creates the relevant user and puts it in the magic group 1.
* Fixed a call to checkAddress() in the login component.
2002-02-01 06:48:02 +00:00
ian%hixie.ch
1c49734d21 Commented out the call to Net::SMTP's verify() method and replaced it with a generic regexp sanity check. It appears that VRFY is not correctly implemented on all servers. (I may be mistaken on this; it might just be a bug somewhere in the PLIF code that is messing something up, but I couldn't find it if so.) 2002-02-01 06:38:55 +00:00
ian%hixie.ch
3a41393898 Added a check that ensures that the configuration file is not readable or writable by anyone except the user running the script. This closes a potential security hole on shared machines. Changed the umask during the creation of the configuration file so that the permission bits are set that way too. Added a comment to clarify the superficially recursive nature of the configuration database and the configuration data source. 2002-02-01 06:36:27 +00:00
ian%hixie.ch
2787ed1409 Another change that should be done at some point: Move PLIF/DataSource/*/MySQL.pm to PLIF/DataSource/MySQL/*.pm 2002-02-01 06:32:17 +00:00
bbaetz%student.usyd.edu.au
883a899bc3 Bug 122744 - charting fails taint checks
r=daa@distributed.net, gerv
2002-01-31 23:51:38 +00:00
bbaetz%student.usyd.edu.au
954fc92673 Fix up "used only once" warning from kiko's checkin.
r=kiko x 2.
2002-01-31 23:46:51 +00:00
jake%acutex.net
c4ee5cb2f7 Bug 122636 - Templatise colchange.cgi
Patch by David Lawrence <dkl@redhat.com> and Christian Reis <kiko@async.com.br>
r= kiko, jake
2002-01-31 20:12:50 +00:00
ian%hixie.ch
7b34209a7b Removed an erroneous comment, which should be the last traces of the old problem of the lack of a configuration file being a fatal error. 2002-01-31 18:30:21 +00:00
ian%hixie.ch
ed5ab39edd Theoretical nit: call inherited constructor just in case at some point in the future it does something useful... 2002-01-31 17:35:52 +00:00
jake%acutex.net
7737ac0eb5 Some additional files we should be ignoring 2002-01-31 16:28:35 +00:00
jake%acutex.net
df7eee0ab3 Bug 122589 -- Update gnats conversion script to newer schema of 2.14.
Patch by Andrea Dell'Amico <adellam@link.it>
2002-01-31 14:29:21 +00:00
mcafee%netscape.com
f4a1b2b4be adding mocha to dns 2002-01-31 05:25:08 +00:00
timeless%mac.com
10e66de5e7 Bug 122518 Speed up the showbuilds.cgi redirect on http://tinderbox.mozilla.org
patch by netdemonz@yahoo.com r=mcafee
2002-01-31 04:22:39 +00:00
myk%mozilla.org
53ec5f6abd Fix for bug 109480: Removes createattachment.cgi from CVS.
Removed by Myk Melez <myk@mozilla.org>.
r=bbaetz x 2
2002-01-30 18:08:01 +00:00
myk%mozilla.org
aba1aab698 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko
2002-01-30 14:14:12 +00:00
bbaetz%student.usyd.edu.au
57b6ddc197 Bug 122154 - change arrays to numeric, and clean up query.atml js
patch by kiko@async.com.br, r=caillon,bbaetz
2002-01-30 13:43:11 +00:00
gerv%gerv.net
160d8f886b Bug 117509 - createaccount.cgi templatisation. 2002-01-29 23:26:37 +00:00
kestes%walrus.com
e3c9bc355d added some thoughts on how this should work. I still need to debug it. 2002-01-29 21:11:59 +00:00
kestes%walrus.com
2fb2a921a2 many bug fixes. it still will not work, I need a few more hours to finish
debugging this.
2002-01-29 11:38:55 +00:00
kestes%walrus.com
8ddb33175c fix comment. 2002-01-29 01:11:10 +00:00
kestes%walrus.com
f075e3a0f4 regularize $last_cvs_data to be $last_vc_data this is clearer and matches
perforce.pm.  Also fix comments about the function call names to match
new naming system.
2002-01-29 01:09:15 +00:00
kestes%walrus.com
8f6db3af70 this is a first draft. I need to debug this before it will work,
but you can see the logic of it and it will not take long to get it
to work.
2002-01-29 01:06:26 +00:00
mcafee%netscape.com
af5cff9c38 adding mocha to pageload list 2002-01-28 08:05:46 +00:00
mcafee%netscape.com
745569d042 graph size wasn't preserving average setting 2002-01-28 06:51:22 +00:00
zach%zachlipton.com
3a2a216faf Fix for bug 121735: Perl warning running checksetup.pl if a module has a
non-numeric version number. Patch sets checksetup.pl to use a string
compare instead of a numeric one.

Patch by Dave Miller. r1=Bradley Baetz and r2=Gerv
2002-01-27 18:59:38 +00:00
gerv%gerv.net
af5e8a7904 Removing new_comment.cgi - all part of quips.cgi now. 2002-01-25 22:41:37 +00:00
gerv%gerv.net
9f7179af83 quips.cgi rewrite and templatisation. 2002-01-25 22:40:04 +00:00
ian%hixie.ch
551d3369d7 Fix a minor typo in some SQL code which was causing an error during the creation of the user table. 2002-01-25 03:18:15 +00:00
ian%hixie.ch
28d425cd54 Moved the DBI module over to thew new more generic settings getting/saving API and removed the old DBI-specific one. Fixed an assert() call to check for the values being defined and not non-zero/non-blank. Fixed the password field to allow blank values (by making a blank value the default). Also fixed the calls to getArgument to not ever pass an undefined value as the default. 2002-01-25 03:17:05 +00:00