Commit Graph

6796 Commits

Author SHA1 Message Date
J.C. Jones
32759c8ed5 Bug 1573662 - Rename sanctions test routines to make it easier to add new ones r=keeler
1) Multipurpose-ing the TLSServer specialization to `SanctionsTestServer`
2) Renaming the `security/manager/ssl/tests/unit/test_symantec_apple_google` folder of certs to `test_sanctions`
3) Prepend a `symantec-` to the start of all relevant certs in the new `test_sanctions` folder
4) Renaming the existing xpcshell test to `test_sanctions_symantec_apple_google.js`

Differential Revision: https://phabricator.services.mozilla.com/D39942

--HG--
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.key => security/manager/ssl/tests/unit/test_sanctions/default-ee.key
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.key.keyspec => security/manager/ssl/tests/unit/test_sanctions/default-ee.key.keyspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.pem => security/manager/ssl/tests/unit/test_sanctions/default-ee.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/default-ee.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/moz.build => security/manager/ssl/tests/unit/test_sanctions/moz.build
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-after-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-after-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-after-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-after-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-before-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-before-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-before-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-before-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-after-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-after-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-after-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-after-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-before-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-before-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-before-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-before-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other-crossigned.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other-crossigned.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other-crossigned.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other-crossigned.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-whitelisted.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-whitelisted.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-whitelisted.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-whitelisted.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/real-google-g2-intermediate.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-real-google-g2-intermediate.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/real-googlecom.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-real-googlecom.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/test-ca.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-test-ca.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/test-ca.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-test-ca.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google.js => security/manager/ssl/tests/unit/test_sanctions_symantec_apple_google.js
rename : security/manager/ssl/tests/unit/tlsserver/cmd/SymantecSanctionsServer.cpp => security/manager/ssl/tests/unit/tlsserver/cmd/SanctionsTestServer.cpp
extra : moz-landing-system : lando
2019-08-13 20:59:17 +00:00
Sylvestre Ledru
645f2d5773 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D41559

--HG--
extra : moz-landing-system : lando
2019-08-13 07:15:25 +00:00
ffxbld
21d02cb6fe No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D41541

--HG--
extra : moz-landing-system : lando
2019-08-12 13:08:23 +00:00
Daniel Varga
8f35473d07 Backed out changeset 65c6d801e7b4 (bug 1571555) for browser chrome failure at browser/components/aboutlogins/tests/browser/browser_masterPassword.js
--HG--
extra : rebase_source : 9182aebd42d50c9a502dc7fabaf99238ac5e62c5
2019-08-10 22:35:50 +03:00
Jared Wein
018b8a1983 Bug 1571555 - Use a blank string in place of the username or password when decryption fails. r=keeler
Don't show the login in about:logins if the username or password cannot be decrypted.

Differential Revision: https://phabricator.services.mozilla.com/D40845

--HG--
extra : moz-landing-system : lando
2019-08-10 00:19:48 +00:00
Tom Schuster
2c4cb96468 Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D41367

--HG--
extra : moz-landing-system : lando
2019-08-09 15:17:06 +00:00
Nicholas Nethercote
b256ece713 Bug 1571934 - Inline security-prefs.js into all.js. r=keeler
security-prefs.js is #included into greprefs.js, but there's no good reason for
it to be separate from all.js. Having it separate makes it easier to overlook,
and all.js has a bunch of `security.*` prefs in it anyway.

This patch inlines it into all.js. It inlines it at the start of the file to
minimize the risk of the change, so that the prefs end up in greprefs.js in the
same order as before.

Differential Revision: https://phabricator.services.mozilla.com/D40919

--HG--
extra : moz-landing-system : lando
2019-08-07 17:41:22 +00:00
Moritz Birghan
899a70f4b9 Bug 1563849 - Get btoa(getDERString(cert)) from an API r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39970

--HG--
extra : moz-landing-system : lando
2019-08-06 09:03:38 +00:00
Andreea Pavel
53820aa30c Backed out 9 changesets (bug 1564221) xpcshell failures on a CLOSED TREE
Backed out changeset 36e33a3b59f0 (bug 1564221)
Backed out changeset 12d1607c1415 (bug 1564221)
Backed out changeset 8c3157ad3ac9 (bug 1564221)
Backed out changeset ad7a644c5a8d (bug 1564221)
Backed out changeset 31f730109760 (bug 1564221)
Backed out changeset a140da3467e0 (bug 1564221)
Backed out changeset 02a324e713d6 (bug 1564221)
Backed out changeset dc76eeb3a74a (bug 1564221)
Backed out changeset bc933f236434 (bug 1564221)
2019-08-06 20:49:21 +03:00
Barret Rennie
3df3c840f0 Bug 1564221 - Make nsITransportSecurityInfo builtinclass r=keeler
There are no longer any consumers of the JS-implemented
`FakeTransportSecurityInfo` class, so it can be removed. That removes the last
JS-implemented `nsITransportSecurityInfo` instance and it therefore can be
marked `builtinclass`.

Differential Revision: https://phabricator.services.mozilla.com/D40355

--HG--
extra : moz-landing-system : lando
2019-08-06 15:36:52 +00:00
Barret Rennie
82b162a511 Bug 1564221 - Do not use FakeTransportSecurityInfo in test_sss_resetState.js r=keeler
As part of making `nsITranportSecurityInfo` builtinclass, we can no longer
use JS-implemented `nsITransportSecurityInfo` instances in test cases.
This patch migrates `test_sss_resetState.js` to use `add_connection_test()` to
get a valid `nsITransportSecurityInfo` instance for the unit tests.

Differential Revision: https://phabricator.services.mozilla.com/D40352

--HG--
extra : moz-landing-system : lando
2019-08-06 16:14:34 +00:00
Barret Rennie
62b5e6bead Bug 1564221 - Do not use FakeTransportSecurityInfo in test_sss_originAttributes.js r=keeler
As part of making `nsITranportSecurityInfo` builtinclass, we can no longer use
JS-implemented `nsITransportSecurityInfo` instances in test cases. This patch
migrates `test_sss_originAttributes.js` to use `add_connection_test()` to get a
valid `nsITransportSecurityInfo` instance for the unit tests.

Differential Revision: https://phabricator.services.mozilla.com/D40351

--HG--
extra : moz-landing-system : lando
2019-08-06 15:36:18 +00:00
Barret Rennie
e7f9be23da Bug 1564221 - Do not use FakeTransportSecurityInfo in test_sss_enumerate.js r=keeler
As part of making `nsITranportSecurityInfo` builtinclass, we can no longer
use JS-implemented `nsITransportSecurityInfo` instances in test cases.
This patch migrates `test_sss_enumerate.js` to use `add_connection_test()` to
get a valid `nsITransportSecurityInfo` instance for the unit tests.

Differential Revision: https://phabricator.services.mozilla.com/D40350

--HG--
extra : moz-landing-system : lando
2019-08-06 16:17:35 +00:00
Barret Rennie
b829b4078b Bug 1564221 - Do not use FakeTransportSecurityInfo in test_pinning_header_parsing.js r=keeler
As part of making `nsITranportSecurityInfo` builtinclass, we can no longer use
JS-implemented `nsITransportSecurityInfo` instances in test cases. This patch
migrates `test_pinning_header_parsing.js` to use `add_connection_test()` to get
a valid `nsITransportSecurityInfo` instance for the unit tests.

Differential Revision: https://phabricator.services.mozilla.com/D40349

--HG--
extra : moz-landing-system : lando
2019-08-06 15:35:51 +00:00
Barret Rennie
a1140840ab Bug 1564221 - Do not use FakeTransportSecurityInfo in test_ocsp_must_staple.js r=keeler
As part of making `nsITranportSecurityInfo` builtinclass, we can no longer use
JS-implemented `nsITransportSecurityInfo` instances in test cases. This patch
migrates `test_ocsp_must_staple.js` to use `add_connection_test()` to get a
valid `nsITransportSecurityInfo` instance for the unit tests.

Differential Revision: https://phabricator.services.mozilla.com/D40348

--HG--
extra : moz-landing-system : lando
2019-08-06 15:35:32 +00:00
Barret Rennie
2629fef012 Bug 1564221 - Do not use FakeTransportSecurityInfo in test_forget_about_site_security_headers.js r=keeler
As part of making `nsITranportSecurityInfo` builtinclass, we can no longer use
JS-implemented `nsITransportSecurityInfo` instances in test cases. This patch
migrates `test_forget_about_site_security_headers.js to use
`add_connection_test()` to get a valid `nsITransportSecurityInfo` instance for
the unit tests.

Differential Revision: https://phabricator.services.mozilla.com/D40347

--HG--
extra : moz-landing-system : lando
2019-08-06 16:03:52 +00:00
Barret Rennie
adf4a3e19e Bug 1564221 - Add a contract ID for nsITransportSecurityInfo r=keeler
There is now a contract ID for `nsITransportSecurityInfo`, allowing
`mozilla::psm::TransportSecurityInfo` instances to be created from JS. Tests
using a JS-implemented `nsITransportSecurityInfo` that were not modifying,
e.g., the `serverCert` attribute have been updated to create a
`mozilla::psm::TransportSecurityInfo` via the contract.

Differential Revision: https://phabricator.services.mozilla.com/D40346

--HG--
extra : moz-landing-system : lando
2019-08-06 15:35:04 +00:00
Moritz Birghan
978fb0351d Bug 1360307 - Improves the arguments to mozilla::psm::InitializeNSS r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39011

--HG--
extra : moz-landing-system : lando
2019-08-02 17:51:22 +00:00
Kershaw Chang
39ab60f95d Bug 1267643 - Remove client certificate filtering based on CA names r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39345

--HG--
extra : moz-landing-system : lando
2019-08-02 12:45:51 +00:00
ffxbld
6dfb6ea6a1 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D40198

--HG--
extra : moz-landing-system : lando
2019-08-01 13:24:01 +00:00
Moritz Birghan
31f729e8c4 Bug 1004308 - rename BadCertServer to BadCertAndPinningServer r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39748

--HG--
rename : security/manager/ssl/tests/unit/tlsserver/cmd/BadCertServer.cpp => security/manager/ssl/tests/unit/tlsserver/cmd/BadCertAndPinningServer.cpp
extra : moz-landing-system : lando
2019-07-31 17:06:07 +00:00
Gurzau Raul
08ddcd8a5a Backed out changeset 4a66bfcbaca5 (bug 1360307) for build bustage at Logging.h on a CLOSED TREE. 2019-07-31 20:22:43 +03:00
Moritz Birghan
356d25bd08 Bug 1360307 - Improves the arguments to mozilla::psm::InitializeNSS r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39011

--HG--
extra : moz-landing-system : lando
2019-07-31 16:52:02 +00:00
Johann Hofmann
7b984428e8 Bug 1567826 - Don't mark any secureContext pages as insecure. r=nhnt11,keeler,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D39012

--HG--
extra : moz-landing-system : lando
2019-07-30 12:31:22 +00:00
Ciure Andrei
e432090afa Backed out changeset ded87cc3f3ee (bug 1567826) for causing browser_check_identity_state.js to perma fail CLOSED TREE 2019-07-30 12:50:29 +03:00
Johann Hofmann
04c28108fc Bug 1567826 - Don't mark any secureContext pages as insecure. r=nhnt11,keeler,Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D39012

--HG--
extra : moz-landing-system : lando
2019-07-30 07:52:59 +00:00
ffxbld
9ee911f801 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D39676

--HG--
extra : moz-landing-system : lando
2019-07-29 13:29:43 +00:00
Bogdan Tara
7658261678 Backed out changeset 9bed62de3d16 (bug 1267643) for browser_urlbar_speculative_connect_not_with_client_cert.js failures CLOSED TREE 2019-07-29 13:02:17 +03:00
Kershaw Chang
2d553f2a61 Bug 1267643 - Remove client certificate filtering based on CA names r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39345

--HG--
extra : moz-landing-system : lando
2019-07-29 08:48:01 +00:00
J.C. Jones
3295f36c36 Bug 1569223 - Add support to pykey.py for exporting EC keys r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39520

--HG--
extra : moz-landing-system : lando
2019-07-26 17:56:31 +00:00
J.C. Jones
7d89d6183a Bug 1569223 - Support EC keys in TLSServer.cpp r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39519

--HG--
extra : moz-landing-system : lando
2019-07-26 19:17:40 +00:00
J.C. Jones
aca1e19c11 Bug 1569221 - Change TLSServer.cpp to support the modern SSL_ConfigServerCert r=keeler
This patch does not change the existing servers to use the new mechanism, rather
attempting to be minimalist. I filed Bug 1569222 for that.

Differential Revision: https://phabricator.services.mozilla.com/D39518

--HG--
extra : moz-landing-system : lando
2019-07-26 20:09:43 +00:00
Jared Wein
d2b2321cc8 Bug 1567667 - Decrypted strings returned from asyncDecryptStrings need to be converted to UTF16. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39443

--HG--
extra : moz-landing-system : lando
2019-07-26 19:13:11 +00:00
Kannan Vijayan
3fb6190ec6 Bug 1559414 - Rename unaudited pre-fission methods with SameProcess for future audit burndown. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D39378

--HG--
extra : moz-landing-system : lando
2019-07-26 16:48:31 +00:00
ffxbld
b7828720b0 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D39331

--HG--
extra : moz-landing-system : lando
2019-07-25 13:20:25 +00:00
Andreea Pavel
e4263c00eb Merge mozilla-inbound to mozilla-central. a=merge 2019-07-25 08:59:39 +03:00
Moritz Birghan
1b9a759258 Bug 1549818 - Removes expired FIPS_ENABLED telemetry probe r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39027

--HG--
extra : moz-landing-system : lando
2019-07-24 19:59:27 +00:00
Moritz Birghan
e58c39f78e Bug 1549015 - Removes privilegedPackageRoot r=keeler
nsIX509CertDB::PrivilegedPackageRoot was added in bug 1178518 to support privileged packaged apps for Firefox OS. However, we no longer need to support this use-case.

Differential Revision: https://phabricator.services.mozilla.com/D38655

--HG--
extra : moz-landing-system : lando
2019-07-24 19:54:41 +00:00
Kershaw Chang
0bcf85d6e8 Bug 1566030 - Remove nsIClientAuthUserDecision r=keeler,snorp
This patch removes nsIClientAuthUserDecision and add another output parameter to nsIClientAuthDialogs.chooseCertificate.

Differential Revision: https://phabricator.services.mozilla.com/D38074

--HG--
extra : moz-landing-system : lando
2019-07-24 17:49:45 +00:00
Moritz Birghan
206270643c Bug 1567005 - Deletes SECKEYEncryptedPrivateKeyInfo_true r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D39007

--HG--
extra : moz-landing-system : lando
2019-07-24 17:08:15 +00:00
J.C. Jones
b2cd117111 Bug 1562773 - Add a preference to enable Delegated Credentials in NSS r=keeler
This patch adds a new pref, "security.tls.enable_delegated_credentials",
default false, which controls the NSS option SSL_ENABLE_DELEGATED_CREDENTIALS.

Tests are in D37918.

Differential Revision: https://phabricator.services.mozilla.com/D37907

--HG--
extra : moz-landing-system : lando
2019-07-22 20:53:48 +00:00
Boris Zbarsky
0f70d08ec8 Bug 1566595. Stop using [array] in nsIBinaryOutputStream. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D38387

--HG--
extra : moz-landing-system : lando
2019-07-22 20:27:39 +00:00
Moritz Birghan
c3b9c4615e Bug 1559520 - Removes nsIX509CertDB::DeveloperImportedRoot r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D38052

--HG--
extra : moz-landing-system : lando
2019-07-22 13:16:13 +00:00
Ciure Andrei
98278afa46 Backed out changeset a858e4411532 (bug 1566595) for causing Windows MinGW builds bustages CLOSED TREE 2019-07-22 21:39:08 +03:00
Boris Zbarsky
9c74919340 Bug 1566595. Stop using [array] in nsIBinaryOutputStream. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D38387

--HG--
extra : moz-landing-system : lando
2019-07-22 14:52:04 +00:00
ffxbld
6f481990b3 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D38858

--HG--
extra : moz-landing-system : lando
2019-07-22 13:21:35 +00:00
Kris Maglione
e40b418215 Bug 1566952: Part 2 - Update Fission failure annotations after skipping crashes. r=mccr8
When a test crashes, the harness skips all of the remaining tests in the
directory. That means that with crashes skipped, we now try to run a whole lot
more tests than we did before, and a lot of them fail under Fission.

This patch adds annotations to the new failures that show up after part 1.

Differential Revision: https://phabricator.services.mozilla.com/D38726

--HG--
extra : rebase_source : 292157039c88fc615f5de41679e96e72766ac4db
2019-07-19 12:30:10 -07:00
Dana Keeler
e32b862175 bug 1560403 - leave cert_storage's lmdb open in rw mode r=nanj
Bug 1543795 configured lmdb to use less memory when opening a database in
read/write mode, so we can remove the workaround code in cert_storage that was
added in bug 1538093 as a way to mitigate the memory usage.

Differential Revision: https://phabricator.services.mozilla.com/D38525

--HG--
extra : moz-landing-system : lando
2019-07-18 21:43:14 +00:00
ffxbld
28af937c05 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D38478

--HG--
extra : moz-landing-system : lando
2019-07-18 12:58:04 +00:00
Kris Maglione
0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00