Automatic update from web-platform-tests
Resolve relative colors for canvas 2d
In https://crrev.com/c/5825542 we deferred resolution of all relative
colors until after parse time for compatibility with expectations on
serialized values. Canvas 2d was still expecting these colors to be
resolved at parse time. The fix is to adjust the code to expect and
handle unresolved color functions.
Bug: 368562233
Change-Id: Iaafcab7cd45c0222317fe84343e3139a76fb1315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5883454
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359669}
--
wpt-commits: e3af2c724e7ddd08425d3fc0a26fda1637242436
wpt-pr: 48330
Automatic update from web-platform-tests
Fix <label>s for base-select custom <button>
This patch makes clicking on a label pointing to a base-select with an
author provided <button> focus the <button>, just like it focuses the
<select> element itself when there is no author provided <button>.
Change-Id: I12355e223de996138b64d9d9b17b8226eea6e06d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5879535
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359568}
--
wpt-commits: 47999dca71ee583c01875e3a8793acd0411c9766
wpt-pr: 48318
Automatic update from web-platform-tests
[wpt] Ignore testdriver messages in `sandboxed_iframe.https.window.js`
Fix two issues causing the test to fail spuriously upstream when run
with WebDriver [0]:
a. testdriver.js uses regular `postMessage()`/`onmessage` to communicate
testdriver commands between the parent and child frames.
Unfortunately, until [1] is resolved, tests that use `onmessage` need
to be aware of this implementation detail and ignore the internal
messages.
b. The parent needs `testdriver(-vendor).js` too so that testdriver
commands from the child frame are correctly pumped out [2] to the
harness, which will send the WebDriver command.
Content shell currently passes the test because its testdriver is backed
by internal JS bindings that directly hook into the browser.
[0]: https://wpt.fyi/results/serial/requestPort/sandboxed_iframe.https.window.html?run_id=5088854063448064
[1]: https://github.com/web-platform-tests/wpt/issues/48326
[2]: https://github.com/web-platform-tests/wpt/blob/8ae822f0/tools/wptrunner/wptrunner/testdriver-extra.js#L22
Bug: None
Change-Id: Iddb130f92c1877e389a46cb89a35c21bbfd1b625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5888384
Reviewed-by: Jack Hsieh <chengweih@chromium.org>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1359563}
--
wpt-commits: 50433bccd99443bf1c59165a0c9a5b88a3c5c3ae
wpt-pr: 48328
Automatic update from web-platform-tests
[Digital credentials WPT] Fix non-fully-active test
This CL switches the test to use navigator.credentials instead of
navigator.identity. navigator.credentials handles ScriptState::ContextIsValid() == false
BUG=343991289
Change-Id: If04237247ada802b6cd2447bc6336422658a94c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5882341
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359564}
--
wpt-commits: 2684c095bd0faa0dcefac102887d3b633b22732a
wpt-pr: 48316
Automatic update from web-platform-tests
FSA: Remove all file entry removing cleanup in directory tests
Now that directory tests have a cleanup function builtin to clear up any
files left behind, remove all the previous cleanup code that added this.
Mostly a mechanical change of removing the test argument from these
functions:
- createEmptyFile
- createDirectory
- createFileWithContents
- create_file_system_handles
Verified that all these functions appear in directory_test.
Bug: 346991169
Change-Id: I751cd6c3eb5292ac791de872a89abe195490c7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878964
Reviewed-by: Christine Hollingsworth <christinesm@chromium.org>
Commit-Queue: Nathan Memmott <memmott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359545}
--
wpt-commits: 4a381c7dbdf744ae0ef9d7e87aeb26eedd68af84
wpt-pr: 48327
In the past we also autofill into invisible <input> fields for the
following scenario:
frame1:
<input id="visibile-cc-number"/>
<input id="invisibile-cc-name"/>
<input id="invisibile-cc-exp"/>
frame2:
<input id="invisibile-cc-number"/>
<input id="visibile-cc-name"/>
<input id="invisibile-cc-exp"/>
frame3:
<input id="invisibile-cc-number"/>
<input id="invisibile-cc-name"/>
<input id="visibile-cc-exp"/>
So when autofilling the first frame, we also autofill invisible fields in
the same frame - cc-name and cc-exp, and then the website propagates these
values to other frames. Although this behavior results in the correct autofill
for all visible <input> across different frames, it can cause issues with display
highlights, clearing autofill results.
Now that we have implemented support for autofill across iframes, we should no
longer autofill into invisible fields.
Differential Revision: https://phabricator.services.mozilla.com/D223294
This attribute can be used to guarantee that some global initialization take
place at compile-time, avoiding library loading overhead and static
initialization order fiasco.
Differential Revision: https://phabricator.services.mozilla.com/D222798
ClearFutureFrames() is not required in MaybeResolveEndPromise() when the
VideoQueue() is empty, because the queue is now not emptied until end of
playback. An empty queue before end of playback means no frames have been set
in the VideoFrameContainer.
Differential Revision: https://phabricator.services.mozilla.com/D223694
This is adding a couple theme variables to handle
the hover background/color for menu and autocomplete list.
The doorhanger item also have an active state which seems
pretty unique, so we're only handling this at the component
level.
Differential Revision: https://phabricator.services.mozilla.com/D223309
This is adding highly contrasted, non-system colors picked by the a11y
team to override --theme-highlight-* colors in High Contrast Mode.
Differential Revision: https://phabricator.services.mozilla.com/D223474
The documentation implied that a minimum queue size of 0 would remedy A/V sync
but this actually just changes the effect to a playback stall, as reported in
bug 1316571 and others.
A subsequent patch will restore the minimum queue size of 1, but still
drop frames while the video is playing.
Differential Revision: https://phabricator.services.mozilla.com/D223693
In bug 1910287, we made the method accept `WM_DEADCHAR` message whose `wParam`
is `0` as a valid char message. However, it may be different from found dead
char message at least for an Ethiopic Syllable input.
In the case, we found a WM_DEADCHAR whose `wParam` may not be `0`. Then, we
remove the message from the queue. However, the keyboard/IME makes us to
remove a dummy message whose wParam (inputting character) is NULL and scancode
is 0. Finally, the found message keeps staying in the queue. The crash report
comes after we started accepting WM_DEADCHAR with NULL character above.
However, we haven't handled only a part of dead key sequence but the user tried
to input Ethiopic Syllable. Therefore, it's hard to guess that the user starts
using Firefox with the IME at the timing and the the user keeps using Firefox
with unfunctional IME. Perhaps the IME does something different hack for us to
make itself available on Firefox. Therefore, we should just return `false` as
what we did to make the caller give up removing the following messages.
Differential Revision: https://phabricator.services.mozilla.com/D223245
This also removes VPN detection. That was only really necessary back when the
weather suggestion was zero-prefix, i.e., when it was shown simply by clicking
in the urlbar without typing anything. I think if you go to the trouble of
typing a weather keyword, we should show you the suggestion even if you're on a
VPN.
Differential Revision: https://phabricator.services.mozilla.com/D223874
This commit extends the Skv importer to allow consolidating multiple
Rkv databases in different storage directories, which add-ons would
like to do when they migrate (bug 1919530).
`nsIKeyValueImporter` is now a fluent builder interface. Callers can
use `importer.add{Database, AllDatabases}()` to configure the importer
to import Rkv databases in the same storage directory, and use
`importer.addSourcePath().add{Database, AllDatabases()}` to configure
importing databases from other directories. The reworked `import()`
method does the actual import.
Differential Revision: https://phabricator.services.mozilla.com/D223229
`kvstore` uses "wide" `ns{A}String`s (potentially ill-formed UTF-16
strings) to represent paths in its XPCOM interface methods.
`ns{A}String` doesn't implement `Hash` or the built-in comparison
traits, so a wide path can't currently be used as a map key.
This commit introduces a `WidePathBuf` wrapper type, with the same
semantics as an `ns{A}String` path, but usable as a map key.
Differential Revision: https://phabricator.services.mozilla.com/D223228
I think this is a bit more consistent, and makes us preserve the
invariant that from_computed_value().to_computed_value() round-trips.
Differential Revision: https://phabricator.services.mozilla.com/D223878
Allowing (once again) a no-gpu-process option increases the number of
pixels which get antialiased differently than the reference image. The
images continue to largely match; it's just an increase in the number of
close-but-not-quite pixels.
Differential Revision: https://phabricator.services.mozilla.com/D223395
This allows us to test platforms that support GPU process without
enabling the GPU process. It may help us flush out differing test
outcomes between the two cases. Eventually this will be retired when all
platforms have mature GPU process implementations.
Differential Revision: https://phabricator.services.mozilla.com/D222340
At some point, UtilityAudioDecoderChild lost the ability to work
*without* a GPU process. This patch remedies that by creating an
alternate connection for the endpoint, modeled after the code in
RDDProcessManager.
Differential Revision: https://phabricator.services.mozilla.com/D223015
