Commit Graph

295 Commits

Author SHA1 Message Date
Jan Varga
a87575bf55 Bug 1619592 - Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D65937

--HG--
extra : moz-landing-system : lando
2020-03-13 12:55:20 +00:00
Simon Giesecke
d8537d4388 Bug 1617170 - Remove some local helper classes. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64343

--HG--
extra : moz-landing-system : lando
2020-03-11 16:49:15 +00:00
shindli
0b7c33c8d9 Backed out changeset 50af9d58c645 (bug 1619592) for causing build bustages in /builds/worker/checkouts/gecko/dom/quota/PersistenceType.cpp CLOSED TREE 2020-03-11 10:37:51 +02:00
Jan Varga
a415028a3c Bug 1619592 - Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D65937

--HG--
extra : moz-landing-system : lando
2020-03-11 08:08:46 +00:00
Simon Giesecke
071004fb63 Bug 1617170 - Added const at a few places. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64342

--HG--
extra : moz-landing-system : lando
2020-03-07 09:34:31 +00:00
Simon Giesecke
2c98fa92a7 Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D63681

--HG--
extra : moz-landing-system : lando
2020-03-07 09:31:48 +00:00
Boris Zbarsky
c878a8bb26 Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D65538

--HG--
extra : moz-landing-system : lando
2020-03-06 21:04:58 +00:00
Boris Zbarsky
0082f55dee Bug 1618011 part 7. Switch most error messages used in bindings to having a method name prefix. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64888

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
Arthur Iakab
14247fb057 Backed out 11 changesets (bug 1618011)for Linting failure.
CLOSED TREE

Backed out changeset 8b11ddd8999f (bug 1618011)
Backed out changeset 11df2f359473 (bug 1618011)
Backed out changeset c50121035d50 (bug 1618011)
Backed out changeset 8b8c4c60c34b (bug 1618011)
Backed out changeset b01f8c66110b (bug 1618011)
Backed out changeset 433fdf04058c (bug 1618011)
Backed out changeset 29a9227d08ac (bug 1618011)
Backed out changeset b2dfa2e66d24 (bug 1618011)
Backed out changeset 85650ee945c4 (bug 1618011)
Backed out changeset 278a213e5304 (bug 1618011)
Backed out changeset 9119aeb72ea4 (bug 1618011)
2020-03-07 00:15:57 +02:00
Boris Zbarsky
bc068d0e54 Bug 1618011 part 7. Switch most error messages used in bindings to having a method name prefix. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D64888

--HG--
extra : moz-landing-system : lando
2020-03-06 20:39:10 +00:00
Andreea Pavel
110347c99a Backed out 8 changesets (bug 1617170) for build bustages at nsTArray.h on a CLOSED TREE
Backed out changeset ed7eaba53757 (bug 1617170)
Backed out changeset 0021ab4bcf77 (bug 1617170)
Backed out changeset 92f4ef8809ec (bug 1617170)
Backed out changeset c9561cb90821 (bug 1617170)
Backed out changeset 739dafac70bc (bug 1617170)
Backed out changeset 51c699b06d04 (bug 1617170)
Backed out changeset 2ae6b424f492 (bug 1617170)
Backed out changeset 6acafdd56175 (bug 1617170)
2020-03-06 17:57:23 +02:00
Simon Giesecke
6cb20b0f86 Bug 1617170 - Added const at a few places. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64342

--HG--
extra : moz-landing-system : lando
2020-03-06 15:37:23 +00:00
Simon Giesecke
63db82d1eb Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D63681

--HG--
extra : moz-landing-system : lando
2020-03-06 15:34:18 +00:00
shindli
ff75fdf21a Backed out 5 changesets (bug 1617170) for toolchains bustages CLOSED TREE
Backed out changeset cc2aadaf5923 (bug 1617170)
Backed out changeset bda38a16aac3 (bug 1617170)
Backed out changeset 5d3ed69aca66 (bug 1617170)
Backed out changeset 90dfe1253fe4 (bug 1617170)
Backed out changeset f1a4f3952931 (bug 1617170)
2020-03-06 14:55:58 +02:00
Simon Giesecke
517784f1bc Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D63681

--HG--
extra : moz-landing-system : lando
2020-03-06 12:30:35 +00:00
Simon Giesecke
26b1a35f01 Bug 1617170 - Use nsBaseHashtable::RemoveIf function in dom/indexedDB code. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D64091

--HG--
extra : moz-landing-system : lando
2020-03-05 19:51:36 +00:00
Simon Giesecke
dbe2bf92ec Bug 1613340 - Remove const_cast relating to ObjectStoreSpec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61669

--HG--
extra : moz-landing-system : lando
2020-03-03 13:44:47 +00:00
Boris Zbarsky
c343055996 Bug 1614164. Stop using NS_ERROR_DOM_TYPE_ERR in IndexedDB. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D62153

--HG--
extra : moz-landing-system : lando
2020-02-11 07:25:44 +00:00
Boris Zbarsky
05327f8a52 Bug 1613978. Allow passing u"...", not just nsAStrings, to templated ThrowType/RangeError. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D62061

--HG--
extra : moz-landing-system : lando
2020-02-10 13:08:48 +00:00
Boris Zbarsky
b88d5ac5a8 Bug 1612213 part 1. Switch most consumers of ThrowDOMException to the new methods. r=smaug,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D61267

--HG--
extra : moz-landing-system : lando
2020-02-03 20:19:11 +00:00
Simon Giesecke
37b6637a59 Bug 1497007 - Replace CanAcceptRequests by the now equivalent IsActive. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D59834

--HG--
extra : moz-landing-system : lando
2020-01-17 12:47:09 +00:00
Andrea Marchesini
a91dd40dff Bug 1024312 - Get rid of IDBDatabase.mozCreateFileHandle, r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D59499

--HG--
extra : moz-landing-system : lando
2020-01-14 15:09:02 +00:00
Simon Giesecke
e4ec4856f2 Bug 1600906 - Use std::move instead of swap, use const where then possible. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57988

Differential Revision: https://phabricator.services.mozilla.com/D57989

--HG--
extra : moz-landing-system : lando
2020-01-09 14:43:57 +00:00
Simon Giesecke
77ea686b98 Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55520

--HG--
extra : moz-landing-system : lando
2019-12-19 09:57:49 +00:00
Simon Giesecke
d6cc618323 Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55515

--HG--
extra : moz-landing-system : lando
2019-12-19 09:56:45 +00:00
Simon Giesecke
1fb48dd681 Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55478

--HG--
extra : moz-landing-system : lando
2019-12-13 12:31:10 +00:00
Simon Giesecke
7e8ae185d6 Bug 1600283 - Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55477

--HG--
extra : moz-landing-system : lando
2019-12-13 12:18:21 +00:00
Simon Giesecke
0d732b3ed3 Bug 1596129 - Extract CreateSortedDOMStringList function and reuse in IDBObjectStore::IndexNames. r=dom-workers-and-storage-reviewers,ytausky
Depends on D52867

Differential Revision: https://phabricator.services.mozilla.com/D52868

--HG--
extra : moz-landing-system : lando
2019-11-28 20:24:33 +00:00
Simon Giesecke
90427d7da3 Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54322

--HG--
extra : moz-landing-system : lando
2019-11-28 16:00:29 +00:00
Simon Giesecke
55a2f652bc Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54321

--HG--
extra : moz-landing-system : lando
2019-11-27 10:54:57 +00:00
Simon Giesecke
be00b51583 Bug 1596129 - Use range-based for, std::find_if, std::unique and avoid insert-sort on a nsTArray in IDBDatabase::Transaction. r=dom-workers-and-storage-reviewers,ytausky
Depends on D52864

Differential Revision: https://phabricator.services.mozilla.com/D52865

--HG--
extra : moz-landing-system : lando
2019-11-21 12:38:12 +00:00
Simon Giesecke
2ac5e4e5ab Bug 1596129 - Make use of std::find_if in IDBDatabase::DeleteObjectStore. r=dom-workers-and-storage-reviewers,ttung
Depends on D52863

Differential Revision: https://phabricator.services.mozilla.com/D52864

--HG--
extra : moz-landing-system : lando
2019-11-21 11:01:55 +00:00
Simon Giesecke
9b32f09fd2 Bug 1596129 - Make use of std::find_if in IDBDatabase::CreateObjectStore. r=dom-workers-and-storage-reviewers,ttung
Depends on D52862

Differential Revision: https://phabricator.services.mozilla.com/D52863

--HG--
extra : moz-landing-system : lando
2019-11-20 15:18:33 +00:00
Simon Giesecke
f81c6cb091 Bug 1596129 - Make use of std::transform, avoid doing an insert sort into an nsTArray in IDBDatabase::ObjectStoreNames. r=dom-workers-and-storage-reviewers,ttung
Depends on D52861

Differential Revision: https://phabricator.services.mozilla.com/D52862

--HG--
extra : moz-landing-system : lando
2019-11-21 08:55:38 +00:00
ssengupta
97bb846b1e Bug 1597959 - Return from IDBDatabase::RenameObjectStore immediately if aObjectStoreId and aName both match. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D53947

--HG--
extra : moz-landing-system : lando
2019-11-21 11:54:40 +00:00
Dorel Luca
30c26d0a23 Backed out changeset a13d1af8d1b5 (bug 1558522) for Crashtest failures in reftest/tests/xpcom/string/crashtests/1113005.html. CLOSED TREE 2019-11-19 19:23:28 +02:00
Simon Giesecke
f20a6e81d8 Bug 1558522 - Added test case from fuzzer. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D48045

--HG--
extra : moz-landing-system : lando
2019-10-22 17:02:38 +00:00
Simon Giesecke
19128f8aae Bug 1497007 - Added explaining comments. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47231

--HG--
extra : moz-landing-system : lando
2019-11-11 08:25:20 +00:00
Simon Giesecke
1bf29f747f Bug 1497007 - Use IDBTransaction::IsWriteAllowed to simplify code. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47230

--HG--
extra : moz-landing-system : lando
2019-11-11 08:25:13 +00:00
Simon Giesecke
deb959c93c Bug 1168606 - Resolved clang-tidy warnings. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D49274

--HG--
extra : moz-landing-system : lando
2019-11-08 13:22:28 +00:00
shindli
7c774ed0a3 Backed out 8 changesets (bug 1497007) for causing build bustages in /builds/worker/workspace/build/src/dom/indexedDB/IDBTransaction.cpp CLOSED TREE
Backed out changeset 15de0d72f1c4 (bug 1497007)
Backed out changeset 7056932f6422 (bug 1497007)
Backed out changeset 7304fae8c436 (bug 1497007)
Backed out changeset be22a95de04b (bug 1497007)
Backed out changeset 98ac48b5f1ef (bug 1497007)
Backed out changeset 562d3cda9fa3 (bug 1497007)
Backed out changeset 3f96e71be2e3 (bug 1497007)
Backed out changeset 3d9e86698c9f (bug 1497007)
2019-11-08 16:28:53 +02:00
Simon Giesecke
67ff3f2964 Bug 1497007 - Added explaining comments. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47231

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:45 +00:00
Simon Giesecke
b390f011e5 Bug 1497007 - Use IDBTransaction::IsWriteAllowed to simplify code. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47230

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:33 +00:00
Simon Giesecke
7e3b8fe633 Bug 1558522 - Ensure that file actors created after the database was closed are expired. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D48046

--HG--
extra : moz-landing-system : lando
2019-10-09 03:21:22 +00:00
Simon Giesecke
bd2e4939bc Bug 1168606 - Remove duplication in uses of IDB_LOG_MARK. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46576

--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:45 +00:00
Andrea Marchesini
da174a4757 Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga
7af208ab28 Backed out changeset 98452610cfcc (bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini
788d12712b Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
violet
44ea792130 Bug 1507229 - Argument sanity check at CreateMutableFile() to avoid assertion failure r=janv
CreateMutableFile() doesn't allow empty name, we should check it before
further processing to avoid assertion failure.

Differential Revision: https://phabricator.services.mozilla.com/D23999

--HG--
extra : moz-landing-system : lando
2019-03-22 14:01:31 +00:00
Emilio Cobos Álvarez
d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00