Commit Graph

25 Commits

Author SHA1 Message Date
Cristian Tuns
3447333df4 Backed out changeset 6fb2cecebdd8 (bug 1913322) for causing multiple failures. CLOSED TREE 2024-08-20 21:01:50 -04:00
Emilio Cobos Álvarez
9a8a267f79 Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 22:31:22 +00:00
Iulian Moraru
e0e41bf500 Backed out changeset 1658290c1b95 (bug 1913322) for causing overflow related failures. CLOSED TREE 2024-08-20 17:54:54 +03:00
Emilio Cobos Álvarez
47c031614c Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 12:58:16 +00:00
Mike Conley
9415a9f13d Bug 1866802 - Move ASRouterAdmin tool to about:asrouter and its own component folder. r=pdahiya,Gijs,desktop-theme-reviewers,dao
This tries to maintain stylistic continuity, while also trying to decouple from
newtab as much as possible. This is a first foray, and future patches will
further this decoupling.

This also modifies about:asrouter to show an error message if the ASRouter devtools
pref is not set to true.

Differential Revision: https://phabricator.services.mozilla.com/D194811
2023-12-14 18:46:55 +00:00
Butkovits Atila
8582db0ea5 Backed out 5 changesets (bug 1866802) for causing failures at test_TopSitesFeed.js. CLOSED TREE
Backed out changeset af9fbbc9ae50 (bug 1866802)
Backed out changeset 81d5b7de7178 (bug 1866802)
Backed out changeset e4d0863ed222 (bug 1866802)
Backed out changeset c0deb681b193 (bug 1866802)
Backed out changeset dda3e5e39f8c (bug 1866802)
2023-12-14 03:22:48 +02:00
Mike Conley
4b9f3545e2 Bug 1866802 - Move ASRouterAdmin tool to about:asrouter and its own component folder. r=pdahiya,Gijs,desktop-theme-reviewers,dao
This tries to maintain stylistic continuity, while also trying to decouple from
newtab as much as possible. This is a first foray, and future patches will
further this decoupling.

This also modifies about:asrouter to show an error message if the ASRouter devtools
pref is not set to true.

Differential Revision: https://phabricator.services.mozilla.com/D194811
2023-12-13 23:29:48 +00:00
Mike Conley
059b8a1cb7 Bug 1868488 - Add aboutwelcome to the same ESLint directory overrides as newtab. r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D196056
2023-12-11 18:02:41 +00:00
Emilio Cobos Álvarez
2efe17814f Bug 1860666 - Add pref-gated ::slider-* pseudo-elements, and some tests. r=layout-reviewers,jfkthame
We fail some because we right now we have a track pseudo for meter/progress.

I plan to fix this, but a lot of these frame classes are basically copy-pasta,
so I wanted to get rid of them first.

Differential Revision: https://phabricator.services.mozilla.com/D192097
2023-10-30 15:15:24 +00:00
Emilio Cobos Álvarez
aa1b4e435a Bug 1857565 - Remove leftover -moz-image-rect from function-no-unknown lint. r=desktop-theme-reviewers,dao
It's gone.

Differential Revision: https://phabricator.services.mozilla.com/D190312
2023-10-12 12:01:05 +00:00
Emilio Cobos Álvarez
113b9abfc1 Bug 1857522 - Don't ignore pseudo-classes in max-nesting-depth limit. r=Gijs
As that allows you to get around the lint with :is() trivially.

Differential Revision: https://phabricator.services.mozilla.com/D190311
2023-10-08 23:07:36 +00:00
Emilio Cobos Álvarez
f3e1e3ff01 Bug 1857522 - Reduce max nesting depth to 3. r=Gijs
That still doesn't trigger on the code in comment 2, so that is a bit
confusing and needs investigation.

Differential Revision: https://phabricator.services.mozilla.com/D190310
2023-10-08 22:33:39 +00:00
Nicolas Chevobbe
684a2f5628 Bug 1856660 - [devtools] Add stylelint max-nesting-depth rule. r=Gijs
The rule was already enabled for newtab, let's make it the default.

Differential Revision: https://phabricator.services.mozilla.com/D190001
2023-10-05 05:20:46 +00:00
Gijs Kruitbosch
1e67277c8f Bug 1851544 - use clearer media queries in new tab styling, r=Standard8,omc-reviewers,thecount,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D188836
2023-09-27 14:45:18 +00:00
Iulian Moraru
8867443f5d Backed out 2 changesets (bug 1852084) for causing bug 1853970. CLOSED TREE
Backed out changeset 427a6983a14b (bug 1852084)
Backed out changeset aac846ab41a5 (bug 1852084)
2023-09-21 00:41:39 +03:00
Emilio Cobos Álvarez
5bddfadebb Bug 1852084 - Add a -moz-themed(<appearance>) background-image. r=boris
Some appearance values are really just a background.

Being able to draw them using `background-image` instead of appearance
allows us to preserve borders, etc.

Differential Revision: https://phabricator.services.mozilla.com/D187851
2023-09-15 22:16:28 +00:00
Mark Banner
e640e38886 Bug 1563927 - Upgrade stylelint to the latest version. r=Gijs
Depends on D186882

Differential Revision: https://phabricator.services.mozilla.com/D187424
2023-09-05 12:59:31 +00:00
Emilio Cobos Álvarez
a942bb2bfc Bug 1850811 - Add light-dark() to stylelintrc. r=dao
MANUAL PUSH: This was originally reviewed in bug 1843044.
2023-09-01 13:01:52 +02:00
Cristian Tuns
72e7b89401 Backed out changeset 37a26c9f2c5c (bug 1843044) for breaking macOS dark theme CLOSED TREE 2023-09-01 05:03:36 -04:00
Emilio Cobos Álvarez
32d7994287 Bug 1843044 - Make the default theme work with dark color schemes. r=dao,pbz
This builds on the light-dark() function added in bug 1845679 to provide
custom colors for both the default light and dark themes, and remove the
"default theme in dark mode" bits.

This is all to be landed after the soft-freeze in any case. Untested on
macOS for now, but no reason it shouldn't work. Will test later today.

Differential Revision: https://phabricator.services.mozilla.com/D184708
2023-08-31 10:43:54 +00:00
Shane Hughes
d399ad1b76 Bug 1835028 - Change newtab stylelint problem severity from warning to error. r=Gijs,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D179906
2023-06-05 12:58:01 +00:00
Gijs Kruitbosch
ecc15a8a0d Bug 1832765 - merge new tab linting into main stylelint config, r=Standard8,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D178533
2023-05-30 22:41:22 +00:00
Gijs Kruitbosch
b4130b15da Bug 1832765 - start linting scss across the tree in our standard config, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D178532
2023-05-30 22:41:22 +00:00
Nicolas Chevobbe
bff321d727 Bug 1831302 - [devtools] remove unused debugger .stylelintrc and .stylelintignore. r=Gijs,devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D177910
2023-05-15 08:35:12 +00:00
Gijs Kruitbosch
f238fa0035 Bug 1508369 - add stylelint linter support to mach lint, r=Standard8,dao,linter-reviewers,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D177477
2023-05-11 16:06:38 +00:00