Commit Graph

756175 Commits

Author SHA1 Message Date
Narcis Beleuzu
6371054f62 Bug 1709401 - Fix lint failure a=lint-fix . CLOSED TREE 2021-05-04 20:59:02 +03:00
Iain Ireland
7e9674da69 Bug 1708839: Add implicit use after folding away fallible unbox r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D114165
2021-05-04 17:41:09 +00:00
Tom Ritter
b5376d204b Bug 1709401 - Shim the python 3.8 API get_source_segment for ./mach vendor r=jewilde
Differential Revision: https://phabricator.services.mozilla.com/D114254
2021-05-04 17:33:17 +00:00
Niklas Goegge
1064d9dc06 Bug 1708704 - Check for null pointers when using GetWindowContext() r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D114226
2021-05-04 17:25:23 +00:00
Dana Keeler
e70c11b585 Bug 1706056 - increase the parallelism of getHSTSPreloadList.js r=releng-reviewers,jmaher
Before this patch, getHSTSPreloadList.js would have no more than 250 requests
in flight at any given time. In the past, this limit was 500. After a refactor
that inadvertantly completely removed the limit, it was reduced to 250.
Presumably increasing it to 500 again will not have negative effects and will
allow the script to run faster.

Differential Revision: https://phabricator.services.mozilla.com/D114019
2021-05-04 17:21:01 +00:00
Rob Lemley
a1d018520f Bug 1566090 - Use sha1 hashes in find-dupes.py. r=glandium
As suggested in the review comments for bug 1526744 (D37758), sha1 is slightly
faster.
Variables with "md5" in their names have been renamed as well.

Differential Revision: https://phabricator.services.mozilla.com/D113681
2021-05-04 17:10:37 +00:00
Tomislav Jovanovic
9da11e6641 Bug 1702231 - Make InstallTrigger tests work with BFcache in parent r=mixedpuppy
With bfcacheInParent enabled, frameloader gets replaced on (each?) navigation,
and now a ContentTask script can't listen for "load" events after navigating.

Differential Revision: https://phabricator.services.mozilla.com/D114051
2021-05-04 17:08:29 +00:00
Yulia Startsev
d15f5ac9b6 Bug 1708469 - Split realms, compartments, zones, context and runtime from JSApi; r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D113813
2021-05-04 16:53:05 +00:00
Dão Gottwald
0951f34344 Bug 1709367 - Clean up primary button variables. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D114238
2021-05-04 16:36:53 +00:00
Dão Gottwald
d6c350a859 Bug 1709335 - Stop overriding --panel-disabled-color for the address and search bars on macOS. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D114228
2021-05-04 16:35:43 +00:00
Calixte Denizet
d1be9b3b85 Bug 1685505 - When env GCOV_CHILD_PREFIX is set then generate gcdas for each process in different directories (named in appending their pid). r=marco
In order to avoid concurrency issues when dumping or to be able to have a ccov report per process, when GCOV_CHILD_PREFIX is set, set child processes' GCOV_PREFIX to GCOV_CHILD_PREFIX + child process PID

Differential Revision: https://phabricator.services.mozilla.com/D114239
2021-05-04 16:34:27 +00:00
Dorel Luca
f8cffec171 Backed out 4 changesets (bug 1707590) for worker/checkouts/gecko/config/rules.mk. CLOSED TREE
Backed out changeset 4ccdb31e1c5a (bug 1707590)
Backed out changeset 4b69f99caf69 (bug 1707590)
Backed out changeset a3f23a20b532 (bug 1707590)
Backed out changeset f591c3da4311 (bug 1707590)
2021-05-04 20:29:51 +03:00
Jon Coppeard
3103c7e943 Bug 1708692 - Rearrange arena header to move alloc kind out of flags bitfield r=sfink
This patch moves the alloc kind out of the flags word and places it between the
freespan and the zone. On 64 bit platforms there is 32 bits of padding here
because zone has pointer alignment and the freespan is 32 bits. On 32 bits
platforms this increases the size of the header but there is enough spare that
this doesn't reduce the arena density for any of our alloc kinds.

This also lets us type allocKind appropraitely.

Depends on D114213

Differential Revision: https://phabricator.services.mozilla.com/D114214
2021-05-04 16:15:32 +00:00
Asumu Takikawa
a96bd5adef Bug 1708124 - Fix OOM case in Wasm ReportError r=rhunt
Differential Revision: https://phabricator.services.mozilla.com/D114146
2021-05-04 16:08:27 +00:00
Calixte Denizet
11d5119f80 Bug 1541224 - Avoid to use uninitialized handle when flushing ccov counters r=marco
Counters can be flushed before init has been called so this patch add a condition in FlushCounters to be sure that everything has been initialized.

Differential Revision: https://phabricator.services.mozilla.com/D110575
2021-05-04 16:02:49 +00:00
Markus Stange
5bcf113e2e Bug 1704102 - On 10.14 and 10.15, make NSMenu adopt the system appearance by briefly changing the NSWindow appearance during menu opening. r=harry
This can be disabled by setting the following pref to false:
widget.macos.enable-pre-bigsur-workaround-for-dark-mode-context-menus

Differential Revision: https://phabricator.services.mozilla.com/D114037
2021-05-04 16:00:52 +00:00
Ryan Hunt
6374503adf Bug 1706124 - wasm: Implement the extended-const proposal. r=lth
This commit implements the extended-constants proposal.
 * A new feature flag and pref are added.
 * Basic tests are added.

Differential Revision: https://phabricator.services.mozilla.com/D112661
2021-05-04 15:58:26 +00:00
Ryan Hunt
17eab55693 Bug 1706124 - wasm: Clean up ref.func/exported function logic in InitExpr. r=lth
ref.func validates specially.
  * In the 'module environment', any function may be the target and using a function
    as a target marks it as available to be targeted in the code section.
  * The the code section, only functions used in the 'module environment' may
    be targeted.

Additionally, any target of ref.func becomes an 'exported function' and will get
a thunk generated for it. The logic for this existed in ModuleGenerator, which
would traverse over all relevant metadata in ModuleEnvironment to find which
functions may be exported. This no longer is trivial, as an InitExpr may
now contain a ref.func instruction encoded in its bytecode vector, instead
of the tagged union that InitExpr was before.

To satisfy all of these requirements, this patch reworks this code.
  * A `FuncFlags` enum is added to `FuncDesc` for each function definition.
  * `FuncFlags` describes whether a func is exported, eager, and can be
    targetted by ref.func.
  * Decoding the ModuleEnvironment now updates the flags of functions as
    it goes.
  * OpIter uses the validation mode to determine whether to check the
    func flags for a ref.func, or not.
  * ConstExpr::decodeAndValidate updates the flags of functions as it goes.
  * ModuleGenerator no longer computes the exported function information
    itself, and relies on function flags.
  * AsmJS writes to function flags for exported functions specially, as
    it previously relied on sharing the exported function code in
    ModuleGenerator that has moved to decoding/validation.

Differential Revision: https://phabricator.services.mozilla.com/D112659
2021-05-04 15:58:26 +00:00
Ryan Hunt
2ea24aaf6b Bug 1706124 - wasm: Rewrite InitExpr to support multiple instructions. r=lth
This commit rewrites InitExpr so that it supports multiple instructions. This
unlocks the ability to implement the extended-constants proposal, along with
rtt.canon/rtt.sub initializers for the GC proposal.

An InitExpr now contains either a literal value for simple expressions, or
a vector of bytecode to be evaluated later. Decoding an InitExpr now uses OpIter
to iterate over instructions and validate the results. OpIter is tweaked to
support alternate validation rules to support the additional restrictions that
initializer expressions have, such as global.get only working on immutable
imported globals. The exception is ref.func, which has special rules that I
defer to its own commit to follow.

An interpreter loop is added to evaluate the bytecode and yield a wasm::Val.
The loop uses a Decoder directly and assumes that the bytecode has been validated
already. The interpreter is not fast, and I assume it doesn't need to be at
this time.

Much code that assumed InitExp was POD had to be updated. Notably, GlobalDesc's
fields have been reorganized to remove the double nested union to make it
sane to store allocated data in it.

I initially intended for the expanded constant expression support to have
it's own header and implementation file (WasmInitExpr.h, WasmInitExpr.cpp).
I then discovered that InitExpr is involved with a challenging include loop
with WasmTypes.h and settled with a just giving it it's own implementation
file. This is unusual for `wasm/` some I'm open to discussions. In the
longer term, I would like to break up WasmTypes.h.

Differential Revision: https://phabricator.services.mozilla.com/D112658
2021-05-04 15:58:25 +00:00
Ryan Hunt
0369231881 Bug 1706124 - wasm: Remove unused reftypes preference. r=lth
Drive-by fix to drop preference for reftypes from StaticPrefList.yaml. This is no
longer used now that the reference types feature gating code is gone.

Depends on D112656

Differential Revision: https://phabricator.services.mozilla.com/D112657
2021-05-04 15:58:25 +00:00
Ryan Hunt
cc3d5b5068 Bug 1706124 - wasm: Organize OpIter. r=lth
Non-essential clean up of OpIter to prepare for being used to decode
and validate constant expressions, in addition to function bodies.

Depends on D112655

Differential Revision: https://phabricator.services.mozilla.com/D112656
2021-05-04 15:58:24 +00:00
Ryan Hunt
88cb224a09 Bug 1706124 - wasm: Organize Decoder for adding more methods. r=lth
Non-essential clean up to prepare Decoder for being used in an
interpreter loop.

Depends on D112654

Differential Revision: https://phabricator.services.mozilla.com/D112655
2021-05-04 15:58:24 +00:00
Ryan Hunt
720cb43b51 Bug 1706124 - wasm: Move Encoder/Decoder to their own file. r=lth
Non-essential clean-up to split off functionality for binary parsing out
of validation. This is useful for a future interpreter loop which runs
in a non-validation context, and would only like to deal with a
Decoder.

Differential Revision: https://phabricator.services.mozilla.com/D112654
2021-05-04 15:58:23 +00:00
AshwiniWankhede
b332049130 Bug 1520434-Improve the error messages when creating unaligned typed arrays r=mgaudet
Improved error messages emitted by JSMSG_TYPED_ARRAY_CONSTRUCT_BOUNDS.Error messages improved to specify the type and cause of error.
Added the test to check the error messages modified matches the expected cases.

Differential Revision: https://phabricator.services.mozilla.com/D113874
2021-05-04 15:34:36 +00:00
Francesco Lodolo (:flod)
0882de8cee WIP: Bug 1709385 - Add Scots (sco) to Nightly builds r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D114248
2021-05-04 15:31:42 +00:00
Kagami Sascha Rosylight
1c2fec0dc9 Bug 1707590 - Part 4: Add image/jxl to Accept header and DownloadsViewableInternally r=necko-reviewers,dragana
Depends on D113360

Differential Revision: https://phabricator.services.mozilla.com/D113688
2021-05-04 15:24:55 +00:00
Kagami Sascha Rosylight
99ed990a2f Bug 1707590 - Part 3: Add feature gate for JXL r=tnikkel,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D113360
2021-05-04 15:24:55 +00:00
Kagami Sascha Rosylight
b28b7b020a Bug 1707590 - Part 2: Implement nsJXLDecoder r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D113359
2021-05-04 15:24:54 +00:00
Kagami Sascha Rosylight
4cf43df159 Bug 1707590 - Part 1: Add vendored libjxl source r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D113358
2021-05-04 15:24:53 +00:00
Sandor Molnar
f7b8c6b3d1 Backed out 2 changesets (bug 1708116) for causing build bustages. CLOSED TREE
Backed out changeset d1488e9d64a6 (bug 1708116)
Backed out changeset 44ed91f0b7b4 (bug 1708116)
2021-05-04 18:41:36 +03:00
Mitchell Hentges
0ff1bef46b Bug 1707953: Remove macOS SDK maximum version check r=firefox-build-system-reviewers,glandium
The maximum version check has caused more unnecessary failed
builds (for freshly up-to-date devs) than helpful guards against
tough-to-diagnose issues.

Differential Revision: https://phabricator.services.mozilla.com/D113675
2021-05-04 15:07:09 +00:00
Mitchell Hentges
20c068df32 Bug 1709084: Don't encode debugger arg as ascii r=sheehan
We're mostly using Python 3 today, so the old `.encode("ascii")`
conversion is no longer needed.

Differential Revision: https://phabricator.services.mozilla.com/D114152
2021-05-04 15:07:07 +00:00
Mitchell Hentges
e170f04fe1 Bug 1707546: Support git worktrees when finding ".arcconfig" r=firefox-build-system-reviewers,andi,tcampbell,glandium
A `.arcconfig` may exist in the `.git` directory. Within worktrees,
the `.git` folder isn't at `<topsrcdir>/.git`, so we have to resolve it.

Differential Revision: https://phabricator.services.mozilla.com/D113320
2021-05-04 15:06:42 +00:00
Joel Maher
2262117921 Bug 1696541 - collect xres again after python3 conversion. r=ahal,perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D113786
2021-05-04 15:02:12 +00:00
Yury Delendik
50fe06fce0 Bug 1706427 - Update wasmparser and cranelift. r=rhunt
Differential Revision: https://phabricator.services.mozilla.com/D112806
2021-05-04 14:59:40 +00:00
Henri Sivonen
cec8f0915a Bug 1702297 - Wait for iframe loading to stabilize before testing element blurring. r=edgar
History shows that the test being modified here tries to test crashiness of
what happens from the onblur handler. That the initial focus originally happened
from the HTML parser instead of from a stable state seems unimportant for the
purpose of the test but introduced an opportunity for timing differences between
runs.

Differential Revision: https://phabricator.services.mozilla.com/D114068
2021-05-04 14:50:53 +00:00
Mark Banner
6ef0eee392 Bug 1529220 - Don't unescape search suggestions in the search bar. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D113852
2021-05-04 14:48:27 +00:00
Steve Fink
d3b88b8f44 Bug 1706364 - Upload built bits (and metadata) for a few more builds that the fuzzing team wants to track r=jkratzer
Differential Revision: https://phabricator.services.mozilla.com/D113883
2021-05-04 14:38:06 +00:00
sanketh
6a3c22f574 Bug 1635603 - Create a nsContentUtils::ShouldResistFingerPrinting(nsIChannel* aChannel) r=tjr,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D95477
2021-05-04 14:34:23 +00:00
Jonathan Kew
5347f125e1 Bug 1708797 - Try to make font fallback code more robust against DWrite failures. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D114225
2021-05-04 14:33:51 +00:00
Sebastian Hengst
8958ae3c7c Bug 1705410 - disable test_drawWindow_widget_layers.html on Windows code coverage for permanent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D113922
2021-05-04 14:33:00 +00:00
Sebastian Hengst
f967d0db01 Bug 1701874 - disable test_TelemetrySend.js on Linux code coverage for permanent failure. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D113929
2021-05-04 14:32:35 +00:00
Sandor Molnar
c5f7ff6b65 Backed out changeset fda42a745baf (bug 1708114) for causing Gtest failures in UnexpectedPrivilegedLoadsTelemetryTest. CLOSED TREE 2021-05-04 18:13:00 +03:00
Sandor Molnar
8dffb4667b Backed out 2 changesets (bug 1708635) for causing dt failures in devtools/client/responsive/test/browser/browser_device_change. CLOSED TREE
Backed out changeset 6bce4e61777b (bug 1708635)
Backed out changeset f15acee46be2 (bug 1708635)
2021-05-04 18:11:27 +03:00
mr.robot
ba9b6c6e39 Bug 1688188: Replace GC parameters and zeal mode with auto classes in jsapi-tests r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D113592
2021-05-04 14:26:17 +00:00
Matthew Gaudet
9601868417 Bug 1708973 - Support private field preferences outside of nightly r=caroline
Differential Revision: https://phabricator.services.mozilla.com/D114125
2021-05-04 14:25:39 +00:00
Emilio Cobos Álvarez
b205c4dd37 Bug 1709319 - Fix DevicePixelsToGdkCoordRoundUp and co. r=rmader
Differential Revision: https://phabricator.services.mozilla.com/D114229
2021-05-04 14:25:14 +00:00
Marco Trevisan (Treviño)
16991ea00c Bug 1709241 - Use JSAutoStructuredCloneBuffer callbacks when set r=sfink
During calls to read() and write() for JSAutoStructuredCloneBuffer the
data callbacks and closure are ignored also if none are explicitly
passed.

Use them in such case

Differential Revision: https://phabricator.services.mozilla.com/D114195
2021-05-04 14:18:54 +00:00
Valentin Gosu
5ae9a468e0 Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-04 14:05:59 +00:00
Valentin Gosu
9e72439569 Bug 1708116 - Add NetAddr::InitFromString r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D98952
2021-05-04 14:05:58 +00:00