Commit Graph

7174 Commits

Author SHA1 Message Date
shindli
f0d8729e09 Merge inbound to mozilla-central. a=merge 2018-07-31 12:50:32 +03:00
James Teh
d585de6620 Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r=surkov
This again exposes the accelerator (e.g. Ctrl+T for New Tab) for menu items via IAccessible::accName on windows.

Bug 1438193 made Accessible::Name const.
On Windows, XULMenuitemAccessibleWrap::Name is overridden to append the accelerator to the name.
Unfortunately, this override was missed when converting Name to const (and wasn't a compile error because it didn't use the override keyword).
As such, this override stopped being called; we always called the const version, since that's the one inherited into AccessibleWrap.
Making this const causes this override to be called.

MozReview-Commit-ID: 7Gb199mzhHa

--HG--
extra : rebase_source : 41d15042a09e4743d127fb12378c775099aa09a0
2018-07-31 11:22:59 +10:00
James Teh
2a45f8f49d Bug 903187: Map HTML ins/del to accessible roles. r=MarcoZ
IA2 now has IA2_ROLE_CONTENT_INSERTION/DELETION.
Mac has AXInsert/DeleteStyleGroup subroles.
We now create accessibles for these elements and expose the appropriate role.
For ATK, there is no specific role for these, so we just use the generic ATK_ROLE_SECTION.

MozReview-Commit-ID: 2khzRa7BQ6z

--HG--
extra : rebase_source : e1c84bdef9a23b225e9870660050790df94c4beb
2018-07-27 16:40:50 +10:00
Kris Maglione
031076f2f3 Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : source : fcfb99baa0f0fb60a7c420a712c6ae7c72576871
extra : histedit_source : 5be9b7b29a52a4b8376ee0bdfc5c08b12e3c775a
2018-05-21 16:58:23 -07:00
Kris Maglione
02ba563399 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : source : 0d69b4fb1ed43751cfcbc0b4f2fe3b6a49bc0494
extra : histedit_source : d0ce31513ffaae2fd7f01f6567a97b6d2d96b797%2Cfff837de7a00fa90809d2c3e755097180dfd56d8
2018-05-20 18:10:16 -07:00
Narcis Beleuzu
561ccb2ceb Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures
Backed out changeset fcfb99baa0f0 (bug 1463291)
Backed out changeset 0d69b4fb1ed4 (bug 1463016)
2018-07-29 03:55:23 +03:00
Kris Maglione
cb1ee1e34d Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : rebase_source : a13c59d1a5ed000187c7fd8e7339408ad6e2dee6
2018-05-21 16:58:23 -07:00
Kris Maglione
636f1839e5 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : rebase_source : 36565ef5e74360aad14062005e5bdab2939e888b
2018-05-20 18:10:16 -07:00
Eitan Isaacson
329ee2b3cc Bug 1477002 - Use message broadcaster to manage jsat content scripts. r=yzen
This patch does several things:
 1. When "domwindowopened" is dispatched it often doesn't have a
document yet, so we need to wait for it to load before determining if we
should attach it.
 2. Instead of managing individual message managers use a broadcaster
and load delayed scripts. This makes new window additions more robust.
 3. A content script now doesn't need a ready/start message but
initializes in-line. This added more complexity which we don't need. All
the info that we passed to it in AccessFu:Start can be gotten in other
ways (also, Services.appinfo.ID now works in child processes, so no need
for that).
 4. Tweaked the tests to support inline frame script initilization.
 5. Removed the scroll callback from content-script.js that was not used
anymore.
2018-07-27 15:19:00 +03:00
Tokio Kajitsuka
a7d855f037 Bug 1468110 - add AccessibleNode relation attributes, r=yzen, qdot
based on ARIA and AOM's ARIA reflection specs (https://wicg.github.io/aom/spec/aria-reflection.html)
2018-07-17 08:37:37 +09:00
James Teh
303c6c89cf Bug 1478568 part 2: Map BLOCKQUOTE role to IA2_ROLE_BLOCK_QUOTE. r=MarcoZ
MozReview-Commit-ID: KxGnO0R1dRJ

--HG--
extra : rebase_source : e09c1a1846b402ba0498773f44be255468154ce6
2018-07-27 10:30:25 +10:00
Brian Grinstead
6a6ca1a08c Bug 1475342 - Move document.getElementsByAttribute[NS] to ParentNode so it'll work for HTML document and elements;r=bz
It's currently only accessible on XULDocument and XULElement, but that makes porting existing
JS to run in an HTML document inconvenient. We could alternatively change calling JS, but
this can be easily moved and exposed in chrome contexts.

MozReview-Commit-ID: JitYET20NSE

--HG--
extra : rebase_source : 75d823c688cba8d84dc19705e83284be383962f2
2018-07-26 13:40:13 -07:00
Mark Banner
15c57e5bee Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
MozReview-Commit-ID: 2l6rvxykrWB

--HG--
extra : rebase_source : c62d614acda9ed1a77c3893ee91c493f1fbbaeec
2018-07-25 11:07:07 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
58e5c3e98f Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
MozReview-Commit-ID: 2l6rvxykrWB

--HG--
extra : rebase_source : 9bfe49a329b0ef38e45b5886070e2c1af1edecbe
2018-07-25 11:07:07 +01:00
Boris Zbarsky
922bc3548a Bug 1476145 part 2. Stop using getInterface(nsIDOMWindowUtils) in accessible/. r=kmag 2018-07-24 19:47:40 -04:00
Narcis Beleuzu
80c1cde899 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-07-25 01:22:42 +03:00
Brian Grinstead
96dc530924 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t

--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
2018-07-24 08:12:50 -07:00
Tokio Kajitsuka
8315ed33de Bug 1468110 - add AccessibleNode string attributes, r=yzen, qdot
based on ARIA and AOM's ARIA reflection specs (https://wicg.github.io/aom/spec/aria-reflection.html)
2018-07-13 21:33:51 +09:00
Tokio Kajitsuka
b3ddbd6aaf Bug 1468110 - add AccessibleNode unsigned long, long & double attributes attributes, r=yzen, qdot
based on ARIA and AOM's ARIA reflection specs (https://wicg.github.io/aom/spec/aria-reflection.html)
2018-07-22 03:45:22 +09:00
Yura Zenevich
dd1eb27a85 Bug 1473690 - add selectable ingegration tests. r=eeejay, jchen
MozReview-Commit-ID: 9ka7CjOJcew
2018-07-23 09:41:39 -04:00
Yura Zenevich
c35c35bb11 Bug 1473690 - add integration tests for checkboxes and associated events/states. r=eeejay, jchen
MozReview-Commit-ID: DIPa582EyTr
2018-07-23 09:41:27 -04:00
Bogdan Tara
ad36eff63e Backed out 2 changesets (bug 1473690) for jsat/test_content_integration.html failures CLOSED TREE
Backed out changeset b41a71c9e2e0 (bug 1473690)
Backed out changeset 6ca2392ff3f9 (bug 1473690)
2018-07-22 06:55:41 +03:00
Yura Zenevich
bb4b5de6ed Bug 1473690 - add selectable ingegration tests. r=eeejay, jchen
MozReview-Commit-ID: 9ka7CjOJcew
2018-07-21 22:54:19 -04:00
Yura Zenevich
f970fc3e21 Bug 1473690 - add integration tests for checkboxes and associated events/states. r=eeejay, jchen
MozReview-Commit-ID: DIPa582EyTr
2018-07-21 22:54:12 -04:00
Cosmin Sabou
0d3874d7d6 Merge mozilla-inbound to mozilla-central. a=merge 2018-07-21 00:42:01 +03:00
Tokio Kajitsuka
6fd289ea7a Bug 1468110 - add AccessibleNode boolean attributes, r=yzen, qdot
based on ARIA and AOM's ARIA reflection specs (https://wicg.github.io/aom/spec/aria-reflection.html)
2018-07-06 18:29:49 +09:00
James Teh
9febcf7435 Bug 1476347: Fix accessibility for HTML dt/dd with a div as its parent. r=MarcoZ
It is conforming in HTML to use a div to group dt/dd elements.
Previously, we didn't create an accessible for dt/dd elements in this case.

MozReview-Commit-ID: 8GDDxU3RbLd

--HG--
extra : rebase_source : 558a67e1b21583c6fac766ee1d1a24606976177f
2018-07-18 20:13:01 +10:00
Masatoshi Kimura
ee9d736001 Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/. r=froydnj
MozReview-Commit-ID: KttvrkWWRPB

--HG--
extra : rebase_source : ce96cd8e12bb53ecb1a1c7a5638bfe0e6fda2d09
2018-07-19 23:05:27 +09:00
Masayuki Nakano
2fa716ed4d Bug 1467799 - part 2: Stop using nsIEditor::GetDocumentIsEmpty() from C++ code r=m_kato
nsIEditor::GetDocumentIsEmpty() is a virtual code and there is non-virtual
method, TextEditor::IsEmpty().  So, any callers in C++ should use
TextEditor::IsEmpty() instead.

MozReview-Commit-ID: CQE8LP6XI96

--HG--
extra : rebase_source : e0027c3d71856adcd5fa7820bf936a6b405560c5
2018-07-18 17:51:49 +09:00
Paolo Amadini
dc49387df8 Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov
MozReview-Commit-ID: Bx1p1nTurCz

--HG--
extra : rebase_source : 6910e500f30eb42b45032dbab85a3dc9c014390b
2018-07-18 11:23:32 +01:00
Chris Peterson
224e62cb6f Bug 1469769 - Part 1: a11y: Replace failing NS_NOTREACHED with NS_ERROR. r=surkov
This SelectionManager assertion fails when running the testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py TestBackForwardNavigation.test_non_remote_about_pages marionette test. This assertion failure is bug 1126649.

This patch DOES NOT fix the cause of the assertion failure (a missing HyperTextAccessible). It just replaces this failing NS_NOTREACHED with NS_ERROR because I am removing the NS_NOTREACHED macro.

MozReview-Commit-ID: EVfyZlMwN4p

--HG--
extra : source : 676e9eb651d710bae1c76c3dae86a5cb1bded4d7
extra : intermediate-source : 6bce8da694e6803b04e7492094fc65b2b0e49bbf
extra : histedit_source : 57073997ac23879767937eaa3b42f78f60d1c942
2018-06-04 01:44:18 -07:00
Paolo Amadini
ce01b10ab3 Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov
This prepares for the removal of the "listbox" element and binding.

MozReview-Commit-ID: G1OxRGBphmw

--HG--
extra : source : 65d7ca38bd086abe7df0e50e9e5a9ba1d70202c3
2018-07-17 17:58:37 +01:00
Eitan Isaacson
c555f6075c Bug 1474688 - Support line movement granularity and remove defunct paragraph. r=yzen r=jchen 2018-07-16 15:59:00 +03:00
Eitan Isaacson
3fa0f4108f Bug 1475087 - Include boundaryType in vc change event. r=surkov 2018-07-16 13:56:00 +03:00
Eitan Isaacson
30579dc4fd Bug 1475078 - Go to last substring in current position when movePreviousByText. r=surkov
In the case of an unbound pivot (endOffset == startOffset == -1), we
should move to the last substring in the current position when
movePreviousByText is called.
2018-07-16 13:46:23 -07:00
Eitan Isaacson
16dbdcb14b Bug 1475068 - If accessible's parent has text interface, use it in pivot move by text. r=surkov 2018-07-16 13:46:23 -07:00
Gurzau Raul
117e86643a Backed out changeset ed8baebfeb78 (bug 1475087) for Windows build bustages on mozilla/a11y/DocAccessibleParent.h on a CLOSED TREE 2018-07-16 23:20:28 +03:00
Eitan Isaacson
95b1000eef Bug 1475087 - Include boundaryType in vc change event. r=surkov 2018-07-16 12:36:31 -07:00
Eitan Isaacson
6d59d60177 Bug 1471951 - Support expand selection with caret (2/2). r=yzen r=jchen 2018-07-16 10:53:27 -07:00
Eitan Isaacson
ffbf9af4d8 Bug 1471951 - Support set selection and clipboard actions (1/2). r=yzen r=jchen 2018-07-16 10:53:27 -07:00
James Teh
e5a1c32097 Bug 1475376: Support aria-valuetext for implicit ARIA roles. r=MarcoZ
For example, <input type="range"> maps to role="slider", so aria-valuetext should be supported.

MozReview-Commit-ID: IYBVTHP3ZLo

--HG--
extra : rebase_source : 906dfacf92d040abf97b46ff67bafbabc5c9a1ea
2018-07-12 20:22:09 -04:00
James Teh
0d1fdc7425 Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ
We don't fire a state change for the focused state, since that would be redundant given that we fire a focus event.
However, that also means the handler cache previously didn't get invalidated when there was a focus change without any other update.
That resulted in stale focused states, which could mean an object was exposed as focused when it wasn't.
Invalidating the cache for focus events ensures the focused state is always up to date.

MozReview-Commit-ID: DZTJMbiTwgt

--HG--
extra : rebase_source : 9977699999218432b07c4af2149cba6e0de466af
2018-07-11 16:26:19 +10:00
shindli
d7270e6100 Merge inbound to mozilla-central. a=merge 2018-07-11 12:42:27 +03:00
Eitan Isaacson
1f354f1604 Bug 1473998 - Use EditText entry in accessible's classNames and use the hint for the label. r=yzen r=jchen 2018-07-10 17:31:00 +03:00
Chris Peterson
16cc517cf9 Bug 1473453 - Part 1: a11y: assert hitregion property is always null or true. r=MarcoZ
Fix clang-tidy warning about bool pointers:

[misc-bool-pointer-implicit-conversion] accessible/generic/Accessible.cpp:644:9: warning: dubious check of 'bool *' against 'nullptr', did you mean to dereference it?

The `hitregion` property is always null or points to a true bool, set here:

https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/canvas/CanvasRenderingContext2D.cpp#3936-3937

The `hitregion` property used to be an nsRect pointer:

https://searchfox.org/mozilla-central/diff/c797577640f306df87e8c32313c5b826d1e58a9b/accessible/src/generic/Accessible.cpp#928

MozReview-Commit-ID: HYlAnMyaitB

--HG--
extra : rebase_source : 2f8d9d151ebc382043c107517838ccdaa0ed7228
2018-07-04 14:39:57 -07:00
Cosmin Sabou
1519cc7aac Backed out changeset ae9049c5ac63 (bug 1473998) for gv-junit failures on test.AccessibilityTest.testTextEntryNode. a=backout 2018-07-11 02:06:05 +03:00
Eitan Isaacson
868533e1cb Bug 1473998 - Use EditText entry in accessible's classNames and use the hint for the label. r=yzen r=jchen 2018-07-10 12:40:00 +03:00
Eitan Isaacson
a17a08b748 Bug 1473730 - Don't speak entire subtree of document when it is focused. r=yzen
After page load the document is focused and the entire subtree is
spoken. It should only speak the name.

--HG--
extra : rebase_source : bfc5542969fa29c45b9617d873a3dba7bf1a47c2
2018-07-10 08:43:00 +03:00
Eitan Isaacson
6e015436cb Bug 1473605 - Don't clump labels and controls together. It messes with focus events. r=yzen 2018-07-05 15:06:00 +03:00