Commit Graph

15 Commits

Author SHA1 Message Date
Chris Peterson
150add3f29 Bug 1236393 - Annotate intentional switch fallthrough to suppress -Wimplicit-fallthrough warning in tools/power/rapl.cpp. r=njn
tools/power/rapl.cpp:331:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-11-23 22:41:07 -08:00
Chris Peterson
3193160487 Bug 1222887 - Suppress -Wunreachable-code warning in tools/power. r=njn
tools/power/rapl.cpp:844:5 [-Wunreachable-code] code will never be executed

clang reports a -Wunreachable-code warning for sigemptyset() because Darwin's sigemptyset() is a macro that always returns 0. Thus `if (sigemptyset(&sa.sa_mask) < 0)` is always false and `Abort("sigemptyset() failed")` is never called. Linux's sigemptyset() can return 0 or -1. The extra parens around (0) suppress the clang warning.
2015-11-09 01:03:54 -08:00
Nicholas Nethercote
557e2db669 Bug 1214924 - Add "WindowServer" and "kernel" processes to |mach power|'s output. r=BenWa.
--HG--
extra : rebase_source : c85d0c6b92c82c32b5e194143358956479a477b9
2015-10-16 14:01:22 +11:00
Nicholas Nethercote
de59a42fb1 Bug 1204787 - Add |mach power|. r=glandium.
This extracts the most useful browser-related measurements from rapl and
powermetrics.

--HG--
extra : rebase_source : 81ce14acc6c6e1bc7ac6c34bf119d8e619956dd1
2015-09-15 16:23:45 +10:00
Nicholas Nethercote
a919a2d114 Bug 1203811 - Clarify two error messages in tools/power/rapl. r=heycam. 2015-09-10 23:12:31 -07:00
Nicholas Nethercote
c93125fd60 Bug 1203834 - Fix's rapl's handling of unsupported power domains. r=glandium.
The "gpu" and "ram" domains aren't supported by all platforms. rapl has a
special constant |kUnsupported_j| to represent this on Linux, but I
accidentally have a minus sign in front of it in several places, which means
that instead of printing "n/a" for unsupported planes we always print "1.0".

I think this happened because I used to hardwire -1 in there and then I later
changed it to a constant but forgot to remove the minus signs.

It sure would be nice to have automated testing for this stuff, but I don't see
how to do it.
2015-09-10 23:12:20 -07:00
Nicholas Nethercote
51b5ca14d4 Bug 1201811 (part 2) - Don't print distribution stats if there was only 1 sample. r=erahm.
--HG--
extra : rebase_source : aa6b26441c5ca285a15d58d97a62f064e891d09b
2015-09-04 01:45:13 -07:00
Nicholas Nethercote
21be35d70a Bug 1201811 (part 1) - Don't use integer arithmetic when summing totals in rapl. r=erahm.
--HG--
extra : rebase_source : 2c800587f4bc49a492fb85be1e7d6c0c7885052e
2015-09-04 01:04:46 -07:00
Nicholas Nethercote
f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Nicholas Nethercote
4e53819fec Bug 1198334 (part 0) - Tighten up warnings-as-errors usage in tools/power/. r=glandium.
--HG--
extra : rebase_source : a8239fd2911e57820eba3c1759365627f669b9d2
2015-08-27 20:40:44 -07:00
Nicholas Nethercote
33d3e011d3 Bug 1198137 (follow-up) - Add a missing #include to unbreak Mac OS builds on a CLOSED TREE. r=me
--HG--
extra : rebase_source : 9704e746704ef614b48b9ebcdb0afd3e729258ad
2015-08-26 11:48:08 +10:00
Nicholas Nethercote
cdcc41338a Bug 1198137 - Add some summary stats to tool/power/rapl's output. r=erahm.
"mean" is most useful, then "min" and "max". The rest are moderately useful.

--HG--
extra : rebase_source : 03fda0e0d32081024abd5cdf859f16dac60bbc19
2015-08-25 18:11:03 -07:00
Nicholas Nethercote
b7f77af473 Bug 1197694 - fflush() rapl output so it always appears immediately. r=erahm.
--HG--
extra : rebase_source : 2de1c517202616e6daad6e578cfbe89b65cdce0f
2015-08-24 15:59:37 -07:00
Nicholas Nethercote
b83cd56ff9 Bug 1194560 (follow-up) - Only build rapl on Linux if the arch is x86 or x86-64. r=glandium.
--HG--
extra : rebase_source : c115f898cb1ce8129657e3435881e4f220eca566
2015-08-20 17:02:18 -07:00
Nicholas Nethercote
68c09ac436 Bug 1194560 - Add tools/power/rapl, a RAPL-reading program for power profiling. r=erahm,glandium.
--HG--
extra : rebase_source : 7303d7209f6c9ae8bbd911a379078343b7cb5a7b
2015-08-19 22:25:30 -07:00