The filterBySource was looping over the whole list once again
but worse, was duplicating the array once more.
Same for filterByUniqLocation.
Finally, once we removed these two last filtering methods... we could prevent the creation of the whole "positions"
intermediate object and craft directly what we aim to store in redux.
Differential Revision: https://phabricator.services.mozilla.com/D189951
We can avoid the creation of an handful of object creations by passing
the "breakpoint positions" objects directly to the Source Map Loader.
(avoid convertToList)
We can also tune `SourceMapLoader.getOriginalLocations` output to better
fit the requirements of the main thread.
Differential Revision: https://phabricator.services.mozilla.com/D189950
This code is a bit hard to follow, so let's add some comments.
Also `columns = [...new Set([...existing, ...columns])];` is probably very bad for performance.
It clones existing and columns into a third array, whose content is cloned into a Set,
which is ultimately cloned into the final array.
Differential Revision: https://phabricator.services.mozilla.com/D189948
For the badges that act as toggles (e.g. the display badge for toggling flex/grid highlighters),
we also set aria-pressed buttons.
Tests are added in the next patch of this stack.
Differential Revision: https://phabricator.services.mozilla.com/D189911
For the badges that act as toggles (e.g. the display badge for toggling flex/grid highlighters),
we also set aria-pressed buttons.
Tests are added in the next patch of this stack.
Differential Revision: https://phabricator.services.mozilla.com/D189911
This adds a similar button to the one we have in the Debugger that users can
click on to pretty print the stylesheet.
We disable the button when the opened file is an original file, as we don't
support pretty printing non CSS files.
The current test for (automatic) pretty printing is updated to check that the
button has the expected states and behaves as it should.
Differential Revision: https://phabricator.services.mozilla.com/D189762
Just the CSS property; not hooked up to any rendering behavior yet.
Currently this is implemented as a simple longhand `text-wrap` property,
but we'll want to rename it to `text-wrap-style` when we update white-space
to be a shorthand and introduce white-space-collapse, text-wrap-mode, etc.
The 'pretty' value is omitted as we have no immediate plans to implement it.
Initially, 'auto' and 'stable' will behave identically, although 'auto' could
change in future once we have higher-quality algorithms available.
Differential Revision: https://phabricator.services.mozilla.com/D187543
Properly close the context menu (and wait until its fully closed).
Use `setProperty` to set the CSS value property as it handles edge cases.
This means we had to move `getRuleViewRuleEditor`, `getTextProperty` and
`setProperty` to `inspector/test/shared-head.js`.
Differential Revision: https://phabricator.services.mozilla.com/D189207
Just the CSS property; not hooked up to any rendering behavior yet.
Currently this is implemented as a simple longhand `text-wrap` property,
but we'll want to rename it to `text-wrap-style` when we update white-space
to be a shorthand and introduce white-space-collapse, text-wrap-mode, etc.
The 'pretty' value is omitted as we have no immediate plans to implement it.
Initially, 'auto' and 'stable' will behave identically, although 'auto' could
change in future once we have higher-quality algorithms available.
Differential Revision: https://phabricator.services.mozilla.com/D187543
Instead of only displaying a small icon when the thread is
paused, add a plain text paused label.
When a thread is paused and not selected, set its background
and color the same as we have for the why paused element.
CSS variables for paused background and color are created and
are used in both WhyPaused and paused thread.
We take this opportunity to refactor Threads.css a bit, cleaning
up spacing and using CSS nesting to make it easier to read.
Differential Revision: https://phabricator.services.mozilla.com/D189341
Just the CSS property; not hooked up to any rendering behavior yet.
Currently this is implemented as a simple longhand `text-wrap` property,
but we'll want to rename it to `text-wrap-style` when we update white-space
to be a shorthand and introduce white-space-collapse, text-wrap-mode, etc.
The 'pretty' value is omitted as we have no immediate plans to implement it.
Initially, 'auto' and 'stable' will behave identically, although 'auto' could
change in future once we have higher-quality algorithms available.
Differential Revision: https://phabricator.services.mozilla.com/D187543
This patch newly allows cases such as MonDDYYYY and Mon.DD.YYYY.
In adding tests for this patch, I noticed that the tests for parsing
periods were broken and could not fail the way that they were written,
so I fixed them.
This patch also fixes a couple of other standing bugs...
fixes Bug 485639 - for cases like "Aug 15 2015 10:00am"
fixes Bug 1760290 - for YYYY.MM.DD
Differential Revision: https://phabricator.services.mozilla.com/D186054
`at <position>` is optional value and we should omit it if author doesn't
specify it, for all basic-shape functions, and ray().
Note that there is a related interpolation issue [1] if one of the end values
doesn't specify `at <position>`. We didn't address this issue in this patch.
[1] https://github.com/w3c/csswg-drafts/issues/9068
Also, this updates the devtool code to give it the default value, "50% 50%",
for circle() and ellipse() if `at <position>` is not specified.
Differential Revision: https://phabricator.services.mozilla.com/D181918
