Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
801,779 Commits 615 Branches 98 Tags 6 GiB
378245e250
Commit Graph

499 Commits

Author SHA1 Message Date
Nicolas Chevobbe
378245e250 Bug 1779043 - [devtools] Fix jumping to media query in inline sheets. r=jdescottes. 
We directly pass the editor stylesheet in the `location` parameter that is passed
to `jumpToLocation`.

`jumpToLocation` wasn't covered in any test, so we modify `browser_styleeditor_media_sidebar.js`
to add coverage for it.
This is also testing Bug 1779180 which is in the same stack.

Differential Revision: https://phabricator.services.mozilla.com/D151597
 2022-07-18 12:13:56 +00:00
Bogdan Szekely
a5bbfdd85a Backed out 2 changesets (bug 1779180, bug 1779043) for causing mochitest failures on test_css-logic-media-queries.html 
CLOSED TREE

Backed out changeset 95e34a0fbb39 (bug 1779043)
Backed out changeset 0931519b4ef2 (bug 1779180)
 2022-07-18 10:37:32 +03:00
Nicolas Chevobbe
cd5945b68a Bug 1779043 - [devtools] Fix jumping to media query in inline sheets. r=jdescottes. 
We directly pass the editor stylesheet in the `location` parameter that is passed
to `jumpToLocation`.

`jumpToLocation` wasn't covered in any test, so we modify `browser_styleeditor_media_sidebar.js`
to add coverage for it.
This is also testing Bug 1779180 which is in the same stack.

Differential Revision: https://phabricator.services.mozilla.com/D151597
 2022-07-18 07:05:18 +00:00
Tooru Fujisawa
6907e51f5c Bug 1777486 - Part 4: Migrate XPCOMUtils.jsm consumers with CommonJS require. r=devtools-reviewers,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D151216
 2022-07-12 04:21:35 +00:00
Andreea Pavel
7738a75fdd Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
2244a9c200 Bug 1777486 - Part 4: Migrate XPCOMUtils.jsm consumers with CommonJS require. r=devtools-reviewers,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D151216
 2022-07-11 15:09:14 +00:00
Nicolas Chevobbe
3c8d1a8b26 Bug 1775411 - [devtools] Fix append new stylesheet link. r=ochameau. 
The link was missing an event listener, that we add in this patch.
A test case is added to make sure the link does work.

Differential Revision: https://phabricator.services.mozilla.com/D149953
 2022-06-22 09:30:05 +00:00
Julian Descottes
2c8736a218 Bug 1767787 - [devtools] Wait until default editor has focus in browser_styleeditor_bug_851132_middle_click.js r=nchevobbe 
I could reproduce the intermittent locally and when it occurs, the initial editor actually didn't have focus.
I think that what happens is that we hit a race condition where the focus is stolen by the initial editor after we clicked on a new stylesheet
and switched to a new editor.

Differential Revision: https://phabricator.services.mozilla.com/D149952
 2022-06-22 07:20:06 +00:00
Nicolas Chevobbe
d0ec19672d Bug 1770899 - [devtools] Use RemoteSettings devtools-devices collection. r=jdescottes. 
Differential Revision: https://phabricator.services.mozilla.com/D149405
 2022-06-17 06:44:18 +00:00
Michael Ratcliffe
7860244360 Bug 1772718 - Reduce mozilla/reject-scriptableunicodeconverter eslint warnings in DevTools code r=nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D148346
 2022-06-16 18:24:17 +00:00
Tooru Fujisawa
725309d478 Bug 1772093 - Part 5: Use plain object for lazy getter in devtools/client/styleeditor/. r=devtools-reviewers,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D147901
 2022-06-06 07:09:53 +00:00
Michael Ratcliffe
3133e874e5 Bug 1771608 - Eliminate mozilla/reject-osfile eslint warning in devTools code r=devtools-reviewers,perftest-reviewers,jdescottes,sparky 
## Removed Some Osfile.jsm and ChromeUtils Dependencies

```diff
-  const { OS } = require("resource://gre/modules/osfile.jsm");

And / Or

-  const ChromeUtils = require("ChromeUtils");
```

- devtools/client/memory/actions/io.js
- devtools/client/memory/utils.js
- devtools/client/netmonitor/src/har/har-menu-utils.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/shared/screenshot.js
- devtools/client/styleeditor/StyleEditorUI.jsm
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/client/webconsole/components/Input/JSTerm.js
- devtools/client/webconsole/test/browser/stub-generator-helpers.js
- devtools/server/actors/heap-snapshot-file.js
- devtools/server/actors/storage.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_01.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_02.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_03.js
- devtools/shared/DevToolsUtils.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js
- devtools/shared/tests/xpcshell/test_fetch-file.js
- testing/talos/talos/tests/devtools/addon/content/tests/toolbox/screenshot.js

## IOUtils.read()

```diff
-  OS.File.read(path);
+  IOUtils.read(path);
```

- devtools/client/aboutdebugging/test/browser/helper-real-usb.js
- devtools/client/netmonitor/src/har/har-menu-utils.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/client/webconsole/components/Input/JSTerm.js
- devtools/client/webconsole/test/browser/browser_jsterm_file_load_save_keyboard_shortcut.js
- devtools/client/webconsole/test/browser/browser_webconsole_context_menu_export_console_output.js
- devtools/shared/DevToolsUtils.js

## IOUtils.write()

```diff
-  OS.File.writeAtomic(filePath, fileContent);
+  IOUtils.write(filePath, fileContent);
```

- devtools/client/webconsole/test/browser/stub-generator-helpers.js
- devtools/shared/DevToolsUtils.js
- devtools/shared/tests/xpcshell/test_fetch-file.js

## PathUtils.split()

```diff
-  OS.Path.split(path);
+  PathUtils.split(path);
```

- devtools/client/styleeditor/StyleSheetEditor.jsm

## PathUtils.join()

```diff
-  OS.Path.join(path, filename);
+  PathUtils.join(path, filename);
```

NOTE: If `filename` is an absolute path then `OS.Path` will ignore `path` and use `filename` but `PathUtils` will try to concatenate both paths. If filename can be an absolute path we need to use `PathUtils.isAbsolute()` and `PathUtils.joinRelative()` to make our desired behaviour explicit.

- devtools/client/debugger/test/mochitest/browser_dbg-chrome-create.js
- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js

## PathUtils.isAbsolute() and PathUtils.joinRelative()

```diff
-  filename = OS.Path.join(path, filename);
+  filename = PathUtils.isAbsolute(filename)
+    ? filename
+    : PathUtils.joinRelative(path, filename);
```

- devtools/client/shared/screenshot.js

## IOUtils.remove()

```diff
-  OS.File.remove(filePath);
+  IOUtils.remove(filePath);
```

- devtools/client/framework/test/browser_toolbox_screenshot_tool.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/responsive/test/browser/browser_screenshot_button_warning.js
- devtools/client/shared/test/shared-head.js
- devtools/client/webconsole/test/browser/browser_console_screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_file.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_fixed_header.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_selector.js
- testing/talos/talos/tests/devtools/addon/content/tests/toolbox/screenshot.js

## PathUtils.toFileURI()

```diff
-  OS.Path.toFileURI(filePath);
+  PathUtils.toFileURI(filePath);
```

- devtools/client/framework/test/browser_toolbox_screenshot_tool.js
- devtools/client/responsive/test/browser/browser_screenshot_button.js
- devtools/client/shared/test/shared-head.js
- devtools/client/webconsole/test/browser/browser_console_screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_file.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_fixed_header.js
- devtools/client/webconsole/test/browser/browser_jsterm_screenshot_command_selector.js

## PathUtils.filename()

```diff
-  OS.Path.basename(path),
+  PathUtils.filename(path),
```

- devtools/client/memory/actions/io.js
- devtools/client/memory/utils.js
- devtools/client/styleeditor/StyleEditorUI.jsm
- devtools/client/styleeditor/StyleSheetEditor.jsm

## IOUtils.copy()

```diff
-  OS.File.copy(path, dest);
+  IOUtils.copy(path, dest);
```

- devtools/client/memory/actions/io.js

## IOUtils.stat()

```diff
-  OS.File.stat(filePath);
+  IOUtils.stat(filePath);
```

The objects that these `stat()` versions return differ from one another. This hasn't made much difference to the codebase but our changed usage is included here for completeness:

```diff
-      this._fileModDate = info.lastModificationDate.getTime();
+      this._fileModDate = info.lastModified;
```

- devtools/client/memory/test/browser/browser_memory_transferHeapSnapshot_e10s_01.js
- devtools/client/memory/test/xpcshell/head.js
- devtools/client/memory/test/xpcshell/test_action-export-snapshot.js
- devtools/client/styleeditor/StyleSheetEditor.jsm
- devtools/server/actors/heap-snapshot-file.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_01.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_02.js
- devtools/server/tests/xpcshell/test_MemoryActor_saveHeapSnapshot_03.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js

## IOUtils.setPermissions

```diff
-  OS.File.setPermissions(filePath, { unixMode: 0o744 });
+  IOUtils.setPermissions(filePath, 0o744);
```

- devtools/client/shared/remote-debugging/adb/adb-binary.js

## IOUtils.makeDirectory

```diff
-  OS.File.makeDir(path);
+  IOUtils.makeDirectory(path);
```

- devtools/client/shared/remote-debugging/adb/adb-binary.js

## IOUtils.exists

```diff
-  OS.File.exists(path);
+  IOUtils.exists(path);
```

- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/client/shared/screenshot.js
- devtools/client/webconsole/test/browser/browser_jsterm_file_load_save_keyboard_shortcut.js
- devtools/client/webconsole/test/browser/browser_webconsole_context_menu_export_console_output.js

## PathUtils.profileDir, PathUtils.localProfileDir and PathUtils.tempDir

```diff
-    const profileDir = OS.Constants.Path.profileDir;
+    const profileDir = PathUtils.profileDir;
```

We can reduce reliance on `Osfile.jsm` in another bug bug this is a small step in that direction.

- devtools/client/shared/remote-debugging/adb/adb-binary.js
- devtools/server/actors/storage.js
- devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js

## IOUtils.getChildren(storagePath)

`IOUtils` does not have a direct equivalent of `OS.File.DirectoryIterator()` so we need to iterate more explicitely using `IOUtils.getChildren()`.

```diff
- async findStorageTypePaths(storagePath) {
-   const iterator = new OS.File.DirectoryIterator(storagePath);
-   const typePaths = [];
-
-   await iterator.forEach(entry => {
-     if (entry.isDir) {
-       typePaths.push(entry.path);
-     }
-   });
-
-   iterator.close();
-   return typePaths;
- }

+ async findStorageTypePaths(storagePath) {
+   const children = await IOUtils.getChildren(storagePath);
+   const typePaths = [];
+
+   for (const path of children) {
+     const exists = await IOUtils.exists(path);
+     if (!exists) {
+       continue;
+     }
+
+     const stats = await IOUtils.stat(path);
+     if (stats.type === "directory") {
+       typePaths.push(path);
+     }
+   }
+
+   return typePaths;
+ }

```

- devtools/server/actors/storage.js

## Misc

Made `IOUtils` and `PathUtils` available to DevTools modules.

```diff
   HeapSnapshot,
+  IOUtils,
   L10nRegistry,
   Localization,
   NamedNodeMap,
   NodeFilter,
+  PathUtils,
   StructuredCloneHolder,
   TelemetryStopwatch,
```

- devtools/shared/loader/builtin-modules.js

Differential Revision: https://phabricator.services.mozilla.com/D147589
 2022-06-02 21:13:56 +00:00
Alexandre Poirot
0eb74c5c7f Bug 1770360 - [devtools] Remove the stylesheets of destroyed targets. r=nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D146889
 2022-05-23 20:09:33 +00:00
Nicolas Chevobbe
2fde15757f Bug 1766602 - [devtools] Speedup jump to styleeditor from inspector. r=jdescottes. 
In `viewSourceInStyleEditor`, we used to first load the styleeditor, and then
select the stylesheet and show the panel. This mean that when clicking on a location
from the rule view, there would be some delays before we show any feedback to the user.
Since the load promise for the panel only settles once we watched for all existing
stylesheets and loaded their content for each of them, it could take a while in
cases where we have lots of stylesheets, like in the BrowserToolbox.

So here we modify `viewSourceInStyleEditor` to directly select the styleeditor and
passing it a stylesheet that can be added right away, in case the panel wasn't
loaded yet, without waiting for the stylesheets to be watched.

We take this as an opportunity add a test when `viewSourceInStyleEditor` is called
with a stylesheet not used on the page, and check that it does open a view-source tab.

Differential Revision: https://phabricator.services.mozilla.com/D146540
 2022-05-20 06:24:37 +00:00
Emilio Cobos Álvarez
05a8fc5ff9 Bug 1769771 - Differentiate inline from constructed stylesheets in rule view. r=nchevobbe 
I think this is worth it, but needs localization changes so splitting
it out.

Differential Revision: https://phabricator.services.mozilla.com/D146683
 2022-05-19 22:32:28 +00:00
Nicolas Chevobbe
17d1efcc34 Bug 1764347 - [devtools] Add Browser Toolbox test for the Style Editor. r=jdescottes. 
Differential Revision: https://phabricator.services.mozilla.com/D146539
 2022-05-19 05:24:55 +00:00
Alexandre Poirot
b798b2e643 Bug 1529621 - [devtools] Make all panel's destroy method be synchronous. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D146533
 2022-05-17 16:45:13 +00:00
Nicolas Chevobbe
547c9df37d Bug 1767788 - [devtools] Fix browser_styleeditor_sv_keynav.js intermittent failure. r=jdescottes. 
Wait for the proper editor-selected event.

Differential Revision: https://phabricator.services.mozilla.com/D146577
 2022-05-17 15:21:50 +00:00
Nicolas Chevobbe
e7198c20ea Bug 1688231 - [devtools] Remove unnecessary StyleSheetEditor#_isUpdating. r=bomsy. 
This was used for pre-86 servers, so we can remove it now.

Differential Revision: https://phabricator.services.mozilla.com/D145884
 2022-05-10 11:48:44 +00:00
Nicolas Chevobbe
03d2974d89 Bug 1768150 - [devtools] Turn StyleEditorUI methods private. r=bomsy. 
Differential Revision: https://phabricator.services.mozilla.com/D145856
 2022-05-10 09:17:50 +00:00
Nicolas Chevobbe
bb8c2ad43f Bug 1768150 - [devtools] Turn StyleEditorUI properties into private fields. r=bomsy. 
Differential Revision: https://phabricator.services.mozilla.com/D145855
 2022-05-10 09:17:49 +00:00
Nicolas Chevobbe
8784696806 Bug 1768150 - [devtools] Don't use ui._* properties from styleeditor tests. r=bomsy. 
This is some prep work to make those loosely private properties
actually be private fields.

Differential Revision: https://phabricator.services.mozilla.com/D145854
 2022-05-10 09:17:49 +00:00
Nicolas Chevobbe
968874d5ce Bug 1767970 - [devtools] Merge SplitView into StyleEditorUI. r=jdescottes. 
This allows to simplify what was done in SplitView and have
direct calls to functions instead of registering callbacks.

Differential Revision: https://phabricator.services.mozilla.com/D145607
 2022-05-09 09:09:57 +00:00
Nicolas Chevobbe
bf6abde59f Bug 1767970 - [devtools] Turn StyleEditorUI into a class. r=jdescottes. 
This is some prep work for the next patch in the stack.

Differential Revision: https://phabricator.services.mozilla.com/D145606
 2022-05-09 09:09:56 +00:00
Nicolas Chevobbe
fea6e021bf Bug 1766975 - [devtools] Add keyboard shortcut to focus StyleEditor filter input. r=jdescottes. 
We using Ctrl|Cmd+P as Ctrl|Cmd+F is used for a in-file search in
the CodeMirror instance.
We're tesing the keyboard shortcut in browser_style_editor_filter.js
by using it instead of manually calling input.focus and clearing it
programatically.

Differential Revision: https://phabricator.services.mozilla.com/D145057
 2022-05-04 06:01:31 +00:00
Nicolas Chevobbe
0f4a927bab Bug 1766603 - [devtools] Lazy load modules in StyleEditor. r=bomsy. 
Those modules are only needed on specific user actions, so we might save a few
cycles not loading them upfront.

Differential Revision: https://phabricator.services.mozilla.com/D144796
 2022-05-04 06:01:31 +00:00
Nicolas Chevobbe
267bff5ff9 Bug 1766811 - [devtools] Remove StyleEditor list item animation. r=jdescottes. 
Differential Revision: https://phabricator.services.mozilla.com/D144930
 2022-05-04 06:01:31 +00:00
Nicolas Chevobbe
c02657bc0c Bug 1470781 - [devtools] Make check in browser_styleeditor_private_perwindowpb.js more specific. r=jdescottes. 
For some reason, the new test added in the previous patch has an impact on this test:
when checking the disk cache, there's a `mochi.test:8888/tests.json` entry, and
since the test was only checking if there was an entry with the `mochi.test:8888` entry,
it was failing.
I wasn't able to understand why we have this entry in the cache, but it reveals
that the test check is a bit too broad, since what we cares about is simply to
know if the fetched stylesheet was added in the disk cache.
So here we're doing just that, checking that the fetched stylesheet wasn't added
to the disk cache.

Depends on D144723

Differential Revision: https://phabricator.services.mozilla.com/D145344
 2022-05-04 06:01:30 +00:00
Nicolas Chevobbe
677b15d13b Bug 1470781 - [devtools] Add filter input for stylesheets list. r=jdescottes,fluent-reviewers. 
The patch adds a filter input in the xhtml file, which will filter the list
of stylesheets displayed on the left side, based on the stylesheet name.
If the active stylesheet is filtered-out, the first visible one gets selected.
If all the stylesheet are filtered-out, a label is displayed indicating that
the search doesn't match any stylesheet.

The splitview CSS already had rules for this behaviour, so we're reusing what's
already there, re-adding the placeholder for the "all filtered" message.

This had an impact on keyboard navigation; the list is sorted by `ordinal` property,
which drives a `MozBoxOrdinalGroup` style property (similar to `order` on a flex item).
The navigation used to simply get the active ordinal, and move to the next one.
Now, the "next" ordinal could be hidden, so we change the behavior to move the focus
to the next (or previous), visible item in the list.

A test is added to check that everything works as intended.

Differential Revision: https://phabricator.services.mozilla.com/D144723
 2022-05-04 06:01:30 +00:00
criss
31c0885034 Backed out 3 changesets (bug 1766603, bug 1470781, bug 1766811) for causing devtools failures. CLOSED TREE 
Backed out changeset 9a28a5613dbd (bug 1766811)
Backed out changeset d1fd983ac8ae (bug 1766603)
Backed out changeset f52a98377722 (bug 1470781)
 2022-05-02 09:44:15 +03:00
Nicolas Chevobbe
2034ad0073 Bug 1766811 - [devtools] Remove StyleEditor list item animation. r=jdescottes. 
Differential Revision: https://phabricator.services.mozilla.com/D144930
 2022-05-02 05:44:20 +00:00
Nicolas Chevobbe
5f5ea908d8 Bug 1766603 - [devtools] Lazy load modules in StyleEditor. r=bomsy. 
Those modules are only needed on specific user actions, so we might save a few
cycles not loading them upfront.

Differential Revision: https://phabricator.services.mozilla.com/D144796
 2022-05-02 05:44:20 +00:00
Nicolas Chevobbe
ca25b31905 Bug 1470781 - [devtools] Add filter input for stylesheets list. r=jdescottes,fluent-reviewers. 
The patch adds a filter input in the xhtml file, which will filter the list
of stylesheets displayed on the left side, based on the stylesheet name.
If the active stylesheet is filtered-out, the first visible one gets selected.
If all the stylesheet are filtered-out, a label is displayed indicating that
the search doesn't match any stylesheet.

The splitview CSS already had rules for this behaviour, so we're reusing what's
already there, re-adding the placeholder for the "all filtered" message.

This had an impact on keyboard navigation; the list is sorted by `ordinal` property,
which drives a `MozBoxOrdinalGroup` style property (similar to `order` on a flex item).
The navigation used to simply get the active ordinal, and move to the next one.
Now, the "next" ordinal could be hidden, so we change the behavior to move the focus
to the next (or previous), visible item in the list.

A test is added to check that everything works as intended.

Differential Revision: https://phabricator.services.mozilla.com/D144723
 2022-05-02 05:44:19 +00:00
Nicolas Chevobbe
0c3ab8a968 Bug 1766390 - [devtools] Remove StyleEditorUtil wire. r=bomsy. 
It's only used to set event listeners, so we replace
all usages with direct calls to addEventListener instead.

Differential Revision: https://phabricator.services.mozilla.com/D144686
 2022-04-26 16:13:20 +00:00
Nicolas Chevobbe
9076b5fa2f Bug 1765748 - [devtools] Remove unncessary complex SplitView#setItemClassName. r=jdescottes. 
The function was setting extra classes on both
the summary and the detail, running extra checks
to not remove the base classes.
It's only called from one place, and we only care
about adding classes to the summary element, which
we have access to directly.
We're switching to classList.(add|remove) , which
allows us to get rid of the SplitView method.

Differential Revision: https://phabricator.services.mozilla.com/D144427
 2022-04-22 13:56:02 +00:00
Nicolas Chevobbe
8578d2224f Bug 1765748 - [devtools] Remove SplitView active summary getter and rename setter. r=ochameau. 
Differential Revision: https://phabricator.services.mozilla.com/D144302
 2022-04-22 13:56:01 +00:00
Nicolas Chevobbe
d24de6a1bc Bug 1765748 - [devtools] Merge SplitView appendTemplateItem and appendItem. r=ochameau. 
The template nodes are retrieved and cached from the constructor so we don't have
to do it for every item we add.

Differential Revision: https://phabricator.services.mozilla.com/D144269
 2022-04-22 13:56:01 +00:00
Nicolas Chevobbe
947e5c6c8f Bug 1765748 - [devtools] Simplify SplitView#appendItem onShow option. r=ochameau. 
Only the detail element was needed in the callback, so we remove all the other
unnecessary parameters.
This allows us to also remove the `data` option.

Differential Revision: https://phabricator.services.mozilla.com/D144268
 2022-04-22 13:56:01 +00:00
Nicolas Chevobbe
6a68e17557 Bug 1765748 - [devtools] Remove SplitView#appendItem onCreate option. r=ochameau. 
Since there's nothing asynchronous happening before the item gets added to the
list, the consumer can directly use the properties of the object returned by
'appendTemplatedItem'.

Differential Revision: https://phabricator.services.mozilla.com/D144267
 2022-04-22 13:56:00 +00:00
Nicolas Chevobbe
703a40f1c8 Bug 1765748 - [devtools] Remove unused SplitView#appendItem options. r=ochameau. 
`onHide` and `onDestroy` aren't declared from the callsite, we can remove them.

Differential Revision: https://phabricator.services.mozilla.com/D144266
 2022-04-22 13:56:00 +00:00
Nicolas Chevobbe
d0b5f00199 Bug 1765748 - [devtools] Turn SplitView.getSummaryElementByOrdinal into a private method. r=ochameau. 
Differential Revision: https://phabricator.services.mozilla.com/D144265
 2022-04-22 13:56:00 +00:00
Nicolas Chevobbe
bd68cc6c18 Bug 1765748 - [devtools] Remove unused SplitView#isLandscape . r=ochameau. 
This allows us to remove the `_mql` property as well as the `LANDSCAPE_MEDIA_QUERY`
const.

Differential Revision: https://phabricator.services.mozilla.com/D144264
 2022-04-22 13:55:59 +00:00
Nicolas Chevobbe
54dc8da65c Bug 1765748 - [devtools] Remove unused SplitView#activeDetails. r=ochameau. 
Differential Revision: https://phabricator.services.mozilla.com/D144263
 2022-04-22 13:55:59 +00:00
Nicolas Chevobbe
94239d0425 Bug 1765239 - [devtools] Turn SplitView into an ES6 class. r=ochameau. 
Depends on D144149

Differential Revision: https://phabricator.services.mozilla.com/D144150
 2022-04-20 15:47:05 +00:00
Nicolas Chevobbe
7565d876bd Bug 1765239 - [devtools] Fix SplitView.jsm ESLint errors. r=ochameau. 
Depends on D144148

Differential Revision: https://phabricator.services.mozilla.com/D144149
 2022-04-20 15:47:05 +00:00
Nicolas Chevobbe
06e5af3c22 Bug 1765239 - [devtools] Move SplitView.jsm to styleeditor. r=ochameau. 
It's only used here, so let's move it back here

Differential Revision: https://phabricator.services.mozilla.com/D144148
 2022-04-20 15:47:05 +00:00
Nicolas Chevobbe
abb6e53e32 Bug 1763312 - [devtools] Remove sourceeditor.dtd. r=jdescottes,flod. 
It was only used in the style editor, so we migrate the existing string
to styleeditor.ftl.

Differential Revision: https://phabricator.services.mozilla.com/D143011
 2022-04-13 12:47:57 +00:00
amy churchwell
13ecbc516a Bug 1754268 - Eliminate preprocessor %includes from toolkit in-content stylesheets. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D141071
 2022-03-23 18:23:55 +00:00
Julian Descottes
99bedf483e Bug 1756763 - [devtools] Update validation for sourcemap resources fetching r=dveditz,ochameau 
Differential Revision: https://phabricator.services.mozilla.com/D141231
 2022-03-22 11:43:00 +00:00
Julian Descottes
5bb2a7a008 Bug 1737387 - [devtools] Add option to wait for devices list in openRDM r=ochameau 
Depends on D141021

Differential Revision: https://phabricator.services.mozilla.com/D141088
 2022-03-15 23:22:23 +00:00