Commit Graph

300661 Commits

Author SHA1 Message Date
Bobby Holley
0c9994db1d Bug 836301 - Hoist some assertions, remove a bunch of no-op trap overrides, and add assertions that we've entered our policy. r=mrbkap 2013-02-25 13:54:18 -08:00
Bobby Holley
59d3c6c36d Bug 836301 - Hoist enter() calls from {Xray,}Wrapper::foo into Proxy::foo. r=mrbkap 2013-02-25 13:54:18 -08:00
Bobby Holley
d916a1015e Bug 836301 - Introduce an RAII class for entering policies. r=mrbkap
This will allow us to make some hard assertions that a given policy has been
entered exactly once.
2013-02-25 13:54:18 -08:00
Bobby Holley
be3814c47e Bug 836301 - Hoist enter() into BaseProxyHandler. r=mrbkap 2013-02-25 13:54:18 -08:00
Bobby Holley
ea8d501a0c Bug 836301 - Add tracking for whether we have a non-trivial enter() trap. r=mrbkap
This will allow us to skip the virtual function call for non-security-wrapper
proxies, which are the cases where we care most about performance.
2013-02-25 13:54:18 -08:00
Bobby Holley
4591fd0a3d Bug 836301 - Stop enter()ing with CALL for nativeCall. r=mrbkap
This is kind of nonsensical, because CALL means "the wrapped object is being
called", whereas nativeCall means "the wrapped object is being unwrapped to
have a JSNative invoked on it", which are two very different things.

We _could_ add a NATIVECALL enter() trap, but our current policy enforcement
around nativeCall involves overriding the trap itself, so we wouldn't use it
for anything. So let's just get rid of it.
2013-02-25 13:54:17 -08:00
Bobby Holley
e969932415 Bug 836301 - Add Special handling to allow us to call enter() for defineProperty on Xrays. r=mrbkap 2013-02-25 13:54:17 -08:00
Bobby Holley
141e362856 Bug 836301 - Stop using JSRESOLVE_ASSIGNING to determine GET vs SET. r=mrbkap
This is just a heuristic, anyway, and some of the usage is downright broken.
There are two cases here:

1 - Deciding what to do for get{Own,}PropertyDescriptor. In these cases, we can
just enter with GET and rely on the filtering machinery to filter out dangerous
setters for security wrappers.

2 - Custom Xray props. None of these make sense in a |set| context. In fact,
    they generally have null setters anyway, so we can just assume GET.

The policy-entering code in XrayWrapper is super haphazard. We'll get rid of it
entirely later in these patches.
2013-02-25 13:54:17 -08:00
Bobby Holley
1c8920e364 Bug 836301 - Assert against JSID_VOID in JSID wrapping. r=mrbkap
Luke explained to me that it should never get there.
2013-02-25 13:54:17 -08:00
Peter Van der Beken
07afde82fb Fix for bug 844559 (Crash [@ mozilla::dom::XrayResolveNativeProperty]). r=bz.
--HG--
extra : rebase_source : 85b3d0ee270f24847b9425cda9f8b56a494f2546
2013-02-25 20:39:15 +01:00
Daniel Holbert
9fbb71c834 Bug 845021: Add size_t cast in assertion, to silence build warning, in ObjectWrapperChild::AnswerNewEnumerateNext. r=Waldo 2013-02-25 13:46:56 -08:00
Tim Taubert
2728bcfbc9 Backed out changeset 4d74fe8e6560 (bug 842511) 2013-02-22 22:23:28 +01:00
Tim Taubert
5a9b5d9093 Backed out changeset 7052d37a8b25 (bug 842512) 2013-02-22 22:23:27 +01:00
Tim Taubert
e2e509208b Backed out changeset 96d8ca0dd540 (bug 842511) 2013-02-22 22:23:25 +01:00
Tim Taubert
281c5ad004 Bug 842511 - Fix xpcshell bustage; r=me 2013-02-22 21:17:44 +01:00
Tim Taubert
46c4acc68d Bug 842512 - Specify a character set for error pages; r=Waldo 2013-02-22 19:56:26 +01:00
Tim Taubert
c29a26701d Bug 842511 - Specify a character set for directory listings; r=Waldo 2013-02-22 19:56:14 +01:00
Nathan Froyd
2defe9ec0b Bug 844188 - use rcs.mk's functions for getting the source repo for telemetry revision ids; r=glandium 2013-02-22 13:49:05 -05:00
Fernando Jiménez
f97846302c Bug 809219 - [WebPayment] mozPay unit tests; r=fabrice 2013-02-25 13:12:44 +01:00
Jim Mathies
32ac9ae336 Bug 844113 - Add tests. r=mbrubeck 2013-02-22 14:11:45 -06:00
Jim Mathies
c2c47ed655 Bug 844113 - Properly calculate offsets in context menu messages originating from sub frames. r=fryn 2013-02-22 14:11:45 -06:00
Jim Mathies
6f479a6a1e Bug 844113 - Cleanup work in ContextMenuHandler.js. r=fryn 2013-02-22 14:11:45 -06:00
Gina Yeh
b8ae65cf9e Bug 844705 - Should send socket data in main thread, r=echou 2013-02-25 18:49:18 +08:00
Jonathan Kew
e2c957f1d0 bug 700023 - enable graphite font shaping by default. r=jdaggett 2013-02-25 10:39:29 +00:00
Mike Hommey
db7bee9956 Bug 841011 - Use the parent directory of XRE_EXECUTABLE_FILE to find autoconf file. r=bsmedberg 2013-02-25 10:50:12 +01:00
Mike Hommey
9d54dc8501 Bug 832272 - Allow mostly parallel build of NSS. r=ted 2013-02-25 10:49:34 +01:00
Vicamo Yang
752bad00e6 Bug 840780 (follow-up): fix nits. r=me 2013-02-25 17:36:05 +08:00
Siddartha Pothapragada
cbfe3f7459 Bug 840780 3/3 - B2G RIL: Add support to manage and access logical channels to UICC. r=vicamo 2013-02-25 17:27:26 +08:00
Siddartha Pothapragada
71525c8deb Bug 840780 2/3 - DOM changes to IccManager to support Secure Access to the UICC. r=vicamo 2013-02-25 17:27:23 +08:00
Siddartha Pothapragada
aaf8d1d374 Bug 840780 1/3 - New interfaces to access Secure element within UICC. r=mounir 2013-02-25 17:27:18 +08:00
L. David Baron
d4d58ab893 Bug 404077: Add mochitest support (currently semi-disabled) for making tests fail when an unexpected number of assertions fire. r=ted
This adds support for assertion checking in all mochitest suites except
for mochitest-browser-chrome.  The checking works much like it does in
reftest, except for the mechanism for annotating expected assertions,
SimpleTest.expectAssertions() (see its in-code documentation).

The support is initially disabled in that:
 (1) It doesn't cause the tests to report failure (and thus turn the
     tree orange).
 (2) It prints TEST-DETCEPXENU-FAIL/PASS instead of
     TEST-UNEXPECTED-FAIL/PASS (so that it doesn't show up in log
     highlighting).

The assertion checking only works within the test runner (which runs
multiple tests); it does not function when running only a single test.
2013-02-24 23:42:38 -08:00
L. David Baron
ca1bc93d5f Bug 842476: Work around leak resulting from exception that happens during unload by propagating only the prompts we expect and not the later ones. r=jlebar
Make this test less sensitive to the timing of its own unloading by
passing on only the expected messages and not any messages that occur
during unloading.  Such messages might cause exceptions (e.g.,
"'TypeError: can't access dead object' when calling method:
[nsIPrompt::alert]"), and those exceptions might in turn trigger leaks
in nsXPConnect that last until shutdown because we store the most recent
exception from a call to an XPCWrappedJS on the XPCJSRuntime through
shutdown (rather than reporting it, as we probably should, and then
freeing it), leaking the window.
2013-02-24 23:42:38 -08:00
Gina Yeh
ebe9a6d53b Bug 844707 - Fix warnings in debug build, r=echou 2013-02-25 15:04:38 +08:00
Phil Ringnalda
16e0bf8187 Back out 0fc2a36c23d8 (bug 844253) for bustage
CLOSED TREE
2013-02-24 22:52:40 -08:00
Chia-hung Tai
e07370ca5d Bug 810067 - Support automatic/manual/never retrieval modes. r=vyang 2013-02-25 14:08:23 +08:00
Kannan Vijayan
259242f46c Bug 844253 - Change useNewType to be a flag on StackFrame instead of an explicitly passed argument. r=bhackett 2013-02-25 00:57:39 -05:00
Tim Taubert
dde55e25cc Bug 817947 - Swap tab states (not docShells) when swapBrowsersAndCloseOther() is called with a pending tab; r=gavin 2013-02-22 18:41:23 +01:00
Raymond Heldt
6d358331e7 Bug 812762 - Use &brandShortName; instead of Firefox; r=jwalker 2013-02-22 16:37:48 +00:00
Adam Goforth
40abf1ce6f Bug 768039 - Refactor 'cmd refresh' to use OS.File; r=jwalker 2013-02-22 16:37:48 +00:00
Adam Goforth
9d78730701 Bug 767588 - GCLI number type should allow restriction to integers; r=jwalker 2013-02-22 16:37:48 +00:00
Joe Walker
14c80f56b2 Bug 841337 - GCLI web should have continuous integration. Maybe Travis-CI; r=mratcliffe 2013-02-22 16:37:48 +00:00
Richard Newman
5c966a31fa Bug 843980 - Switch tests to check for category entries, not service existence. r=mconnor 2013-02-22 08:15:53 -08:00
Tim Taubert
e4969d2669 merge m-c to fx-team 2013-02-22 16:19:50 +01:00
Sriram Ramasubramanian
c941cd2e2a Bug 843619: Remove tabs tray menu. [r=mfinkle] [needs-clobber]
--HG--
extra : rebase_source : 1a5f82f47ea115d38ad96af61df7dcb77babdeca
2013-02-21 14:21:57 -08:00
Jonathan Griffin
febca4f424 Bug 844942 - Let switching to top-level frame work even when current frame is invalid, r=mdas 2013-02-25 13:24:19 -08:00
Matt Woodrow
a3bb993fb1 Bug 835045 - Use CreateThebesSurfaceAliasForDrawTarget_hack to avoid having multiple cairo_surface_quartz objects for a single CGContext. r=nrc 2013-02-26 10:18:52 +13:00
Matt Woodrow
2ed4bbe377 Bug 841308 - Make WillPaintWindow be called for cocoa popups. r=roc 2013-02-26 10:18:48 +13:00
Matt Brubeck
cbc0046a01 Bug 840360 - Extract reftest-content.js's setTimeout implementation into new Timer.jsm [r=jwalker r=cjones sr=gavin]
--HG--
rename : browser/devtools/shared/Browser.jsm => toolkit/modules/Timer.jsm
rename : browser/devtools/shared/test/browser_browser_basic.js => toolkit/modules/tests/xpcshell/test_timer.js
2013-02-25 11:08:33 -08:00
Kartikaya Gupta
dfdd0b2b64 Bug 840721 - Add a PostDelayedTask method to the GeckoContentController interface. r=cjones 2013-02-25 15:50:49 -05:00
Matt Brubeck
378d71c084 Bug 844328 - Silence debug warning about _onTouchStart return value [r=jimm] 2013-02-25 11:08:25 -08:00