8869 Commits

Author SHA1 Message Date
Gijs Kruitbosch
9f3a3e9669 Bug 1578709 - Only set flash only pref for those tests that need it, r=mconley,ahal
Differential Revision: https://phabricator.services.mozilla.com/D44648

--HG--
extra : moz-landing-system : lando
2019-09-04 22:12:39 +00:00
Gurzau Raul
f96e9cd73f Backed out changeset 887d125d7f59 (bug 1578709) for failing at test_bug427744.html on a CLOSED TREE. 2019-09-04 21:34:11 +03:00
Gijs Kruitbosch
bb899238e7 Bug 1578709 - Only set flash only pref for those tests that need it, r=mconley,ahal
Differential Revision: https://phabricator.services.mozilla.com/D44648

--HG--
extra : moz-landing-system : lando
2019-09-04 17:28:02 +00:00
Mark Striemer
81ccc8bda3 Bug 1568687 - Move the shortcuts view into the HTML view browser r=robwu,rpl
This moves the shortcuts view into the regular HTML views so they can eventually share a header. This also reduces the number of browser on the page by 1 \o/

Differential Revision: https://phabricator.services.mozilla.com/D39371

--HG--
extra : moz-landing-system : lando
2019-08-27 14:15:49 +00:00
Itiel
1e8f420fff Bug 1575483 - Force LTR the homepage url for extensions r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D42971

--HG--
extra : moz-landing-system : lando
2019-09-03 18:35:18 +00:00
Paul Zuehlcke
c4e3669f0f Bug 1558439 - Log warning to web console when add-on installation was blocked due to fullscreen. r=johannh,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D44161

--HG--
extra : moz-landing-system : lando
2019-08-30 16:34:08 +00:00
Itiel
9bb55ae4d8 Bug 1578092 - Fix about:addons "Contribute" button background icon position for RTL r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D44317

--HG--
extra : moz-landing-system : lando
2019-09-03 04:29:13 +00:00
Olli Pettay
4a778f8d78 Bug 1574290, browser_html_options_ui.js should wait for the load event before expecting that the whole extension page has been loaded, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D44143

--HG--
extra : moz-landing-system : lando
2019-08-30 21:08:32 +00:00
Olli Pettay
7df1ef4aec Bug 1558676, browser_html_options_ui.js should wait long enough to ensure layout has been flushed everywhere, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D44063

--HG--
extra : moz-landing-system : lando
2019-08-29 23:35:20 +00:00
Olli Pettay
c0d2f69881 Bug 1576783, make browser_doorhanger_bc_downloadAutoFailures_bgWin.js more resilient to when popupshown event fires, r=rstrong
popupshown may get fired while waiting for closeWindow or promiseFocus to be executed.
Other uses of runDoorhangerUpdateTest seem to be simpler and should be fine without popupShown parameter.

Differential Revision: https://phabricator.services.mozilla.com/D43672

--HG--
extra : moz-landing-system : lando
2019-08-27 20:40:33 +00:00
Adam Gashlin
05036fda25 Bug 1572844 - Consistently check for MOZ_BITS_DOWNLOAD. r=bytesized
BITS download can be disabled on Windows. This patch checks for the
config/define MOZ_BITS_DOWNLOAD when including the C++ parts of the
service, exposing the service in JS, setting the pref, and including
BITS-specific tests. For consistency and simplicity it also removes
the Windows checks; the configure system won't allow
MOZ_BITS_DOWNLOAD if not on Windows.

Differential Revision: https://phabricator.services.mozilla.com/D43493

--HG--
extra : moz-landing-system : lando
2019-08-26 23:38:50 +00:00
Luca Greco
1904edd972 Bug 1572173 - AbuseReporter should send addon install source and method without pre-classification. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D42834

--HG--
extra : moz-landing-system : lando
2019-08-23 10:50:33 +00:00
Mark Striemer
f56c62c460 Bug 1567600 - Part 4: Add aria-label to about:addons more options button r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D42680

--HG--
extra : moz-landing-system : lando
2019-08-22 21:00:09 +00:00
Mark Striemer
056f2d5ae8 Bug 1567600 - Part 3: Better accessibility for named-deck and about:addons detail view r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D42370

--HG--
extra : moz-landing-system : lando
2019-08-22 21:00:09 +00:00
Mark Striemer
c19ef4049e Bug 1567600 - Part 2: Better accessibility for about:addons panel-list r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D40506

--HG--
extra : moz-landing-system : lando
2019-08-22 21:00:09 +00:00
Mark Striemer
97c482692c Bug 1567600 - Part 1: Better accessibility for about:addons list view r=fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D40505

--HG--
extra : moz-landing-system : lando
2019-08-22 21:00:08 +00:00
Robert Strong
ec210ed823 Bug 1574980 - followup. a=mingw32-fix
--HG--
extra : amend_source : 7248399774b5741857360cdf3318b4d1a59719a8
2019-08-22 22:35:04 +02:00
Luca Greco
b2c8b8875b Bug 1572711 - Record extensions.blocklist.useXML and services.blocklist.*.checked prefs into new telemetry scalars. r=janerik,leplatrem,Gijs
Depends on D41734

Differential Revision: https://phabricator.services.mozilla.com/D41735

--HG--
extra : moz-landing-system : lando
2019-08-22 16:32:19 +00:00
Luca Greco
85ae99d8ee Bug 1572711 - Record addonsManager.blocklistUpdateError telemetry event on blocklist update failures. r=janerik,Gijs
Depends on D41733

Differential Revision: https://phabricator.services.mozilla.com/D41734

--HG--
extra : moz-landing-system : lando
2019-08-21 19:37:03 +00:00
Luca Greco
23344811d9 Bug 1572711 - Added blocklist.lastModified_xml telemetry scalar to record extensions.blocklist.lastModified value. r=janerik,leplatrem,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D41733

--HG--
extra : moz-landing-system : lando
2019-08-21 19:51:52 +00:00
Robert Strong
c39174d546 Bug 1574980 - Fix issues with maintenance service install. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D43034

--HG--
extra : moz-landing-system : lando
2019-08-22 16:23:51 +00:00
Luca Greco
ef1c0b40d8 Bug 1574431 - Preserve installTelemetryInfo when rebuilding the DB from the addons manifest files. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D42281

--HG--
extra : moz-landing-system : lando
2019-08-22 12:22:31 +00:00
Mike Hommey
66d7fe943e Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D42765

--HG--
extra : moz-landing-system : lando
2019-08-21 12:25:42 +00:00
Matt Howell
6f1b6a839a Bug 1567247 Part 3 - Support for reading and uninstalling registry-reflected prefs. r=agashlin
We intentionally only clean out the prefs registry key during uninstall, unlike
the other registry keys that the installer creates, because we might want to do
experiments that involve the procedures that normally clean out registry keys.
This leaves open the possibility that an experiment causes some problem that
by its nature makes it difficult to disable the experiment, since it wouldn't
be disabled by either a normal update or a paveover install, but it's
necessary to make sure that experiments persist for longer than e.g. a single
update cycle.

Depends on D40327

Differential Revision: https://phabricator.services.mozilla.com/D40328

--HG--
extra : moz-landing-system : lando
2019-08-21 16:09:46 +00:00
Mark Striemer
a9733a6c3b Bug 1560155 - Link add-on badges to their SUMO page r=robwu,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D42681

--HG--
extra : moz-landing-system : lando
2019-08-21 04:53:45 +00:00
Sylvestre Ledru
7759b614e2 Bug 1575249 - Ride along: remove +x permissions on source files r=Ehsan
Depends on D42672

Differential Revision: https://phabricator.services.mozilla.com/D42673

--HG--
extra : moz-landing-system : lando
2019-08-21 09:57:03 +00:00
Nick Alexander
ae36e5d5c2 Bug 1550146 - Part 1: Do less (no mozharness.zip) in local mach package. r=chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D41449

--HG--
extra : moz-landing-system : lando
2019-08-21 03:22:14 +00:00
Gijs Kruitbosch
e5baa47643 Bug 1541706 - attempt to fix intermittent browser_privatebrowsing.js, r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D42663

--HG--
extra : moz-landing-system : lando
2019-08-20 16:05:26 +00:00
Olli Pettay
1950b63b62 Bug 1556579, try to make browser_html_options_ui_in_tab.js less racy, r=rpl
The test starts to fail more often with Fission session history (which is still using sync IPC).
The change should guarantee that there is time to send and receive options-loaded message.

Differential Revision: https://phabricator.services.mozilla.com/D42574

--HG--
extra : moz-landing-system : lando
2019-08-20 10:06:48 +00:00
Geoff Lankow
b1ff557a85 Bug 1572819 - Enable toolkit/mozapps/extensions/test/xpcshell/test_system_update_enterprisepolicy.js for Thunderbird; r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D42083

--HG--
extra : moz-landing-system : lando
2019-08-19 16:44:10 +00:00
Robert Strong
8be2059dbd Bug 1486637 - Backout bug 1486637 and related patches. r=agashlin
Differential Revision: https://phabricator.services.mozilla.com/D42143

--HG--
extra : moz-landing-system : lando
2019-08-19 19:43:17 +00:00
Kirk Steuber
28ff71c2d6 Bug 1570396 - Fix misc. issues with permission setting r=mhowell
This patch fixes a number of miscellaneous issues with permission setting.
When we move a directory, recreate it, and move the contents back, those contents may be in use (possibly by antivirus). To address this, we now fall back to copying the data back and removing the originals.

The maximum number of backups to make when moving conflicting files is now 3 instead of 9. 9 seemed a bit excessive.

There is now an additional level of SetPermissionsOf, FilesAndDirsWithBadPerms. This new value causes permissions not to be fixed if we are unable to read them. This should prevent unnecessary permission fixes while still allowing us to aggressively set them when necessary.

Differential Revision: https://phabricator.services.mozilla.com/D42066

--HG--
extra : moz-landing-system : lando
2019-08-19 17:35:29 +00:00
Ciure Andrei
9a123fb597 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan
240771fa29 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
Mark Banner
b1970e6a2f Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
These are raised as redeclares or unused variables by ESLint 6.

Differential Revision: https://phabricator.services.mozilla.com/D37268

--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
Luca Greco
87aa804651 Bug 1473837 - AddonInstall should flush the jar cache for the temporary xpi file before trying to remove it. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D41360

--HG--
extra : moz-landing-system : lando
2019-08-16 21:49:33 +00:00
Robert Strong
78a7ea9c45 Bug 1574080 - Remove gDestPath and associated code in updater.cpp since it is no longer used. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D42316

--HG--
extra : moz-landing-system : lando
2019-08-16 15:43:13 +00:00
Mark Striemer
bd5ab026e1 Bug 1557175 - Hide inline options when add-on is disabled r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D35068

--HG--
extra : moz-landing-system : lando
2019-08-01 18:55:30 +00:00
Paul Zuehlcke
3d15cf5b29 Bug 1531303 - Refactored tests using SitePermissions URI methods for PermissionTestUtils and principals. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41490

--HG--
extra : moz-landing-system : lando
2019-08-15 14:35:38 +00:00
Paul Zuehlcke
89fb47a8d9 Bug 1531303 - Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41029

--HG--
extra : moz-landing-system : lando
2019-08-15 14:32:48 +00:00
Trishul
9129ff2c95 Bug 1520123: Notify users when there is a duplicate shortcut r=mstriemer,fluent-reviewers,flod,Gijs
Notify users when there is a duplicate shortcut

Differential Revision: https://phabricator.services.mozilla.com/D29125

--HG--
extra : moz-landing-system : lando
2019-08-15 10:15:28 +00:00
Luca Greco
570c0ac6ca Bug 1548481 - Rewrite assertions used in Add-ons Manager tests to make use of TelemetryTestUtils. r=mstriemer,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D41594

--HG--
extra : moz-landing-system : lando
2019-08-14 20:31:58 +00:00
Brindusan Cristian
3a61fb322f Merge inbound to mozilla-central. a=merge 2019-08-15 12:45:55 +03:00
Mike Hommey
c173540215 Bug 1573435 - Use toolchain fetches for all remaining toolchain uses. r=nalexander
The remaining uses all need adjustements to in-tree mozconfigs, so they
all need to be done at once.

However, to make things slightly more intelligible, we do this in two
steps. This is step 1: we modify the use_toolchain transform to take care of
the transformation, while keeping the task definitions intact, so that
we only deal with mozconfig and build script adjustements here.

Differential Revision: https://phabricator.services.mozilla.com/D41890
2019-08-15 11:21:52 +09:00
Nick Alexander
44608f65ab Bug 1570411 - Add --without-fennec to make mach package not produce Fennec APK. r=chmanchester
When working on GeckoView, there's no need to produce a Fennec APK.
This commit avoids doing that work at `mach package` time.  There are
many other things we'd like to stop doing as we remove Fennec from the
tree, so we add a general flag to guard such things.

Depends on D41447

Differential Revision: https://phabricator.services.mozilla.com/D41448

--HG--
extra : moz-landing-system : lando
2019-08-14 20:40:00 +00:00
Ciure Andrei
b454daea7a Backed out 3 changesets (bug 1531303) for causing close_window/close.py and browser_permissions_dialog.js to perma fail CLOSED TREE
Backed out changeset 87305e83174e (bug 1531303)
Backed out changeset 0c75c3bac00b (bug 1531303)
Backed out changeset 865c2a5d40da (bug 1531303)
2019-08-14 13:07:55 +03:00
Paul Zuehlcke
065ae1e01e Bug 1531303 - Refactored tests using SitePermissions URI methods for PermissionTestUtils and principals. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41490

--HG--
extra : moz-landing-system : lando
2019-08-14 08:31:39 +00:00
Paul Zuehlcke
93bacc1004 Bug 1531303 - Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41029

--HG--
extra : moz-landing-system : lando
2019-08-14 08:31:23 +00:00
J.C. Jones
32759c8ed5 Bug 1573662 - Rename sanctions test routines to make it easier to add new ones r=keeler
1) Multipurpose-ing the TLSServer specialization to `SanctionsTestServer`
2) Renaming the `security/manager/ssl/tests/unit/test_symantec_apple_google` folder of certs to `test_sanctions`
3) Prepend a `symantec-` to the start of all relevant certs in the new `test_sanctions` folder
4) Renaming the existing xpcshell test to `test_sanctions_symantec_apple_google.js`

Differential Revision: https://phabricator.services.mozilla.com/D39942

--HG--
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.key => security/manager/ssl/tests/unit/test_sanctions/default-ee.key
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.key.keyspec => security/manager/ssl/tests/unit/test_sanctions/default-ee.key.keyspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.pem => security/manager/ssl/tests/unit/test_sanctions/default-ee.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/default-ee.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/default-ee.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/moz.build => security/manager/ssl/tests/unit/test_sanctions/moz.build
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-after-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-after-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-after-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-after-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-before-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-before-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-from-whitelist-before-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-from-whitelist-before-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-after-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-after-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-after-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-after-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-before-cutoff.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-before-cutoff.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/ee-not-whitelisted-before-cutoff.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-ee-not-whitelisted-before-cutoff.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other-crossigned.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other-crossigned.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other-crossigned.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other-crossigned.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-other.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-other.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-whitelisted.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-whitelisted.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/intermediate-whitelisted.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-intermediate-whitelisted.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/real-google-g2-intermediate.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-real-google-g2-intermediate.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/real-googlecom.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-real-googlecom.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/test-ca.pem => security/manager/ssl/tests/unit/test_sanctions/symantec-test-ca.pem
rename : security/manager/ssl/tests/unit/test_symantec_apple_google/test-ca.pem.certspec => security/manager/ssl/tests/unit/test_sanctions/symantec-test-ca.pem.certspec
rename : security/manager/ssl/tests/unit/test_symantec_apple_google.js => security/manager/ssl/tests/unit/test_sanctions_symantec_apple_google.js
rename : security/manager/ssl/tests/unit/tlsserver/cmd/SymantecSanctionsServer.cpp => security/manager/ssl/tests/unit/tlsserver/cmd/SanctionsTestServer.cpp
extra : moz-landing-system : lando
2019-08-13 20:59:17 +00:00
Emilio Cobos Álvarez
c3ee3ac3a8 Bug 1418624 - Allow mozilla::Result to be moved, make unwrap{,Err}() move, and add inspect() APIs that return references. r=froydnj
Also adjust some of the callers that were either calling unwrap() repeatedly on
the same result, or were doing silly copies, to use inspect().

We could try to use stuff like:

https://clang.llvm.org/docs/AttributeReference.html#consumed-annotation-checking

Differential Revision: https://phabricator.services.mozilla.com/D41425

--HG--
extra : moz-landing-system : lando
2019-08-13 08:26:18 +00:00