Masayuki Nakano
b30dc0891e
Bug 1337718 part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible r=m_kato
...
MozReview-Commit-ID: EMFevpq9ftM
--HG--
extra : rebase_source : bc2074cf119b8ea698f3eed809b43d4a93d49168
2017-02-08 22:55:54 +09:00
Masayuki Nakano
fa85dc8ad8
Bug 1337718 part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato
...
MozReview-Commit-ID: KdoMcxW8lkT
--HG--
extra : rebase_source : a03316e3a6ca7daf937032f32e00f2a4b2fd23fc
2017-02-08 22:29:14 +09:00
Masayuki Nakano
a6bd2cc214
Bug 1337718 part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato
...
MozReview-Commit-ID: A53lxmDXLMb
--HG--
extra : rebase_source : 4b022a38c45d68563fcd89b9e8c504cb52f7fab0
2017-02-08 22:19:14 +09:00
Masayuki Nakano
cee96a2b9a
Bug 1337718 part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent r=m_kato
...
MozReview-Commit-ID: FDselwSymZq
--HG--
extra : rebase_source : 211e4f91075d0a93bf10fd82273856010957b3ee
2017-02-08 22:02:49 +09:00
Masayuki Nakano
3e94f4acb9
Bug 1337718 part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
...
MozReview-Commit-ID: 6gST8uULwSb
--HG--
extra : rebase_source : 1428e1d24b0b8295a3d57764535651f221fcf637
2017-02-08 21:30:27 +09:00
Masayuki Nakano
b66e2b2e6e
Bug 1337718 part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
...
Additionally, this patch removes unnecessary name space wrapper of IsCtrlShiftPressed(). Perhaps, it was necessary when mozilla::EditorEventListener was nsEditorEventListener.
MozReview-Commit-ID: EHzt7aRtYgQ
--HG--
extra : rebase_source : d38d73226de8f5563ad66de10f8f8ed701d766a1
2017-02-08 20:05:12 +09:00
Masayuki Nakano
c58f95a48b
Bug 1337718 part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
...
MozReview-Commit-ID: K9zCJsYgfbL
--HG--
extra : rebase_source : 77941f0fe5be600a61576706968f25ff13d218c7
2017-02-08 20:22:57 +09:00
Masayuki Nakano
2f6ff9d325
Bug 1337718 part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
...
MozReview-Commit-ID: 49fcZXPSsQ4
--HG--
extra : rebase_source : f0e3791c0067c580cb4f134d3ff9c1f5f504aaa2
2017-02-08 19:50:50 +09:00
Masayuki Nakano
87c78a5bfb
Bug 1337718 part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
...
MozReview-Commit-ID: 4JS2yJ6iXgY
--HG--
extra : rebase_source : 30cbcab74da7731e446329a3263dd82cd16fdfab
2017-02-08 19:47:05 +09:00
Masayuki Nakano
c4cea9a380
Bug 1337718 part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
...
MozReview-Commit-ID: 8QUiHPRf9AH
--HG--
extra : rebase_source : d9a531248f4e72dfb501146976af7efd64d1e122
2017-02-08 20:18:17 +09:00
Masayuki Nakano
5442d350f3
Bug 1337739 Create an enum eKeyLocation* for avoiding to use nsIDOMKeyEvent::DOM_KEY_LOCATION_* r=smaug
...
Currently, we use alias NS_VK_* for WidgetKeyboardEvent::mKeyCode. Similarly, we should create alias enum for nsIDOMKeyEvent::DOM_KEY_LOCATION_*. Then, we can reduce the length and avoid to include nsIDOMKeyEvent in some cpp files.
MozReview-Commit-ID: 5cs4zQ061Lc
--HG--
extra : rebase_source : e6a6edd27718b9e3d4a40b07902d029791876999
2017-02-08 21:04:22 +09:00
Wes Kocher
d3307f19d5
Merge inbound to central, a=merge
...
MozReview-Commit-ID: 9TTIrjfNKZm
--HG--
rename : dom/base/test/test_bug1263696.html => testing/web-platform/tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback-2.html
rename : dom/base/test/test_bug1263696.html => testing/web-platform/tests/html/semantics/embedded-content/the-object-element/object-in-object-fallback-2.html
2017-02-09 17:01:39 -08:00
Carsten "Tomcat" Book
e2a2f8d124
merge mozilla-inbound to mozilla-central a=merge
2017-02-09 16:04:14 +01:00
Carsten "Tomcat" Book
ffe70d35b2
Merge mozilla-central to mozilla-inbound
2017-02-09 11:38:08 +01:00
Makoto Kato
894130bddc
Bug 1337698 - Part 3. TypeInState should use UniquePtr. r=masayuki
...
MozReview-Commit-ID: K9UY83Nx1v3
--HG--
extra : rebase_source : e9177c1c31805288e04270b589300c8e49d59940
extra : amend_source : 91bea4e023031b1c1594799b8dbe70dc3fb5b6ed
extra : histedit_source : 2ee5b839c0f8019d18586a1b07e06e122e7780ee
2017-02-08 18:14:53 +09:00
Makoto Kato
d84f1fef72
Bug 1337698 - Part 2. HTMLEditor should use UniquePtr. r=masayuki
...
MozReview-Commit-ID: 2O9f0K1RSU4
--HG--
extra : rebase_source : 966ffcf877756a876d72a0e09659dbeee406cddd
extra : histedit_source : 6eac1458a8f3826e73238cfbdbd03c1426a390be
2017-02-08 18:14:24 +09:00
Makoto Kato
b8d5c8b156
Bug 1337698 - Part 1. PlaceholderTransaction should use UniquePtr. r=masayuki
...
MozReview-Commit-ID: 8xqAKRcKCLb
--HG--
extra : rebase_source : d0a8d202e973d06c823cd5351d9561b9b5919f43
extra : histedit_source : 696ac1246fbb3691b2f042a0d16e438f37dcf64d%2C446038a833523fed82771c3c177811971679c269
2017-02-09 14:26:10 +09:00
Cameron McCormack
90e83367ae
Bug 1334768 - stylo: Test expectation adjustments for for 2017-02-09 merge. r=me
...
MozReview-Commit-ID: AhvCAu3NYrb
2017-02-09 21:11:09 +08:00
Makoto Kato
6b3afdd60e
Bug 1337273 - Don't use mTextEditor from HTMLEditRules. r=masayuki
...
HTMLEditRules can access both mTextEditor and mHTMLEditor, but we should use mHTMLEditor only on HTMLEditRules for readability.
MozReview-Commit-ID: HfzwAD554XQ
--HG--
extra : rebase_source : 7d722915a41eb878e2cd2ff711ac4925bd91d1d8
2017-02-08 18:32:32 +09:00
Masayuki Nakano
431e1a12b3
Bug 1336011 part.3 Create an alias of the type of mDocStateListeners r=smaug
...
MozReview-Commit-ID: L0TczDcH4t8
--HG--
extra : rebase_source : 0a250056797c6fb760e7aa674565d3e71df6f568
2017-02-07 22:52:23 +09:00
Masayuki Nakano
a5c23d8c73
Bug 1336011 part.2 Create an alias of the type of mEditorObservers r=smaug
...
MozReview-Commit-ID: 7LWl5F4C0Ge
--HG--
extra : rebase_source : 0393619ad8f3ea1090244db5eeb117f73afb47ea
2017-02-07 22:36:16 +09:00
Masayuki Nakano
36efe8eb2b
Bug 1336011 part.1 EditorBase shouldn't refer mActionListeners directly in loops because it might be removed during a loop r=smaug
...
Items in mActionListeners may be removed during a call of a method of another item. Therefore, all items should be copied to different array before each loop referring mActionListeners.
MozReview-Commit-ID: FA2xXdJ9SoR
--HG--
extra : rebase_source : 054a58f5a82df6911d42b17fdb3f11738ceab2af
2017-02-07 22:26:56 +09:00
Makoto Kato
78b1b5964b
Bug 1336349 - Merge GetIsDocumentEditable implementation to EditorBase. r=masayuki
...
GetIsDocumentEditable is implemnted in EditorBase, TextEditor, and HTMLEditor. This is virtual method, we won't use EditorBase::GetIsDocumentEditable. Also, TextEditor::GetIsDocumentEditable and HTMLEditor::GetIsDocumentEditable are same implementation. So we should merge this to EditorBase.
MozReview-Commit-ID: 62euqUaYAuY
--HG--
extra : rebase_source : 1a3025aeddc61d0ae3e0de334472ee8393893114
2017-02-03 16:22:50 +09:00
Phil Ringnalda
b1aadb3572
Backed out 5 changesets (bug 1285898) for causing the crashes of bug 1336242
...
Backed out changeset 15b3b9feb54f (bug 1285898)
Backed out changeset 1d0bfb02d6c0 (bug 1285898)
Backed out changeset bc99844772ee (bug 1285898)
Backed out changeset 8bbe285cf5c0 (bug 1285898)
Backed out changeset e56108122b90 (bug 1285898)
2017-02-02 22:02:24 -08:00
Wes Kocher
2dcccc4332
Merge inbound to central, a=merge
...
MozReview-Commit-ID: 9bhCPrArK3P
2017-02-02 16:39:24 -08:00
Boris Zbarsky
08d76ec702
Bug 1332812. Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj
2017-02-02 10:32:58 -05:00
Sebastian Hengst
4c5957bbd3
Backed out changeset c724fbd9c326 (bug 1332812) for build bustage. r=backout on a CLOSED TREE
2017-02-02 16:58:52 +01:00
Boris Zbarsky
b249de7c3a
Bug 1332812. Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj
2017-02-02 10:32:58 -05:00
Makoto Kato
54208413e9
Bug 1335672 - Missing virtual keyword into HTMLEditor. r=masayuki
...
MozReview-Commit-ID: 9C9KMfs5GAF
--HG--
extra : rebase_source : 0e2dd971b4b7c77dea04a74b9b4af8e5a2c822c2
2017-02-01 17:09:54 +09:00
Andrea Marchesini
1e58b980f5
Bug 1285898 - [e10s-multi] Localstorage "storage" event is not fired with multiple content processes. r=asuth
...
--HG--
extra : rebase_source : 9968fd96960aecd516bfcc5c239b9de85280ab8a
extra : source : 6681b50c1f6d0d2d22d5f631234402e020c0b78a
2017-01-17 15:43:12 -05:00
Masayuki Nakano
6ec0bf9ddd
Bug 1314053 part.4 EditorEventListener should grab mEditorBase in smaller scope as far as possible and shouldn't access it directly during handling an event r=smaug
...
So, EditorEventListener should grab mEditorBase in smaller scope as far as possible. And each event listener method shouldn't access mEditorBase directly at calling its method since it might be changed to another instance.
MozReview-Commit-ID: IUCl5gbh4ut
--HG--
extra : rebase_source : 217d881923193a25db0649fc1f1a87bd43fa4d99
2017-01-17 19:30:39 +09:00
Masayuki Nakano
18382319ef
Bug 1314053 part.3 EditorEventListener should check if it's removed during a call of editor's method r=smaug
...
EditorEventListener doesn't check if mEditorBase is available even after it's removed from the editor. If it becomes nullptr, i.e., it's detached from editor, it shouldn't continue to handle event.
This patch changes some methods' nsIDOM*Event argument to WidgetEvent since it's simpler.
MozReview-Commit-ID: CI3U4pfVxtb
--HG--
extra : rebase_source : 7135c4615f6a1dd8bb4b6698261c75a9f8c70930
2017-01-21 00:13:45 +09:00
Masayuki Nakano
7ab96b2cef
Bug 1314053 part.2 Change EditorBase::IsAcceptableInputEvent()'s argument from nsIDOMEvent* to WidgetGUIEvent* r=smaug
...
MozReview-Commit-ID: Jo6EwQubUAM
--HG--
extra : rebase_source : 098b23946f349bbe7641a2059538ffb20ae4f5bb
2017-01-17 17:17:06 +09:00
Masayuki Nakano
91360648d1
Bug 1314053 part.1 Change EditorBase::UpdateIMEComposition()'s argument from nsIDOMEvent* to WidgetCompositionEvent* r=smaug
...
Before cleaning up EditorEventListener, we need to make it use Widget*Event at each event method.
MozReview-Commit-ID: 482HHN0bCVV
--HG--
extra : rebase_source : a2f504ca931ec98945f7317b972b21d765304c92
2017-01-17 17:01:17 +09:00
Cameron McCormack
8731638062
Bug 1334768 - stylo: Adjust a bunch of reftest expectations. r=me on a CLOSED TREE
...
MozReview-Commit-ID: 1qa08cspl7o
2017-01-31 17:38:24 +01:00
Cameron McCormack
590058f927
Bug 1324669 - stylo: Downgrade SMIL assertion even further to a non-test-failing warning. r=me
...
MozReview-Commit-ID: 5fk6C9qaOgW
2017-01-31 17:37:08 +01:00
Sebastian Hengst
ed5bd31f9b
Backed out changeset ad45a3da5e4a (bug 1324669) for Windows build bustage: OverflowChangedTracker.h(44). r=backout on a CLOSED TREE
2017-01-31 17:32:12 +01:00
Sebastian Hengst
79a42c161e
Backed out changeset e3687105be00 (bug 1334768)
2017-01-31 17:30:16 +01:00
Cameron McCormack
0333846acf
Bug 1334768 - stylo: Adjust a bunch of reftest expectations. r=me
...
MozReview-Commit-ID: 1qa08cspl7o
2017-01-31 23:36:46 +08:00
Cameron McCormack
946b5c3633
Bug 1324669 - stylo: Downgrade SMIL assertion even further to a non-test-failing warning. r=me
...
MozReview-Commit-ID: 5fk6C9qaOgW
2017-01-31 23:36:12 +08:00
Makoto Kato
e904b47a40
Bug 1328023 - Part 2. Add test for undo. r=masayuki
...
MozReview-Commit-ID: 6ZuluRWrYxb
--HG--
extra : rebase_source : 40a08dbc688ee7c862f716c643897c84e6e86fde
2017-01-30 17:27:26 +09:00
Makoto Kato
1f259574fb
Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki
...
Part 3 fix of bug 1310912 is incorrect for not composition transaction. PlaceholderTransation is for saving and restoring current selection for undo. So we shouldn't use range updater to normal transaction.
Composition transaction can modify multiple nodes and it merges text node for ime into single text node. So if current selection is into IME text node, it might be failed to restore selection by UndoTransaction. So we need update selection by range updater to work UndoTransaction.
Also, CompositionTransaction::UndoTransaction will set selection after committed text. So at finally, selection will set correct position that composition transaction wants.
MozReview-Commit-ID: 1NcH32YoKPQ
--HG--
extra : rebase_source : 8a29ef3d4d4c64997416a8f3c7fd174766764ad3
2017-01-30 17:25:43 +09:00
Phil Ringnalda
85843f4cff
Backed out 4 changesets (bug 1285898) for browser_localStorage_e10s.js failure
...
Backed out changeset 9c6057cde326 (bug 1285898)
Backed out changeset bd68ebab64fa (bug 1285898)
Backed out changeset 6fdb24e1256d (bug 1285898)
Backed out changeset 6681b50c1f6d (bug 1285898)
2017-01-30 21:49:42 -08:00
Andrea Marchesini
db2311e1e0
Bug 1285898 - [e10s-multi] Localstorage "storage" event is not fired with multiple content processes. r=asuth
2017-01-30 22:47:06 -05:00
Wes Kocher
584127af5f
Merge inbound to central, a=merge
...
MozReview-Commit-ID: 4GYZ5Pzy7BY
2017-01-30 15:44:58 -08:00
Carsten "Tomcat" Book
86d6d898a4
Merge mozilla-central to mozilla-inbound
2017-01-30 16:02:19 +01:00
Carsten "Tomcat" Book
29cd257175
merge mozilla-inbound to mozilla-central a=merge
2017-01-30 15:59:14 +01:00
Cameron McCormack
9c4ea5685f
Bug 1334768 - stylo: Back out 800030115d2e and 404506488cfb for being completely wrong due to bug 1334938.
...
MozReview-Commit-ID: 8CGTqmtlguT
2017-01-30 16:49:54 +08:00
Florian Quèze
bdc1ffa608
Bug 1334831 - script-generated patch to use .remove() instead of .parentNode.removeChild, r=jaws.
2017-01-30 08:10:22 +01:00
Mats Palmgren
454b00deaa
Bug 1332876 - test.
2017-01-30 04:54:38 +01:00