Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 23:02:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
935,465 Commits 615 Branches 98 Tags 6 GiB
39c24294a3
Commit Graph

4646 Commits

Author SHA1 Message Date
Timothy Nikkel
c9583fe34e Bug 1873422. Ignore "invalid chunk type" errors in pngs if we have enough data to display something when encountered. r=aosmond 
GetFrameCount() > 0 means that we've started a frame, but not necessarily finished it.

Differential Revision: https://phabricator.services.mozilla.com/D198511
 2024-02-24 01:00:10 +00:00
Joel Maher
eaf8b887ab Bug 1879538 - cleanup unnecessary and redundant reftest conditions. r=aryx,jgilbert 
Differential Revision: https://phabricator.services.mozilla.com/D201794
 2024-02-22 23:04:45 +00:00
Gijs Kruitbosch
ff17e7fc68 Bug 1780071 - Manual fixes/disabling of no-comparison-or-assignment-inside-ok for exceptional cases, r=Standard8,devtools-reviewers,anti-tracking-reviewers,places-reviewers,dom-storage-reviewers,pbz,asuth,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D198979
 2024-02-19 23:30:40 +00:00
Perry McManis
1ebc673e72 Bug 1877840 - Migrate GVST metrics in the avif namespace to pure glean r=chutten,tnikkel 
GVST is how these probes sent data in Fenix and is now unnecessary (and doesn't send data in Fenix release) since Firefox Desktop has direct access to Glean. We therefore need to clean them up in some capacity.

Following the recommendations from the GeckoView Streaming (GVST) validation effort, this is a pure Glean api implementation of the metrics that fell under network in geckoview streaming.

Because these were all categorical histograms, to retain previous functionality we've added parallel instrumentation in Glean.

Differential Revision: https://phabricator.services.mozilla.com/D201024
 2024-02-09 19:47:46 +00:00
Tyson Smith
0be16bc8ee Bug 1874779 - Set image.mem.max_legal_imgframe_size_kb for libfuzzer targets. r=truber 
Differential Revision: https://phabricator.services.mozilla.com/D198633
 2024-02-02 16:53:54 +00:00
Timothy Nikkel
78e9020148 Bug 1864550. Allow pref image.mem.max_legal_imgframe_size_kb to be live. r=gfx-reviewers,gw 
This pref exists only for fuzzers so they don't waste time on overly large images. The way fuzzers set the pref requires it to be live.

Differential Revision: https://phabricator.services.mozilla.com/D198498
 2024-02-02 04:42:17 +00:00
Norisz Fay
34ba7989ae Backed out changeset c5ac0dc2aa69 (bug 1864550) for causing multiple image.mem.max_legal_imgframe_size_kb related failures CLOSED TREE 2024-02-02 04:48:43 +02:00
Timothy Nikkel
cd38dfd760 Bug 1864550. Allow pref image.mem.max_legal_imgframe_size_kb to be live. r=gfx-reviewers,gw 
This pref exists only for fuzzers so they don't waste time on overly large images. The way fuzzers set the pref requires it to be live.

Differential Revision: https://phabricator.services.mozilla.com/D198498
 2024-02-02 02:15:05 +00:00
Tom Marble
3c78905f47 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-29 17:30:48 +00:00
Sandor Molnar
51bb77759a Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
2434015dc5 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-26 20:06:56 +00:00
Paul Adenot
d6181b64f8 Bug 1868615 - Remove define usage. r=chunmin 
It doesn't exist anymore in upstream libaom, and we're only using it for this
assertion.

Differential Revision: https://phabricator.services.mozilla.com/D198364
 2024-01-19 10:35:19 +00:00
Tom Schuster
58300c5e90 Bug 1873474 - Use ImageBlocker directly instead of nsIContentPolicy::ShouldProcess in ImageDocument. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D198142
 2024-01-17 09:49:32 +00:00
Benjamin VanderSloot
5bd36b24b1 Bug 1873490, part 1 - Refactor the only external call to StorageDisabledByAntiTracking - r=anti-tracking-reviewers,timhuang 
I'm considering dropping this if statement entirely because this is only hit when we disable network state partitioning.
According to code coverage, we only see the ""_ns as the result of this ternary in our testing too.

But, if you disable network state partitioning and then block cookies from a given domain, then we would still want to partition network state I suppose, so I'll leave it like this..

Differential Revision: https://phabricator.services.mozilla.com/D198034
 2024-01-12 17:03:20 +00:00
Tom Schuster
346cecd51c Bug 1872839 - Remove aMimeTypeGuess parameter from nsIContentPolicy. r=freddyb 
Differential Revision: https://phabricator.services.mozilla.com/D197794
 2024-01-08 15:47:42 +00:00
Timothy Nikkel
0f39860036 Bug 1862059. Handle edge cases of svg images in multipart images. r=aosmond,gfx-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192827
 2024-01-02 07:13:01 +00:00
Andrew Osmond
0d3eae78e5 Bug 1872536 - Use MakeUniqueFallible for large buffers in image decoders/encoders. r=gfx-reviewers,lsalzman 
Differential Revision: https://phabricator.services.mozilla.com/D197461
 2023-12-31 22:16:46 +00:00
Timothy Nikkel
ea36a87c56 Bug 1869938. For docs that don't have a load context/docshell, try to inherit private browsing from the doc's channel. r=necko-reviewers,kershaw 
This is how we decide which imgLoader to use (private or not) when we load an image: https://searchfox.org/mozilla-central/rev/91cc8848427fdbbeb324e6ca56a0d08d32d3c308/dom/base/nsContentUtils.cpp#3898

Differential Revision: https://phabricator.services.mozilla.com/D196720
 2023-12-28 10:57:40 +00:00
Andrew Osmond
484b8d4e39 Bug 1871613 - Ensure CanvasDrawEventRecorder releases external surface dependencies. r=gfx-reviewers,lsalzman 
This patch makes CanvasDrawEventRecorder track what eventCount we
recorded an external surface reference. When the reader has increment
its processedCount above that, we will release our reference as it
should have acquired a strong reference to the data. This was previously
done when we forwarded the texture, but with remote textures, we no
longer have this event. Now we check when we start a new recording, or
attempt to clear cached resources.

Differential Revision: https://phabricator.services.mozilla.com/D197216
 2023-12-23 01:34:31 +00:00
Paul Adenot
fcf35cd837 Bug 1869332 - Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin 
Differential Revision: https://phabricator.services.mozilla.com/D196058
 2023-12-20 02:32:34 +00:00
Narcis Beleuzu
0f250fb8c2 Backed out 7 changesets (bug 1869332) for Android bustages. CLOSED TREE 
Backed out changeset e1a7852ec85a (bug 1869332)
Backed out changeset 886e59d6495f (bug 1869332)
Backed out changeset 03ac3598f84f (bug 1869332)
Backed out changeset 5e775f2c2b9c (bug 1869332)
Backed out changeset 295a1e1f01d5 (bug 1869332)
Backed out changeset 2909ac6aeb41 (bug 1869332)
Backed out changeset dfab47873174 (bug 1869332)
 2023-12-19 18:52:01 +02:00
Paul Adenot
e2e68cab50 Bug 1869332 - Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin 
Differential Revision: https://phabricator.services.mozilla.com/D196058
 2023-12-19 15:21:50 +00:00
Ryan VanderMeulen
3ffb39ec52 Bug 1852649 - Add crashtest. r=tnikkel 
Differential Revision: https://phabricator.services.mozilla.com/D187955
 2023-12-15 21:46:45 +00:00
Noemi Erli
862354d813 Backed out 7 changesets (bug 1869332) for causing libavcodec related bustages CLOSED TREE 
Backed out changeset 1c0fd259312d (bug 1869332)
Backed out changeset d51eba30a225 (bug 1869332)
Backed out changeset 483d3f275da7 (bug 1869332)
Backed out changeset c401449274b4 (bug 1869332)
Backed out changeset c83313202040 (bug 1869332)
Backed out changeset 00ceb6e47715 (bug 1869332)
Backed out changeset 5acc2f4f12c2 (bug 1869332)
 2023-12-14 12:02:45 +02:00
Paul Adenot
039cbc5bda Bug 1869332 - Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin 
Differential Revision: https://phabricator.services.mozilla.com/D196058
 2023-12-14 09:12:32 +00:00
Stanca Serban
d84ca52ee4 Backed out 6 changesets (bug 1869332) for causing build bustages. CLOSED TREE 
Backed out changeset 4f8c19f9dfcf (bug 1869332)
Backed out changeset 661e520c2991 (bug 1869332)
Backed out changeset 74e2acabc439 (bug 1869332)
Backed out changeset 1c4b5311ac03 (bug 1869332)
Backed out changeset af22bc552759 (bug 1869332)
Backed out changeset f557e130d997 (bug 1869332)
 2023-12-13 18:13:24 +02:00
Paul Adenot
9b4c4a5bb9 Bug 1869332 - Move libaom to libgkcodecs. r=glandium,media-playback-reviewers,chunmin 
Differential Revision: https://phabricator.services.mozilla.com/D196058
 2023-12-13 13:46:39 +00:00
Mike Hommey
619672a8e4 Bug 1867459 - Replace CPU_ARCH with TARGET_CPU. r=firefox-build-system-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D195157
 2023-12-08 10:43:59 +00:00
Joel Maher
c993099c60 Bug 1865385 - remove win7/win-aarch64 annotations from reftest manifests. r=gbrown 
Differential Revision: https://phabricator.services.mozilla.com/D193995
 2023-12-05 21:49:04 +00:00
Joel Maher
9d203b1d46 Bug 1859893 - batch 15 - migrate xpcshell.ini -> .toml. r=aryx,geckoview-reviewers,extension-reviewers,valentin,cookie-reviewers,pbz,owlish,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D194384
 2023-11-24 14:41:35 +00:00
Jonathan Watt
85bdec26c1 Bug 1866010 p2. Update UpdateContentViewerRegistration to reflect nsIDocumentViewer's new name. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194358
 2023-11-24 09:10:48 +00:00
Jonathan Watt
c96a66c3de Bug 1865480. Rename nsIContentViewer to nsIDocumentViewer. r=layout-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D193987
 2023-11-21 12:45:59 +00:00
Emilio Cobos Álvarez
ec7a1d06ff Bug 1864425 - Remove PendingAnimationTracker. r=birtles 
Instead of starting transitions and animations as a result of a paint,
use the refresh driver tick to do this.

This sets the transition-ready time to the current time during the next
refresh driver tick that it was started on (see mSawTickWhilePending).

This is similar to what's described in the bugs comments, and seems to
work nicely in practice.

We could easily change that (current time) by a paint-based time if
needed (when available), which would be more similar to what we were
doing. But I'd rather do the simple thing for now, and land this shortly
after the soft freeze is over so that we have time to watch out for
regressions.

There's one regression on a test that birtles wrote (using an XHR doc
and switching the timeline to a rendered doc's timeline).

We use the timeline's document rather than the target document to
determine whether to trigger animations now. That's one of the cases
where we'd keep vsync perma-running without this patch, and Chrome also
fails that test. Maybe the test should be removed / the spec should be
tweaked to allow this behavior?

This causes some progression in some CSS transitions tests too, and I
added an extra test for the vsync behavior.

Over-all this is much simpler to reason about and I think we should try
to do this.

Differential Revision: https://phabricator.services.mozilla.com/D193583
 2023-11-20 09:31:41 +00:00
Daisuke Akatsuka
62b2826a12 Bug 1864985: Add hasUserPass attribute to nsIURI r=necko-reviewers,valentin 
We will remove the user and pass from the URL for Histories and Favicons using
nsIOService::CreateExposableURI()[1], then store them to the database. And, for
Favicons. And, for Favicons, we will also read them. Therefore, as the
frequency calling CreateExposableURI() will be higher, we want to optimize it.
Currently, CreateExposableURI() gets/copies the String of UserPass to check whether there is a user pass info in the URL[2]. Its copying will be waste. To
prevent it, implement hasUserPass in nsIURI, and refer to it instead.

[1] https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/netwerk/base/nsIOService.cpp#1031
[2] https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/netwerk/base/nsIOService.cpp#1017

Differential Revision: https://phabricator.services.mozilla.com/D193623
 2023-11-17 20:12:10 +00:00
Sean Feng
539e32202b Bug 1722322 - Implement LargestContentfulPaint r=emilio 
Spec: https://w3c.github.io/largest-contentful-paint

Differential Revision: https://phabricator.services.mozilla.com/D151079
 2023-11-02 20:53:36 +00:00
Sandor Molnar
a4163792c6 Backed out 7 changesets (bug 1722322) for causing bp-nu bustages 
Backed out changeset 0ebd32e273b8 (bug 1722322)
Backed out changeset 7a75717f127c (bug 1722322)
Backed out changeset c2a6440a83d7 (bug 1722322)
Backed out changeset 9955756855bd (bug 1722322)
Backed out changeset 37fccb407777 (bug 1722322)
Backed out changeset f52b1f28f753 (bug 1722322)
Backed out changeset 0121c8cf5d2f (bug 1722322)
 2023-11-02 21:27:24 +02:00
Sean Feng
611093989e Bug 1722322 - Implement LargestContentfulPaint r=emilio 
Spec: https://w3c.github.io/largest-contentful-paint

Differential Revision: https://phabricator.services.mozilla.com/D151079
 2023-11-02 17:04:47 +00:00
ChaseKnowlden
4932771b24 Bug 1857746 - Remove std max in downscaler. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D192166
 2023-10-30 08:12:41 +00:00
sunil mayya
8ce40ef93d Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D187833
 2023-10-27 13:30:11 +00:00
Tom Marble
28edc0c671 Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz 
Differential Revision: https://phabricator.services.mozilla.com/D191771
 2023-10-25 21:47:25 +00:00
Natalia Csoregi
8a8efda530 Backed out changeset 1ca403a2c00e (bug 1859905) for causing failures on test_mochitest_integration.py CLOSED TREE 2023-10-25 22:26:24 +03:00
Tom Marble
9c93e7d5df Bug 1859905 - convert .ini manifests to .toml: batch 19 browser_*.ini r=jmaher,webdriver-reviewers,necko-reviewers,extension-reviewers,devtools-reviewers,anti-tracking-reviewers,valentin,robwu,pbz 
Differential Revision: https://phabricator.services.mozilla.com/D191771
 2023-10-25 17:12:24 +00:00
Narcis Beleuzu
722f6a1679 Backed out 6 changesets (bug 1851992) for DT failure on browser_net_image_cache.js . CLOSED TREE 
Backed out changeset 3ceaf46f8f55 (bug 1851992)
Backed out changeset c9d322362e22 (bug 1851992)
Backed out changeset 673df3f83249 (bug 1851992)
Backed out changeset 46e18c56dd39 (bug 1851992)
Backed out changeset f9f9143ac713 (bug 1851992)
Backed out changeset 38c40d735ab7 (bug 1851992)
 2023-10-24 13:16:40 +03:00
sunil mayya
1acfb3f11f Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D187833
 2023-10-24 01:48:09 +00:00
Tooru Fujisawa
5d9a5df4e1 Bug 1846407 - Use enum class for Task::Run return value. r=bas,win-reviewers,rkraesig 
Differential Revision: https://phabricator.services.mozilla.com/D185043
 2023-10-18 15:23:29 +00:00
Noemi Erli
c3c92500ef Backed out changeset 7718734e95b1 (bug 1846407) for causing bustages in nsWindow.cpp CLOSED TREE 2023-10-18 05:31:49 +03:00
Tooru Fujisawa
0054ab3127 Bug 1846407 - Use enum class for Task::Run return value. r=bas,win-reviewers,rkraesig 
Differential Revision: https://phabricator.services.mozilla.com/D185043
 2023-10-18 01:54:43 +00:00
Cristian Tuns
524513d9ff Backed out changeset a44ec30d604f (bug 1846407) for causing build bustages in ScriptLoader.cpp CLOSED TREE 2023-10-17 18:46:25 -04:00
Tooru Fujisawa
091001f4a1 Bug 1846407 - Use enum class for Task::Run return value. r=bas,win-reviewers,rkraesig 
Differential Revision: https://phabricator.services.mozilla.com/D185043
 2023-10-17 22:16:58 +00:00
Cristina Horotan
ea9336a2ca Backed out 5 changesets (bug 1851992) for causing multiple failures 
Backed out changeset d28399b3d947 (bug 1851992)
Backed out changeset 95e4df69007a (bug 1851992)
Backed out changeset fa61d4e76827 (bug 1851992)
Backed out changeset 79969d9eb5cd (bug 1851992)
Backed out changeset 03c17255f1af (bug 1851992)
 2023-10-17 14:48:23 +03:00
sunil mayya
f350089afd Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D187833
 2023-10-17 08:27:49 +00:00
Sylvestre Ledru
1e776756dd Bug 1856795 - ride along: use = default; on some recently modified files r=emilio 
More on:
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html

Command:
L=$(hg export -r tip|grep +++|cut -d/ -f2-)
./mach static-analysis check --checks="-*, modernize-use-equals-default" --fix $L

Differential Revision: https://phabricator.services.mozilla.com/D191016
 2023-10-15 15:29:03 +00:00
Sylvestre Ledru
d0f6c7fc66 Bug 1856795 - Remove redundant member init r=emilio 
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
 2023-10-15 15:29:02 +00:00
Cristina Horotan
6a90f5eded Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h CLOSED TREE 
Backed out changeset 1d98b028923a (bug 1856795)
Backed out changeset eae2ac93e17c (bug 1856795)
 2023-10-14 21:42:14 +03:00
Sylvestre Ledru
c164bd9937 Bug 1856795 - ride along: use = default; on some recently modified files r=emilio 
More on:
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html

Command:
L=$(hg export -r tip|grep +++|cut -d/ -f2-)
./mach static-analysis check --checks="-*, modernize-use-equals-default" --fix $L

Differential Revision: https://phabricator.services.mozilla.com/D191016
 2023-10-14 17:34:27 +00:00
Sylvestre Ledru
cc8a0ee742 Bug 1856795 - Remove redundant member init r=emilio 
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
 2023-10-14 17:34:26 +00:00
Tom Marble
0cb91fe33e Bug 1855300 - convert .ini manifests to .toml: batch 11 remaining **/mochitest.ini r=jmaher,geckoview-reviewers,extension-reviewers,valentin,credential-management-reviewers,cookie-reviewers,sgalich,m_kato,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D190515
 2023-10-13 02:32:24 +00:00
Mirko Brodesser
6a36108054 Bug 1839315: part 3) Remove no-op method PreloaderBase::PrioritizeAsPreload. r=necko-reviewers,valentin 
Because it's confusing.

Differential Revision: https://phabricator.services.mozilla.com/D190015
 2023-10-11 10:21:56 +00:00
Timothy Nikkel
01da45e0d3 Bug 1848717. Check that an avif has primary image data too. r=Zaggy1024 
Differential Revision: https://phabricator.services.mozilla.com/D190456
 2023-10-10 23:06:10 +00:00
Andrew Halberstadt
4e2559a7a1 Bug 1833653 - Enable mochitest-plain on 'linux2204-64-wayland', r=jmaher,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D190202
 2023-10-10 14:19:11 +00:00
Emilio Cobos Álvarez
25c0d10932 Bug 1624819 - Remove TaskCategory and other quantum dom remnants. r=smaug,media-playback-reviewers,credential-management-reviewers,cookie-reviewers,places-reviewers,win-reviewers,valentin,mhowell,sgalich,alwu 
Sorry this is not a particularly easy patch to review. But it should be
mostly straight-forward.

I kept Document::Dispatch mostly for convenience, but could be
cleaned-up too / changed by SchedulerGroup::Dispatch. Similarly maybe
that can just be NS_DispatchToMainThread if we add an NS_IsMainThread
check there or something (to preserve shutdown semantics).

Differential Revision: https://phabricator.services.mozilla.com/D190450
 2023-10-10 08:51:12 +00:00
Andrew Halberstadt
dc8d745e52 Bug 1856358 - Run 'crashtests' on linux2204-64-wayland/opt, r=jmaher,lsalzman 
This also skips a handful of tests that were failing.

Differential Revision: https://phabricator.services.mozilla.com/D189829
 2023-10-05 17:54:30 +00:00
Sylvestre Ledru
4c29c24344 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D189896
 2023-10-03 09:22:18 +00:00
Timothy Nikkel
52922a36a4 Bug 1853026. Add a pref for fuzzers to limit image size so fuzzing can proceed more quickly. r=gfx-reviewers,lsalzman 
Large image sizes slow down fuzzing for webp and aren't likely to catch any more issues. We will still want to fuzz without this pref to catch any large image issues though.

Differential Revision: https://phabricator.services.mozilla.com/D188156
 2023-10-02 21:22:52 +00:00
Daniel Holbert
5041ff3d97 Bug 1273714: Remove an imagelib warning that's more spammy than useful at this point. r=tnikkel DONTBUILD 
The condition that causes us to warn is typically a web-server configuration
issue, not a Firefox issue; and we handle it gracefully, so there's no real
point in adding to our debug-build terminal warning-spam.

Differential Revision: https://phabricator.services.mozilla.com/D189421
 2023-09-27 23:27:13 +00:00
Dan Robertson
68be4359ce Bug 1853991 - Refactor SVGSVGElement intrinsic size APIs to return LengthPercentage. r=dholbert 
- Use LengthPercentage as the return type for GetIntrinsicHeight and
   GetIntrinsicWidth. This allows the caller to handle percent values.
   No callers have additional logic to handle percent values as of now,
   but this may change in the future, for compat; see last paragraph of
   bug 700533 comment 69.

 - Refactor intrinsic size function definitions.

Differential Revision: https://phabricator.services.mozilla.com/D176974
 2023-09-26 20:28:06 +00:00
Joel Maher
99abb50b8d Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.25). r=aryx,webdriver-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D189221
 2023-09-26 17:40:01 +00:00
Mark Banner
adc07ece4e Bug 1854913 - Turn off ESLint rule mozilla/use-chromeutils-generateqi for plain mochitests as it should not apply there. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D189099
 2023-09-26 13:38:20 +00:00
Andrew Osmond
31921ad4d8 Bug 1641389 - Remove image.webp.enabled pref, always on by default. r=necko-reviewers,tnikkel,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D188276
 2023-09-15 19:36:34 +00:00
Cosmin Sabou
00e0ca2c08 Backed out changeset 106a8fb08a87 (bug 1641389) for causing bc failures on browser_persist_image_accept.js. 2023-09-15 17:42:46 +03:00
Andrew Osmond
82946e5ce7 Bug 1641389 - Remove image.webp.enabled pref, always on by default. r=necko-reviewers,tnikkel,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D188276
 2023-09-15 11:57:53 +00:00
Marco Bonardo
70fdad6676 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-15 09:16:34 +00:00
Sandor Molnar
950a3c620d Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE 
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
 2023-09-14 20:29:06 +03:00
Marco Bonardo
61f8ecc425 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-14 16:33:13 +00:00
Tom Marble
9e40a719f2 Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D187597
 2023-09-13 18:28:32 +00:00
Emilio Cobos Álvarez
f17a0754ab Bug 1812488 - Drive-by clean-ups. r=tnikkel 
Differential Revision: https://phabricator.services.mozilla.com/D187664
 2023-09-07 11:16:47 +00:00
Mike Hommey
9331b9fb07 Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 
For some reason, its value in the Google style we use is 80... except
for Objective-C, where it's 100, which led to things like:
https://hg.mozilla.org/mozilla-central/rev/31bf68247e6e
https://hg.mozilla.org/mozilla-central/rev/64ceb33533a4.

There's probably a discussion to have about whether 80 is the right
limit, but since it's what's used for everything except ObjC, let's roll
with it.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D187409
 2023-09-05 11:23:01 +00:00
Andrew Creskey
baa6cd2868 Bug 1850892 - Remove expiring probe HTTP_PRELOAD_IMAGE_STARTREQUEST_DELAY r=necko-reviewers,valentin 
We are working on an alternative approach to improving OnStart/OnStop request timing, and so will remove this probe because it's no longer as relevant and the implementation touchs many classes and methods.

Differential Revision: https://phabricator.services.mozilla.com/D187233
 2023-09-01 14:45:06 +00:00
Emilio Cobos Álvarez
ea11c5c0b4 Bug 1847811 - Remove network.preload pref. r=necko-reviewers,anti-tracking-reviewers,pbz,kershaw 
Having it disabled is not web compatible, and there's no strong reason
to keep it, IMO.

If we want another pref to determine whether preloads are actually
triggered we can add it in the future.

Differential Revision: https://phabricator.services.mozilla.com/D186014
 2023-08-14 10:46:03 +00:00
Valentin Gosu
23974138e5 Bug 1847741 - Add an API to nsIURI to know if the query string is missing or an empty string r=edgul 
This patch adds a hasQuery attribute to nsIURI, similar to hasRef.
This is needed to distinguish between an empty and a non-existant query.

Differential Revision: https://phabricator.services.mozilla.com/D185672
 2023-08-09 07:01:48 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Tooru Fujisawa
8df4c988ca Bug 1839102 - Use enum class for Task kind. r=bas 
Differential Revision: https://phabricator.services.mozilla.com/D182980
 2023-07-26 05:09:29 +00:00
Sandor Molnar
e25db9b336 Backed out changeset b99cc4960043 (bug 1839102) for causing build bustages in idget/windows/nsWindow.cpp CLOSED TREE 2023-07-26 05:53:26 +03:00
Tooru Fujisawa
b7229fa6d8 Bug 1839102 - Use enum class for Task kind. r=bas 
Differential Revision: https://phabricator.services.mozilla.com/D182980
 2023-07-26 02:26:15 +00:00
Nika Layzell
ca0d37e8d5 Bug 1842658 - Part 1: Use a refcounting macro for imgCacheEntry, r=tnikkel 
It appears that when this was originally added in bug 430061, the inline
refcounting macros didn't exist yet.

Differential Revision: https://phabricator.services.mozilla.com/D183203
 2023-07-14 16:20:53 +00:00
Mark Banner
0b2d2afdea Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D181159
 2023-07-12 13:38:34 +00:00
Nika Layzell
d02de7ba99 Bug 1840647 - Part 2: Stop using GetWebExposedOriginSerialization in imgLoader, r=tnikkel 
The current behaviour would treat all null principals as the same, and
is using an extra comparison for origin attributes explicitly in
addition to the web exposed origin serialization. As far as I can tell,
this will never be called with a null `aPrincipal`, but I figured it was
worth fixing.

This changes the logic to use full principals for comparison, rather
than serializing to strings.

Differential Revision: https://phabricator.services.mozilla.com/D182227
 2023-07-07 17:08:35 +00:00
Timothy Nikkel
dff579d30a Bug 1831457. Call MaybeRestrictSVGContext in VectorImage::GetImageProvider. r=aosmond 
The main part of MaybeRestrictSVGContext blocks context paint where is it not allowed. The css style that enables it is already restricted to chrome, see https://searchfox.org/mozilla-central/source/servo/components/style/properties/longhands/inherited_svg.mako.rs#208 so this isn't a big deal.

We've had a test that context paint isn't enabled in content for a long time

https://searchfox.org/mozilla-central/rev/85b4f7363292b272eb9b606e00de2c37a6be73f0/layout/reftests/svg/as-image/reftest.list#59

So this never regressed. So this just makes it consistent and blocks it further and executes the preserve aspect ratio code.

Differential Revision: https://phabricator.services.mozilla.com/D177216
 2023-07-06 11:59:34 +00:00
Kershaw Chang
705e17a537 Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D181251
 2023-06-28 13:21:00 +00:00
Nika Layzell
1fdee2314c Bug 1839920 - Rename Get{ASCII,UTF}Origin to GetWebExposedOriginSerialization, r=smaug,necko-reviewers,anti-tracking-reviewers,bvandersloot,jesup 
This should make uses of the type more clearly indicating where the
origin came from, and should help avoid potential confusion between this
origin and nsIPrincipal::origin in new code.

This new name is long, but explicit. The string returned from this
function corresponds to the "serialization of an origin" from the WHATWG
html spec:
https://html.spec.whatwg.org/multipage/browsers.html#ascii-serialisation-of-an-origin

Differential Revision: https://phabricator.services.mozilla.com/D181794
 2023-06-27 19:59:15 +00:00
Norisz Fay
07a91b8c6a Backed out 2 changesets (bug 1838829) for causing perma mochitest failure with dom/websocket/tests being skipped CLOSED TREE 
Backed out changeset 19a5d4f1850a (bug 1838829)
Backed out changeset 97cd8a256954 (bug 1838829)
 2023-06-27 02:52:52 +03:00
Kershaw Chang
75c68b6864 Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D181251
 2023-06-26 14:22:14 +00:00
Norisz Fay
e86f1fa0e9 Backed out 5 changesets (bug 1838829) for causing mochitest failures CLOSED TREE 
Backed out changeset 693d34c8447d (bug 1838829)
Backed out changeset 903d9ff4afaa (bug 1838829)
Backed out changeset 5e51feff7467 (bug 1838829)
Backed out changeset e125be49d2a6 (bug 1838829)
Backed out changeset 1a8cf3c83dc4 (bug 1838829)
 2023-06-22 03:37:07 +03:00
Kershaw Chang
2cdb6b3a96 Bug 1838829 - Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D181251
 2023-06-21 19:43:33 +00:00
Nika Layzell
9f4d22f4e0 Bug 1826206 - Require nsISerialEventTarget for RetargetDeliveryTo, r=necko-reviewers,valentin 
This avoids potential issues where multiple OnDataAvailable callbacks or
similar could theoretically be called concurrently on different
StreamTransportService threads when targeting the STS - these cases will
now target a TaskQueue on the STS instead, structurally ensuring serial
execution.

Differential Revision: https://phabricator.services.mozilla.com/D179984
 2023-06-07 14:48:38 +00:00
Mark Banner
6725448902 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-06-07 08:42:36 +00:00
Christian Holler (:decoder)
b48efc60ec Bug 1833351 - Handle invalid URI to nsIconChannel gracefully. r=jld 
Differential Revision: https://phabricator.services.mozilla.com/D178158
 2023-05-25 22:58:59 +00:00
Emilio Cobos Álvarez
7d479f6a4a Bug 1832528 - Make cors mode part of the image cache key. r=tnikkel 
So that we can hold entries loaded with different CORS modes, such as
masks and backgrounds.

Differential Revision: https://phabricator.services.mozilla.com/D177759
 2023-05-25 22:25:31 +00:00
Otto Länd
43499f6fab Bug 1703812, 1817997, 1821362: apply code formatting via Lando 
# ignore-this-changeset
 2023-05-24 13:28:38 +00:00
Paul Adenot
a9bfcf37e3 Bug 1817997 - Update nsAVIFDecoder to use the new mp4parse-rust time units. r=kinetik 
Differential Revision: https://phabricator.services.mozilla.com/D176048
 2023-05-24 13:18:44 +00:00
Paul Adenot
20b2262251 Bug 1817997 - Adjust code to take advantage of the new TimeUnit API. r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D171256
 2023-05-24 13:18:39 +00:00
Natalia Csoregi
e87ecf485e Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE 
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
 2023-05-24 04:29:45 +03:00
Mark Banner
fbc15bdb60 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 19:09:29 +00:00
Noemi Erli
aa2f146d78 Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE 
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
 2023-05-23 12:14:37 +03:00
Mark Banner
e3e9a991b8 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D178589
 2023-05-23 08:13:08 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Cosmin Sabou
5fd965f028 Backed out 80 changesets (bug 1821362, bug 1703812, bug 1817997) for causing media crashes as in Bug 1833890. a=backout 
Backed out changeset f2113c9b661f (bug 1817997)
Backed out changeset f1ecfbba7ed2 (bug 1703812)
Backed out changeset 011cece33b0d (bug 1817997)
Backed out changeset 4b42659090f3 (bug 1817997)
Backed out changeset 2d92f903dd66 (bug 1817997)
Backed out changeset 0ef13d357ee3 (bug 1817997)
Backed out changeset 7353f869efd2 (bug 1703812)
Backed out changeset 14b061d0f595 (bug 1817997)
Backed out changeset d29bc29397c8 (bug 1703812)
Backed out changeset 54c3294f0839 (bug 1817997)
Backed out changeset b9f2e1155bd7 (bug 1817997)
Backed out changeset d5d5d390dcbf (bug 1817997)
Backed out changeset 8fca27bd0f6b (bug 1817997)
Backed out changeset 670c599a3b99 (bug 1817997)
Backed out changeset deea3077f762 (bug 1817997)
Backed out changeset 25ecea0f3d49 (bug 1817997)
Backed out changeset 35ab3ed5e3fc (bug 1817997)
Backed out changeset f516a428ba32 (bug 1817997)
Backed out changeset e589b4d30995 (bug 1817997)
Backed out changeset d096b9cc905d (bug 1817997)
Backed out changeset 2952a6fa06e5 (bug 1817997)
Backed out changeset c1ac4c31ad9a (bug 1817997)
Backed out changeset 04c60cd83c5f (bug 1821362)
Backed out changeset 6dd80575e551 (bug 1821362)
Backed out changeset b86b569ecd46 (bug 1817997)
Backed out changeset 412e0a9ec4e8 (bug 1817997)
Backed out changeset 8e0dcf163138 (bug 1817997)
Backed out changeset 7af506896930 (bug 1817997)
Backed out changeset 29f7cd2b341c (bug 1817997)
Backed out changeset 7f64e65d9497 (bug 1817997)
Backed out changeset 89c241451a32 (bug 1817997)
Backed out changeset 66e4a26e1ebe (bug 1817997)
Backed out changeset ea1aebd4e245 (bug 1817997)
Backed out changeset 2d88a5915db9 (bug 1817997)
Backed out changeset 697ec1928f9c (bug 1817997)
Backed out changeset 41c0bd1133c5 (bug 1817997)
Backed out changeset b20cc750c020 (bug 1817997)
Backed out changeset dc5fd84a3a4c (bug 1703812)
Backed out changeset efa6d130d4eb (bug 1703812)
Backed out changeset 20d9b7cf0ddc (bug 1703812)
Backed out changeset e77c61e8fad2 (bug 1703812)
Backed out changeset 582d5c680e5a (bug 1703812)
Backed out changeset 96c9aacc6811 (bug 1703812)
Backed out changeset 56ec4a57a6a6 (bug 1703812)
Backed out changeset 8f96c8811675 (bug 1703812)
Backed out changeset a79a2f1b2b51 (bug 1703812)
Backed out changeset 07eb8b2c5b9f (bug 1703812)
Backed out changeset bae2b2fb9759 (bug 1703812)
Backed out changeset 38b0416538f3 (bug 1703812)
Backed out changeset b27b54c95cf2 (bug 1703812)
Backed out changeset cab00065d83d (bug 1703812)
Backed out changeset ab44727b2e1a (bug 1703812)
Backed out changeset b7fdcb494670 (bug 1703812)
Backed out changeset 73db43d49c6d (bug 1703812)
Backed out changeset ce754dbfb862 (bug 1703812)
Backed out changeset d694726a3ee6 (bug 1703812)
Backed out changeset 6acede55acbb (bug 1703812)
Backed out changeset 86e7d4784a20 (bug 1703812)
Backed out changeset 6b2e055d9314 (bug 1703812)
Backed out changeset b08695e5728a (bug 1703812)
Backed out changeset 3b8a0081fd10 (bug 1703812)
Backed out changeset 3a163596f982 (bug 1703812)
Backed out changeset 5be1d4b282ab (bug 1703812)
Backed out changeset 1ce012d7509e (bug 1703812)
Backed out changeset ee2fab5881c7 (bug 1703812)
Backed out changeset 62941a522893 (bug 1703812)
Backed out changeset d4f11dc33eed (bug 1703812)
Backed out changeset 781bb4c3cc02 (bug 1703812)
Backed out changeset f070e0de0566 (bug 1703812)
Backed out changeset 9f65c67ba2a6 (bug 1703812)
Backed out changeset 1e76eecb85e2 (bug 1703812)
Backed out changeset 953432408a83 (bug 1703812)
Backed out changeset fd1dc92d3911 (bug 1703812)
Backed out changeset 34d56948c6b6 (bug 1703812)
Backed out changeset 2ba7ca61ecc3 (bug 1703812)
Backed out changeset 545253c469e6 (bug 1703812)
Backed out changeset fb4a61ab1300 (bug 1703812)
Backed out changeset bf07b3cfd3d5 (bug 1703812)
Backed out changeset eaff51e7754b (bug 1703812)
Backed out changeset f5c485c41d13 (bug 1703812)
 2023-05-19 14:49:57 +03:00
Sean Feng
bd1e35c1d2 Bug 1816287 - Always exit fullscreen when triggering on external protocol r=edgar 
It's a security risk such that the maximized external program can obscure
the fullscreen notification and the malicious site can use this trick
to load a spoofed page in the background without user notices it.

This patch minimized the risk by always exit the fullscreen mode when
an external protocol is triggered.

Differential Revision: https://phabricator.services.mozilla.com/D177771
 2023-05-17 18:00:18 +00:00
Norisz Fay
34b6c94a76 Backed out changeset 6fa00ccfe7e0 (bug 1816287) for causing bustages on LocationBase.cpp CLOSED TREE 2023-05-17 20:11:39 +03:00
Sean Feng
9740581cf7 Bug 1816287 - Always exit fullscreen when triggering on external protocol r=edgar 
It's a security risk such that the maximized external program can obscure
the fullscreen notification and the malicious site can use this trick
to load a spoofed page in the background without user notices it.

This patch minimized the risk by always exit the fullscreen mode when
an external protocol is triggered.

Differential Revision: https://phabricator.services.mozilla.com/D177771
 2023-05-17 16:34:57 +00:00
Otto Länd
73f06050fb Bug 1703812, 1817997, 1821362: apply code formatting via Lando 
# ignore-this-changeset
 2023-05-17 16:00:46 +00:00
Paul Adenot
9925667f68 Bug 1817997 - Update nsAVIFDecoder to use the new mp4parse-rust time units. r=kinetik 
Differential Revision: https://phabricator.services.mozilla.com/D176048
 2023-05-17 15:47:08 +00:00
Paul Adenot
0aeade5787 Bug 1817997 - Adjust code to take advantage of the new TimeUnit API. r=alwu 
Differential Revision: https://phabricator.services.mozilla.com/D171256
 2023-05-17 15:47:03 +00:00
nicklas boman
5e31225558 Bug 1724649 - Followup to remove #include plstr.h r=necko-reviewers,xpcom-reviewers,valentin,nika 
Differential Revision: https://phabricator.services.mozilla.com/D177690
 2023-05-15 14:53:02 +00:00
Emilio Cobos Álvarez
6d294944a6 Bug 1832553 - Remove the chrome / non-chrome image cache split. r=tnikkel 
This probably made more sense when everything was in the same process,
so that prefs like the image cache size etc only measured web content.

But that's achieved via e10s nowadays, so probably having different
cache tables for chrome:// URIs is overkill. Plus, we probably want to
also clear resource:// URIs etc when flushing chrome caches and so on.

Differential Revision: https://phabricator.services.mozilla.com/D177765
 2023-05-13 08:31:46 +00:00
Kershaw Chang
8f95e3fca6 Bug 1808323 - Add telemetry for the page load time and the time to first paint for sites that supports Early Hints response, r=manuel,necko-reviewers,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D165966
 2023-05-02 08:08:44 +00:00
Timothy Nikkel
9d0226a146 Bug 1823375. Fix all variable shadowing warnings in imagelib. r=Zaggy1024,gfx-reviewers,nical 
We can't actually enable the warning because there are some warnings generated by includes coming from outside of imagelib.

Note that change in AOMDecoder::Init is actually a behaviour change: the new behaviour is to return the error code if we fail to decode the alpha image. This matches what we do for the dav1d decoder.

Depends on D173000

Differential Revision: https://phabricator.services.mozilla.com/D173001
 2023-04-11 08:06:29 +00:00
Nika Layzell
d57c9498f6 Bug 1825360 - Remove the NS_DISPATCH_SYNC flag, r=necko-reviewers,geckoview-reviewers,media-playback-reviewers,karlt,jesup,m_kato,emilio 
This flag is not supported by most event targets and can have unexpected
side effects (namely spinning a nested event loop). All consumers have
been replaced with a new function which is more explicit about this side
effect.

Differential Revision: https://phabricator.services.mozilla.com/D173985
 2023-03-30 16:53:51 +00:00
Otto Länd
314123012b Bug 1276351: apply code formatting via Lando 
# ignore-this-changeset
 2023-03-27 07:23:36 +00:00
Andi-Bogdan Postelnicu
4efa1bd0ba Bug 1276351 - Move away from mozilla::tuple to std::tuple. r=necko-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D173256
 2023-03-27 07:20:25 +00:00
Sandor Molnar
9db345d4c1 Backed out 2 changesets (bug 1276351) for causing build bustage in image/ClippedImage.cp CLOSED TREE 
Backed out changeset e84598eb82c1 (bug 1276351)
Backed out changeset e940b0554484 (bug 1276351)
 2023-03-25 14:16:43 +02:00
Andi-Bogdan Postelnicu
447f1e3358 Bug 1276351 - Move away from mozilla::tuple to std::tuple. r=necko-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D173256
 2023-03-25 06:58:52 +00:00
Timothy Nikkel
2f85ec68a3 Bug 1823614. Limit the number of scans we allow in jpeg images to some finite value. r=gfx-reviewers,bradwerth a=reland 
We want to provide some finite limit to prevent small jpeg files from being able to tie up cpus for a much larger time than their small size would normally allow. We want to choose a number high enough so that no sane jpeg file would approach it, unless it had been crafted to take advantage of this problem.

Skia's jpeg decoder limit's it to 100:

https://searchfox.org/mozilla-central/rev/f078cd02746b29652c134b144f0629d47e378166/gfx/skia/skia/src/codec/SkJpegDecoderMgr.cpp#33

The OSS_Fuzz targets for libjpeg-turbo limit it to 500:

https://bugzilla.mozilla.org/show_bug.cgi?id=1252196#c11

Differential Revision: https://phabricator.services.mozilla.com/D173120
 2023-03-25 01:46:53 +00:00
Iulian Moraru
0b75230e48 Backed out changeset 9e5254e7728e (bug 1823614) for causing reftest failures on pattern-transformed. CLOSED TREE 2023-03-25 05:23:27 +02:00
Timothy Nikkel
6a90e1f8f5 Bug 1823614. Limit the number of scans we allow in jpeg images to some finite value. r=gfx-reviewers,bradwerth 
We want to provide some finite limit to prevent small jpeg files from being able to tie up cpus for a much larger time than their small size would normally allow. We want to choose a number high enough so that no sane jpeg file would approach it, unless it had been crafted to take advantage of this problem.

Skia's jpeg decoder limit's it to 100:

https://searchfox.org/mozilla-central/rev/f078cd02746b29652c134b144f0629d47e378166/gfx/skia/skia/src/codec/SkJpegDecoderMgr.cpp#33

The OSS_Fuzz targets for libjpeg-turbo limit it to 500:

https://bugzilla.mozilla.org/show_bug.cgi?id=1252196#c11

Differential Revision: https://phabricator.services.mozilla.com/D173120
 2023-03-25 01:46:53 +00:00
Iulian Moraru
6d40eee997 Backed out 2 changesets (bug 1276351) for causing multiple failures. 
Backed out changeset eeaf4f1e06af (bug 1276351)
Backed out changeset d44cb5704342 (bug 1276351)
 2023-03-25 00:08:24 +02:00
Andi-Bogdan Postelnicu
a1b827b503 Bug 1276351 - Move away from mozilla::tuple to std::tuple. r=necko-reviewers,sergesanspaille 
Differential Revision: https://phabricator.services.mozilla.com/D173256
 2023-03-24 18:55:39 +00:00
Timothy Nikkel
57ebc1d81a Bug 1277397. Set a max memory limit for libjpeg turbo to use. r=gfx-reviewers,bradwerth 
This means that for trivial images whose header specifies large dimensions but with no image data  we don't use a lot of memory.

Differential Revision: https://phabricator.services.mozilla.com/D173119
 2023-03-24 04:47:43 +00:00
Timothy Nikkel
3fb8b06877 Bug 1818725. Don't ignore the return value of nsAVIFDecoder::CreateDecoder. r=Zaggy1024 
And also make it return a better result when mDecoder already exists, Complete is not what we want to return.

Depends on D172994

Differential Revision: https://phabricator.services.mozilla.com/D172998
 2023-03-23 03:39:06 +00:00
Tom Schuster
1509ba1c86 Bug 1808146 - When creating a file promise for images, remember the referrer. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D172920
 2023-03-22 21:55:08 +00:00
Kershaw Chang
5e58575e28 Bug 1809843 - Skip Failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,valentin,sgalich,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D171842
 2023-03-21 09:09:58 +00:00
Timothy Nikkel
c869e31d5e Bug 1818724. Rename nsAVIFDecoder::Decode. r=Zaggy1024 
Because it has the same name as the base class function Decoder::Decode but different arguments, which is confusing.

Depends on D172998

Differential Revision: https://phabricator.services.mozilla.com/D173000
 2023-03-20 23:46:50 +00:00
Timothy Nikkel
2c69c06d89 Bug 1813562. Fix leak with color profile and transform in avif decoder. r=Zaggy1024 
We run this code for every frame of animated images, so we need to make the code handle that.

Differential Revision: https://phabricator.services.mozilla.com/D172994
 2023-03-20 22:49:39 +00:00
zaggy1024
ef5aaf44a9 Bug 1813466 - Store AVIF prefs as default decoder flags in RasterImage. r=tnikkel 
This prevents a crash that would occur if a redecode of an animated AVIF happened after changing the `sequences.enabled` pref from `true` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D170190
 2023-03-17 00:50:07 +00:00
Nika Layzell
3b40268cc1 Bug 1818305 - Part 2: Add a streamStatus method to nsIInputStream, r=xpcom-reviewers,necko-reviewers,geckoview-reviewers,valentin,jesup,m_kato,mccr8 
This is semantically similar to the existing available() method, however will
not block, and doesn't need to do the work to actually determine the number of
available bytes.

As part of this patch, I also fixed one available() implementation which was
incorrectly throwing NS_BASE_STREAM_WOULD_BLOCK.

Differential Revision: https://phabricator.services.mozilla.com/D170697
 2023-03-15 19:52:34 +00:00
Marian-Vasile Laza
ee72efd1e9 Backed out 5 changesets (bug 1809843) for causing Cargo related build bustages. CLOSED TREE 
Backed out changeset 5c494680f448 (bug 1809843)
Backed out changeset 02742b38edab (bug 1809843)
Backed out changeset 2b9b32ca8294 (bug 1809843)
Backed out changeset 56631cb02ae6 (bug 1809843)
Backed out changeset 37e35a60a71f (bug 1809843)
 2023-03-13 13:53:26 +02:00
Kershaw Chang
a60df34ad0 Bug 1809843 - Skip Failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,valentin,sgalich,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D171842
 2023-03-13 11:12:33 +00:00
Timothy Nikkel
379fa32eff Bug 1818903. Adjust fuzz on moz-icon reftest for Windows 11. r=emilio 
I looked at the failures compared to the passing results. The passing results look very faint and blurry. The failures look much better actually.

Differential Revision: https://phabricator.services.mozilla.com/D171552
 2023-03-03 12:17:21 +00:00
zaggy1024
e349b686f8 Bug 1817108 - Check that AVIF frame sizes remain unchanged during animation. r=tnikkel 
Differential Revision: https://phabricator.services.mozilla.com/D170193
 2023-03-01 07:04:31 +00:00
Brad Werth
75eeec6a99 Bug 1768495 Part 4: Disable window occlusion tracker pref on crashtests that rely on a running compositor. r=emilio 
These crashtests rely upon either a requestAnimationFrame callback or a
MozAfterPaint event. Those currently won't happen when the compositor is
paused, and on Windows these crashtests are occluded, which will now pause
the compositor. To deal with this, we disable the occlusion tracking pref
on Windows. Other platforms seem not to treat the crashtests as occluded,
so their compositors keep running.

Differential Revision: https://phabricator.services.mozilla.com/D171137
 2023-02-28 23:04:54 +00:00
Jonathan Kew
4594ae314a Bug 1815404 - Replace most uses of gfxContext::CreateOrNull with stack-allocated contexts. r=gfx-reviewers,lsalzman 
Depends on D170370

Differential Revision: https://phabricator.services.mozilla.com/D170371
 2023-02-21 07:28:25 +00:00
Jonathan Kew
1b3e69f8aa Bug 1815404 - Remove refcounting from gfxContext. r=gfx-reviewers,lsalzman 
Depends on D170367

Differential Revision: https://phabricator.services.mozilla.com/D170369
 2023-02-21 07:28:24 +00:00
Tyson Smith
f14d70cf52 Bug 1817479 - Enable AVIF sequence support in DecodeToSurface Fuzzer. r=tnikkel 
Differential Revision: https://phabricator.services.mozilla.com/D170230
 2023-02-18 04:19:54 +00:00
Gijs Kruitbosch
387cf24ca0 Bug 1810141 - fix tests to deal with changes to loadURI, r=mossop,perftest-reviewers,geckoview-reviewers,extension-reviewers,sparky,owlish 
Depends on D168396

Differential Revision: https://phabricator.services.mozilla.com/D168397
 2023-02-13 23:50:41 +00:00
Andi-Bogdan Postelnicu
d7e8a09c21 Bug 1519636 - Reformat recent changes to the Google coding style. r=glandium 
Updated with clang-format version 15.0.5 (taskcluster-MKK8dHUpQkGfPLA793lizg)
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D168658
 2023-02-13 15:02:07 +00:00
Cristina Horotan
5f4356e527 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE 
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
 2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
ff1cc20bd7 Bug 1810141 - fix tests to deal with changes to loadURI, r=mossop,perftest-reviewers,geckoview-reviewers,extension-reviewers,sparky,owlish 
Depends on D168396

Differential Revision: https://phabricator.services.mozilla.com/D168397
 2023-02-13 12:55:26 +00:00
Manuel Bucher
0a2efcaedf Bug 1813132 - Fix Early Hints image Link preloads not connecting back to preloader in parent process r=emilio,necko-reviewers,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D168131
 2023-02-09 16:35:50 +00:00
Emilio Cobos Álvarez
d28f1e4d47 Bug 1815255 - Fix tests to deal with flexbox emulation. r=Jamie,Gijs 
Mostly changing XUL attributes to CSS properties, though there are a few
tricky ones:

 * test_offsets.xhtml expects the scroller to be full-width, while
   modern flexbox would honor width: 200px (so just remove it).

 * window_intrinsic_size.xhtml was relying on the div imposing a XUL
   min-size (the test is for SetSizeConstraints, bug 1447056). Use
   min-height instead as that's what modern flexbox reads. Confirmed
   that bug doesn't regress in any case.

 * object-fit-contain-png-001.xhtml has a float: left which had no
   effect on -moz-box, but which assert with modern layout[1]. In the
   future I think we could remove that assert but anyways, for now just
   keeping behavior.

 * image-size.xhtml has a couple uninvestigated sizing differences. They
   didn't seem problematic.

 * 579323-1-ref.html changes because the other file has a canvas with
   width=100 height=100 which imposes an aspect ratio (which XUL never
   honored).

 * window_largemenu.xhtml shows a regression, but this never worked on
   some platforms (at least Linux+Wayland) and nobody has noticed it in
   the browser area, so I suspect we're fine.

[1]: https://searchfox.org/mozilla-central/rev/08362489086b10de96e7a199b267ea5504c01583/layout/generic/ReflowInput.cpp#2137

Differential Revision: https://phabricator.services.mozilla.com/D169084
 2023-02-09 12:24:53 +00:00